lib/dummyload: Cleanup access to spin obj array
PATCH 1/1 lib/dummyload: Cleanup access to spin obj array
Instead of relying a static obj array inside igt_spin_t, access it with proper indexing.
--- lib/igt_dummyload.c | 32 +++++++++++++++----------------- lib/igt_dummyload.h | 1 + tests/i915/gem_exec_schedule.c | 25 +++++++++++++++---------- tests/i915/gem_softpin.c | 2 +- tests/i915/gem_spin_batch.c | 4 ++-- tests/i915/i915_hangman.c | 2 +- 6 files changed, 35 insertions(+), 31 deletions(-)
lib/igt_dummyload.c +15 -17
@@ -72,7 +72,6 @@ emit_recursive_batch(igt_spin_t *spin, int fd, const struct igt_spin_factory *opts) { #define SCRATCH 0 -#define BATCH 1 const int gen = intel_gen(intel_get_drm_devid(fd));struct drm_i915_gem_relocation_entry relocs[2 ], *r;struct drm_i915_gem_execbuffer2 *execbuf;
@@ -105,14 +104,14 @@ emit_recursive_batch(igt_spin_t *spin, obj = spin->obj;memset (relocs,0 ,sizeof (relocs)); - obj[BATCH ].handle =gem_create (fd,BATCH_SIZE ); - batch =__gem_mmap__wc (fd, obj[BATCH ].handle, + obj[SPIN_OBJ_BATCH ].handle =gem_create (fd,BATCH_SIZE ); + batch =__gem_mmap__wc (fd, obj[SPIN_OBJ_BATCH ].handle,0 ,BATCH_SIZE ,PROT_WRITE );if (!batch) - batch =gem_mmap__gtt (fd, obj[BATCH ].handle, + batch =gem_mmap__gtt (fd, obj[SPIN_OBJ_BATCH ].handle,BATCH_SIZE ,PROT_WRITE ); -gem_set_domain (fd, obj[BATCH ].handle, +gem_set_domain (fd, obj[SPIN_OBJ_BATCH ].handle,I915_GEM_DOMAIN_GTT ,I915_GEM_DOMAIN_GTT ); execbuf->buffer_count++; cs = batch;
@@ -120,7 +119,7 @@ emit_recursive_batch(igt_spin_t *spin,if (opts->dependency) {igt_assert (!(opts->flags &IGT_SPIN_POLL_RUN )); - r = &relocs[obj[BATCH ].relocation_count++]; + r = &relocs[obj[SPIN_OBJ_BATCH ].relocation_count++];/* dummy write to dependency */ obj[SCRATCH ].handle = opts->dependency;
@@ -133,7 +132,7 @@ emit_recursive_batch(igt_spin_t *spin, execbuf->buffer_count++; }else if (opts->flags &IGT_SPIN_POLL_RUN ) { - r = &relocs[obj[BATCH ].relocation_count++]; + r = &relocs[obj[SPIN_OBJ_BATCH ].relocation_count++];igt_assert (!opts->dependency);
@@ -182,7 +181,7 @@ emit_recursive_batch(igt_spin_t *spin, execbuf->buffer_count++; } - spin->handle = obj[BATCH ].handle; + spin->handle = obj[SPIN_OBJ_BATCH ].handle;igt_assert_lt (cs - batch,LOOP_START_OFFSET /sizeof (*cs)); spin->condition = batch +LOOP_START_OFFSET /sizeof (*cs);
@@ -207,8 +206,8 @@ emit_recursive_batch(igt_spin_t *spin, cs +=1000 ;/* recurse */ - r = &relocs[obj[BATCH ].relocation_count++]; - r->target_handle = obj[BATCH ].handle; + r = &relocs[obj[SPIN_OBJ_BATCH ].relocation_count++]; + r->target_handle = obj[SPIN_OBJ_BATCH ].handle; r->offset = (cs +1 - batch) *sizeof (*cs); r->read_domains =I915_GEM_DOMAIN_COMMAND ; r->delta =LOOP_START_OFFSET ;
@@ -226,7 +225,7 @@ emit_recursive_batch(igt_spin_t *spin, *cs = r->delta; cs++; } - obj[BATCH ].relocs_ptr =to_user_pointer (relocs); + obj[SPIN_OBJ_BATCH ].relocs_ptr =to_user_pointer (relocs); execbuf->buffers_ptr =to_user_pointer (obj + (2 - execbuf->buffer_count));
@@ -261,12 +260,11 @@ emit_recursive_batch(igt_spin_t *spin,igt_assert_lt (cs - batch,BATCH_SIZE /sizeof (*cs));/* Make it easier for callers to resubmit. */ - - obj[BATCH ].relocation_count =0 ; - obj[BATCH ].relocs_ptr =0 ; - - obj[SCRATCH ].flags =EXEC_OBJECT_PINNED ; - obj[BATCH ].flags =EXEC_OBJECT_PINNED ; +for (i =0 ; i <ARRAY_SIZE (spin->obj); i++) { + spin->obj[i].relocation_count =0 ; + spin->obj[i].relocs_ptr =0 ; + spin->obj[i].flags =EXEC_OBJECT_PINNED ; + } spin->cmd_precondition = *spin->condition;
lib/igt_dummyload.h +1 -0
@@ -42,6 +42,7 @@ typedef struct igt_spin {int out_fence;struct drm_i915_gem_exec_object2 obj[2 ]; +#define SPIN_OBJ_BATCH 1struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle;uint32_t *poll;
tests/i915/gem_exec_schedule.c +15 -10
@@ -234,7 +234,8 @@ static void independent(int fd, unsigned int engine) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr = +to_user_pointer (&spin->obj[SPIN_OBJ_BATCH ]), .flags = other, };gem_execbuf (fd, &eb);
@@ -537,7 +538,8 @@ static void semaphore_resolve(int i915)/* Then cancel the spinner */ *cs++ =MI_STORE_DWORD_IMM ; - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[SPIN_OBJ_BATCH ].offset + +offset_in_page (spin->condition); *cs++ =0 ; *cs++ =MI_BATCH_BUFFER_END ;
@@ -548,7 +550,7 @@ static void semaphore_resolve(int i915)/* First up is our spinning semaphore */ memset (obj,0 ,sizeof (obj)); - obj[0 ] = spin->obj[1 ]; + obj[0 ] = spin->obj[SPIN_OBJ_BATCH ]; obj[1 ].handle = semaphore; obj[1 ].offset =SEMAPHORE_ADDR ; obj[1 ].flags =EXEC_OBJECT_PINNED ;
@@ -562,7 +564,7 @@ static void semaphore_resolve(int i915)memset (obj,0 ,sizeof (obj)); obj[0 ].handle = handle; obj[0 ].flags =EXEC_OBJECT_WRITE ;/* always after semaphore */ - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[SPIN_OBJ_BATCH ]; eb.buffer_count =2 ; eb.rsvd1 =0 ;gem_execbuf (i915, &eb);
@@ -638,11 +640,13 @@ static void semaphore_noskip(int i915)/* Cancel the following spinner */ *cs++ =MI_STORE_DWORD_IMM ;if (gen >=8 ) { - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[SPIN_OBJ_BATCH ].offset + +offset_in_page (spin->condition); *cs++ =0 ; }else { *cs++ =0 ; - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[SPIN_OBJ_BATCH ].offset + +offset_in_page (spin->condition); } *cs++ =MI_BATCH_BUFFER_END ;
@@ -651,9 +655,9 @@ static void semaphore_noskip(int i915)/* port0: implicit semaphore from engine */ memset (obj,0 ,sizeof (obj)); - obj[0 ] = chain->obj[1 ]; + obj[0 ] = chain->obj[SPIN_OBJ_BATCH ]; obj[0 ].flags |=EXEC_OBJECT_WRITE ; - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[SPIN_OBJ_BATCH ]; obj[2 ].handle = handle;memset (&eb,0 ,sizeof (eb)); eb.buffer_count =3 ;
@@ -666,7 +670,7 @@ static void semaphore_noskip(int i915)memset (obj,0 ,sizeof (obj)); obj[0 ].handle = handle; obj[0 ].flags =EXEC_OBJECT_WRITE ; - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[SPIN_OBJ_BATCH ];memset (&eb,0 ,sizeof (eb)); eb.buffer_count =2 ; eb.buffers_ptr =to_user_pointer (obj);
@@ -842,7 +846,8 @@ static igt_spin_t *__noise(int fd, uint32_t ctx, int prio, igt_spin_t *spin) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr = +to_user_pointer (&spin->obj[SPIN_OBJ_BATCH ]), .rsvd1 = ctx, .flags = other, };
tests/i915/gem_softpin.c +1 -1
@@ -360,7 +360,7 @@ static void test_evict_hang(int fd) execbuf.buffer_count =1 ; hang =igt_hang_ctx (fd,0 ,0 ,0 ); - expected = hang.spin->obj[1 ].offset; + expected = hang.spin->obj[SPIN_OBJ_BATCH ].offset;/* Replace the hung batch with ourselves, forcing an eviction */ object.offset = expected;
tests/i915/gem_spin_batch.c +2 -2
@@ -79,7 +79,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr =to_user_pointer (&spin->obj[SPIN_OBJ_BATCH ]), .rsvd1 = ctx1, };
@@ -98,7 +98,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)igt_spin_end (spin); -gem_sync (fd, spin->obj[1 ].handle); +gem_sync (fd, spin->handle);igt_spin_free (fd, spin);
tests/i915/i915_hangman.c +1 -1
@@ -209,7 +209,7 @@ static void test_error_state_capture(unsigned ring_id,clear_error_state (); hang =igt_hang_ctx (device,0 , ring_id,HANG_ALLOW_CAPTURE ); - offset = hang.spin->obj[1 ].offset; + offset = hang.spin->obj[SPIN_OBJ_BATCH ].offset; batch =gem_mmap__cpu (device, hang.spin->handle,0 ,4096 ,PROT_READ );gem_set_domain (device, hang.spin->handle,I915_GEM_DOMAIN_CPU ,0 );
Signature · 6 lines
2.17.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Mika Kuoppala (2019-05-22 10:13:46)
Quoted 19 lines
Instead of relying a static obj array inside
igt_spin_t, access it with proper indexing.Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>--- lib/igt_dummyload.c | 32 +++++++++++++++----------------- lib/igt_dummyload.h | 1 + tests/i915/gem_exec_schedule.c | 25 +++++++++++++++---------- tests/i915/gem_softpin.c | 2 +- tests/i915/gem_spin_batch.c | 4 ++-- tests/i915/i915_hangman.c | 2 +- 6 files changed, 35 insertions(+), 31 deletions(-)lib/igt_dummyload.c +0
-0
lib/igt_dummyload.c emit_recursive_batch(igt_spin_t *spin, · line 75
Quoted 4 lines
lib/igt_dummyload.c +0
-1@@ -72,7 +72,6 @@ emit_recursive_batch(igt_spin_t *spin, int fd, const struct igt_spin_factory *opts) { #define SCRATCH 0 -#define BATCH 1
#define BATCH IGT_SPIN_BATCH
lib/igt_dummyload.h typedef struct igt_spin { · line 45
Quoted 9 lines
lib/igt_dummyload.h +1
-0@@ -42,6 +42,7 @@ typedef struct igt_spin {int out_fence;struct drm_i915_gem_exec_object2 obj[2 ]; +#define SPIN_OBJ_BATCH 1
Leading IGT_SPIN to match type.IGT_SPIN_BATCH is unique enough for the moment.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 1/1 lib/dummyload: Cleanup access to spin obj array
Instead of relying a static obj array inside igt_spin_t, access it with proper indexing.
v2: IGT_SPIN_BATCH
--- lib/igt_dummyload.c | 13 ++++++------- lib/igt_dummyload.h | 1 + tests/i915/gem_exec_schedule.c | 25 +++++++++++++++---------- tests/i915/gem_softpin.c | 2 +- tests/i915/gem_spin_batch.c | 4 ++-- tests/i915/i915_hangman.c | 2 +- 6 files changed, 26 insertions(+), 21 deletions(-)
lib/igt_dummyload.c +6 -7
@@ -72,7 +72,7 @@ emit_recursive_batch(igt_spin_t *spin, int fd, const struct igt_spin_factory *opts) { #define SCRATCH 0 -#define BATCH 1 +#define BATCH IGT_SPIN_BATCH const int gen = intel_gen(intel_get_drm_devid(fd));struct drm_i915_gem_relocation_entry relocs[2 ], *r;struct drm_i915_gem_execbuffer2 *execbuf;
@@ -261,12 +261,11 @@ emit_recursive_batch(igt_spin_t *spin,igt_assert_lt (cs - batch,BATCH_SIZE /sizeof (*cs));/* Make it easier for callers to resubmit. */ - - obj[BATCH ].relocation_count =0 ; - obj[BATCH ].relocs_ptr =0 ; - - obj[SCRATCH ].flags =EXEC_OBJECT_PINNED ; - obj[BATCH ].flags =EXEC_OBJECT_PINNED ; +for (i =0 ; i <ARRAY_SIZE (spin->obj); i++) { + spin->obj[i].relocation_count =0 ; + spin->obj[i].relocs_ptr =0 ; + spin->obj[i].flags =EXEC_OBJECT_PINNED ; + } spin->cmd_precondition = *spin->condition;
lib/igt_dummyload.h +1 -0
@@ -42,6 +42,7 @@ typedef struct igt_spin {int out_fence;struct drm_i915_gem_exec_object2 obj[2 ]; +#define IGT_SPIN_BATCH 1struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle;uint32_t *poll;
tests/i915/gem_exec_schedule.c +15 -10
@@ -234,7 +234,8 @@ static void independent(int fd, unsigned int engine) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr = +to_user_pointer (&spin->obj[IGT_SPIN_BATCH ]), .flags = other, };gem_execbuf (fd, &eb);
@@ -537,7 +538,8 @@ static void semaphore_resolve(int i915)/* Then cancel the spinner */ *cs++ =MI_STORE_DWORD_IMM ; - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[IGT_SPIN_BATCH ].offset + +offset_in_page (spin->condition); *cs++ =0 ; *cs++ =MI_BATCH_BUFFER_END ;
@@ -548,7 +550,7 @@ static void semaphore_resolve(int i915)/* First up is our spinning semaphore */ memset (obj,0 ,sizeof (obj)); - obj[0 ] = spin->obj[1 ]; + obj[0 ] = spin->obj[IGT_SPIN_BATCH ]; obj[1 ].handle = semaphore; obj[1 ].offset =SEMAPHORE_ADDR ; obj[1 ].flags =EXEC_OBJECT_PINNED ;
@@ -562,7 +564,7 @@ static void semaphore_resolve(int i915)memset (obj,0 ,sizeof (obj)); obj[0 ].handle = handle; obj[0 ].flags =EXEC_OBJECT_WRITE ;/* always after semaphore */ - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[IGT_SPIN_BATCH ]; eb.buffer_count =2 ; eb.rsvd1 =0 ;gem_execbuf (i915, &eb);
@@ -638,11 +640,13 @@ static void semaphore_noskip(int i915)/* Cancel the following spinner */ *cs++ =MI_STORE_DWORD_IMM ;if (gen >=8 ) { - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[IGT_SPIN_BATCH ].offset + +offset_in_page (spin->condition); *cs++ =0 ; }else { *cs++ =0 ; - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[IGT_SPIN_BATCH ].offset + +offset_in_page (spin->condition); } *cs++ =MI_BATCH_BUFFER_END ;
@@ -651,9 +655,9 @@ static void semaphore_noskip(int i915)/* port0: implicit semaphore from engine */ memset (obj,0 ,sizeof (obj)); - obj[0 ] = chain->obj[1 ]; + obj[0 ] = chain->obj[IGT_SPIN_BATCH ]; obj[0 ].flags |=EXEC_OBJECT_WRITE ; - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[IGT_SPIN_BATCH ]; obj[2 ].handle = handle;memset (&eb,0 ,sizeof (eb)); eb.buffer_count =3 ;
@@ -666,7 +670,7 @@ static void semaphore_noskip(int i915)memset (obj,0 ,sizeof (obj)); obj[0 ].handle = handle; obj[0 ].flags =EXEC_OBJECT_WRITE ; - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[IGT_SPIN_BATCH ];memset (&eb,0 ,sizeof (eb)); eb.buffer_count =2 ; eb.buffers_ptr =to_user_pointer (obj);
@@ -842,7 +846,8 @@ static igt_spin_t *__noise(int fd, uint32_t ctx, int prio, igt_spin_t *spin) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr = +to_user_pointer (&spin->obj[IGT_SPIN_BATCH ]), .rsvd1 = ctx, .flags = other, };
tests/i915/gem_softpin.c +1 -1
@@ -360,7 +360,7 @@ static void test_evict_hang(int fd) execbuf.buffer_count =1 ; hang =igt_hang_ctx (fd,0 ,0 ,0 ); - expected = hang.spin->obj[1 ].offset; + expected = hang.spin->obj[IGT_SPIN_BATCH ].offset;/* Replace the hung batch with ourselves, forcing an eviction */ object.offset = expected;
tests/i915/gem_spin_batch.c +2 -2
@@ -79,7 +79,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr =to_user_pointer (&spin->obj[IGT_SPIN_BATCH ]), .rsvd1 = ctx1, };
@@ -98,7 +98,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)igt_spin_end (spin); -gem_sync (fd, spin->obj[1 ].handle); +gem_sync (fd, spin->handle);igt_spin_free (fd, spin);
tests/i915/i915_hangman.c +1 -1
@@ -209,7 +209,7 @@ static void test_error_state_capture(unsigned ring_id,clear_error_state (); hang =igt_hang_ctx (device,0 , ring_id,HANG_ALLOW_CAPTURE ); - offset = hang.spin->obj[1 ].offset; + offset = hang.spin->obj[IGT_SPIN_BATCH ].offset; batch =gem_mmap__cpu (device, hang.spin->handle,0 ,4096 ,PROT_READ );gem_set_domain (device, hang.spin->handle,I915_GEM_DOMAIN_CPU ,0 );
Signature · 6 lines
2.17.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Mika Kuoppala (2019-05-22 10:34:02)
Quoted 64 lines
Instead of relying a static obj array inside
igt_spin_t, access it with proper indexing.v2:
IGT_SPIN_BATCHCc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>--- lib/igt_dummyload.c | 13 ++++++------- lib/igt_dummyload.h | 1 + tests/i915/gem_exec_schedule.c | 25 +++++++++++++++---------- tests/i915/gem_softpin.c | 2 +- tests/i915/gem_spin_batch.c | 4 ++-- tests/i915/i915_hangman.c | 2 +- 6 files changed, 26 insertions(+), 21 deletions(-)lib/igt_dummyload.c +6
-7@@ -72,7 +72,7 @@ emit_recursive_batch(igt_spin_t *spin, int fd, const struct igt_spin_factory *opts) { #define SCRATCH 0 -#define BATCH 1 +#define BATCH IGT_SPIN_BATCH const int gen = intel_gen(intel_get_drm_devid(fd));struct drm_i915_gem_relocation_entry relocs[2 ], *r;struct drm_i915_gem_execbuffer2 *execbuf;@@ -261,12 +261,11 @@ emit_recursive_batch(igt_spin_t *spin,igt_assert_lt (cs - batch,BATCH_SIZE /sizeof (*cs));/* Make it easier for callers to resubmit. */ - - obj[BATCH ].relocation_count =0 ; - obj[BATCH ].relocs_ptr =0 ; - - obj[SCRATCH ].flags =EXEC_OBJECT_PINNED ; - obj[BATCH ].flags =EXEC_OBJECT_PINNED ; +for (i =0 ; i <ARRAY_SIZE (spin->obj); i++) { + spin->obj[i].relocation_count =0 ; + spin->obj[i].relocs_ptr =0 ; + spin->obj[i].flags =EXEC_OBJECT_PINNED ; + } spin->cmd_precondition = *spin->condition;lib/igt_dummyload.h +1
-0@@ -42,6 +42,7 @@ typedef struct igt_spin {int out_fence;struct drm_i915_gem_exec_object2 obj[2 ]; +#define IGT_SPIN_BATCH 1struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle;uint32_t *poll;tests/i915/gem_exec_schedule.c +0
-0
tests/i915/gem_exec_schedule.c static void independent(int fd, unsigned int engine) · line 238
Quoted 6 lines
tests/i915/gem_exec_schedule.c +2
-1@@ -234,7 +234,8 @@ static void independent(int fd, unsigned int engine) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr = to_user_pointer(&spin->obj[1]), + .buffers_ptr = + to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
That should have an extra level of indent, at which point realise the attempt to avoid the 80col is moot and just keep it on one long line.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 1/1 lib/dummyload: Cleanup access to spin obj array
Instead of relying a static obj array inside igt_spin_t, access it with proper indexing.
v2: IGT_SPIN_BATCH
v3: indent
--- lib/igt_dummyload.c | 13 ++++++------- lib/igt_dummyload.h | 1 + tests/i915/gem_exec_schedule.c | 23 +++++++++++++---------- tests/i915/gem_softpin.c | 2 +- tests/i915/gem_spin_batch.c | 4 ++-- tests/i915/i915_hangman.c | 2 +- 6 files changed, 24 insertions(+), 21 deletions(-)
lib/igt_dummyload.c +6 -7
@@ -72,7 +72,7 @@ emit_recursive_batch(igt_spin_t *spin, int fd, const struct igt_spin_factory *opts) { #define SCRATCH 0 -#define BATCH 1 +#define BATCH IGT_SPIN_BATCH const int gen = intel_gen(intel_get_drm_devid(fd));struct drm_i915_gem_relocation_entry relocs[2 ], *r;struct drm_i915_gem_execbuffer2 *execbuf;
@@ -261,12 +261,11 @@ emit_recursive_batch(igt_spin_t *spin,igt_assert_lt (cs - batch,BATCH_SIZE /sizeof (*cs));/* Make it easier for callers to resubmit. */ - - obj[BATCH ].relocation_count =0 ; - obj[BATCH ].relocs_ptr =0 ; - - obj[SCRATCH ].flags =EXEC_OBJECT_PINNED ; - obj[BATCH ].flags =EXEC_OBJECT_PINNED ; +for (i =0 ; i <ARRAY_SIZE (spin->obj); i++) { + spin->obj[i].relocation_count =0 ; + spin->obj[i].relocs_ptr =0 ; + spin->obj[i].flags =EXEC_OBJECT_PINNED ; + } spin->cmd_precondition = *spin->condition;
lib/igt_dummyload.h +1 -0
@@ -42,6 +42,7 @@ typedef struct igt_spin {int out_fence;struct drm_i915_gem_exec_object2 obj[2 ]; +#define IGT_SPIN_BATCH 1struct drm_i915_gem_execbuffer2 execbuf;uint32_t poll_handle;uint32_t *poll;
tests/i915/gem_exec_schedule.c +13 -10
@@ -234,7 +234,7 @@ static void independent(int fd, unsigned int engine) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr =to_user_pointer (&spin->obj[IGT_SPIN_BATCH ]), .flags = other, };gem_execbuf (fd, &eb);
@@ -537,7 +537,8 @@ static void semaphore_resolve(int i915)/* Then cancel the spinner */ *cs++ =MI_STORE_DWORD_IMM ; - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[IGT_SPIN_BATCH ].offset + +offset_in_page (spin->condition); *cs++ =0 ; *cs++ =MI_BATCH_BUFFER_END ;
@@ -548,7 +549,7 @@ static void semaphore_resolve(int i915)/* First up is our spinning semaphore */ memset (obj,0 ,sizeof (obj)); - obj[0 ] = spin->obj[1 ]; + obj[0 ] = spin->obj[IGT_SPIN_BATCH ]; obj[1 ].handle = semaphore; obj[1 ].offset =SEMAPHORE_ADDR ; obj[1 ].flags =EXEC_OBJECT_PINNED ;
@@ -562,7 +563,7 @@ static void semaphore_resolve(int i915)memset (obj,0 ,sizeof (obj)); obj[0 ].handle = handle; obj[0 ].flags =EXEC_OBJECT_WRITE ;/* always after semaphore */ - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[IGT_SPIN_BATCH ]; eb.buffer_count =2 ; eb.rsvd1 =0 ;gem_execbuf (i915, &eb);
@@ -638,11 +639,13 @@ static void semaphore_noskip(int i915)/* Cancel the following spinner */ *cs++ =MI_STORE_DWORD_IMM ;if (gen >=8 ) { - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[IGT_SPIN_BATCH ].offset + +offset_in_page (spin->condition); *cs++ =0 ; }else { *cs++ =0 ; - *cs++ = spin->obj[1 ].offset +offset_in_page (spin->condition); + *cs++ = spin->obj[IGT_SPIN_BATCH ].offset + +offset_in_page (spin->condition); } *cs++ =MI_BATCH_BUFFER_END ;
@@ -651,9 +654,9 @@ static void semaphore_noskip(int i915)/* port0: implicit semaphore from engine */ memset (obj,0 ,sizeof (obj)); - obj[0 ] = chain->obj[1 ]; + obj[0 ] = chain->obj[IGT_SPIN_BATCH ]; obj[0 ].flags |=EXEC_OBJECT_WRITE ; - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[IGT_SPIN_BATCH ]; obj[2 ].handle = handle;memset (&eb,0 ,sizeof (eb)); eb.buffer_count =3 ;
@@ -666,7 +669,7 @@ static void semaphore_noskip(int i915)memset (obj,0 ,sizeof (obj)); obj[0 ].handle = handle; obj[0 ].flags =EXEC_OBJECT_WRITE ; - obj[1 ] = spin->obj[1 ]; + obj[1 ] = spin->obj[IGT_SPIN_BATCH ];memset (&eb,0 ,sizeof (eb)); eb.buffer_count =2 ; eb.buffers_ptr =to_user_pointer (obj);
@@ -842,7 +845,7 @@ static igt_spin_t *__noise(int fd, uint32_t ctx, int prio, igt_spin_t *spin) }else {struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr =to_user_pointer (&spin->obj[IGT_SPIN_BATCH ]), .rsvd1 = ctx, .flags = other, };
tests/i915/gem_softpin.c +1 -1
@@ -360,7 +360,7 @@ static void test_evict_hang(int fd) execbuf.buffer_count =1 ; hang =igt_hang_ctx (fd,0 ,0 ,0 ); - expected = hang.spin->obj[1 ].offset; + expected = hang.spin->obj[IGT_SPIN_BATCH ].offset;/* Replace the hung batch with ourselves, forcing an eviction */ object.offset = expected;
tests/i915/gem_spin_batch.c +2 -2
@@ -79,7 +79,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)struct drm_i915_gem_execbuffer2 eb = { .buffer_count =1 , - .buffers_ptr =to_user_pointer (&spin->obj[1 ]), + .buffers_ptr =to_user_pointer (&spin->obj[IGT_SPIN_BATCH ]), .rsvd1 = ctx1, };
@@ -98,7 +98,7 @@ static void spin_resubmit(int fd, unsigned int engine, unsigned int flags)igt_spin_end (spin); -gem_sync (fd, spin->obj[1 ].handle); +gem_sync (fd, spin->handle);igt_spin_free (fd, spin);
tests/i915/i915_hangman.c +1 -1
@@ -209,7 +209,7 @@ static void test_error_state_capture(unsigned ring_id,clear_error_state (); hang =igt_hang_ctx (device,0 , ring_id,HANG_ALLOW_CAPTURE ); - offset = hang.spin->obj[1 ].offset; + offset = hang.spin->obj[IGT_SPIN_BATCH ].offset; batch =gem_mmap__cpu (device, hang.spin->handle,0 ,4096 ,PROT_READ );gem_set_domain (device, hang.spin->handle,I915_GEM_DOMAIN_CPU ,0 );
Signature · 6 lines
2.17.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 2 lines · Chris Wilson
Reviewed-by Chris Wilson <[email protected]>
Pushed, thanks for review.
-Mika
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for lib/dummyload: Cleanup access to spin obj array (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: lib/dummyload: Cleanup access to spin obj array (rev3)
URL : https://patchwork.freedesktop.org/series/60947/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6118 -> IGTPW_3021
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60947/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_3021 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2] ([fdo#110620])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@gem_exec_basic@readonly-blt:
- {fi-icl-u2}: [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-icl-u2/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6700k2: [INCOMPLETE][5] ([fdo#104108]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-skl-6700k2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-skl-6700k2/igt@[email protected]
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-blb-e6850/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-blb-e6850/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: [INCOMPLETE][9] ([fdo#103927] / [fdo#109720]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-apl-guc/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-apl-guc/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [INCOMPLETE][11] ([fdo#108602] / [fdo#108744]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
#### Warnings ####
* igt@runner@aborted:
- fi-apl-guc: [FAIL][13] ([fdo#108622] / [fdo#109720]) -> [FAIL][14] ([fdo#110622])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/fi-apl-guc/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/fi-apl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110620]: https://bugs.freedesktop.org/show_bug.cgi?id=110620
[fdo#110622]: https://bugs.freedesktop.org/show_bug.cgi?id=110622
Participating hosts (52 -> 46)
------------------------------
Additional (1): fi-hsw-peppy
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5002 -> IGTPW_3021
CI_DRM_6118: baf7701210779020b71d4d67f8c0a96afd567c22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3021: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/
IGT_5002: c27de2a2a3be7302eb8d23a9f0e6d654c64292f0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for lib/dummyload: Cleanup access to spin obj array (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: lib/dummyload: Cleanup access to spin obj array (rev3)
URL : https://patchwork.freedesktop.org/series/60947/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6118_full -> IGTPW_3021_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60947/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_3021_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_cpu_reloc@full:
- shard-glk: [PASS][1] -> [INCOMPLETE][2] ([fdo#103359] / [k.org#198133])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk2/igt@[email protected]
* igt@kms_flip@bo-too-big:
- shard-hsw: [PASS][3] -> [INCOMPLETE][4] ([fdo#103540])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-hsw7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-hsw4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][5] -> [FAIL][6] ([fdo#103167]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-pgflip-blt:
- shard-glk: [PASS][7] -> [FAIL][8] ([fdo#103167])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk7/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109441]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][11] -> [FAIL][12] ([fdo#99912])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-kbl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-kbl7/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-apl5/igt@[email protected]
* igt@perf_pmu@rc6-runtime-pm:
- shard-glk: [PASS][15] -> [FAIL][16] ([fdo#105010])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk5/igt@[email protected]
- shard-apl: [PASS][17] -> [FAIL][18] ([fdo#105010])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-apl8/igt@[email protected]
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#105010])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb1/igt@[email protected]
- shard-hsw: [PASS][21] -> [FAIL][22] ([fdo#105010])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-hsw1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-hsw7/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-apl5/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [DMESG-WARN][25] ([fdo#108686]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk2/igt@[email protected]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-glk: [INCOMPLETE][27] ([fdo#103359] / [k.org#198133]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk1/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [FAIL][29] ([fdo#103355]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-hsw1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-hsw8/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][31] ([fdo#109349]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-glk: [FAIL][33] ([fdo#100368]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [FAIL][35] ([fdo#102887] / [fdo#105363]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-apl1/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [INCOMPLETE][37] ([fdo#103665]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-kbl3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-kbl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-kbl: [FAIL][39] ([fdo#103167]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
- shard-apl: [FAIL][41] ([fdo#103167]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
- shard-glk: [FAIL][43] ([fdo#103167]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-glk4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-glk1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][45] ([fdo#103167]) -> [PASS][46] +9 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][47] ([fdo#103166]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][51] ([fdo#100047]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb2/igt@kms_sysfs_edid_timing.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb5/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@gem_mmap_gtt@forked-big-copy-odd:
- shard-iclb: [INCOMPLETE][53] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][54] ([fdo#109673])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-iclb1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-iclb3/igt@[email protected]
* igt@kms_busy@extended-modeset-hang-newfb-render-e:
- shard-apl: [INCOMPLETE][55] ([fdo#103927]) -> [SKIP][56] ([fdo#109271] / [fdo#109278])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6118/shard-apl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/shard-apl8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5002 -> IGTPW_3021
* Piglit: piglit_4509 -> None
CI_DRM_6118: baf7701210779020b71d4d67f8c0a96afd567c22 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3021: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/
IGT_5002: c27de2a2a3be7302eb8d23a9f0e6d654c64292f0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3021/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev