fix GCC BUG 71124 and 85862
cover fix GCC BUG 71124 and 85862
Following 'Fix GCC BUG 85180 per-package' patchset:
https://patchwork.ozlabs.org/project/buildroot/list/?series=109024
this patchset makes possible to build packages affected by GCC bugs 71124 and 85862.
Giulio Benetti (8):
toolchain: GCC bug 71124
package/sqlite: fix BUG_71124 build timeout package/ffmpeg: re-enable package if BUG_71124 is present package/assimp: re-enable package if BR2_microblaze is enabled package/libnss: re-enable package if BUG_85862 is present package/ecryptfs-utils: allow building with GCC_BUG_85862 and on
Microblaze
package/qt5webengine: re-enable building if BUG_85682=y on latest Qt5 package/flashbench: remove old check if BR2_microblaze & BR2_sh2a
package/assimp/Config.in | 5 ----- package/assimp/assimp.mk | 4 ++++ package/ecryptfs-utils/Config.in | 6 ------ package/ffmpeg/Config.in | 2 -- package/ffmpeg/ffmpeg.mk | 5 +++++ package/flashbench/flashbench.mk | 5 ----- package/libnss/Config.in | 4 ---- package/libnss/libnss.mk | 8 ++++++-- package/qt5/qt5webengine/Config.in | 6 ------ package/sqlite/sqlite.mk | 4 ++++ toolchain/Config.in | 7 +++++++ 11 files changed, 26 insertions(+), 30 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/8 toolchain: GCC bug 71124
GCC < 8.x hangs while building sqlite for the Microblaze Arch.
Reported:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124
Similar to:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
--- toolchain/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)
toolchain/Config.in +7 -0
@@ -124,6 +124,13 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 default y if !BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS && \ !BR2_TOOLCHAIN_GCC_AT_LEAST_7 +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124. This bug no +# longer exists in gcc 8.x. +config BR2_TOOLCHAIN_HAS_GCC_BUG_71124 + bool + default y if BR2_microblaze + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 + # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. This bug no # longer exists in gcc 8.x. config BR2_TOOLCHAIN_HAS_GCC_BUG_85180
Signature · 1 line
2.17.1
PATCH 2/8 package/sqlite: fix BUG_71124 build timeout
In reply to Giulio BenettiWith Microblaze Gcc version < 8.x build hangs on compiling last files before linking.
This is due to bug 71124:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124
Bug shows up building sqlite with optimization but not when building with -O0.
If BR2_TOOLCHAIN_HAS_GCC_BUG_71124=y force using -O0 passing it to SQLITE_CFLAGS.
--- package/sqlite/sqlite.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/sqlite/sqlite.mk +4 -0
@@ -39,8 +39,12 @@ ifeq ($(BR2_PACKAGE_SQLITE_NO_SYNC),y) SQLITE_CFLAGS += -DSQLITE_NO_SYNC endif +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_71124),y) +SQLITE_CFLAGS += -O0 +else # fallback to standard -O3 when -Ofast is present to avoid -ffast-math SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS)) +endif SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
Signature · 1 line
2.17.1
PATCH 3/8 package/ffmpeg: re-enable package if BUG_71124 is present
In reply to Giulio BenettiWith Microblaze Gcc version < 8.x build hangs on compiling. This is due to bug 71124:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124
This package has been excluded from building if BUG_71124 is present. Bug shows up building ffmpeg with optimization.
In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_71124=y force using -O0 by:
- add --disable-optimizations to FFMPEG_CONF_OPTS
- passing -O0 to CFLAGS in FFMPEG_CONF_ENV
Then remove 'depends on !BR2_microblaze' from Config.in
--- package/ffmpeg/Config.in | 2 -- package/ffmpeg/ffmpeg.mk | 5 +++++ 2 files changed, 5 insertions(+), 2 deletions(-)
package/ffmpeg/Config.in +0 -2
@@ -7,8 +7,6 @@ config BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS depends on !BR2_nios2 # No support for ARMv7-M in the ARM assembly logic depends on !BR2_ARM_CPU_ARMV7M - # Microblaze build affected by gcc PR71124 (infinite loop) - depends on !BR2_microblaze # m68k coldfire causes a build failure, because the check for # atomics (atomic_store) succeeds, which causes ffmpeg to # think atomic intrinsics are available, while they are
package/ffmpeg/ffmpeg.mk +5 -0
@@ -525,6 +525,11 @@ endif FFMPEG_CONF_OPTS += $(call qstrip,$(BR2_PACKAGE_FFMPEG_EXTRACONF)) +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_71124),y) +FFMPEG_CONF_OPTS += --disable-optimizations +FFMPEG_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0" +endif + # Override FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others define FFMPEG_CONFIGURE_CMDS (cd $(FFMPEG_SRCDIR) && rm -rf config.cache && \
Signature · 1 line
2.17.1
PATCH 4/8 package/assimp: re-enable package if BR2_microblaze is enabled
In reply to Giulio BenettiWith Microblaze Gcc version < 8.x build hangs on compiling first files. This is due to bug 71124:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124
This package has been excluded from building if BR2_microblaze is enabled.
Bug shows up building assimp with optimization but not when building with -O0.
In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_71124=y force using -O0 by:
- passing -O0 to ASSIMP_CXXFLAGS
Then remove 'depends on !BR2_microblaze' and its comment if not available from Config.in
--- package/assimp/Config.in | 5 ----- package/assimp/assimp.mk | 4 ++++ 2 files changed, 4 insertions(+), 5 deletions(-)
package/assimp/Config.in +0 -5
@@ -1,9 +1,5 @@ config BR2_PACKAGE_ASSIMP bool "assimp" - # All gcc versions affected by - # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124, that - # cause an infinite loop in gcc when building this package. - depends on !BR2_microblaze depends on BR2_INSTALL_LIBSTDCPP select BR2_PACKAGE_ZLIB help
@@ -16,5 +12,4 @@ config BR2_PACKAGE_ASSIMP http://www.assimp.org comment "assimp needs a toolchain w/ C++" - depends on !BR2_microblaze depends on !BR2_INSTALL_LIBSTDCPP
package/assimp/assimp.mk +4 -0
@@ -24,6 +24,10 @@ ifeq ($(BR2_sh):$(BR2_STATIC_LIBS):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:y:) ASSIMP_CXXFLAGS += -O2 endif +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) +ASSIMP_CXXFLAGS += -O0 +endif + ASSIMP_CONF_OPTS += -DASSIMP_BUILD_TESTS=OFF \ -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) $(ASSIMP_CXXFLAGS)"
Signature · 1 line
2.17.1
PATCH 5/8 package/libnss: re-enable package if BUG_85862 is present
In reply to Giulio BenettiWith Microblaze Gcc version < 7.x build hangs on compiling first files. This is due to bug 85862:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
This package has been excluded from building if BUG_85862 is present. Bug shows up building libnss with optimization.
In config.mk append BUILD_OPT=1 only if BR2_TOOLCHAIN_HAS_GCC_BUG_85862=y otherwise don't declare BUILD_OPT forcing build system to not emit -O* flag.
Then remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and its comment if not available from Config.in
--- package/libnss/Config.in | 4 ---- package/libnss/libnss.mk | 8 ++++++-- 2 files changed, 6 insertions(+), 6 deletions(-)
package/libnss/Config.in +0 -4
@@ -3,7 +3,6 @@ config BR2_PACKAGE_LIBNSS depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr depends on !BR2_STATIC_LIBS - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 select BR2_PACKAGE_LIBNSPR select BR2_PACKAGE_SQLITE select BR2_PACKAGE_ZLIB
@@ -19,6 +18,3 @@ config BR2_PACKAGE_LIBNSS comment "libnss needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - -comment "libnss needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862
package/libnss/libnss.mk +6 -2
@@ -13,6 +13,7 @@ LIBNSS_DEPENDENCIES = libnspr sqlite zlib LIBNSS_LICENSE = MPL-2.0 LIBNSS_LICENSE_FILES = nss/COPYING + # --gc-sections triggers binutils ld segfault # https://sourceware.org/bugzilla/show_bug.cgi?id=21180 ifeq ($(BR2_microblaze),y)
@@ -33,7 +34,6 @@ LIBNSS_BUILD_VARS = \ MOZILLA_CLIENT=1 \ NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \ NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \ - BUILD_OPT=1 \ NS_USE_GCC=1 \ NSS_DISABLE_GTESTS=1 \ NSS_USE_SYSTEM_SQLITE=1 \
@@ -43,6 +43,10 @@ LIBNSS_BUILD_VARS = \ OS_RELEASE="2.6" \ OS_TEST="$(LIBNSS_ARCH)" +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85862),) +LIBNSS_BUILD_VARS += BUILD_OPT=1 +endif + # #pragma usage needs gcc >= 4.8 # See https://bugzilla.mozilla.org/show_bug.cgi?id=1226179 ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_4_8),)
@@ -62,7 +66,7 @@ define LIBNSS_BUILD_CMDS SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \ DIST=$(@D)/$(LIBNSS_DISTDIR) \ CHECKLOC= \ - $(LIBNSS_BUILD_VARS) + $(LIBNSS_BUILD_VARS) CFLAGS="$(LIBNSS_CFLAGS)" $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/nss lib/dbm all \ SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \ DIST=$(@D)/$(LIBNSS_DISTDIR) \
Signature · 1 line
2.17.1
PATCH 6/8 package/ecryptfs-utils: allow building with GCC_BUG_85862 and on Microblaze
In reply to Giulio Benettilibnss gcc bug 85862 has been worked around and that caused build failure on Microblaze.
Remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and 'depends on !BR2_microblaze' from Config.in allowing this package to build.
--- package/ecryptfs-utils/Config.in | 6 ------ 1 file changed, 6 deletions(-)
package/ecryptfs-utils/Config.in +0 -6
@@ -2,12 +2,10 @@ config BR2_PACKAGE_ECRYPTFS_UTILS bool "ecryptfs-utils" depends on BR2_USE_WCHAR # gettext depends on BR2_USE_MMU # keyutils - depends on !BR2_microblaze # keyutils depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr depends on !BR2_MIPS_NABI32 # libnss depends on !BR2_STATIC_LIBS # libnss, keyutils - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # microblaze specific & GCC < 7.x select BR2_PACKAGE_KEYUTILS select BR2_PACKAGE_LIBNSS # runtime dependency only, some scripts are using the
@@ -31,11 +29,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS http://ecryptfs.org comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynami library" - depends on !BR2_microblaze depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ BR2_STATIC_LIBS - -comment "ecryptfs needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # libnss
Signature · 1 line
2.17.1
PATCH 7/8 package/qt5webengine: re-enable building if BUG_85682=y on latest Qt5
In reply to Giulio Benetti'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' is listed because libnss was affected by that bug in latest Qt5, but now that bug has been worked around.
So remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and allow building latest Qt5 by removing also '|| BR2_PACKAGE_QT5_VERSION_5_6'.
--- package/qt5/qt5webengine/Config.in | 6 ------ 1 file changed, 6 deletions(-)
package/qt5/qt5webengine/Config.in +0 -6
@@ -20,18 +20,12 @@ comment "qt5webengine needs an OpenGL and EGL-capable backend" depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS depends on !BR2_PACKAGE_QT5_GL_AVAILABLE || !BR2_PACKAGE_HAS_LIBEGL -comment "qt5webengine needs a toolchain not affected by GCC bug 85862" - depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS - depends on !BR2_PACKAGE_QT5_VERSION_5_6 - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # libnss - config BR2_PACKAGE_QT5WEBENGINE bool "qt5webengine" depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h, mallinfo depends on BR2_HOST_GCC_AT_LEAST_4_8 # qt5base-icu depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # qt5base-icu - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus depends on BR2_USE_WCHAR # libglib2 depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, qt5base-eglfs
Signature · 1 line
2.17.1
PATCH 8/8 package/flashbench: remove old check if BR2_microblaze & BR2_sh2a
In reply to Giulio BenettiCommit:
https://git.buildroot.net/buildroot/commit/?id=bad25aff36b70b55b34ea4580b45f657385ae9ac
removed sourcery toolchain already deprecated in 2014 causing build failure. It was based on Gcc 4.6.2 and Buildroot doesn't use this anymore.
Remove check against BR2_microblaze and BR2_sh2a.
--- package/flashbench/flashbench.mk | 5 ----- 1 file changed, 5 deletions(-)
package/flashbench/flashbench.mk +0 -5
@@ -11,11 +11,6 @@ FLASHBENCH_LICENSE_FILES = COPYING FLASHBENCH_CFLAGS = $(TARGET_CFLAGS) -ifeq ($(BR2_microblaze)$(BR2_sh2a),y) -# microblaze and sh2a toolchains only provide LLONG_MAX when used with gnu99 dialect -FLASHBENCH_CFLAGS += -std=gnu99 -endif - define FLASHBENCH_BUILD_CMDS $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \ CFLAGS="$(FLASHBENCH_CFLAGS)" \
Signature · 1 line
2.17.1
cover fix GCC BUG 71124 and 85862
In reply to Giulio BenettiHello Giulio,
Quoted 4 lines · On Wed, 22 May 2019 14:25:34 +0200 Giulio Benetti…
Following 'Fix GCC BUG 85180 per-package' patchset:
https://patchwork.ozlabs.org/project/buildroot/list/?series=109024
this patchset makes possible to build packages affected by GCC bugs 71124 and 85862.
Is there any evidence that bug 71124 and 85180 are different ?
When there is an infinite loop when building a package on Microblaze, how do you know if it's caused by gcc bug 71124 or gcc bug 85180 ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
cover fix GCC BUG 71124 and 85862
Hello Thomas,
Il 22/05/2019 14:31, Thomas Petazzoni ha scritto:
Quoted 10 lines
Hello Giulio,
Quoted 4 lines · On Wed, 22 May 2019 14:25:34 +0200 Giulio Benetti…
Following 'Fix GCC BUG 85180 per-package' patchset:
https://patchwork.ozlabs.org/project/buildroot/list/?series=109024
this patchset makes possible to build packages affected by GCC bugs 71124 and 85862.
Quoted 4 lines
Is there any evidence that bug 71124 and 85180 are different ?
When there is an infinite loop when building a package on Microblaze, how do you know if it's caused by gcc bug 71124 or gcc bug 85180 ?
Actually not, I only based it on comments present inside Config.in, but almost probably they are the same.
Maybe is it better to fuse them into 85180?
Also, do i need to send these for next branch?
Because these patches don't fix bug, they only allow to build packages that before were not available.
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
Quoted 4 lines
Best regards,
Thomas
cover fix GCC BUG 71124 and 85862
Hello,
Quoted 6 lines · On Wed, 22 May 2019 14:34:53 +0200 Giulio Benetti…
Quoted 2 lines
When there is an infinite loop when building a package on Microblaze, how do you know if it's caused by gcc bug 71124 or gcc bug 85180 ?
Actually not, I only based it on comments present inside Config.in, but almost probably they are the same.
Maybe is it better to fuse them into 85180?
I would suggest so, and perhaps we can mark 71124 as a duplicate of 85180 on the gcc bug tracker as well.
Quoted 1 line
Also, do i need to send these for next branch?
As said on IRC: just base your patches in master. I think it's material from master, and if Peter/Arnout disagree, we will apply on next: there won't be much conflicts anyway, and if there's any, it will be a trivial conflict.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
cover fix GCC BUG 71124 and 85862
Hello,
Il 22/05/2019 15:02, Thomas Petazzoni ha scritto:
Quoted 8 lines
Hello,
Quoted 3 lines · On Wed, 22 May 2019 14:34:53 +0200 Giulio Benetti…
Quoted 2 lines
When there is an infinite loop when building a package on Microblaze, how do you know if it's caused by gcc bug 71124 or gcc bug 85180 ?
Quoted 6 lines
Quoted 3 lines
Actually not, I only based it on comments present inside Config.in, but almost probably they are the same.
Maybe is it better to fuse them into 85180?I would suggest so, and perhaps we can mark 71124 as a duplicate of 85180 on the gcc bug tracker as well.
Ok, I'm going to mark as duplicate on gcc bug tracker and fuse 71124 into 85180.
Quoted 6 lines
Quoted 1 line
Also, do i need to send these for next branch?
As said on IRC: just base your patches in master. I think it's material from master, and if Peter/Arnout disagree, we will apply on next: there won't be much conflicts anyway, and if there's any, it will be a trivial conflict.
Ok.
Thank you!
Kind regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
Quoted 4 lines
Best regards,
Thomas
v2 cover fix GCC BUG 85180 and 85862
Following 'Fix GCC BUG 85180 per-package' patchset:
https://patchwork.ozlabs.org/project/buildroot/list/?series=109024
this patchset makes possible to build packages affected by GCC bugs 85180 and 85862.
V1->V2:
* merge gcc bug 71124 into 85180 since they are the same 71124 has been marked as duplicate of 85180.
* removed patch 0001 where BUG_71124 was added since it's useless now
Giulio Benetti (7):
package/sqlite: fix BUG_85180 build timeout package/ffmpeg: re-enable package if BUG_85180 is present package/assimp: re-enable package if BR2_microblaze is enabled package/libnss: re-enable package if BUG_85862 is present package/ecryptfs-utils: allow building with GCC_BUG_85862 and on
Microblaze
package/qt5webengine: re-enable building if BUG_85682=y on latest Qt5 package/flashbench: remove old check if BR2_microblaze & BR2_sh2a
package/assimp/Config.in | 5 ----- package/assimp/assimp.mk | 4 ++++ package/ecryptfs-utils/Config.in | 6 ------ package/ffmpeg/Config.in | 2 -- package/ffmpeg/ffmpeg.mk | 5 +++++ package/flashbench/flashbench.mk | 5 ----- package/libnss/Config.in | 4 ---- package/libnss/libnss.mk | 8 ++++++-- package/qt5/qt5webengine/Config.in | 6 ------ package/sqlite/sqlite.mk | 4 ++++ 10 files changed, 19 insertions(+), 30 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
With Microblaze Gcc version < 8.x build hangs on compiling last files before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building sqlite with optimization but not when building with -O0.
If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to SQLITE_CFLAGS.
---V1->V2:
* use BUG_85180 instead of BUG_71124 since they are the same bug
package/sqlite/sqlite.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/sqlite/sqlite.mk +4 -0
@@ -39,8 +39,12 @@ ifeq ($(BR2_PACKAGE_SQLITE_NO_SYNC),y) SQLITE_CFLAGS += -DSQLITE_NO_SYNC endif +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) +SQLITE_CFLAGS += -O0 +else # fallback to standard -O3 when -Ofast is present to avoid -ffast-math SQLITE_CFLAGS += $(subst -Ofast,-O3,$(TARGET_CFLAGS)) +endif SQLITE_CONF_ENV = CFLAGS="$(SQLITE_CFLAGS)"
Signature · 1 line
2.17.1
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Quoted 11 lines · On Wed, 22 May 2019 15:59:00 +0200 Giulio Benetti…
With Microblaze Gcc version < 8.x build hangs on compiling last files before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building sqlite with optimization but not when building with -O0.If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
SQLITE_CFLAGS.Signed-off-by Giulio Benetti <[email protected]>
I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Hello Thomas,
Il 26/05/2019 00:14, Giulio Benetti ha scritto:
Quoted 18 lines
Il 24/05/2019 22:24, Thomas Petazzoni ha scritto:
Quoted 17 lines
Quoted 11 lines · On Wed, 22 May 2019 15:59:00 +0200 Giulio Benetti…
With Microblaze Gcc version < 8.x build hangs on compiling last files before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building sqlite with optimization but not when building with -O0.If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
SQLITE_CFLAGS.Signed-off-by Giulio Benetti <[email protected]>I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Sure, the problems comes out building libnss with gcc4.9/5/6/7. Here is pastebin of my savedefconfig:
https://pastebin.com/wmR8Dme3
I use external toolchains, but they are BR toolchains. The commit log is not precise, need to improve it.
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Hello,
Quoted 6 lines · On Mon, 27 May 2019 11:06:06 +0200 Giulio Benetti…
Quoted 2 lines
Quoted 2 lines
I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Sure, the problems comes out building libnss with gcc4.9/5/6/7. Here is pastebin of my savedefconfig:
https://pastebin.com/wmR8Dme3
I still don't understand. You're mentioning libnss, but your defconfig does not have libnss enabled. Am I missing something ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Il 27/05/2019 11:37, Thomas Petazzoni ha scritto:
Quoted 8 lines
Hello,
Quoted 3 lines · On Mon, 27 May 2019 11:06:06 +0200 Giulio Benetti…
Quoted 2 lines
Quoted 2 lines
I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Quoted 6 lines
Quoted 3 lines
Sure, the problems comes out building libnss with gcc4.9/5/6/7. Here is pastebin of my savedefconfig:
https://pastebin.com/wmR8Dme3I still don't understand. You're mentioning libnss, but your defconfig does not have libnss enabled. Am I missing something ?
Oh sorry, I use that defconfig and then I give:
"make libnss"
that causes 85180.
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Quoted 13 lines · On Mon, 27 May 2019 11:44:45 +0200 Giulio Benetti…
Il 27/05/2019 11:37, Thomas Petazzoni ha scritto:
Quoted 12 lines
Hello,
Quoted 6 lines · On Mon, 27 May 2019 11:06:06 +0200 Giulio Benetti…
Quoted 2 lines
Quoted 2 lines
I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Sure, the problems comes out building libnss with gcc4.9/5/6/7. Here is pastebin of my savedefconfig:
https://pastebin.com/wmR8Dme3
Quoted 7 lines
Quoted 2 lines
I still don't understand. You're mentioning libnss, but your defconfig does not have libnss enabled. Am I missing something ?
Oh sorry, I use that defconfig and then I give:
"make libnss"that causes 85180.
But then what is the relationship with sqlite ? Your original patch, which I'm replying to, is about fixing a build timeout in sqlite.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Il 27/05/2019 11:46, Thomas Petazzoni ha scritto:
Quoted 19 lines
Quoted 16 lines · On Mon, 27 May 2019 11:44:45 +0200 Giulio Benetti…
Il 27/05/2019 11:37, Thomas Petazzoni ha scritto:
Quoted 14 lines
Hello,
Quoted 6 lines · On Mon, 27 May 2019 11:06:06 +0200 Giulio Benetti…
Quoted 2 lines
Quoted 2 lines
I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Sure, the problems comes out building libnss with gcc4.9/5/6/7. Here is pastebin of my savedefconfig:
https://pastebin.com/wmR8Dme3I still don't understand. You're mentioning libnss, but your defconfig does not have libnss enabled. Am I missing something ?
Quoted 7 lines
Quoted 4 lines
Oh sorry, I use that defconfig and then I give:
"make libnss"that causes 85180.
But then what is the relationship with sqlite ? Your original patch, which I'm replying to, is about fixing a build timeout in sqlite.
Ah yes, sqlite is a dependency of libnss.
And now I've found that it happens only with Gcc 4.9
I've been confused because when compiling sqlite3.c file it takes a very long time with Gcc 5/6/7/8/9 and I thought they hanged.
Instead it hangs only with Gcc 4.9, so it's a different Gcc bug, not 85180. Need to check in gcc bugzilla, otherwise I should submit a new bug.
Can you try to build and check it hangs with gcc 4.9 and building sqlite during compiling sqlite3.c ?
This is to double check.
Thank you
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Hello Thomas,
adding Atharva+
Il 27/05/2019 12:20, Giulio Benetti ha scritto:
Quoted 28 lines
Il 27/05/2019 11:46, Thomas Petazzoni ha scritto:
Quoted 19 lines
Quoted 16 lines · On Mon, 27 May 2019 11:44:45 +0200 Giulio Benetti…
Il 27/05/2019 11:37, Thomas Petazzoni ha scritto:
Quoted 14 lines
Hello,
Quoted 7 lines · On Mon, 27 May 2019 11:06:06 +0200 Giulio Benetti…
Quoted 3 lines
Quoted 3 lines
I cannot reproduce this timeout, and you don't have any autobuilder failure. Could you provide a configuration that exhibits the failure ?
Sure, the problems comes out building libnss with gcc4.9/5/6/7. Here is pastebin of my savedefconfig:
https://pastebin.com/wmR8Dme3I still don't understand. You're mentioning libnss, but your defconfig does not have libnss enabled. Am I missing something ?
Quoted 7 lines
Quoted 4 lines
Oh sorry, I use that defconfig and then I give:
"make libnss"that causes 85180.
But then what is the relationship with sqlite ? Your original patch, which I'm replying to, is about fixing a build timeout in sqlite.
Quoted 6 lines
Ah yes, sqlite is a dependency of libnss.
And now I've found that it happens only with Gcc 4.9
I've been confused because when compilingsqlite3.cfile it takes a very long time with Gcc 5/6/7/8/9 and I thought they hanged.
Instead it hangs only with Gcc 4.9, so it's a different Gcc bug, not 85180. Need to check in gcc bugzilla, otherwise I should submit a new bug.
It's a Gcc 4.9 only bug that I need to submit to gcc bugzilla.
Atharva built it and found it hangs while compiling sqlite3.c as me.
So, after submitting Gcc bug I'm going to add that bug to toolchain's Config.in and setting -O0 in sqlite.mk if that bug=y
Then I rewrite commit log and resubmit, but at this point this is not part of this patchset.
Right?
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Quoted 1 line · Giulio Benetti
It's a Gcc 4.9 only bug that I need to submit to gcc bugzilla.
There's not much point to submit a bug for GCC 4.9, which is no longer
maintained...
Regards,
Arnout
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Il 27/05/2019 23:11, Arnout Vandecappelle ha scritto:
Quoted 7 lines · Giulio Benetti
Quoted 1 line
It's a Gcc 4.9 only bug that I need to submit to gcc bugzilla.
There's not much point to submit a bug for GCC 4.9, which is no longer
maintained...
Ah, I didn't know it's maintained anymore.
So in this case I can base the rule for using -O0 on BR2_TOOLCHAIN_GCC_AT_LEAST_5 and comment on top of it. At the moment sqlite is the only package suffering from this.
Thank you
Kind regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Quoted 6 lines · Giulio Benetti
Il 27/05/2019 23:11, Arnout Vandecappelle ha scritto:
Quoted 5 lines · Giulio Benetti
Quoted 1 line
It's a Gcc 4.9 only bug that I need to submit to gcc bugzilla.
Quoted 7 lines
Quoted 2 lines
? There's not much point to submit a bug for GCC 4.9, which is no longer maintained...
Ah, I didn't know it's maintained anymore.
So in this case I can base the rule for using -O0 onBR2_TOOLCHAIN_GCC_AT_LEAST_5and comment on top of it. At the moment sqlite is the only package suffering from this.
You mean, without introducing a _GCC_HAS_BUG_ option, right? Sounds good to me.
Regards,
Arnout
PATCH v2 1/7 package/sqlite: fix BUG_85180 build timeout
Il 27/05/2019 23:28, Arnout Vandecappelle ha scritto:
Quoted 12 lines · Giulio Benetti
Quoted 9 lines
Il 27/05/2019 23:11, Arnout Vandecappelle ha scritto:
Quoted 7 lines · Giulio Benetti
Quoted 1 line
It's a Gcc 4.9 only bug that I need to submit to gcc bugzilla.
? There's not much point to submit a bug for GCC 4.9, which is no longer
maintained...
Quoted 6 lines
Quoted 4 lines
Ah, I didn't know it's maintained anymore.
So in this case I can base the rule for using -O0 onBR2_TOOLCHAIN_GCC_AT_LEAST_5and comment on top of it. At the moment sqlite is the only package suffering from this.You mean, without introducing a _GCC_HAS_BUG_ option, right? Sounds good to me.
Yes. I hope there won't be other packages affected by this, but since 4.9 is no longer maintained I don't see other way, excect adding internal special _GCC_HAS_BUG_ but I think that could mess things up.
Kind regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 2/7 package/ffmpeg: re-enable package if BUG_85180 is present
In reply to Giulio BenettiWith Microblaze Gcc version < 8.x build hangs on compiling. This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
This package has been excluded from building if BUG_85180 is present. Bug shows up building ffmpeg with optimization.
In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- add --disable-optimizations to FFMPEG_CONF_OPTS
- passing -O0 to CFLAGS in FFMPEG_CONF_ENV
Then remove 'depends on !BR2_microblaze' from Config.in
---V1->V2:
* use BUG_85180 instead of BUG_71124 since they are the same bug
package/ffmpeg/Config.in | 2 -- package/ffmpeg/ffmpeg.mk | 5 +++++ 2 files changed, 5 insertions(+), 2 deletions(-)
package/ffmpeg/Config.in +0 -2
@@ -7,8 +7,6 @@ config BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS depends on !BR2_nios2 # No support for ARMv7-M in the ARM assembly logic depends on !BR2_ARM_CPU_ARMV7M - # Microblaze build affected by gcc PR71124 (infinite loop) - depends on !BR2_microblaze # m68k coldfire causes a build failure, because the check for # atomics (atomic_store) succeeds, which causes ffmpeg to # think atomic intrinsics are available, while they are
package/ffmpeg/ffmpeg.mk +5 -0
@@ -525,6 +525,11 @@ endif FFMPEG_CONF_OPTS += $(call qstrip,$(BR2_PACKAGE_FFMPEG_EXTRACONF)) +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) +FFMPEG_CONF_OPTS += --disable-optimizations +FFMPEG_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0" +endif + # Override FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others define FFMPEG_CONFIGURE_CMDS (cd $(FFMPEG_SRCDIR) && rm -rf config.cache && \
Signature · 1 line
2.17.1
Thomas Petazzoni
AppliedPATCH v2 2/7 package/ffmpeg: re-enable package if BUG_85180 is present
Quoted 11 lines · On Wed, 22 May 2019 15:59:01 +0200 Giulio Benetti…
With Microblaze Gcc version < 8.x build hangs on compiling. This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
This package has been excluded from building ifBUG_85180is present. Bug shows up building ffmpeg with optimization.In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- add --disable-optimizations toFFMPEG_CONF_OPTS
- passing -O0 to CFLAGS inFFMPEG_CONF_ENV
Then remove 'depends on !BR2_microblaze' from Config.in
Quoted 4 lines
Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* useBUG_85180instead ofBUG_71124since they are the same bug
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 2/7 package/ffmpeg: re-enable package if BUG_85180 is present
In reply to Giulio BenettiQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Giulio" == Giulio Benetti <[email protected]> writes:
With Microblaze Gcc version < 8.x build hangs on compiling. This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
This package has been excluded from building ifBUG_85180is present. Bug shows up building ffmpeg with optimization.
Quoted 6 lines
In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- add --disable-optimizations toFFMPEG_CONF_OPTS
- passing -O0 to CFLAGS inFFMPEG_CONF_ENV
Then remove 'depends on !BR2_microblaze' from Config.inSigned-off-by Giulio Benetti <[email protected]>
Committed to 2019.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 3/7 package/assimp: re-enable package if BR2_microblaze is enabled
In reply to Giulio BenettiWith Microblaze Gcc version < 8.x build hangs on compiling first files. This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
This package has been excluded from building if BR2_microblaze is enabled.
Bug shows up building assimp with optimization but not when building with -O0.
In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- passing -O0 to ASSIMP_CXXFLAGS
Then remove 'depends on !BR2_microblaze' and its comment if not available from Config.in
---V1->V2:
* use BUG_85180 instead of BUG_71124 since they are the same bug
package/assimp/Config.in | 5 ----- package/assimp/assimp.mk | 4 ++++ 2 files changed, 4 insertions(+), 5 deletions(-)
package/assimp/Config.in +0 -5
@@ -1,9 +1,5 @@ config BR2_PACKAGE_ASSIMP bool "assimp" - # All gcc versions affected by - # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71124, that - # cause an infinite loop in gcc when building this package. - depends on !BR2_microblaze depends on BR2_INSTALL_LIBSTDCPP select BR2_PACKAGE_ZLIB help
@@ -16,5 +12,4 @@ config BR2_PACKAGE_ASSIMP http://www.assimp.org comment "assimp needs a toolchain w/ C++" - depends on !BR2_microblaze depends on !BR2_INSTALL_LIBSTDCPP
package/assimp/assimp.mk +4 -0
@@ -24,6 +24,10 @@ ifeq ($(BR2_sh):$(BR2_STATIC_LIBS):$(BR2_TOOLCHAIN_GCC_AT_LEAST_6),y:y:) ASSIMP_CXXFLAGS += -O2 endif +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y) +ASSIMP_CXXFLAGS += -O0 +endif + ASSIMP_CONF_OPTS += -DASSIMP_BUILD_TESTS=OFF \ -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) $(ASSIMP_CXXFLAGS)"
Signature · 1 line
2.17.1
Thomas Petazzoni
AppliedPATCH v2 3/7 package/assimp: re-enable package if BR2_microblaze is enabled
Quoted 13 lines · On Wed, 22 May 2019 15:59:02 +0200 Giulio Benetti…
With Microblaze Gcc version < 8.x build hangs on compiling first files. This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
This package has been excluded from building ifBR2_microblazeis enabled.
Bug shows up building assimp with optimization but not when building with -O0.In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- passing -O0 toASSIMP_CXXFLAGS
Then remove 'depends on !BR2_microblaze' and its comment if not available from Config.in
Quoted 4 lines
Signed-off-by Giulio Benetti <[email protected]>---
V1->V2:
* useBUG_85180instead ofBUG_71124since they are the same bug
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 4/7 package/libnss: re-enable package if BUG_85862 is present
In reply to Giulio BenettiWith Microblaze Gcc version < 7.x build hangs on compiling first files. This is due to bug 85862:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
This package has been excluded from building if BUG_85862 is present. Bug shows up building libnss with optimization.
In config.mk append BUILD_OPT=1 only if BR2_TOOLCHAIN_HAS_GCC_BUG_85862=y otherwise don't declare BUILD_OPT forcing build system to not emit -O* flag.
Then remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and its comment if not available from Config.in
--- package/libnss/Config.in | 4 ---- package/libnss/libnss.mk | 8 ++++++-- 2 files changed, 6 insertions(+), 6 deletions(-)
package/libnss/Config.in +0 -4
@@ -3,7 +3,6 @@ config BR2_PACKAGE_LIBNSS depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr depends on !BR2_STATIC_LIBS - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 select BR2_PACKAGE_LIBNSPR select BR2_PACKAGE_SQLITE select BR2_PACKAGE_ZLIB
@@ -19,6 +18,3 @@ config BR2_PACKAGE_LIBNSS comment "libnss needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - -comment "libnss needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862
package/libnss/libnss.mk +6 -2
@@ -13,6 +13,7 @@ LIBNSS_DEPENDENCIES = libnspr sqlite zlib LIBNSS_LICENSE = MPL-2.0 LIBNSS_LICENSE_FILES = nss/COPYING + # --gc-sections triggers binutils ld segfault # https://sourceware.org/bugzilla/show_bug.cgi?id=21180 ifeq ($(BR2_microblaze),y)
@@ -33,7 +34,6 @@ LIBNSS_BUILD_VARS = \ MOZILLA_CLIENT=1 \ NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \ NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \ - BUILD_OPT=1 \ NS_USE_GCC=1 \ NSS_DISABLE_GTESTS=1 \ NSS_USE_SYSTEM_SQLITE=1 \
@@ -43,6 +43,10 @@ LIBNSS_BUILD_VARS = \ OS_RELEASE="2.6" \ OS_TEST="$(LIBNSS_ARCH)" +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85862),) +LIBNSS_BUILD_VARS += BUILD_OPT=1 +endif + # #pragma usage needs gcc >= 4.8 # See https://bugzilla.mozilla.org/show_bug.cgi?id=1226179 ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_4_8),)
@@ -62,7 +66,7 @@ define LIBNSS_BUILD_CMDS SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \ DIST=$(@D)/$(LIBNSS_DISTDIR) \ CHECKLOC= \ - $(LIBNSS_BUILD_VARS) + $(LIBNSS_BUILD_VARS) CFLAGS="$(LIBNSS_CFLAGS)" $(TARGET_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/nss lib/dbm all \ SOURCE_MD_DIR=$(@D)/$(LIBNSS_DISTDIR) \ DIST=$(@D)/$(LIBNSS_DISTDIR) \
Signature · 1 line
2.17.1
PATCH v2 4/7 package/libnss: re-enable package if BUG_85862 is present
package/libnss/libnss.mk LIBNSS_BUILD_VARS = \ · line 36
Quoted 8 lines · On Wed, 22 May 2019 15:59:03 +0200 Giulio Benetti…
# --gc-sections triggers binutils ld segfault # https://sourceware.org/bugzilla/show_bug.cgi?id=21180
ifeq ($(BR2_microblaze),y)package/libnss/libnss.mk +0
-1@@ -33,7 +34,6 @@ LIBNSS_BUILD_VARS = \ MOZILLA_CLIENT=1 \ NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \ NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \ - BUILD_OPT=1 \
In fact why are we building with BUILD_OPT=1 at all ? This adds some semi-random optimization flags decided by libnss. I guess we should not pass BUILD_OPT=1 at all, and simply pass CFLAGS=$(LIBNSS_CFLAGS), with LIBNSS_CFLAGS = $(TARGET_CFLAGS), with -O0 added to work around the Microblaze bug.
What do you think ?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 4/7 package/libnss: re-enable package if BUG_85862 is present
Hello Thomas,
Il 24/05/2019 23:15, Thomas Petazzoni ha scritto:
Quoted 18 lines
package/libnss/libnss.mk LIBNSS_BUILD_VARS = \ · line 36
Quoted 8 lines · On Wed, 22 May 2019 15:59:03 +0200 Giulio Benetti…
# --gc-sections triggers binutils ld segfault # https://sourceware.org/bugzilla/show_bug.cgi?id=21180 ifeq ($(BR2_microblaze),y)package/libnss/libnss.mk +0
-1@@ -33,7 +34,6 @@ LIBNSS_BUILD_VARS = \ MOZILLA_CLIENT=1 \ NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \ NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \ - BUILD_OPT=1 \In fact why are we building with BUILD_OPT=1 at all ? This adds some semi-random optimization flags decided by libnss. I guess we should not pass BUILD_OPT=1 at all, and simply pass CFLAGS=$(LIBNSS_CFLAGS), with
LIBNSS_CFLAGS= $(TARGET_CFLAGS), with -O0 added to work around the Microblaze bug.
Quoted 1 line
What do you think ?
I totally agree. I've taken a closer look to what I've done on this patch, LIBNSS_CFLAGS are not setup and CFLAGS=".." passed to $(MAKE1) are actually ignored by libnss. Need to find a way to pass our $(TARGET_CFLAGS).
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH 1/2 package/libnss: use correct CFLAGS and LDFLAGS
In reply to Thomas PetazzoniActually libnss is configure with BUILD_OPT=1 that doesn't take into account TARGET_CFLAGS nor TARGET_LDFLAGS resulting in pre-chosen optimizations and debugging symbols.
Can't pass TARGET_CFLAGS through CFLAGS or similar otherwise other iternal libnss will be overwritten(i.e. -fPIC), so prefer to append TARGET_CFLAGS at the end of Linux.mk as well as TARGET_LDFLAGS according to internal libnss Makefile system's names. And obviously remove BUILD_OPT=1 from BUILD_VARS.
--- package/libnss/libnss.mk | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
package/libnss/libnss.mk +8 -2
@@ -13,6 +13,14 @@ LIBNSS_DEPENDENCIES = libnspr sqlite zlib LIBNSS_LICENSE = MPL-2.0 LIBNSS_LICENSE_FILES = nss/COPYING +# Need to pass down TARGET_CFLAGS and TARGET_LDFLAGS +define LIBNSS_FIXUP_LINUX_MK + echo 'OS_CFLAGS += ${TARGET_CFLAGS}' >> $(@D)/nss/coreconf/Linux.mk + echo 'LDFLAGS += ${TARGET_LDFLAGS}' >> $(@D)/nss/coreconf/Linux.mk +endef + +LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_FIXUP_LINUX_MK + # --gc-sections triggers binutils ld segfault # https://sourceware.org/bugzilla/show_bug.cgi?id=21180 ifeq ($(BR2_microblaze),y)
@@ -33,7 +41,6 @@ LIBNSS_BUILD_VARS = \ MOZILLA_CLIENT=1 \ NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \ NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \ - BUILD_OPT=1 \ NS_USE_GCC=1 \ NSS_DISABLE_GTESTS=1 \ NSS_USE_SYSTEM_SQLITE=1 \
@@ -102,7 +109,6 @@ HOST_LIBNSS_BUILD_VARS = \ MOZILLA_CLIENT=1 \ NSPR_INCLUDE_DIR=$(HOST_DIR)/include/nspr \ NSPR_LIB_DIR=$(HOST_DIR)/lib \ - BUILD_OPT=1 \ NS_USE_GCC=1 \ NSS_DISABLE_GTESTS=1 \ NSS_USE_SYSTEM_SQLITE=1 \
Signature · 1 line
2.17.1
PATCH 2/2 package/libnss: re-enable package on microblaze
With Microblaze Gcc version < 8.x the build hangs due to bug 85862:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
To avoid this, the libnss package has a !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 dependency. However, gcc bug 85862 only triggers when optimization is enabled, so we can work around the issue by passing -O0, which is what we do in other Buildroot packages to work around this bug.
--- package/libnss/Config.in | 4 ---- package/libnss/libnss.mk | 8 +++++++- 2 files changed, 7 insertions(+), 5 deletions(-)
package/libnss/Config.in +0 -4
@@ -3,7 +3,6 @@ config BR2_PACKAGE_LIBNSS depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr depends on !BR2_STATIC_LIBS - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 select BR2_PACKAGE_LIBNSPR select BR2_PACKAGE_SQLITE select BR2_PACKAGE_ZLIB
@@ -19,6 +18,3 @@ config BR2_PACKAGE_LIBNSS comment "libnss needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - -comment "libnss needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862
package/libnss/libnss.mk +7 -1
@@ -13,9 +13,15 @@ LIBNSS_DEPENDENCIES = libnspr sqlite zlib LIBNSS_LICENSE = MPL-2.0 LIBNSS_LICENSE_FILES = nss/COPYING +LIBNSS_CFLAGS = $(TARGET_CFLAGS) + +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85862),y) +LIBNSS_CFLAGS += -O0 +endif + # Need to pass down TARGET_CFLAGS and TARGET_LDFLAGS define LIBNSS_FIXUP_LINUX_MK - echo 'OS_CFLAGS += ${TARGET_CFLAGS}' >> $(@D)/nss/coreconf/Linux.mk + echo 'OS_CFLAGS += ${LIBNSS_CFLAGS}' >> $(@D)/nss/coreconf/Linux.mk echo 'LDFLAGS += ${TARGET_LDFLAGS}' >> $(@D)/nss/coreconf/Linux.mk endef
Signature · 1 line
2.17.1
PATCH 2/2 package/libnss: re-enable package on microblaze
Hello Thomas,
adding you in Cc
Il 05/06/2019 14:13, Giulio Benetti ha scritto:
Quoted 54 lines
With Microblaze Gcc version < 8.x the build hangs due to bug 85862:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
To avoid this, the libnss package has a !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 dependency. However, gcc bug 85862 only triggers when optimization is enabled, so we can work around the issue by passing -O0, which is what we do in other Buildroot packages to work around this bug.Signed-off-by Giulio Benetti <[email protected]>--- package/libnss/Config.in | 4 ---- package/libnss/libnss.mk | 8 +++++++- 2 files changed, 7 insertions(+), 5 deletions(-)package/libnss/Config.in +0
-4@@ -3,7 +3,6 @@ config BR2_PACKAGE_LIBNSS depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr depends on !BR2_STATIC_LIBS - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 select BR2_PACKAGE_LIBNSPR select BR2_PACKAGE_SQLITE select BR2_PACKAGE_ZLIB@@ -19,6 +18,3 @@ config BR2_PACKAGE_LIBNSS comment "libnss needs a toolchain w/ threads, dynamic library" depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS - -comment "libnss needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862package/libnss/libnss.mk +7
-1@@ -13,9 +13,15 @@ LIBNSS_DEPENDENCIES = libnspr sqlite zlib LIBNSS_LICENSE = MPL-2.0 LIBNSS_LICENSE_FILES = nss/COPYING +LIBNSS_CFLAGS = $(TARGET_CFLAGS) + +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85862),y) +LIBNSS_CFLAGS += -O0 +endif + # Need to pass down TARGET_CFLAGS and TARGET_LDFLAGS define LIBNSS_FIXUP_LINUX_MK - echo 'OS_CFLAGS += ${TARGET_CFLAGS}' >> $(@D)/nss/coreconf/Linux.mk + echo 'OS_CFLAGS += ${LIBNSS_CFLAGS}' >> $(@D)/nss/coreconf/Linux.mk echo 'LDFLAGS += ${TARGET_LDFLAGS}' >> $(@D)/nss/coreconf/Linux.mk endef
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 5/7 package/ecryptfs-utils: allow building with GCC_BUG_85862 and on Microblaze
In reply to Giulio Benettilibnss gcc bug 85862 has been worked around and that caused build failure on Microblaze.
Remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and 'depends on !BR2_microblaze' from Config.in allowing this package to build.
--- package/ecryptfs-utils/Config.in | 6 ------ 1 file changed, 6 deletions(-)
package/ecryptfs-utils/Config.in +0 -6
@@ -2,12 +2,10 @@ config BR2_PACKAGE_ECRYPTFS_UTILS bool "ecryptfs-utils" depends on BR2_USE_WCHAR # gettext depends on BR2_USE_MMU # keyutils - depends on !BR2_microblaze # keyutils depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr depends on !BR2_MIPS_NABI32 # libnss depends on !BR2_STATIC_LIBS # libnss, keyutils - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # microblaze specific & GCC < 7.x select BR2_PACKAGE_KEYUTILS select BR2_PACKAGE_LIBNSS # runtime dependency only, some scripts are using the
@@ -31,11 +29,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS http://ecryptfs.org comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynami library" - depends on !BR2_microblaze depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ BR2_STATIC_LIBS - -comment "ecryptfs needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # libnss
Signature · 1 line
2.17.1
PATCH v2 5/7 package/ecryptfs-utils: allow building with GCC_BUG_85862 and on Microblaze
Hello Thomas,
Il 22/05/2019 15:59, Giulio Benetti ha scritto:
Quoted 31 lines
libnss gcc bug 85862 has been worked around and that caused build failure on Microblaze.
Remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and 'depends on !BR2_microblaze' from Config.in allowing this package to build.
Signed-off-by Giulio Benetti <[email protected]>--- package/ecryptfs-utils/Config.in | 6 ------ 1 file changed, 6 deletions(-)package/ecryptfs-utils/Config.in +0
-2@@ -2,12 +2,10 @@ config BR2_PACKAGE_ECRYPTFS_UTILS bool "ecryptfs-utils" depends on BR2_USE_WCHAR # gettext depends on BR2_USE_MMU # keyutils - depends on !BR2_microblaze # keyutils depends on BR2_TOOLCHAIN_HAS_THREADS # libnss -> libnspr depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnss -> libnspr depends on !BR2_MIPS_NABI32 # libnss depends on !BR2_STATIC_LIBS # libnss, keyutils - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # microblaze specific & GCC < 7.x select BR2_PACKAGE_KEYUTILS select BR2_PACKAGE_LIBNSS # runtime dependency only, some scripts are using the@@ -31,11 +29,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS http://ecryptfs.org
package/ecryptfs-utils/Config.in config BR2_PACKAGE_ECRYPTFS_UTILS · line 41
Quoted 10 lines
package/ecryptfs-utils/Config.in +0
-4comment "ecryptfs-utils needs a toolchain w/ threads, wchar, dynami library" - depends on !BR2_microblaze depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT depends on BR2_USE_MMU depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \ BR2_STATIC_LIBS - -comment "ecryptfs needs a toolchain not affected by GCC bug 85862" - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # libnss
I've seen you've tagged this as Changes Requested:
https://patchwork.ozlabs.org/patch/1103358/
It is because of dependency to "keyutils" still not fixed right?
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 5/7 package/ecryptfs-utils: allow building with GCC_BUG_85862 and on Microblaze
Quoted 4 lines · On Mon, 27 May 2019 19:28:32 +0200 Giulio Benetti…
I've seen you've tagged this as Changes Requested:
https://patchwork.ozlabs.org/patch/1103358/It is because of dependency to "keyutils" still not fixed right?
Because this patch depends on the libnss patch, which was also marked as Changes Requested.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 5/7 package/ecryptfs-utils: allow building with GCC_BUG_85862 and on Microblaze
Il 27/05/2019 21:13, Thomas Petazzoni ha scritto:
Quoted 10 lines
Quoted 4 lines · On Mon, 27 May 2019 19:28:32 +0200 Giulio Benetti…
I've seen you've tagged this as Changes Requested:
https://patchwork.ozlabs.org/patch/1103358/It is because of dependency to "keyutils" still not fixed right?
Because this patch depends on the libnss patch, which was also marked as Changes Requested.
Ok, thanks.
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 6/7 package/qt5webengine: re-enable building if BUG_85682=y on latest Qt5
In reply to Giulio Benetti'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' is listed because libnss was affected by that bug in latest Qt5, but now that bug has been worked around.
So remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862' and allow building latest Qt5 by removing also '|| BR2_PACKAGE_QT5_VERSION_5_6'.
--- package/qt5/qt5webengine/Config.in | 6 ------ 1 file changed, 6 deletions(-)
package/qt5/qt5webengine/Config.in +0 -6
@@ -20,18 +20,12 @@ comment "qt5webengine needs an OpenGL and EGL-capable backend" depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS depends on !BR2_PACKAGE_QT5_GL_AVAILABLE || !BR2_PACKAGE_HAS_LIBEGL -comment "qt5webengine needs a toolchain not affected by GCC bug 85862" - depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS - depends on !BR2_PACKAGE_QT5_VERSION_5_6 - depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85862 # libnss - config BR2_PACKAGE_QT5WEBENGINE bool "qt5webengine" depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h, mallinfo depends on BR2_HOST_GCC_AT_LEAST_4_8 # qt5base-icu depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # qt5base-icu - depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus depends on BR2_USE_WCHAR # libglib2 depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, qt5base-eglfs
Signature · 1 line
2.17.1
PATCH v2 7/7 package/flashbench: remove old check if BR2_microblaze & BR2_sh2a
In reply to Giulio BenettiCommit:
https://git.buildroot.net/buildroot/commit/?id=bad25aff36b70b55b34ea4580b45f657385ae9ac
removed sourcery toolchain already deprecated in 2014 causing build failure. It was based on Gcc 4.6.2 and Buildroot doesn't use this anymore.
Remove check against BR2_microblaze and BR2_sh2a.
--- package/flashbench/flashbench.mk | 5 ----- 1 file changed, 5 deletions(-)
package/flashbench/flashbench.mk +0 -5
@@ -11,11 +11,6 @@ FLASHBENCH_LICENSE_FILES = COPYING FLASHBENCH_CFLAGS = $(TARGET_CFLAGS) -ifeq ($(BR2_microblaze)$(BR2_sh2a),y) -# microblaze and sh2a toolchains only provide LLONG_MAX when used with gnu99 dialect -FLASHBENCH_CFLAGS += -std=gnu99 -endif - define FLASHBENCH_BUILD_CMDS $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \ CFLAGS="$(FLASHBENCH_CFLAGS)" \
Signature · 1 line
2.17.1
PATCH v2 7/7 package/flashbench: remove old check if BR2_microblaze & BR2_sh2a
Hello,
Quoted 5 lines · On Wed, 22 May 2019 15:59:06 +0200 Giulio Benetti…
Commit:
https://git.buildroot.net/buildroot/commit/?id=bad25aff36b70b55b34ea4580b45f657385ae9ac
removed sourcery toolchain already deprecated in 2014 causing build failure. It was based on Gcc 4.6.2 and Buildroot doesn't use this anymore.
This explanation is quite fuzzy. What is the relationship between the removal of those toolchains and this particular issue ? Also this commit only removes Microblaze toolchains, not SH2A toolchains.
Since when the LLONG_MAX issue has been fixed ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 7/7 package/flashbench: remove old check if BR2_microblaze & BR2_sh2a
Hello Thomas,
Il 24/05/2019 23:18, Thomas Petazzoni ha scritto:
Quoted 5 lines
Hello,
On Wed, 22 May 2019 15:59:06 +0200
Giulio Benetti <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
Commit:
https://git.buildroot.net/buildroot/commit/?id=bad25aff36b70b55b34ea4580b45f657385ae9ac
removed sourcery toolchain already deprecated in 2014 causing build failure. It was based on Gcc 4.6.2 and Buildroot doesn't use this anymore.This explanation is quite fuzzy. What is the relationship between the removal of those toolchains and this particular issue ?
I improve commit log.
Quoted 1 line
Also this commit only removes Microblaze toolchains, not SH2A toolchains.
I've messed up, I need to remove BR2_microblaze only.
Quoted 1 line
Since when the
LLONG_MAXissue has been fixed ?
Need to check and report on commit log.
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
Quoted 4 lines
Best regards,
Thomas