ALSA: usb-audio: Fix UAF decrement if card has no live interfaces in card.c
Subsystems (2)
PATCH 1/1 ALSA: usb-audio: Fix UAF decrement if card has no live interfaces in card.c
Commit 5f8cf712582617d523120df67d392059eaf2fc4b upstream.
This is a backport to stable 3.18.y. Implementation in 3.18 differs using chip->probing flag instead of chip->active atomic but it still has the UAF issue.
If a USB sound card reports 0 interfaces, an error condition is triggered and the function usb_audio_probe errors out. In the error path, there was a use-after-free vulnerability where the memory object of the card was first freed, followed by a decrement of the number of active chips. Moving the decrement above the atomic_dec fixes the UAF.
[ The original problem was introduced in 3.1 kernel, while it was
developed in a different form. The Fixes tag below indicates the original commit but it doesn't mean that the patch is applicable cleanly. -- tiwai ]
---
Analysis for 3.18 codebase:snd_usb_audio_create() sets card->device_data = chip snd_usb_audio_probe() calls snd_card_free() and then resets chip->probing snd_card_free() results in the following call chain:
snd_card_free_when_closed() which waits on release_completion snd_card_do_free() calls snd_device_free_all() and signals release_completion snd_card_do_free() calls __snd_device_free()
__snd_device_free() calls dev->ops->dev_free() == snd_usb_audio_dev_free() snd_usb_audio_dev_free() calls snd_usb_audio_free(chip) and frees "chip"chip->probing = 0 results in UAF
sound/usb/card.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
sound/usb/card.c +4 -1
@@ -593,9 +593,12 @@ snd_usb_audio_probe(struct usb_device *dev, __error:if (chip) { +/* chip->probing is inside the chip->card object, +* reset before memory is possibly returned. +*/ + chip->probing =0 ;if (!chip->num_interfaces)snd_card_free (chip->card); - chip->probing =0 ; }mutex_unlock (®ister_mutex); __err_val:
Signature · 1 line
2.21.0.1020.gf2820cf01a-goog
Sorry, missed CC'ing the maintainers. Will repost.
Quoted 63 lines · Suren Baghdasaryan
Commit
5f8cf712582617d523120df67d392059eaf2fc4bupstream.This is a backport to stable 3.18.y. Implementation in 3.18 differs using
chip->probingflag instead ofchip->activeatomic but it still has the UAF issue.If a USB sound card reports 0 interfaces, an error condition is triggered and the function
usb_audio_probeerrors out. In the error path, there was a use-after-free vulnerability where the memory object of the card was first freed, followed by a decrement of the number of active chips. Moving the decrement above theatomic_decfixes the UAF.[ The original problem was introduced in 3.1 kernel, while it was
developed in a different form. The Fixes tag below indicates the original commit but it doesn't mean that the patch is applicable cleanly. -- tiwai ]Fixes 362e4e49abe5 ("ALSA: usb-audio - clear chip->probing on error exit")Reported-by Hui Peng <[email protected]>Reported-by Mathias Payer <[email protected]>Signed-off-by Hui Peng <[email protected]>Signed-off-by Mathias Payer <[email protected]>Cc <[email protected]>Signed-off-by Takashi Iwai <[email protected]>[[email protected]: resolve 3.18 differences]Signed-off-by Suren Baghdasaryan <[email protected]>---
Analysis for 3.18 codebase:snd_usb_audio_create()setscard->device_data= chipsnd_usb_audio_probe()callssnd_card_free()and then resetschip->probingsnd_card_free()results in the following call chain:
snd_card_free_when_closed()which waits onrelease_completionsnd_card_do_free()callssnd_device_free_all()and signalsrelease_completionsnd_card_do_free()calls__snd_device_free()
__snd_device_free()callsdev->ops->dev_free()==snd_usb_audio_dev_free()snd_usb_audio_dev_free()callssnd_usb_audio_free(chip)and frees "chip"chip->probing= 0 results in UAFsound/usb/card.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)sound/usb/card.c +4
-2@@ -593,9 +593,12 @@ snd_usb_audio_probe(struct usb_device *dev, __error:if (chip) { +/* chip->probing is inside the chip->card object, +* reset before memory is possibly returned. +*/ + chip->probing =0 ;if (!chip->num_interfaces)snd_card_free (chip->card); - chip->probing =0 ; }mutex_unlock (®ister_mutex); __err_val: --2.21.0.1020.gf2820cf01a-goog