Skip to contentSkip to conversation

util-linux: Add missing ptest dependencies

PATCH In review Mariano López 3 participants 5 messages May 19, 2019 – May 22, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 util-linux: Add missing ptest dependencies

There are some missing dependencies for the util-linux-ptest package that causes inconsistencies in the package tests run in different images.

The kernel module in RRECOMMENDS is not build at this time, it needs more testing and check if the configuration change can be part of the yocto-kernel-cache repository.

---
 meta/recipes-core/util-linux/util-linux.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/util-linux/util-linux.inc +2 -1
index 34255a2dec..6dfbe0b683 100644
@@ -142,7 +142,8 @@ RDEPENDS_${PN}_class-nativesdk = ""
 RPROVIDES_${PN}-dev = "${PN}-libblkid-dev ${PN}-libmount-dev ${PN}-libuuid-dev"
 
 RDEPENDS_${PN}-bash-completion += "${PN}-lsblk"
-RDEPENDS_${PN}-ptest = "bash grep coreutils which btrfs-tools ${PN} sed"
+RDEPENDS_${PN}-ptest = "bash bc btrfs-tools coreutils e2fsprogs grep iproute2 kmod mdadm ${PN} procps sed socat which xz"
+RRECOMMENDS_${PN}-ptest = "kernel-module-scsi-debug"
 RDEPENDS_${PN}-swaponoff = "${PN}-swapon ${PN}-swapoff"
 ALLOW_EMPTY_${PN}-swaponoff = "1"
 
Signature · 1 line
2.21.0
#2 lore raw

This pulls bc to many images with busybox, causing busybox postinst to fail with:

update-alternatives: Error: not linking /usr/bin/bc to /bin/busybox.nosuid since /usr/bin/bc exists and is not a link

I'll check which busybox defconfig entry enables BC and send patch to use u-a for bc in ./meta/recipes-extended/bc/bc_1.07.1.bb

There already is:
ALTERNATIVE_${PN} = "dc"
ALTERNATIVE_PRIORITY = "100"
but maybe dc is a typo.

Quoted 38 lines · Mariano López

There are some missing dependencies for the util-linux-ptest package that causes inconsistencies in the package tests run in different images.

The kernel module in RRECOMMENDS is not build at this time, it needs more testing and check if the configuration change can be part of the yocto-kernel-cache repository.

---
 meta/recipes-core/util-linux/util-linux.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/util-linux/util-linux.inc +0 -0
index 34255a2dec..6dfbe0b683 100644
@@ -142,7 +142,8 @@ RDEPENDS_${PN}_class-nativesdk = ""
 RPROVIDES_${PN}-dev = "${PN}-libblkid-dev ${PN}-libmount-dev

${PN}-libuuid-dev"

RDEPENDS_${PN}-bash-completion += "${PN}-lsblk"

meta/recipes-core/util-linux/util-linux.inc +1 -1
-RDEPENDS_${PN}-ptest = "bash grep coreutils which btrfs-tools ${PN} sed"
+RDEPENDS_${PN}-ptest = "bash bc btrfs-tools coreutils e2fsprogs grep

iproute2 kmod mdadm ${PN} procps sed socat which xz" +RRECOMMENDS_${PN}-ptest = "kernel-module-scsi-debug"
RDEPENDS_${PN}-swaponoff = "${PN}-swapon ${PN}-swapoff" ALLOW_EMPTY_${PN}-swaponoff = "1"

--
2.21.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 5 lines · Martin Jansa

This pulls bc to many images with busybox, causing busybox postinst to fail with:

update-alternatives: Error: not linking /usr/bin/bc to /bin/busybox.nosuid since /usr/bin/bc exists and is not a link

Are you enabling CONFIG_BC in your busybox config?
It is not enabled in meta/recipes-core/busybox/busybox/defconfig

Quoted 7 lines

I'll check which busybox defconfig entry enables BC and send patch to use u-a for bc in ./meta/recipes-extended/bc/bc_1.07.1.bb

There already is:
ALTERNATIVE_${PN} = "dc"
ALTERNATIVE_PRIORITY = "100"
but maybe dc is a typo.

bc and dc are two different binaries built from bc.

busybox used to only have dc, bc was added 6 months ago.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 9 lines · Adrian Bunk
Quoted 5 lines · Martin Jansa

This pulls bc to many images with busybox, causing busybox postinst to fail with:

update-alternatives: Error: not linking /usr/bin/bc to /bin/busybox.nosuid since /usr/bin/bc exists and is not a link

Are you enabling CONFIG_BC in your busybox config?
It is not enabled in meta/recipes-core/busybox/busybox/defconfig

It's not disabled in my defconfig like it is in meta/recipes-core/busybox/busybox/defconfig, maybe it got auto enabled.

In log.do_configure I see:
...
*
* Miscellaneous Utilities
*
adjtimex (4.7 kb) (ADJTIMEX) [N/y/?] n
bbconfig (9.7 kb) (BBCONFIG) [N/y/?] n
bc (45 kb) (BC) [Y/n/?] (NEW) dc (36 kb) (DC) [Y/n/?] y
Use bc code base for dc (larger, more features) (FEATURE_DC_BIG) [Y] (NEW) y
Interactive mode (+4kb) (FEATURE_BC_INTERACTIVE) [Y/n/?] (NEW) Enable bc/dc long options (FEATURE_BC_LONG_OPTIONS) [Y/n] (NEW) beep (2.4 kb) (BEEP) [N/y/?] n
chat (6.3 kb) (CHAT) [N/y/?] n
conspy (10 kb) (CONSPY) [N/y/?] n
...

Quoted 11 lines
Quoted 7 lines

I'll check which busybox defconfig entry enables BC and send patch to use u-a for bc in ./meta/recipes-extended/bc/bc_1.07.1.bb

There already is:
ALTERNATIVE_${PN} = "dc"
ALTERNATIVE_PRIORITY = "100"
but maybe dc is a typo.

bc and dc are two different binaries built from bc.

busybox used to only have dc, bc was added 6 months ago.

Thanks I've never noticed dc before.

I see both dc and bc in 1.06 version from meta-gplv2 which was released on 2000-11-15

bc/1.06-r3/image/usr/bin/bc

As there is already u-a for dc, I will sent u-a for bc as well.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw
Quoted 38 lines · Martin Jansa
Quoted 9 lines · Adrian Bunk
Quoted 5 lines · Martin Jansa

This pulls bc to many images with busybox, causing busybox postinst to fail with:

update-alternatives: Error: not linking /usr/bin/bc to /bin/busybox.nosuid since /usr/bin/bc exists and is not a link

Are you enabling CONFIG_BC in your busybox config?
It is not enabled in meta/recipes-core/busybox/busybox/defconfig

It's not disabled in my defconfig like it is in meta/recipes-core/busybox/busybox/defconfig, maybe it got auto enabled.

In log.do_configure I see:
...
*
* Miscellaneous Utilities
*
adjtimex (4.7 kb) (ADJTIMEX) [N/y/?] n
bbconfig (9.7 kb) (BBCONFIG) [N/y/?] n
bc (45 kb) (BC) [Y/n/?] (NEW) dc (36 kb) (DC) [Y/n/?] y
Use bc code base for dc (larger, more features) (FEATURE_DC_BIG) [Y] (NEW) y
Interactive mode (+4kb) (FEATURE_BC_INTERACTIVE) [Y/n/?] (NEW) Enable bc/dc long options (FEATURE_BC_LONG_OPTIONS) [Y/n] (NEW) beep (2.4 kb) (BEEP) [N/y/?] n
chat (6.3 kb) (CHAT) [N/y/?] n
conspy (10 kb) (CONSPY) [N/y/?] n
...

Quoted 10 lines
Quoted 7 lines

I'll check which busybox defconfig entry enables BC and send patch to use u-a for bc in ./meta/recipes-extended/bc/bc_1.07.1.bb

There already is:
ALTERNATIVE_${PN} = "dc"
ALTERNATIVE_PRIORITY = "100"
but maybe dc is a typo.

bc and dc are two different binaries built from bc.

Quoted 8 lines
Quoted 1 line

busybox used to only have dc, bc was added 6 months ago.

Thanks I've never noticed dc before.

I see both dc and bc in 1.06 version from meta-gplv2 which was released on 2000-11-15

bc/1.06-r3/image/usr/bin/bc

Ah you were talking about busybox having only dc until 6 months ago.

Makes sense now, thanks.

Quoted 3 lines

As there is already u-a for dc, I will sent u-a for bc as well.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]