ipv6: Fix redirect with VRF
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: Fix redirect with VRF
From: David Ahern <[email protected]>
IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB entries looking for an exact match on ifindex. With VRF the flowi6_oif is updated by l3mdev_update_flow to the l3mdev index and the FLOWI_FLAG_SKIP_NH_OIF set in the flags to tell the lookup to skip the device match. For redirects the device match is requires so use that flag to know when the oif needs to be reset to the skb device index.
--- net/ipv6/route.c | 6 ++++++ 1 file changed, 6 insertions(+)
net/ipv6/route.c +6 -0
@@ -2512,6 +2512,12 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,struct fib6_info *rt;struct fib6_node *fn; +/* l3mdev_update_flow overrides oif if the device is enslaved; in +* this case we must match on the real ingress device, so reset it +*/ +if (fl6->flowi6_flags &FLOWI_FLAG_SKIP_NH_OIF ) + fl6->flowi6_oif = skb->dev->ifindex; +/* Get the "current" route for this destination and * check if the redirect has come from appropriate router. *
Signature · 1 line
2.11.0
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Wed, 22 May 2019 15:12:18 -0700
Quoted 11 lines
From: David Ahern <[email protected]>
IPv6 redirect is broken for VRF.
__ip6_route_redirectwalks the FIB entries looking for an exact match on ifindex. With VRF theflowi6_oifis updated byl3mdev_update_flowto the l3mdev index and theFLOWI_FLAG_SKIP_NH_OIFset in the flags to tell the lookup to skip the device match. For redirects the device match is requires so use that flag to know when the oif needs to be reset to the skb device index.Fixes ca254490c8df ("net: Add VRF support to IPv6 stack")Signed-off-by David Ahern <[email protected]>
Applied and queued up for -stable.