test/i915: gem_busy: fix misuse of the "flags" parameter in basic()
PATCH 1/1 test/i915: gem_busy: fix misuse of the "flags" parameter in basic()
The "flags" parameter received by the "basic()" function checks for the HANG (0x2) bit, while callers give it a boolean true/false value.
Restore the original meaning of "flags" as a bit mask.
--- tests/i915/gem_busy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/i915/gem_busy.c +2 -2
@@ -483,7 +483,7 @@ igt_main e->class == I915_ENGINE_CLASS_RENDER ? "basic-" : "", e->name) {gem_quiescent_gpu (fd); -basic (fd, e, false); +basic (fd, e,0 ); } } }
@@ -548,7 +548,7 @@ igt_main ? "basic-" : "", e->name) {igt_skip_on_simulation ();gem_quiescent_gpu (fd); -basic (fd, e, true); +basic (fd, e,HANG ); } }
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoting Andi Shyti (2019-05-22 23:13:02)
Quoted 28 lines
The "flags" parameter received by the "
basic()" function checks for the HANG (0x2) bit, while callers give it a boolean true/false value.Restore the original meaning of "flags" as a bit mask.
Fixes 88318b0771f9 ("test/i915: gem_busy: use the gem_engine_topology library")Signed-off-by Andi Shyti <[email protected]>Cc Chris Wilson <[email protected]>Cc Tvrtko Ursulin <[email protected]>--- tests/i915/gem_busy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tests/i915/gem_busy.c +1
-1@@ -483,7 +483,7 @@ igt_main e->class == I915_ENGINE_CLASS_RENDER ? "basic-" : "", e->name) {gem_quiescent_gpu (fd); -basic (fd, e, false); +basic (fd, e,0 ); } } }
tests/i915/gem_busy.c igt_main · line 551
Quoted 5 lines
tests/i915/gem_busy.c +1
-1@@ -548,7 +548,7 @@ igt_main ? "basic-" : "", e->name) {igt_skip_on_simulation ();gem_quiescent_gpu (fd); -basic (fd, e, true); +basic (fd, e,HANG );
No harm done,
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for test/i915: gem_busy: fix misuse of the "flags" parameter in basic()
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: test/i915: gem_busy: fix misuse of the "flags" parameter in basic()
URL : https://patchwork.freedesktop.org/series/61005/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6125 -> IGTPW_3035
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3035 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_3035, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/61005/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3035:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-snb-2600: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/fi-snb-2600/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_3035 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [PASS][2] -> [INCOMPLETE][3] ([fdo#103927] / [fdo#110624])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6125/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-icl-y}: [INCOMPLETE][4] ([fdo#107713] / [fdo#109100]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6125/fi-icl-y/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/fi-icl-y/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled:
- {fi-icl-u3}: [DMESG-WARN][6] ([fdo#107724]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6125/fi-icl-u3/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/fi-icl-u3/igt@[email protected]
#### Warnings ####
* igt@runner@aborted:
- fi-apl-guc: [FAIL][8] ([fdo#108622] / [fdo#109720]) -> [FAIL][9] ([fdo#110624])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6125/fi-apl-guc/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/fi-apl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110624]: https://bugs.freedesktop.org/show_bug.cgi?id=110624
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5005 -> IGTPW_3035
CI_DRM_6125: 1f3265649e76db5d26c76e7167ecb9b12c838155 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3035: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/
IGT_5005: adf9f435a795d692e30cd6eafe26eddf4993c8ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3035/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev