Skip to contentSkip to conversation

regulator: max77650: Move max77651_SBB1_desc's declaration down

PATCH In review Nathan Chancellor 3 participants 3 messages May 23, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: max77650: Move max77651_SBB1_desc's declaration down

Clang warns:

drivers/regulator/max77650-regulator.c:32:39: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct max77650_regulator_desc' [-Wtentative-definition-incomplete-type]

static struct max77650_regulator_desc max77651_SBB1_desc;
                                      ^
drivers/regulator/max77650-regulator.c:32:15: note: forward declaration
of 'struct max77650_regulator_desc'
static struct max77650_regulator_desc max77651_SBB1_desc;
              ^

1 warning generated.

Move max77651_SBB1_desc's declaration below max77650_regulator_desc's definition so this warning does not happen.

Fixes 3df4235ac41c ("regulator: max77650: Convert MAX77651 SBB1 to pickable linear range")
---
 drivers/regulator/max77650-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/max77650-regulator.c +2 -2
index ecf8cf7aad20..e3b28fc68cdb 100644
@@ -29,8 +29,6 @@
 
 #define MAX77650_REGULATOR_CURR_LIM_MASK	GENMASK(7, 6)
 
-static struct max77650_regulator_desc max77651_SBB1_desc;
-
 enum {
 	MAX77650_REGULATOR_ID_LDO = 0,
 	MAX77650_REGULATOR_ID_SBB0,
@@ -45,6 +43,8 @@ struct max77650_regulator_desc {
 	unsigned int regB;
 };
 
+static struct max77650_regulator_desc max77651_SBB1_desc;
+
 static const unsigned int max77651_sbb1_volt_range_sel[] = {
 	0x0, 0x1, 0x2, 0x3
 };
Signature · 1 line
2.22.0.rc1
Reviewed-by on v1 1/1
#1 lore raw

Nathan Chancellor <[email protected]> 於 2019年5月23日 週四 上午9:27寫道:

Quoted 13 lines

Clang warns:

drivers/regulator/max77650-regulator.c:32:39: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct max77650_regulator_desc' [-Wtentative-definition-incomplete-type]

static struct max77650_regulator_desc max77651_SBB1_desc;
                                      ^
drivers/regulator/max77650-regulator.c:32:15: note: forward declaration
of 'struct max77650_regulator_desc'
static struct max77650_regulator_desc max77651_SBB1_desc;
              ^
Quoted 8 lines

1 warning generated.

Move max77651_SBB1_desc's declaration below max77650_regulator_desc's definition so this warning does not happen.

Fixes 3df4235ac41c ("regulator: max77650: Convert MAX77651 SBB1 to pickable linear range")
maintainer
#2 lore raw

Applied "regulator: max77650: Move max77651_SBB1_desc's declaration down" to the regulator tree

In reply to Nathan Chancellor

The patch

regulator: max77650: Move max77651_SBB1_desc's declaration down

has been applied to the regulator tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.3

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

From 59dec1f0fac8107f3bffaa0051afce795e24c3e4 Mon Sep 17 00:00:00 2001
From: Nathan Chancellor <[email protected]>
Date: Wed, 22 May 2019 18:26:29 -0700
Subject: [PATCH] regulator: max77650: Move max77651_SBB1_desc's declaration
down

Clang warns:

drivers/regulator/max77650-regulator.c:32:39: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct max77650_regulator_desc' [-Wtentative-definition-incomplete-type]

static struct max77650_regulator_desc max77651_SBB1_desc;
                                      ^
drivers/regulator/max77650-regulator.c:32:15: note: forward declaration
of 'struct max77650_regulator_desc'
static struct max77650_regulator_desc max77651_SBB1_desc;
              ^

1 warning generated.

Move max77651_SBB1_desc's declaration below max77650_regulator_desc's definition so this warning does not happen.

Fixes 3df4235ac41c ("regulator: max77650: Convert MAX77651 SBB1 to pickable linear range")
---
 drivers/regulator/max77650-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/max77650-regulator.c +2 -2
index ecf8cf7aad20..e3b28fc68cdb 100644
@@ -29,8 +29,6 @@
 
 #define MAX77650_REGULATOR_CURR_LIM_MASK	GENMASK(7, 6)
 
-static struct max77650_regulator_desc max77651_SBB1_desc;
-
 enum {
 	MAX77650_REGULATOR_ID_LDO = 0,
 	MAX77650_REGULATOR_ID_SBB0,
@@ -45,6 +43,8 @@ struct max77650_regulator_desc {
 	unsigned int regB;
 };
 
+static struct max77650_regulator_desc max77651_SBB1_desc;
+
 static const unsigned int max77651_sbb1_volt_range_sel[] = {
 	0x0, 0x1, 0x2, 0x3
 };
Signature · 1 line
2.20.1