Skip to contentSkip to conversation

iommu/intel: fix variable 'iommu' set but not used

PATCH New Qian Cai 1 participant 1 message May 23, 2019 IOMMU

lore
Share & tools
lore

Qian Cai

author
#0 lore raw

PATCH v2 1/1 iommu/intel: fix variable 'iommu' set but not used

The commit cf04eee8bf0e ("iommu/vt-d: Include ACPI devices in iommu=pt") added for_each_active_iommu() in iommu_prepare_static_identity_mapping() but never used the each element, i.e, "drhd->iommu".

drivers/iommu/intel-iommu.c: In function 'iommu_prepare_static_identity_mapping':
drivers/iommu/intel-iommu.c:3037:22: warning: variable 'iommu' set but not used [-Wunused-but-set-variable]
struct intel_iommu *iommu;

Fixed the warning by appending a compiler attribute __maybe_unused for it.

---
 drivers/iommu/intel-iommu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iommu/intel-iommu.c +2 -1
index a209199f3af6..09b8ff0d856a 100644
@@ -3034,7 +3034,8 @@ static int __init iommu_prepare_static_identity_mapping(int hw)
 {
 	struct pci_dev *pdev = NULL;
 	struct dmar_drhd_unit *drhd;
-	struct intel_iommu *iommu;
+	/* To avoid a -Wunused-but-set-variable warning. */
+	struct intel_iommu *iommu __maybe_unused;
 	struct device *dev;
 	int i;
 	int ret = 0;
Signature · 1 line
2.20.1 (Apple Git-117)