Skip to contentSkip to conversation

arm64: dts: ls1028a: Fix CPU idle fail.

PATCH Applied Ran Wang 3 participants 4 messages May 17, 2019 – Jun 12, 2019

Subsystems (2)
lore
Share & tools
lore

Ran Wang

author
#0 lore raw

PATCH v2 1/1 arm64: dts: ls1028a: Fix CPU idle fail.

PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to indicate CPU State Type: 0 for standby, 1 for power down. In this case, we want to select standby for CPU idle feature. But current setting wrongly select power down and cause CPU SUSPEND fail every time. Need this fix.

Fixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +9 -9
index b045812..bf7f845 100644
@@ -28,7 +28,7 @@
 			enable-method = "psci";
 			clocks = <&clockgen 1 0>;
 			next-level-cache = <&l2>;
-			cpu-idle-states = <&CPU_PH20>;
+			cpu-idle-states = <&CPU_PW20>;
 		};
 
 		cpu1: cpu@1 {
@@ -38,7 +38,7 @@
 			enable-method = "psci";
 			clocks = <&clockgen 1 0>;
 			next-level-cache = <&l2>;
-			cpu-idle-states = <&CPU_PH20>;
+			cpu-idle-states = <&CPU_PW20>;
 		};
 
 		l2: l2-cache {
@@ -53,13 +53,13 @@
 		 */
 		entry-method = "arm,psci";
 
-		CPU_PH20: cpu-ph20 {
-			compatible = "arm,idle-state";
-			idle-state-name = "PH20";
-			arm,psci-suspend-param = <0x00010000>;
-			entry-latency-us = <1000>;
-			exit-latency-us = <1000>;
-			min-residency-us = <3000>;
+		CPU_PW20: cpu-pw20 {
+			  compatible = "arm,idle-state";
+			  idle-state-name = "PW20";
+			  arm,psci-suspend-param = <0x0>;
+			  entry-latency-us = <2000>;
+			  exit-latency-us = <2000>;
+			  min-residency-us = <6000>;
 		};
 	};
 
Signature · 1 line
1.7.1
#1 lore raw
Quoted 8 lines · Ran Wang

PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to indicate CPU State Type: 0 for standby, 1 for power down. In this case, we want to select standby for CPU idle feature. But current setting wrongly select power down and cause CPU SUSPEND fail every time. Need this fix.

Fixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")

Leo, Bhaskar,

Do you guys agree with it?

Shawn

Quoted 50 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +9 -9
index b045812..bf7f845 100644
@@ -28,7 +28,7 @@
 			enable-method = "psci";
 			clocks = <&clockgen 1 0>;
 			next-level-cache = <&l2>;
-			cpu-idle-states = <&CPU_PH20>;
+			cpu-idle-states = <&CPU_PW20>;
 		};
 
 		cpu1: cpu@1 {
@@ -38,7 +38,7 @@
 			enable-method = "psci";
 			clocks = <&clockgen 1 0>;
 			next-level-cache = <&l2>;
-			cpu-idle-states = <&CPU_PH20>;
+			cpu-idle-states = <&CPU_PW20>;
 		};
 
 		l2: l2-cache {
@@ -53,13 +53,13 @@
 		 */
 		entry-method = "arm,psci";
 
-		CPU_PH20: cpu-ph20 {
-			compatible = "arm,idle-state";
-			idle-state-name = "PH20";
-			arm,psci-suspend-param = <0x00010000>;
-			entry-latency-us = <1000>;
-			exit-latency-us = <1000>;
-			min-residency-us = <3000>;
+		CPU_PW20: cpu-pw20 {
+			  compatible = "arm,idle-state";
+			  idle-state-name = "PW20";
+			  arm,psci-suspend-param = <0x0>;
+			  entry-latency-us = <2000>;
+			  exit-latency-us = <2000>;
+			  min-residency-us = <6000>;
 		};
 	};
 
Signature · 1 line
1.7.1
#2 lore raw
Quoted 8 lines · Shawn Guo
Quoted 6 lines · Ran Wang

PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to indicate CPU State Type: 0 for standby, 1 for power down. In this case, we want to select standby for CPU idle feature. But current setting wrongly select power down and cause CPU SUSPEND fail every time. Need this fix.

Quoted 6 lines
Quoted 2 lines
Fixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")

Leo, Bhaskar,

Do you guys agree with it?

Sorry that I missed this email previously. I agree with this change. CPU idle should use a low power state that could be waked up by interrupts and that should be PW20. And Ran is right that both PW20 and PH20 are actually not power down state.

- Leo

Quoted 53 lines

Shawn

Quoted 50 lines
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +9 -10
index b045812..bf7f845 100644
@@ -28,7 +28,7 @@
                      enable-method = "psci";
                      clocks = <&clockgen 1 0>;
                      next-level-cache = <&l2>;
-                     cpu-idle-states = <&CPU_PH20>;
+                     cpu-idle-states = <&CPU_PW20>;
              };
 
              cpu1: cpu@1 {
@@ -38,7 +38,7 @@
                      enable-method = "psci";
                      clocks = <&clockgen 1 0>;
                      next-level-cache = <&l2>;
-                     cpu-idle-states = <&CPU_PH20>;
+                     cpu-idle-states = <&CPU_PW20>;
              };
 
              l2: l2-cache {
@@ -53,13 +53,13 @@
               */
              entry-method = "arm,psci";
 
-             CPU_PH20: cpu-ph20 {
-                     compatible = "arm,idle-state";
-                     idle-state-name = "PH20";
-                     arm,psci-suspend-param = <0x00010000>;
-                     entry-latency-us = <1000>;
-                     exit-latency-us = <1000>;
-                     min-residency-us = <3000>;
+             CPU_PW20: cpu-pw20 {
+                       compatible = "arm,idle-state";
+                       idle-state-name = "PW20";
+                       arm,psci-suspend-param = <0x0>;
+                       entry-latency-us = <2000>;
+                       exit-latency-us = <2000>;
+                       min-residency-us = <6000>;
              };
      };
 
--

1.7.1

Applied
#3 lore raw
In reply to Ran Wang
Quoted 8 lines · Ran Wang

PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to indicate CPU State Type: 0 for standby, 1 for power down. In this case, we want to select standby for CPU idle feature. But current setting wrongly select power down and cause CPU SUSPEND fail every time. Need this fix.

Fixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")

Applied, thanks.