Skip to contentSkip to conversation

MAINTAINERS: Add entry for fieldbus subsystem

PATCH Superseded Sven Van Asbroeck 2 participants 5 messages May 23, 2019

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 MAINTAINERS: Add entry for fieldbus subsystem

Add myself as the maintainer of the fieldbus subsystem.

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
MAINTAINERS +5 -0
index 5cfbea4ce575..1cac53bced08 100644
@@ -14905,6 +14905,11 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/staging/erofs/
 
+STAGING - FIELDBUS SUBSYSTEM
+M:	Sven Van Asbroeck <[email protected]>
+S:	Maintained
+F:	drivers/staging/fieldbus/*
+
 STAGING - INDUSTRIAL IO
 M:	Jonathan Cameron <[email protected]>
 L:	[email protected]
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 MAINTAINERS: Add entry for anybuss drivers

Add myself as the maintainer of the anybuss bus driver, and its client drivers.

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
MAINTAINERS +5 -0
index 1cac53bced08..68d49623186f 100644
@@ -14910,6 +14910,11 @@ M:	Sven Van Asbroeck <[email protected]>
 S:	Maintained
 F:	drivers/staging/fieldbus/*
 
+STAGING - HMS ANYBUS-S BUS
+M:	Sven Van Asbroeck <[email protected]>
+S:	Maintained
+F:	drivers/staging/fieldbus/anybuss/
+
 STAGING - INDUSTRIAL IO
 M:	Jonathan Cameron <[email protected]>
 L:	[email protected]
Signature · 1 line
2.17.1
#2 lore raw
In reply to Sven Van Asbroeck
Quoted 1 line · Sven Van Asbroeck

Add myself as the maintainer of the fieldbus subsystem.

[]

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

MAINTAINERS L: [email protected] · line 14911

Quoted 8 lines
MAINTAINERS +4 -0
@@ -14905,6 +14905,11 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/staging/erofs/
 
+STAGING - FIELDBUS SUBSYSTEM
+M:	Sven Van Asbroeck <[email protected]>
+S:	Maintained
+F:	drivers/staging/fieldbus/*

The F: pattern above excludes subdirectories.

What about the drivers/staging/fieldbus/Documentation directory?

patch 2/2 specifically covers the anybuss directory, but the Documentation directory has no matching pattern.

trivia: anybuss looks like a misspelling.
It might be better as anybus-s.

#3 lore raw
Quoted 2 lines · Joe Perches

patch 2/2 specifically covers the anybuss directory, but the Documentation directory has no matching pattern.

Thank you for spotting that, I will re-spin the set.

Quoted 4 lines

trivia: anybuss looks like a misspelling.
It might be better as anybus-s.

This came up as well during the review process. When we insert a separator, the include files start looking like anybus-s-controller.h, and the structs become like struct anybus_s_ops. It then no longer looks like a misspelling, but becomes harder to read?

An alternative solution is to get rid of the 's' suffix altogether. Anybus-S is the only flavour we support right now. Although that may obviously change in the future.

#4 lore raw
Quoted 11 lines · Sven Van Asbroeck
Quoted 2 lines · Joe Perches

trivia: anybuss looks like a misspelling.
It might be better as anybus-s.

This came up as well during the review process. When we insert a separator, the include files start looking like anybus-s-controller.h, and the structs become like struct anybus_s_ops. It then no longer looks like a misspelling, but becomes harder to read?

An alternative solution is to get rid of the 's' suffix altogether. Anybus-S is the only flavour we support right now. Although that may obviously change in the future.

anybuss just looked odd to me.

Whatever you choose is up to you and
no doubt you'll choose well.

cheers, Joe