md: md.c: Return -ENODEV when mddev is NULL in rdev_attr_show
PATCH 1/1 md: md.c: Return -ENODEV when mddev is NULL in rdev_attr_show
Commit c42d3240990814eec1e4b2b93fa0487fc4873aed
("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to return -ENODEV when rdev->mddev is NULL, now do the same to rdev_attr_show.
Signed-off-by Marcos Paulo de Souza <[email protected]>
--- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/md.c +1 -1
@@ -3363,7 +3363,7 @@ rdev_attr_show(struct kobject *kobj, struct attribute *attr, char *page)if (!entry->show)return -EIO ;if (!rdev->mddev) -return -EBUSY ; +return -ENODEV ;return entry->show (rdev, page); }
Signature · 1 line
2.21.0
Quoted 4 lines · Marcos Paulo de Souza
Commit
c42d3240990814eec1e4b2b93fa0487fc4873aed
("md: return-ENODEVif rdev has no mddev assigned") changedrdev_attr_storeto return-ENODEVwhenrdev->mddevis NULL, now do the same tordev_attr_show.
nit: checkpatch.pl complains
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#84:
("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to
I fixed this in my tree, so no need to resend.
Thanks,
Song
Quoted 22 lines
Signed-off-by Marcos Paulo de Souza <[email protected]>--- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/md/md.c +1
-2@@ -3363,7 +3363,7 @@ rdev_attr_show(struct kobject *kobj, struct attribute *attr, char *page)if (!entry->show)return -EIO ;if (!rdev->mddev) -return -EBUSY ; +return -ENODEV ;return entry->show (rdev, page); } --2.21.0