dt-bindings: thermal: Make cooling-maps property optional
Subsystems (2)
PATCH 1/1 dt-bindings: thermal: Make cooling-maps property optional
There may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared.
So make this property optional to remove such limitations.
--- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/thermal/thermal.txt +2 -2
@@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip point nodes Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of only cooling device Type: sub-node map nodes, used to describe the relation between trips and cooling devices. - -Optional property: - coefficients: An array of integers (one signed cell) containing Type: array coefficients to compose a linear relation between Elem size: one cell the sensors listed in the thermal-sensors property.
Signature · 1 line
1.7.1
Quoted 4 lines · Yuantian Tang
There may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared.
So make this property optional to remove such limitations.
Yeah, I am not sure that is enough reason to make this property optional. Let me maybe ask you why do you care creating a thermal zone if your control has no actions? Or rather, why bothering setting up a control that has no actuators?
Quoted 27 lines
Signed-off-by Yuantian Tang <[email protected]>--- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +2
-2@@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip point nodes Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of only cooling device Type: sub-node map nodes, used to describe the relation between trips and cooling devices. - -Optional property: - coefficients: An array of integers (one signed cell) containing Type: array coefficients to compose a linear relation between Elem size: one cell the sensors listed in the thermal-sensors property.Signature · 1 line
1.7.1
Quoted 18 lines
-----Original Message-----
From: Eduardo Valentin <[email protected]>
Sent: 2019年5月24日 10:50
To: Andy Tang <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optionalCaution: EXT Email
Quoted 4 lines · Yuantian Tang
There may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared.
So make this property optional to remove such limitations.
Quoted 4 lines
Yeah, I am not sure that is enough reason to make this property optional. Let me maybe ask you why do you care creating a thermal zone if your control has no actions? Or rather, why bothering setting up a control that has no actuators?
No cooling-device map doesn't mean NO ACTIONS. There could be critic trips that trigger CPU reset or shutdown.
The root cause for it here is: there is no enough cooling device for each zone when multiple zone exist.
For example, for our ls2088a platform, there are 7 thermal zones, but we have only one cooling device which is cpufreq.
Due to this option limitation, multiple zones can't be supported.
I believe on most platform, there are only two type of cooling devices, cpufreq and fan. So how many cooling devices it could be?
So making the property optional is reasonable. We can assign cooling devices to certain thermal zones and leave the thermal zone with no cooling device taking default actions.
BR,
Andy
Quoted 35 lines
Quoted 13 lines
Signed-off-by Yuantian Tang <[email protected]>--- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +0
-0Documentation/devicetree/bindings/thermal/thermal.txt Required properties: · line 142
Quoted 1 line
Documentation/devicetree/bindings/thermal/thermal.txt +0
-0@@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip pointnodes
Documentation/devicetree/bindings/thermal/thermal.txt Required properties:
Quoted 5 lines
Documentation/devicetree/bindings/thermal/thermal.txt +2
-0Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of onlycooling device
Documentation/devicetree/bindings/thermal/thermal.txt Required properties: · line 148
Quoted 1 line
Documentation/devicetree/bindings/thermal/thermal.txt +0
-0Type: sub-node map nodes, used to describe the relationbetween trips
Documentation/devicetree/bindings/thermal/thermal.txt Required properties:
Quoted 4 lines
Documentation/devicetree/bindings/thermal/thermal.txt +0
-2and cooling devices. - -Optional property: - coefficients: An array of integers (one signed cell)containing
Documentation/devicetree/bindings/thermal/thermal.txt Required properties: · line 151
Quoted 1 line
Documentation/devicetree/bindings/thermal/thermal.txt +0
-0Type: array coefficients to compose a linear relationbetween
Documentation/devicetree/bindings/thermal/thermal.txt Required properties: · line 152
Quoted 1 line
Documentation/devicetree/bindings/thermal/thermal.txt +0
-0Elem size: one cell the sensors listed in the thermal-sensorsproperty.
Quoted 3 lines
--
1.7.1
Hi Edubezval, Rui,
Any further comments?
BR,
Andy
Quoted 41 lines
-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: 2019年5月15日 17:37
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property optionalThere may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared.
So make this property optional to remove such limitations.Signed-off-by Yuantian Tang <[email protected]>--- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +2
-0@@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip point nodes Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of only cooling device Type: sub-node map nodes, used to describe the relation betweentrips
Documentation/devicetree/bindings/thermal/thermal.txt +0
-3and cooling devices. - -Optional property: - coefficients: An array of integers (one signed cell) containing Type: array coefficients to compose a linear relation between Elem size: one cell the sensors listed in the thermal-sensors property. --1.7.1
Daniel Lezcano
Acked-byQuoted 5 lines · Andy Tang
Hi Edubezval, Rui,
Any further comments?
From my POV, this patch makes sense. We may be interested to show up the
thermal zones in sysfs and optionally mitigate them via an userspace governor.
Quoted 42 lines
Quoted 41 lines
-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: 2019年5月15日 17:37
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property optionalThere may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared.
So make this property optional to remove such limitations.Signed-off-by Yuantian Tang <[email protected]>--- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +2
-0@@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip point nodes Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of only cooling device Type: sub-node map nodes, used to describe the relation betweentrips
Documentation/devicetree/bindings/thermal/thermal.txt +0
-3and cooling devices. - -Optional property: - coefficients: An array of integers (one signed cell) containing Type: array coefficients to compose a linear relation between Elem size: one cell the sensors listed in the thermal-sensors property. --1.7.1
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Hi Edubezval, Rui,
Are you going to pick up this patch?
BR,
Andy
Quoted 101 lines
-----Original Message-----
From: Daniel Lezcano <[email protected]>
Sent: 2019年6月4日 14:04
To: Andy Tang <[email protected]>; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optionalCaution: EXT Email
Quoted 3 lines · Andy Tang
Hi Edubezval, Rui,
Any further comments?
From my POV, this patch makes sense. We may be interested to show up the thermal zones in sysfs and optionally mitigate them via an userspace governor.
Acked-by Daniel Lezcano <[email protected]>Quoted 21 lines
Quoted 21 lines
-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: 2019年5月15日 17:37
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Andy Tang <[email protected]>
Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property optionalThere may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared.
So make this property optional to remove such limitations.Signed-off-by Yuantian Tang <[email protected]>--- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)Quoted 7 lines
Documentation/devicetree/bindings/thermal/thermal.txt Required properties: · line 142
Quoted 7 lines
Documentation/devicetree/bindings/thermal/thermal.txt +0
-0@@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip pointnodes
Quoted 5 lines
Documentation/devicetree/bindings/thermal/thermal.txt Required properties:
Quoted 5 lines
Documentation/devicetree/bindings/thermal/thermal.txt +2
-0Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of onlycooling device
Quoted 1 line
Documentation/devicetree/bindings/thermal/thermal.txt Required properties: · line 148
Quoted 1 line
Documentation/devicetree/bindings/thermal/thermal.txt +0
-0Type: sub-node map nodes, used to describe the relationbetween
Quoted 5 lines
Documentation/devicetree/bindings/thermal/thermal.txt Required properties:
Quoted 5 lines
trips
and cooling devices.Documentation/devicetree/bindings/thermal/thermal.txt +0
-2- -Optional property: - coefficients: An array of integers (one signed cell)containing
Quoted 1 line
Quoted 1 line
Type: array coefficients to compose a linear relation
between
Quoted 1 line
Quoted 1 line
Elem size: one cell the sensors listed in the thermal-sensors
property.
Quoted 3 lines
Quoted 2 lines
--
1.7.1--
<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
linaro.org%2F&data=02%7C01%7Candy.tang%40nxp.com%7C2287a987 116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C 0%7C0%7C636952250606346540&sdata=D8XH3corlkEU91u7FguNtCF8 hkzR8viNntDQ4NjF9OM%3D&reserved=0> Linaro.org │ Open source software for ARM SoCsFollow Linaro:
<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
facebook.com%2Fpages%2FLinaro&data=02%7C01%7Candy.tang%40nx p.com%7C2287a987116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92 cd99c5c301635%7C0%7C0%7C636952250606356528&sdata=hRuvmW %2BrQ61tDEy7XIHKhTaTqxL%2FJC6gRy29YgsEazk%3D&reserved=0> Facebook |
<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitte
r.com%2F%23!%2Flinaroorg&data=02%7C01%7Candy.tang%40nxp.com %7C2287a987116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92cd99c 5c301635%7C0%7C0%7C636952250606356528&sdata=j6yO88tkG0uQs ViSV%2F9SCOYLa3iJ6pXs8mqxs6qt4uA%3D&reserved=0> Twitter |
<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
linaro.org%2Flinaro-blog%2F&data=02%7C01%7Candy.tang%40nxp.co m%7C2287a987116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92cd99 c5c301635%7C0%7C0%7C636952250606356528&sdata=q9tOF%2FiOL6 GpdvpSiT%2FyFIFL33Dx0%2FuBBaOxcmdD1Ro%3D&reserved=0> Blog