staging: iio: adis16240: add of_match_table entry
Subsystems (4)
PATCH 1/1 staging: iio: adis16240: add of_match_table entry
This patch adds of_match_table entry in device driver in order to enable spi fallback probing.
--- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/iio/accel/adis16240.c +1 -0
@@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);static struct spi_driver adis16240_driver = { .driver = { .name ="adis16240" , + .of_match_table = adis16240_of_match, }, .probe = adis16240_probe, .remove = adis16240_remove,
Signature · 1 line
2.20.1
Quoted 15 lines · Rodrigo Ribeiro
This patch adds
of_match_tableentry in device driver in order to enable spi fallback probing.Signed-off-by Rodrigo Ribeiro <[email protected]>Reviewed-by Marcelo Schmitt <[email protected]>--- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/iio/accel/adis16240.c +0
-0
drivers/staging/iio/accel/adis16240.c MODULE_DEVICE_TABLE(of, adis16240_of_match); · line 447
Quoted 4 lines
drivers/staging/iio/accel/adis16240.c +1
-0@@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);static struct spi_driver adis16240_driver = { .driver = { .name ="adis16240" , + .of_match_table = adis16240_of_match,
This patch is missing the actual table.
Quoted 6 lines
drivers/staging/iio/accel/adis16240.c +0
-1}, .probe = adis16240_probe, .remove = adis16240_remove, --2.20.1
Hi Alexandru,
Quoted 11 lines · Alexandru Ardelean
Quoted 10 lines · Rodrigo Ribeiro
This patch adds
of_match_tableentry in device driver in order to enable spi fallback probing.Signed-off-by Rodrigo Ribeiro <[email protected]>Reviewed-by Marcelo Schmitt <[email protected]>--- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
drivers/staging/iio/accel/adis16240.c MODULE_DEVICE_TABLE(of, adis16240_of_match); · line 447
Quoted 9 lines
drivers/staging/iio/accel/adis16240.c +1
-0@@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);static struct spi_driver adis16240_driver = { .driver = { .name ="adis16240" , + .of_match_table = adis16240_of_match,This patch is missing the actual table.
Struct with compatible devices table was included separately in a previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. Yeah, I also thought it was missing the match table the first time I was this patch. It's really confusing when we have two patches, one depending on another, that are not part of the same patch set. We're trying to avoid things like this the most but that slipped out from our internal review. We're sorry about that.
Quoted 7 lines
Quoted 7 lines
drivers/staging/iio/accel/adis16240.c +0
-1}, .probe = adis16240_probe, .remove = adis16240_remove, --2.20.1
Quoted 29 lines · Marcelo Schmitt
[External]
Hi Alexandru,
Quoted 11 lines · Alexandru Ardelean
Quoted 10 lines · Rodrigo Ribeiro
This patch adds
of_match_tableentry in device driver in order to enable spi fallback probing.Signed-off-by Rodrigo Ribeiro <[email protected]>Reviewed-by Marcelo Schmitt <[email protected]>--- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+)Quoted 11 lines
drivers/staging/iio/accel/adis16240.c MODULE_DEVICE_TABLE(of, adis16240_of_match); · line 447
Quoted 9 lines
drivers/staging/iio/accel/adis16240.c +1
-0@@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);static struct spi_driver adis16240_driver = { .driver = { .name ="adis16240" , + .of_match_table = adis16240_of_match,This patch is missing the actual table.
Quoted 7 lines
Struct with compatible devices table was included separately in a previous patch at commit
d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. Yeah, I also thought it was missing the match table the first time I was this patch. It's really confusing when we have two patches, one depending on another, that are not part of the same patch set. We're trying to avoid things like this the most but that slipped out from our internal review. We're sorry about that.
No worries.
It happens to me too.
Thanks
Alex
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/staging/iio/accel/adis16240.c +0
-1}, .probe = adis16240_probe, .remove = adis16240_remove, --2.20.1
Jonathan Cameron
maintainerQuoted 38 lines · Alexandru
Quoted 29 lines · Marcelo Schmitt
[External]
Hi Alexandru,
Quoted 11 lines · Alexandru Ardelean
Quoted 10 lines · Rodrigo Ribeiro
This patch adds
of_match_tableentry in device driver in order to enable spi fallback probing.Signed-off-by Rodrigo Ribeiro <[email protected]>Reviewed-by Marcelo Schmitt <[email protected]>--- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+)Quoted 11 lines
drivers/staging/iio/accel/adis16240.c MODULE_DEVICE_TABLE(of, adis16240_of_match); · line 447
Quoted 9 lines
drivers/staging/iio/accel/adis16240.c +1
-0@@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);static struct spi_driver adis16240_driver = { .driver = { .name ="adis16240" , + .of_match_table = adis16240_of_match,This patch is missing the actual table.
Quoted 7 lines
Struct with compatible devices table was included separately in a previous patch at commit
d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb. Yeah, I also thought it was missing the match table the first time I was this patch. It's really confusing when we have two patches, one depending on another, that are not part of the same patch set. We're trying to avoid things like this the most but that slipped out from our internal review. We're sorry about that.
Quoted 6 lines
No worries.
It happens to me too.
Thanks
Alex
Oops. I should have caught that one in review as well. Oh well, these things happen.
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. I rebased the tree to pick up on all the other stuff in staging/staging-next after the mere window.
Thanks,
Jonathan
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/staging/iio/accel/adis16240.c +0
-1}, .probe = adis16240_probe, .remove = adis16240_remove, --2.20.1