Skip to contentSkip to conversation

staging: fieldbus: anybuss: Remove variables

PATCH In review Nishka Dasgupta 2 participants 2 messages May 24, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fieldbus: anybuss: Remove variables

The local variable cd, used in multiple functions, is immediately passed to another function call, whose result is returned. As that is the only use of cd, it can be replaced with its variable.
Issue found with Coccinelle.

---
 drivers/staging/fieldbus/anybuss/host.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)
drivers/staging/fieldbus/anybuss/host.c +6 -12
index f69dc4930457..9679cd0b737b 100644
@@ -1046,10 +1046,8 @@ EXPORT_SYMBOL_GPL(anybuss_start_init);
 
 int anybuss_finish_init(struct anybuss_client *client)
 {
-	struct anybuss_host *cd = client->host;
-
-	return _anybus_mbox_cmd(cd, CMD_END_INIT, false, NULL, 0,
-					NULL, 0, NULL, 0);
+	return _anybus_mbox_cmd(client->host, CMD_END_INIT, false, NULL, 0,
+				NULL, 0, NULL, 0);
 }
 EXPORT_SYMBOL_GPL(anybuss_finish_init);
 
@@ -1146,20 +1144,16 @@ EXPORT_SYMBOL_GPL(anybuss_send_msg);
 int anybuss_send_ext(struct anybuss_client *client, u16 cmd_num,
 		     const void *buf, size_t count)
 {
-	struct anybuss_host *cd = client->host;
-
-	return _anybus_mbox_cmd(cd, cmd_num, true, NULL, 0, NULL, 0,
-					buf, count);
+	return _anybus_mbox_cmd(client->host, cmd_num, true, NULL, 0, NULL, 0,
+				buf, count);
 }
 EXPORT_SYMBOL_GPL(anybuss_send_ext);
 
 int anybuss_recv_msg(struct anybuss_client *client, u16 cmd_num,
 		     void *buf, size_t count)
 {
-	struct anybuss_host *cd = client->host;
-
-	return _anybus_mbox_cmd(cd, cmd_num, true, NULL, 0, buf, count,
-					NULL, 0);
+	return _anybus_mbox_cmd(client->host, cmd_num, true, NULL, 0, buf,
+				count, NULL, 0);
 }
 EXPORT_SYMBOL_GPL(anybuss_recv_msg);
 
Signature · 1 line
2.19.1
maintainer
#1 lore raw
Quoted 9 lines · Nishka Dasgupta

The local variable cd, used in multiple functions, is immediately passed to another function call, whose result is returned. As that is the only use of cd, it can be replaced with its variable.
Issue found with Coccinelle.

---
 drivers/staging/fieldbus/anybuss/host.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

Your subject line might say:
"remove unneeded temporary variables"
or something like that?

Quoted 6 lines
drivers/staging/fieldbus/anybuss/host.c +0 -0
index f69dc4930457..9679cd0b737b 100644

drivers/staging/fieldbus/anybuss/host.c EXPORT_SYMBOL_GPL(anybuss_start_init); · line 1051

Quoted 10 lines
drivers/staging/fieldbus/anybuss/host.c +2 -4
@@ -1046,10 +1046,8 @@ EXPORT_SYMBOL_GPL(anybuss_start_init);
 
 int anybuss_finish_init(struct anybuss_client *client)
 {
-	struct anybuss_host *cd = client->host;
-
-	return _anybus_mbox_cmd(cd, CMD_END_INIT, false, NULL, 0,
-					NULL, 0, NULL, 0);
+	return _anybus_mbox_cmd(client->host, CMD_END_INIT, false, NULL, 0,
+				NULL, 0, NULL, 0);
 }

While a potential change, this really doesn't help anything be it object code size, or make anything easier to understand.

Again, don't change things just because a tool said it could be changed, think about what you are doing and why it would, or would not, be something that is worth doing.

thanks,

greg k-h