dm: i2c: Add a flag that needs to generate a stop bit
Subsystems (3)
PATCH v2 1/3 dm: i2c: Add a flag that needs to generate a stop bit
Usually the i2c bus needs to write the address of the register before reading the internal register data of the device (ignoring the transmission of the slave address).
Generally, the stop signal is not needed before the register is read, but there is a special chip that needs this stop signal (such as pcf2127), this patch adds a flag that needs to generate a stop bit to determine whether the i2c host needs to generate a stop signal before reading the register data.
---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patch
drivers/i2c/i2c-uclass.c | 2 ++ include/i2c.h | 2 ++ 2 files changed, 4 insertions(+)
drivers/i2c/i2c-uclass.c +2 -0
@@ -141,6 +141,8 @@ int dm_i2c_read(struct udevice *dev, uint offset, uint8_t *buffer, int len)if (len) { ptr->addr = chip->chip_addr; ptr->flags = chip->flags &DM_I2C_CHIP_10BIT ?I2C_M_TEN :0 ; + ptr->flags |= chip->flags &DM_I2C_CHIP_RD_NEED_STOP_BIT ? +I2C_M_RD_NEED_STOP_BIT :0 ; ptr->flags |=I2C_M_RD ; ptr->len = len; ptr->buf = buffer;
include/i2c.h +2 -0
@@ -28,6 +28,7 @@ enum dm_i2c_chip_flags {DM_I2C_CHIP_10BIT =1 <<0 ,/* Use 10-bit addressing */ DM_I2C_CHIP_RD_ADDRESS =1 <<1 ,/* Send address for each read byte */ DM_I2C_CHIP_WR_ADDRESS =1 <<2 ,/* Send address for each write byte */ + DM_I2C_CHIP_RD_NEED_STOP_BIT = 1 << 3, /* Need generate stop bit */ };struct udevice ;
@@ -87,6 +88,7 @@ enum dm_i2c_msg_flags {I2C_M_IGNORE_NAK =0x1000 ,/* continue after NAK */ I2C_M_NO_RD_ACK =0x0800 ,/* skip the Ack bit on reads */ I2C_M_RECV_LEN =0x0400 ,/* length is first received byte */ + I2C_M_RD_NEED_STOP_BIT = 0x0002, /* need generate stop bit */ };/**
Signature · 1 line
2.17.1
PATCH v2 2/3 i2c: mxc_i2c: The i2c controller generates a stop signal before reading the register data
This patch enables the i2c controller to generate a stop signal before reading the slave device's internal register after setting the register address (need to determine if the signal is needed according to the message flag).
---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patch
drivers/i2c/mxc_i2c.c | 70 ++++++++++++++++++++++++++++++++++++++----- 1 file changed, 62 insertions(+), 8 deletions(-)
drivers/i2c/mxc_i2c.c +62 -8
@@ -961,6 +961,8 @@ static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs)int reg_shift = i2c_bus->driver_data &I2C_QUIRK_FLAG ?VF610_I2C_REGSHIFT :IMX_I2C_REGSHIFT ;int read_mode; +bool quirk = i2c_bus->driver_data &I2C_QUIRK_FLAG ? true : false; +unsigned int temp;/* Here address len is set to -1 to not send any address at first. * Otherwise i2c_init_transfer will send the chip address with write
@@ -975,6 +977,7 @@ static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs) read_mode =-1 ;/* So it's always different on the first message */ for (; nmsgs >0 ; nmsgs--, msg++) {const int msg_is_read = !!(msg->flags &I2C_M_RD ); +bool next_is_read = nmsgs >1 && (msg[1 ].flags &I2C_M_RD );debug ("i2c_xfer: chip=0x%x, len=0x%x, dir=%c\n" , msg->addr, msg->len, msg_is_read ?'R' :'W' );
@@ -982,13 +985,16 @@ static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs)if (msg_is_read != read_mode) {/* Send repeated start if not 1st message */ if (read_mode !=-1 ) { -debug ("i2c_xfer: [RSTART]\n" ); - ret =readb (base + (I2CR << reg_shift)); - ret |=I2CR_RSTA ; -writeb (ret, base + (I2CR << reg_shift)); +if (!(msg[1 ].flags &I2C_M_RD_NEED_STOP_BIT )) { +debug ("i2c_xfer: [RSTART]\n" ); + ret =readb (base + (I2CR << reg_shift)); + ret |=I2CR_RSTA ; +writeb (ret, base + (I2CR << reg_shift)); + } }debug ("i2c_xfer: [ADDR %02x | %c]\n" , msg->addr, msg_is_read ?'R' :'W' ); + ret =tx_byte (i2c_bus, (msg->addr <<1 ) | msg_is_read);if (ret <0 ) {debug ("i2c_xfer: [STOP]\n" );
@@ -998,16 +1004,64 @@ static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs) read_mode = msg_is_read; } -if (msg->flags &I2C_M_RD ) +if (msg->flags &I2C_M_RD ) { ret =i2c_read_data (i2c_bus, msg->addr, msg->buf, msg->len, nmsgs ==1 || (msg->flags &I2C_M_STOP )); -else - ret =i2c_write_data (i2c_bus, msg->addr, msg->buf, - msg->len); +if (ret <0 ) +break ; +continue ; + } +/* Write message */ + ret =i2c_write_data (i2c_bus, msg->addr, msg->buf, + msg->len);if (ret <0 )break ; + +if (!next_is_read) +continue ; + +/* Read message following write message */ +if (msg[1 ].flags &I2C_M_RD_NEED_STOP_BIT ) { +/* Generate a stop bit */ +i2c_imx_stop (i2c_bus); +/* Reset i2c slave */ +i2c_force_reset_slave (); + +/* Enable I2C controller */ +if (quirk) + ret =readb (base + (I2CR << reg_shift)) + &I2CR_IDIS ; +else + ret = !(readb (base + (I2CR << reg_shift)) + &I2CR_IEN ); +if (ret) { +writeb (I2CR_IEN , base + (I2CR << reg_shift)); +/* Wait for controller to be stable */ +udelay (50 ); + } + +/* Clear interrupt bit */ +writeb (I2SR_IIF_CLEAR , base + (I2SR << reg_shift)); + ret =wait_for_sr_state (i2c_bus,ST_BUS_IDLE ); +if (ret <0 ) +return ret; + +/* Start I2C transaction */ + temp =readb (base + (I2CR << reg_shift)); + temp |=I2CR_MSTA ; +writeb (temp, base + (I2CR << reg_shift)); + + ret =wait_for_sr_state (i2c_bus,ST_BUS_BUSY ); +if (ret <0 ) +return ret; + +/* Enter transfer mode */ + temp |=I2CR_MTX |I2CR_TX_NO_AK ; +writeb (temp, base + (I2CR << reg_shift)); +udelay (50 ); + } }if (ret)
Signature · 1 line
2.17.1
PATCH v2 2/3 i2c: mxc_i2c: The i2c controller generates a stop signal before reading the register data
Hi Chuanhua,
Quoted 5 lines
This patch enables the i2c controller to generate a stop signal before reading the slave device's internal register after setting the register address (need to determine if the signal is needed according to the message flag).
Quoted 8 lines
Signed-off-by Biwen Li <[email protected]>Signed-off-by Chuanhua Han <[email protected]>---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patchdrivers/i2c/mxc_i2c.c | 70
I must admit that I'm a bit puzzled - in the patch 1/3 you added the U-Boot wide I2C_M_RD_NEED_STOP_BIT flag to indicate the need to generate a stop bit.
Iin this patch you change the respective mxc_i2c.c
driver (which is NXP SoC specific). Shouldn't those changes go in to a "generic" i2c code (or better to the pcf2127 driver) ?
What would happen if somebody use this device (pcf2127.c) on board running e.g. TI processor? (like Beagle Bone Black). Would the pcf2127 work properly in that case?
Quoted 121 lines
++++++++++++++++++++++++++++++++++++++----- 1 file changed, 62 insertions(+), 8 deletions(-)
drivers/i2c/mxc_i2c.c +0
-0@@ -961,6 +961,8 @@ static int mxc_i2c_xfer(struct udevice *bus,struct
i2c_msg*msg, int nmsgs) intreg_shift=i2c_bus->driver_data&I2C_QUIRK_FLAG?VF610_I2C_REGSHIFT:IMX_I2C_REGSHIFT;drivers/i2c/mxc_i2c.c +1
-0int read_mode; + bool quirk = i2c_bus->driver_data & I2C_QUIRK_FLAG ? true :false;
drivers/i2c/mxc_i2c.c +1
-0+unsigned int temp;/* Here address len is set to -1 to not send any address at first.
* Otherwisei2c_init_transferwill send the chip address
with write @@ -975,6 +977,7 @@ static intmxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs)read_mode= -1; /* So it's always different on the first message */ for (; nmsgs > 0; nmsgs--, msg++) { const intmsg_is_read= !!(msg->flags &I2C_M_RD);drivers/i2c/mxc_i2c.c +1
-0+ bool next_is_read = nmsgs > 1 && (msg[1].flags &
I2C_M_RD);
debug("i2c_xfer: chip=0x%x, len=0x%x, dir=%c\n",msg->addr,msg->len,msg_is_read? 'R' : 'W');drivers/i2c/mxc_i2c.c +6
-4@@ -982,13 +985,16 @@ static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs) if (msg_is_read != read_mode) {/* Send repeated start if not 1st message */ if (read_mode !=-1 ) { -debug ("i2c_xfer: [RSTART]\n" ); - ret =readb (base + (I2CR << reg_shift)); - ret |=I2CR_RSTA ; -writeb (ret, base + (I2CR << reg_shift)); +if (!(msg[1 ].flags &I2C_M_RD_NEED_STOP_BIT )) { + debug("i2c_xfer: [RSTART]\n"); + ret =readb (base + (I2CR << reg_shift)); + ret |=I2CR_RSTA ; +writeb (ret, base + (I2CR << reg_shift)); + } } debug("i2c_xfer: [ADDR %02x | %c]\n",
msg->addr,msg_is_read? 'R' : 'W');drivers/i2c/mxc_i2c.c +1
-0+ ret = tx_byte(i2c_bus, (msg->addr << 1) |
msg_is_read); if (ret < 0) {drivers/i2c/mxc_i2c.c +1
-1debug ("i2c_xfer: [STOP]\n" );@@ -998,16 +1004,64 @@ static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs) read_mode = msg_is_read; } -if (msg->flags &I2C_M_RD ) +if (msg->flags &I2C_M_RD ) { ret = i2c_read_data(i2c_bus, msg->addr,
msg->buf,msg->len, nmsgs == 1 ||
(msg->flags&I2C_M_STOP));drivers/i2c/mxc_i2c.c +0
-2-else - ret = i2c_write_data(i2c_bus, msg->addr,
msg->buf,drivers/i2c/mxc_i2c.c +21
-1- msg->len); +if (ret <0 ) +break ; +continue ; + } +/* Write message */ + ret =i2c_write_data (i2c_bus, msg->addr, msg->buf, + msg->len);if (ret <0 )break ; + +if (!next_is_read) +continue ; + +/* Read message following write message */ +if (msg[1 ].flags &I2C_M_RD_NEED_STOP_BIT ) { +/* Generate a stop bit */ +i2c_imx_stop (i2c_bus); +/* Reset i2c slave */ +i2c_force_reset_slave (); + +/* Enable I2C controller */ +if (quirk) + ret = readb(base + (I2CR <<
reg_shift))drivers/i2c/mxc_i2c.c +3
-0+ &I2CR_IDIS ; + else + ret = !(readb(base + (I2CR <<
reg_shift))drivers/i2c/mxc_i2c.c +3
-0+ & I2CR_IEN); +if (ret) { + writeb(I2CR_IEN, base + (I2CR <<
reg_shift));drivers/i2c/mxc_i2c.c +1
-0+/* Wait for controller to be stable */
drivers/i2c/mxc_i2c.c +5
-0+udelay (50 ); + } + +/* Clear interrupt bit */ + writeb(I2SR_IIF_CLEAR, base + (I2SR <<
reg_shift));drivers/i2c/mxc_i2c.c +1
-0+ ret = wait_for_sr_state(i2c_bus,
ST_BUS_IDLE);drivers/i2c/mxc_i2c.c +9
-0+if (ret <0 ) +return ret; + +/* Start I2C transaction */ + temp =readb (base + (I2CR << reg_shift)); + temp |=I2CR_MSTA ; +writeb (temp, base + (I2CR << reg_shift)); + + ret = wait_for_sr_state(i2c_bus,
ST_BUS_BUSY);drivers/i2c/mxc_i2c.c +1
-0+if (ret <0 )
drivers/i2c/mxc_i2c.c static int mxc_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs) · line 1067
Quoted 10 lines
drivers/i2c/mxc_i2c.c +7
-0+return ret; + +/* Enter transfer mode */ + temp |=I2CR_MTX |I2CR_TX_NO_AK ; +writeb (temp, base + (I2CR << reg_shift)); +udelay (50 ); + } }if (ret)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190524/3653fdf0/attachment.sig>
PATCH v2 3/3 rtc: pcf2127: Fixed bug with rtc settings and getting error time
In reply to Chuanhua HanThe previous pcf2127 RTC chip could not read and set the correct time. When reading the data of internal registers, the read address was the value of register plus 1. This is because this chip requires the host to send a stop signal after setting the register address and before reading the register data.
This patch sets the flag that the stop signal is needed and fixes the bug of the original read and write time.
---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patch
drivers/rtc/pcf2127.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/rtc/pcf2127.c +10 -8
@@ -24,12 +24,9 @@static int pcf2127_rtc_set (struct udevice *dev,const struct rtc_time *tm) { -uchar buf[8 ]; +uchar buf[7 ] = {0 };int i =0 , ret; -/* start register address */ - buf[i++] =PCF2127_REG_SC ; -/* hours, minutes and seconds */ buf[i++] =bin2bcd (tm->tm_sec); buf[i++] =bin2bcd (tm->tm_min);
@@ -44,7 +41,7 @@ static int pcf2127_rtc_set(struct udevice *dev, const struct rtc_time *tm) buf[i++] =bin2bcd (tm->tm_year %100 );/* write register's data */ - ret =dm_i2c_write (dev,PCF2127_REG_CTRL1 , buf,sizeof (buf)); + ret =dm_i2c_write (dev,PCF2127_REG_SC , buf, i);return ret; }
@@ -54,9 +51,6 @@ static int pcf2127_rtc_get(struct udevice *dev, struct rtc_time *tm)int ret =0 ;uchar buf[10 ] = {PCF2127_REG_CTRL1 }; - ret =dm_i2c_write (dev,PCF2127_REG_CTRL1 , buf,1 ); -if (ret <0 ) -return ret; ret =dm_i2c_read (dev,PCF2127_REG_CTRL1 , buf,sizeof (buf));if (ret <0 )return ret;
@@ -90,6 +84,13 @@ static int pcf2127_rtc_reset(struct udevice *dev)return 0 ; } +static int pcf2127_probe (struct udevice *dev) +{ +i2c_set_chip_flags (dev,DM_I2C_CHIP_RD_NEED_STOP_BIT ); + +return 0 ; +} +static const struct rtc_ops pcf2127_rtc_ops = { .get = pcf2127_rtc_get, .set = pcf2127_rtc_set,
@@ -104,6 +105,7 @@ static const struct udevice_id pcf2127_rtc_ids[] = {U_BOOT_DRIVER (rtc_pcf2127) = { .name ="rtc-pcf2127" , .id =UCLASS_RTC , + .probe = pcf2127_probe, .of_match = pcf2127_rtc_ids, .ops = &pcf2127_rtc_ops, };
Signature · 1 line
2.17.1
PATCH v2 3/3 rtc: pcf2127: Fixed bug with rtc settings and getting error time
Hi,
Quoted 12 lines · Chuanhua Han
The previous pcf2127 RTC chip could not read and set the correct time. When reading the data of internal registers, the read address was the value of register plus 1. This is because this chip requires the host to send a stop signal after setting the register address and before reading the register data.
This patch sets the flag that the stop signal is needed and fixes the bug of the original read and write time.
Signed-off-by Biwen Li <[email protected]>Signed-off-by Chuanhua Han <[email protected]>
Quoted 7 lines
---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patchdrivers/rtc/pcf2127.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
Can you modify this to use i2c_xfer() so that separate transactions are done?
Regards,
SImon
[U-Boot] [EXT] Re: [PATCH v2 3/3] rtc: pcf2127: Fixed bug with rtc settings and getting error time
Hi,
Quoted 32 lines
-----Original Message-----
From: Simon Glass <[email protected]>
Sent: 2019年6月23日 3:10
To: Chuanhua Han <[email protected]>
Cc: Heiko Schocher <[email protected]>; U-Boot Mailing List <[email protected]>; Biwen Li <[email protected]>; Lukasz Majewski <[email protected]>
Subject: [EXT] Re: [PATCH v2 3/3] rtc: pcf2127: Fixed bug with rtc settings and getting error timeCaution: EXT Email
Hi,
Quoted 17 lines · Chuanhua Han
The previous pcf2127 RTC chip could not read and set the correct time. When reading the data of internal registers, the read address was the value of register plus 1. This is because this chip requires the host to send a stop signal after setting the register address and before reading the register data.
This patch sets the flag that the stop signal is needed and fixes the bug of the original read and write time.
Signed-off-by Biwen Li <[email protected]>Signed-off-by Chuanhua Han <[email protected]>---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patch
Quoted 5 lines
Quoted 2 lines
drivers/rtc/pcf2127.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)Can you modify this to use
i2c_xfer()so that separate transactions are done?
I have sent the fourth edition you see the new patchwork:
http://patchwork.ozlabs.org/project/uboot/list/?series=114242
Quoted 2 lines
Regards,
SImon
PATCH v2 1/3 dm: i2c: Add a flag that needs to generate a stop bit
In reply to Chuanhua HanHi,
Quoted 10 lines · Chuanhua Han
Usually the i2c bus needs to write the address of the register before reading the internal register data of the device (ignoring the transmission of the slave address).
Generally, the stop signal is not needed before the register is read, but there is a special chip that needs this stop signal (such as pcf2127), this patch adds a flag that needs to generate a stop bit to determine whether the i2c host needs to generate a stop signal before reading the register data.
Does this mean that the chip does not comply with the i2c protocol?
Is it possible instead to so a write and then a read?
See dm_i2c_xfer().
Quoted 48 lines
Signed-off-by Biwen Li <[email protected]>Signed-off-by Chuanhua Han <[email protected]>---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patchdrivers/i2c/i2c-uclass.c | 2 ++ include/i2c.h | 2 ++ 2 files changed, 4 insertions(+)drivers/i2c/i2c-uclass.c +2
-0@@ -141,6 +141,8 @@ int dm_i2c_read(struct udevice *dev, uint offset, uint8_t *buffer, int len)if (len) { ptr->addr = chip->chip_addr; ptr->flags = chip->flags &DM_I2C_CHIP_10BIT ?I2C_M_TEN :0 ; + ptr->flags |= chip->flags &DM_I2C_CHIP_RD_NEED_STOP_BIT ? +I2C_M_RD_NEED_STOP_BIT :0 ; ptr->flags |=I2C_M_RD ; ptr->len = len; ptr->buf = buffer;include/i2c.h +2
-1@@ -28,6 +28,7 @@ enum dm_i2c_chip_flags {DM_I2C_CHIP_10BIT =1 <<0 ,/* Use 10-bit addressing */ DM_I2C_CHIP_RD_ADDRESS =1 <<1 ,/* Send address for each read byte */ DM_I2C_CHIP_WR_ADDRESS =1 <<2 ,/* Send address for each write byte */ + DM_I2C_CHIP_RD_NEED_STOP_BIT = 1 << 3, /* Need generate stop bit */ };struct udevice ;@@ -87,6 +88,7 @@ enum dm_i2c_msg_flags {I2C_M_IGNORE_NAK =0x1000 ,/* continue after NAK */ I2C_M_NO_RD_ACK =0x0800 ,/* skip the Ack bit on reads */ I2C_M_RECV_LEN =0x0400 ,/* length is first received byte */ + I2C_M_RD_NEED_STOP_BIT = 0x0002, /* need generate stop bit */ };/** -- 2.17.1
Quoted 27 lines
-----Original Message-----
From: Simon Glass <[email protected]>
Sent: 2019年6月23日 3:10
To: Chuanhua Han <[email protected]>
Cc: Heiko Schocher <[email protected]>; U-Boot Mailing List <[email protected]>; Biwen Li <[email protected]>; Lukasz Majewski <[email protected]>
Subject: [EXT] Re: [PATCH v2 1/3] dm: i2c: Add a flag that needs to generate a stop bitCaution: EXT Email
Hi,
Quoted 10 lines · Chuanhua Han
Usually the i2c bus needs to write the address of the register before reading the internal register data of the device (ignoring the transmission of the slave address).
Generally, the stop signal is not needed before the register is read, but there is a special chip that needs this stop signal (such as pcf2127), this patch adds a flag that needs to generate a stop bit to determine whether the i2c host needs to generate a stop signal before reading the register data.
Quoted 5 lines
Does this mean that the chip does not comply with the i2c protocol?
Is it possible instead to so a write and then a read?
See
dm_i2c_xfer().
Please see the fourth version of the patch, use the dm_i2c_xfer () function to do and I use a flag to limit the dm_i2c_read function It is the same to transmit only one msg. Since the core layer already provides the dm_i2c_read function, it is appropriate to use this function. Only condition flag is required to limit
Quoted 59 lines
drivers/i2c/i2c-uclass.c int dm_i2c_read(struct udevice *dev, uint offset,
Quoted 19 lines
Signed-off-by Biwen Li <[email protected]>Signed-off-by Chuanhua Han <[email protected]>---
Changes in v2:
- Split the original patch into 3 patches
- Add detailed description information for each patchdrivers/i2c/i2c-uclass.c | 2 ++ include/i2c.h | 2 ++ 2 files changed, 4 insertions(+)drivers/i2c/i2c-uclass.c index renamed from drivers/i2c/i2c-uclass.c +0
-0
e47abf1833..18f7364d72100644drivers/i2c/i2c-uclass.c +0
-0@@ -141,6 +141,8 @@ int dm_i2c_read(struct udevice *dev, uint offset,
uint8_t*buffer, int len)drivers/i2c/i2c-uclass.c int dm_i2c_read(struct udevice *dev, uint offset, · line 145
Quoted 5 lines
drivers/i2c/i2c-uclass.c +1
-0if (len) { ptr->addr = chip->chip_addr; ptr->flags = chip->flags &DM_I2C_CHIP_10BIT ?I2C_M_TEN :0 ; + ptr->flags |= chip->flags &
DM_I2C_CHIP_RD_NEED_STOP_BIT?include/i2c.h enum dm_i2c_chip_flags { · line 29
Quoted 11 lines
drivers/i2c/i2c-uclass.c +1
-0+ I2C_M_RD_NEED_STOP_BIT :0 ; ptr->flags |=I2C_M_RD ; ptr->len = len;ptr->buf = buffer;include/i2c.h index renamed from include/i2c.h +0
-0
a5c760c711..beaa028349100644include/i2c.h +0
-0@@ -28,6 +28,7 @@ enum dm_i2c_chip_flags {DM_I2C_CHIP_10BIT =1 <<0 ,/* Use 10-bit addressing */ DM_I2C_CHIP_RD_ADDRESS = 1 << 1, /* Send address for eachread byte */
Quoted 3 lines
include/i2c.h +0
-0DM_I2C_CHIP_WR_ADDRESS = 1 << 2, /* Send address for eachwrite byte */
+DM_I2C_CHIP_RD_NEED_STOP_BIT= 1 << 3, /* Need generatestop bit */
include/i2c.h enum dm_i2c_msg_flags { · line 89
Quoted 6 lines
};
struct udevice;
include/i2c.h +0
-0@@ -87,6 +88,7 @@ enum dm_i2c_msg_flags {I2C_M_IGNORE_NAK =0x1000 ,/* continue after NAK */ I2C_M_NO_RD_ACK = 0x0800, /* skip the Ack bit onreads */
include/i2c.h enum dm_i2c_msg_flags { · line 90
Quoted 1 line
include/i2c.h +0
-0I2C_M_RECV_LEN = 0x0400, /* length is first receivedbyte */
include/i2c.h enum dm_i2c_msg_flags { · line 91
Quoted 1 line
include/i2c.h +1
-0+ I2C_M_RD_NEED_STOP_BIT = 0x0002, /* need generate stop bit*/
Quoted 6 lines
include/i2c.h +0
-1};/** -- 2.17.1
Hi Chuanhua,
Quoted 28 lines · Chuanhua Han
Quoted 28 lines
-----Original Message-----
From: Simon Glass <[email protected]>
Sent: 2019年6月23日 3:10
To: Chuanhua Han <[email protected]>
Cc: Heiko Schocher <[email protected]>; U-Boot Mailing List <[email protected]>; Biwen Li <[email protected]>; Lukasz Majewski <[email protected]>
Subject: [EXT] Re: [PATCH v2 1/3] dm: i2c: Add a flag that needs to generate a stop bitCaution: EXT Email
Hi,
Quoted 10 lines · Chuanhua Han
Usually the i2c bus needs to write the address of the register before reading the internal register data of the device (ignoring the transmission of the slave address).
Generally, the stop signal is not needed before the register is read, but there is a special chip that needs this stop signal (such as pcf2127), this patch adds a flag that needs to generate a stop bit to determine whether the i2c host needs to generate a stop signal before reading the register data.
Quoted 8 lines
Quoted 5 lines
Does this mean that the chip does not comply with the i2c protocol?
Is it possible instead to so a write and then a read?
See
dm_i2c_xfer().Please see the fourth version of the patch, use the
dm_i2c_xfer() function to do and I use a flag to limit thedm_i2c_readfunction It is the same to transmit only one msg. Since the core layer already provides thedm_i2c_readfunction, it is appropriate to use this function. Only condition flag is required to limit
I cannot find that patch. On another thread you pointed me to a v4 patch but when I looked it was not v4.
Can you please link to the v4 patch in patchwork?
I found a v2 that I will reply to in any case.
Regards,
Simon