Skip to contentSkip to conversation

drm: panel-orientation-quirks: Add quirk for GPD pocket2

PATCH In review Hans de Goede 2 participants 8 messages May 24, 2019 – Jun 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 drm: panel-orientation-quirks: Add quirk for GPD pocket2

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_pocket2 data struct may very well need to be updated with some extra bios-dates in the future.

Changes in v2:
-Add one more known BIOS date to the list of BIOS dates

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -0
index 521aff99b08a..98679c831f66 100644
@@ -50,6 +50,14 @@ static const struct drm_dmi_panel_orientation_data gpd_pocket = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data gpd_pocket2 = {
+	.width = 1200,
+	.height = 1920,
+	.bios_dates = (const char * const []){ "06/28/2018", "08/28/2018",
+		"12/07/2018", NULL },
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data gpd_win = {
 	.width = 720,
 	.height = 1280,
@@ -112,6 +120,14 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
 		},
 		.driver_data = (void *)&gpd_pocket,
+	}, {	/* GPD Pocket 2 (generic strings, also match on bios date) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
+		},
+		.driver_data = (void *)&gpd_pocket2,
 	}, {	/* GPD Win (same note on DMI match as GPD Pocket) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH v2 2/2 drm: panel-orientation-quirks: Add quirk for GPD MicroPC

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -0
index 98679c831f66..d8a0bcd02f34 100644
@@ -42,6 +42,14 @@ static const struct drm_dmi_panel_orientation_data asus_t100ha = {
 	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data gpd_micropc = {
+	.width = 720,
+	.height = 1280,
+	.bios_dates = (const char * const []){ "04/26/2019",
+		NULL },
+	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data gpd_pocket = {
 	.width = 1200,
 	.height = 1920,
@@ -107,6 +115,14 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
 		},
 		.driver_data = (void *)&asus_t100ha,
+	}, {	/* GPD MicroPC (generic strings, also match on bios date) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
+		},
+		.driver_data = (void *)&gpd_micropc,
 	}, {	/*
 		 * GPD Pocket, note that the the DMI data is less generic then
 		 * it seems, devices with a board-vendor of "AMI Corporation"
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

Quoted 8 lines · Hans de Goede

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

For both patches,

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

Hi,

Quoted 4 lines · Maxime Ripard
Quoted 3 lines · Hans de Goede

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Quoted 8 lines
Quoted 5 lines

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

For both patches,

Thank you, I've pushed both to drm-misc-next now.

Can you add them to drm-misc-fixes please ?

(AFAIK I'm not supposed to do that myself)

Regards,

Hans

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

Quoted 11 lines · Hans de Goede
Quoted 10 lines · Maxime Ripard
Quoted 8 lines · Hans de Goede

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

Quoted 8 lines
Quoted 2 lines

For both patches,

Thank you, I've pushed both to drm-misc-next now.

Can you add them to drm-misc-fixes please ?

(AFAIK I'm not supposed to do that myself)

You definitely can :)

Now that it's in next though, it's pretty hard to come back in time. I guess we could just apply it in fixes and let git figure it out, or revert the one in next. I'm not sure which one is preferred though.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

Hi,

Quoted 19 lines · Maxime Ripard
Quoted 18 lines · Hans de Goede
Quoted 4 lines · Maxime Ripard
Quoted 3 lines · Hans de Goede

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Quoted 8 lines
Quoted 5 lines

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

For both patches,

Thank you, I've pushed both to drm-misc-next now.

Can you add them to drm-misc-fixes please ?

Quoted 8 lines
Quoted 1 line

(AFAIK I'm not supposed to do that myself)

You definitely can :)

Now that it's in next though, it's pretty hard to come back in time. I guess we could just apply it in fixes and let git figure it out, or revert the one in next. I'm not sure which one is preferred though.

I thought that the procedure was to get it in -next and then cherry-pick into -fixes? Git should sort this out without issues when Linus merges -next; or when we back-merge Linus' tree.

Regards,

Hans

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

Quoted 26 lines · Hans de Goede

Hi,

Quoted 23 lines · Maxime Ripard
Quoted 11 lines · Hans de Goede
Quoted 10 lines · Maxime Ripard
Quoted 8 lines · Hans de Goede

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

Quoted 8 lines
Quoted 2 lines

For both patches,

Thank you, I've pushed both to drm-misc-next now.

Can you add them to drm-misc-fixes please ?

(AFAIK I'm not supposed to do that myself)

You definitely can :)

Quoted 7 lines
Quoted 4 lines

Now that it's in next though, it's pretty hard to come back in time. I guess we could just apply it in fixes and let git figure it out, or revert the one in next. I'm not sure which one is preferred though.

I thought that the procedure was to get it in -next and then cherry-pick into -fixes?

If you feel like something should be in fixes, you can definitely apply it there only.

Quoted 2 lines

Git should sort this out without issues when Linus merges -next; or when we back-merge Linus' tree.

Yeah, looking at the doc, cherry-picking is the one encouraged, so feel free to cherry-pick them in drm-misc-fixes.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

Hi,

Quoted 35 lines · Maxime Ripard
Quoted 26 lines · Hans de Goede

Hi,

Quoted 23 lines · Maxime Ripard
Quoted 11 lines · Hans de Goede
Quoted 10 lines · Maxime Ripard
Quoted 8 lines · Hans de Goede

GPD has done it again, make a nice device (good), use way too generic DMI strings (bad) and use a portrait screen rotated 90 degrees (ugly).

Because of the too generic DMI strings this entry is also doing bios-date matching, so the gpd_micropc data struct may very well need to be updated with some extra bios-dates in the future.

Quoted 8 lines
Quoted 2 lines

For both patches,

Thank you, I've pushed both to drm-misc-next now.

Can you add them to drm-misc-fixes please ?

(AFAIK I'm not supposed to do that myself)

You definitely can :)

Quoted 7 lines
Quoted 4 lines

Now that it's in next though, it's pretty hard to come back in time. I guess we could just apply it in fixes and let git figure it out, or revert the one in next. I'm not sure which one is preferred though.

I thought that the procedure was to get it in -next and then cherry-pick into -fixes?

Quoted 8 lines

If you feel like something should be in fixes, you can definitely apply it there only.

Quoted 2 lines

Git should sort this out without issues when Linus merges -next; or when we back-merge Linus' tree.

Yeah, looking at the doc, cherry-picking is the one encouraged, so feel free to cherry-pick them in drm-misc-fixes.

Ok, cherry-picked and pushed, thanks.

Regards,

Hans

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel