Fixes for staging/kpc2000's Kconfig
cover Fixes for staging/kpc2000's Kconfig
Hi,
Here are two patches that fixes issues in kpc2000's Kconfig.
The first one is a typo fix (I'm guessing Kaktronics is a typo...).
The second one is a fix for a dependency issues I met when trying to build kpc2000 on a default x86_64 config. I'm not familiar with neither MFD nor UIO, so I'm not sure that I solved it correctly. Maybe there are some other things to consider as this is in staging?
- Simon
Simon Sandström (2):
staging: kpc2000: fix typo in Kconfig
staging: kpc2000: add missing dependencies for kpc2000
drivers/staging/kpc2000/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/2 staging: kpc2000: fix typo in Kconfig
Fixes two minor typos in kpc2000's Kconfig: s/Kaktronics/Daktronics
--- drivers/staging/kpc2000/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/kpc2000/Kconfig +2 -2
@@ -21,7 +21,7 @@ config KPC2000_CORE If unsure, say N. config KPC2000_SPI - tristate "Kaktronics KPC SPI device" + tristate "Daktronics KPC SPI device" depends on KPC2000 && SPI help Say Y here if you wish to support the Daktronics KPC PCI
@@ -33,7 +33,7 @@ config KPC2000_SPI If unsure, say N. config KPC2000_I2C - tristate "Kaktronics KPC I2C device" + tristate "Daktronics KPC I2C device" depends on KPC2000 && I2C help Say Y here if you wish to support the Daktronics KPC PCI
Signature · 1 line
2.20.1
PATCH 2/2 staging: kpc2000: add missing dependencies for kpc2000
In reply to Simon SandströmFixes build errors:
ERROR: "mfd_remove_devices" [kpc2000.ko] undefined!
ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
ERROR: "__uio_register_device" [kpc2000.ko] undefined!
--- drivers/staging/kpc2000/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/staging/kpc2000/Kconfig +2 -0
@@ -3,6 +3,8 @@ config KPC2000 bool "Daktronics KPC Device support" depends on PCI + select MFD_CORE + select UIO help Select this if you wish to use the Daktronics KPC PCI devices
Signature · 1 line
2.20.1
Greg KH
maintainerRe: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000
Quoted 17 lines · Simon Sandström
Fixes build errors:
ERROR: "
mfd_remove_devices" [kpc2000.ko] undefined!
ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
ERROR: "__uio_register_device" [kpc2000.ko] undefined!Signed-off-by Simon Sandström <[email protected]>--- drivers/staging/kpc2000/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/staging/kpc2000/Kconfig +0
-0
drivers/staging/kpc2000/Kconfig line 10
Quoted 8 lines
drivers/staging/kpc2000/Kconfig +2
-0@@ -3,6 +3,8 @@ config KPC2000 bool "Daktronics KPC Device support" depends on PCI + select MFD_CORE + select UIO help Select this if you wish to use the Daktronics KPC PCI devices
This is already in linux-next (in a different form), are you sure you are working against the latest kernel tree?
thanks,
greg k-h
Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000
Quoted 30 lines · Greg KH
Quoted 17 lines · Simon Sandström
Fixes build errors:
ERROR: "
mfd_remove_devices" [kpc2000.ko] undefined!
ERROR: "uio_unregister_device" [kpc2000.ko] undefined!
ERROR: "mfd_add_devices" [kpc2000.ko] undefined!
ERROR: "__uio_register_device" [kpc2000.ko] undefined!Signed-off-by Simon Sandström <[email protected]>--- drivers/staging/kpc2000/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/staging/kpc2000/Kconfig +0
-0drivers/staging/kpc2000/Kconfig line 10
Quoted 8 lines
drivers/staging/kpc2000/Kconfig +2
-0@@ -3,6 +3,8 @@ config KPC2000 bool "Daktronics KPC Device support" depends on PCI + select MFD_CORE + select UIO help Select this if you wish to use the Daktronics KPC PCI devicesThis is already in linux-next (in a different form), are you sure you are working against the latest kernel tree?
Quoted 3 lines
thanks,
greg k-h
It's based on your staging tree. I think that I have to go back and read about next trees again, because I thought it took longer time for things to get from staging-next to linux-next.
Anyway, neither the MFD_CORE nor the typo fix is in linux-next so I guess that I could just rebase this on linux-next and re-send as v2. I'm not sure if MFD_CORE should be "depends on" or "select" though...
- Simon
Re: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000
Quoted 13 lines · Simon Sandström
Quoted 7 lines · Greg KH
This is already in linux-next (in a different form), are you sure you are working against the latest kernel tree?
thanks,
greg k-h
It's based on your staging tree. I think that I have to go back and read about next trees again, because I thought it took longer time for things to get from staging-next to linux-next.
Quoted 6 lines
Anyway, neither the
MFD_COREnor the typo fix is in linux-next so I guess that I could just rebase this on linux-next and re-send as v2. I'm not sure ifMFD_COREshould be "depends on" or "select" though...- Simon
Oh, it must be "select MFD_CORE" because there is no prompt for MFD_CORE? Should I just rebase it on linux-next and re-send as v2 then?
- Simon
Greg KH
maintainerRe: [PATCH 2/2] staging: kpc2000: add missing dependencies for kpc2000
Quoted 19 lines · Simon Sandström
Quoted 18 lines · Simon Sandström
Quoted 7 lines · Greg KH
This is already in linux-next (in a different form), are you sure you are working against the latest kernel tree?
thanks,
greg k-h
It's based on your staging tree. I think that I have to go back and read about next trees again, because I thought it took longer time for things to get from staging-next to linux-next.
Anyway, neither the
MFD_COREnor the typo fix is in linux-next so I guess that I could just rebase this on linux-next and re-send as v2. I'm not sure ifMFD_COREshould be "depends on" or "select" though...
Quoted 4 lines
Quoted 1 line
- Simon
Oh, it must be "select
MFD_CORE" because there is no prompt forMFD_CORE? Should I just rebase it on linux-next and re-send as v2 then?
Yes please.