Skip to contentSkip to conversation

spi: gpio: fix warning PTR_ERR_OR_ZERO can be used

PATCH New Hariprasad Kelam 1 participant 1 message May 25, 2019 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: gpio: fix warning PTR_ERR_OR_ZERO can be used

fix below warning reported by coccicheck

./drivers/spi/spi-gpio.c:302:1-3: WARNING: PTR_ERR_OR_ZERO can be used

---
 drivers/spi/spi-gpio.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/spi/spi-gpio.c +1 -3
index 487ee55..8c5b98a 100644
@@ -299,10 +299,8 @@ static int spi_gpio_request(struct device *dev, struct spi_gpio *spi_gpio)
 		return PTR_ERR(spi_gpio->miso);
 
 	spi_gpio->sck = devm_gpiod_get(dev, "sck", GPIOD_OUT_LOW);
-	if (IS_ERR(spi_gpio->sck))
-		return PTR_ERR(spi_gpio->sck);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(spi_gpio->sck);
 }
 
 #ifdef CONFIG_OF
Signature · 1 line
2.7.4