Skip to contentSkip to conversation

ARM: dts: sun8i: a711: Change LRADC node names to avoid warnings

PATCH Applied Maxime Ripard 1 participant 2 messages May 25, 2019 – May 29, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: sun8i: a711: Change LRADC node names to avoid warnings

One of the usage of the LRADC is to implement buttons. The bindings define that we should have one subnode per button, with their associated voltage as a property.

However, there was no reg property but we still used the voltage associated to the button as the unit-address, which eventually generated warnings in DTC.

Rename the node names to avoid those warnings.

---
 arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts +2 -2
index 66d078053d5f..568b90ece342 100644
@@ -224,14 +224,14 @@
 	vref-supply = <&reg_aldo2>;
 	status = "okay";
 
-	button@210 {
+	button-210 {
 		label = "Volume Up";
 		linux,code = <KEY_VOLUMEUP>;
 		channel = <0>;
 		voltage = <210000>;
 	};
 
-	button@410 {
+	button-410 {
 		label = "Volume Down";
 		linux,code = <KEY_VOLUMEDOWN>;
 		channel = <0>;
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author Applied
#1 lore raw
Quoted 11 lines · Maxime Ripard

One of the usage of the LRADC is to implement buttons. The bindings define that we should have one subnode per button, with their associated voltage as a property.

However, there was no reg property but we still used the voltage associated to the button as the unit-address, which eventually generated warnings in DTC.

Rename the node names to avoid those warnings.

Applied.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel