Skip to contentSkip to conversation

ARM: dts: sunxi: h3/h5: Fix GPIO regulator state array

PATCH Applied Maxime Ripard 1 participant 2 messages May 25, 2019 – May 29, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: sunxi: h3/h5: Fix GPIO regulator state array

Even though it translates to the same thing down to the binary level, we should have an array of 2 number cells to describe each voltage state, which in turns create a validation warning.

Let's fix this.

---
 arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts           | 3 +--
 arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts              | 3 +--
 arch/arm/boot/dts/sun8i-h3-orangepi-one.dts                    | 3 +--
 arch/arm/boot/dts/sunxi-bananapi-m2-plus-v1.2.dtsi             | 3 +--
 .../boot/dts/allwinner/sun50i-h5-emlid-neutis-n5-devboard.dts  | 3 +--
 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 3 +--
 6 files changed, 6 insertions(+), 12 deletions(-)
arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts +1 -2
index 78a37a47185a..d277d043031b 100644
@@ -59,8 +59,7 @@
 		gpios = <&r_pio 0 1 GPIO_ACTIVE_HIGH>; /* PL1 */
 		enable-active-high;
 		gpios-states = <0x1>;
-		states = <1100000 0x0
-			  1300000 0x1>;
+		states = <1100000 0>, <1300000 1>;
 	};
 
 	wifi_pwrseq: wifi_pwrseq {
arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts +1 -2
index 4970eda2877e..f19ed981da9d 100644
@@ -102,8 +102,7 @@
 		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
 		enable-active-high;
 		gpios-states = <1>;
-		states = <1100000 0
-			  1300000 1>;
+		states = <1100000 0>, <1300000 1>;
 	};
 
 	wifi_pwrseq: wifi_pwrseq {
arch/arm/boot/dts/sun8i-h3-orangepi-one.dts +1 -2
index 840849169bed..4759ba3f2986 100644
@@ -109,8 +109,7 @@
 		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
 		enable-active-high;
 		gpios-states = <0x1>;
-		states = <1100000 0x0
-			  1300000 0x1>;
+		states = <1100000 0>, <1300000 1>;
 	};
 };
 
arch/arm/boot/dts/sunxi-bananapi-m2-plus-v1.2.dtsi +1 -2
index 53edd1faee99..22466afd38a3 100644
@@ -21,8 +21,7 @@
 		regulator-ramp-delay = <50>; /* 4ms */
 		gpios = <&r_pio 0 1 GPIO_ACTIVE_HIGH>; /* PL1 */
 		gpios-states = <0x1>;
-		states = <1100000 0x0
-			  1300000 0x1>;
+		states = <1100000 0>, <1300000 1>;
 	};
 };
 
arch/arm64/boot/dts/allwinner/sun50i-h5-emlid-neutis-n5-devboard.dts +1 -2
index 62409afbaf06..c924090331d0 100644
@@ -55,8 +55,7 @@
 		regulator-ramp-delay = <50>; /* 4ms */
 		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
 		gpios-states = <0x1>;
-		states = <1100000 0x0
-			  1300000 0x1>;
+		states = <1100000 0>, <1300000 1>;
 	};
 };
 
arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts +1 -2
index 9887948d5c86..1c7dde84e54d 100644
@@ -104,8 +104,7 @@
 		regulator-ramp-delay = <50>; /* 4ms */
 		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
 		gpios-states = <0x1>;
-		states = <1100000 0x0
-			  1300000 0x1>;
+		states = <1100000 0>, <1300000 1>;
 	};
 
 	wifi_pwrseq: wifi_pwrseq {
Signature · 7 lines
2.21.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author Applied
#1 lore raw
Quoted 7 lines · Maxime Ripard

Even though it translates to the same thing down to the binary level, we should have an array of 2 number cells to describe each voltage state, which in turns create a validation warning.

Let's fix this.

Applied

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel