Skip to contentSkip to conversation

drm/bridge: analogix_dp: possible condition with no effect (if == else)

PATCH In review Hariprasad Kelam 2 participants 2 messages May 25, 2019 – Jun 13, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: analogix_dp: possible condition with no effect (if == else)

fix below warning reported by coccicheck

./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
possible condition with no effect (if == else)

---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +0 -2
index 257d69b..cfcd159 100644
@@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
 		video->color_space = COLOR_YCBCR444;
 	else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
 		video->color_space = COLOR_YCBCR422;
-	else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
-		video->color_space = COLOR_RGB;
 	else
 		video->color_space = COLOR_RGB;
 
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Hariprasad Kelam

fix below warning reported by coccicheck

./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
possible condition with no effect (if == else)

Mixed feelings about it, but:

I will queue it to drm-misc-next.
 --
Regards
Andrzej

Quoted 9 lines
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +0 -0
index 257d69b..cfcd159 100644

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge, · line 1416

Quoted 8 lines
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +0 -2
@@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
 		video->color_space = COLOR_YCBCR444;
 	else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
 		video->color_space = COLOR_YCBCR422;
-	else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
-		video->color_space = COLOR_RGB;
 	else
 		video->color_space = COLOR_RGB;
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel