package/iputils: fix build with nettle
PATCH 1/1 package/iputils: fix build with nettle
Fixes:
- http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684
--- ...-ninfod_name.c-fix-build-with-nettle.patch | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch
package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch new file +38 -0
@@ -0,0 +1,38 @@ +From f209ebb91e65980bcdddce8cc12b00ec11623f76 Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Tue, 21 May 2019 19:14:18 +0200 +Subject: [PATCH] ninfod/ninfod_name.c: fix build with nettle + +Build of ninfod with nettle fails on: +/home/test/autobuild/run/instance-1/output/host/bin/mips64el-linux-gcc -o ninfod/ninfod 'ninfod/0cb6efe@@ninfod at exe/ni_ifaddrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_addrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_core.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-O1 -Wl,--start-group libcommon.a -lcap /home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib/libnettle.so -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/..:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib' -Wl,-rpath-link,/home/test/autobuild/run/instance-1/output/build/iputils-s20190515/build/:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib +ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o: In function `init_nodeinfo_nodename': +ninfod_name.c:(.text+0x378): undefined reference to `MD5_Init' + +This error is raised because MD5_Init is not defined by nettle. +To fix this error, include iputils_md5dig.h if USE_NETTLE is defined. + +Fixes: + - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: https://github.com/iputils/iputils/pull/181] +--- + ninfod/ninfod_name.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/ninfod/ninfod_name.c b/ninfod/ninfod_name.c +index daf606d..525c93d 100644 +--- a/ninfod/ninfod_name.c ++++ b/ninfod/ninfod_name.c +@@ -95,7 +95,7 @@ + + #include <arpa/inet.h> + +-#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API) ++#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API) || defined(USE_NETTLE) + # include "iputils_md5dig.h" + #elif defined(HAVE_GNUTLS_OPENSSL_H) + # include <gnutls/openssl.h> +-- +2.20.1 +
Signature · 1 line
2.20.1
PATCH 1/1 package/iputils: fix build with nettle
Hi Fabrice,
Quoted 4 lines
Fixes:
- http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684Signed-off-by Fabrice Fontaine <[email protected]>
Thanks for your fix!
...
package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch line 18
Quoted 5 lines
package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch new file +5
-0+Fixes: + - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: https://github.com/iputils/iputils/pull/181]
Actually merged as f209ebb ("ninfod/ninfod_name.c: fix build with nettle") Upstream status: f209ebb91e65980bcdddce8cc12b00ec11623f76
Kind regards,
Petr
PATCH 1/1 package/iputils: fix build with nettle
In reply to Fabrice FontaineHi,
Quoted 2 lines
Fixes:
- http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684
FYI this fixes failures for other archs (I guess incomplete list):
riscv64 | iputils-s20190515 | http://autobuild.buildroot.net/results/f78ac0d3c9a679a584bd54ac7f908390f5a4087b xtensa | iputils-s20190515 | http://autobuild.buildroot.net/results/a15323897950f8166f2b14f235a36cd88387d5de
Kind regards,
Petr
PATCH 1/1 package/iputils: fix build with nettle
In reply to Fabrice FontaineHi Peter,
can you please merge this fix to next?
Thanks a lot.
Kind regards,
Petr
Quoted 53 lines
Fixes:
- http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684Signed-off-by Fabrice Fontaine <[email protected]>--- ...-ninfod_name.c-fix-build-with-nettle.patch | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patchpackage/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch new file +38
-0@@ -0,0 +1,38 @@ +From f209ebb91e65980bcdddce8cc12b00ec11623f76 Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Tue, 21 May 2019 19:14:18 +0200 +Subject: [PATCH] ninfod/ninfod_name.c: fix build with nettle + +Build of ninfod with nettle fails on: +/home/test/autobuild/run/instance-1/output/host/bin/mips64el-linux-gcc -o ninfod/ninfod 'ninfod/0cb6efe@@ninfod at exe/ni_ifaddrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_addrs.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_core.c.o' 'ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-O1 -Wl,--start-group libcommon.a -lcap /home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib/libnettle.so -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/..:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib' -Wl,-rpath-link,/home/test/autobuild/run/instance-1/output/build/iputils-s20190515/build/:/home/test/autobuild/run/instance-1/output/host/usr/bin/../mips64el-buildroot-linux-uclibc/sysroot/usr/lib +ninfod/0cb6efe@@ninfod at exe/ninfod_name.c.o: In function `init_nodeinfo_nodename': +ninfod_name.c:(.text+0x378): undefined reference to `MD5_Init' + +This error is raised because MD5_Init is not defined by nettle. +To fix this error, include iputils_md5dig.h if USE_NETTLE is defined. + +Fixes: + - http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: https://github.com/iputils/iputils/pull/181] +--- + ninfod/ninfod_name.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/ninfod/ninfod_name.c b/ninfod/ninfod_name.c +index daf606d..525c93d 100644 +--- a/ninfod/ninfod_name.c ++++ b/ninfod/ninfod_name.c +@@ -95,7 +95,7 @@ + + #include <arpa/inet.h> + +-#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API) ++#if defined(HAVE_GCRYPT_H) || defined(USE_KERNEL_CRYPTO_API) || defined(USE_NETTLE) + # include "iputils_md5dig.h" + #elif defined(HAVE_GNUTLS_OPENSSL_H) + # include <gnutls/openssl.h> +-- +2.20.1 +
Thomas Petazzoni
AppliedPATCH 1/1 package/iputils: fix build with nettle
In reply to Fabrice FontaineQuoted 8 lines · On Tue, 21 May 2019 19:23:25 +0200 Fabrice Fontaine…
Fixes:
- http://autobuild.buildroot.org/results/e86555090e27b631ba35214ef100aa9331844684Signed-off-by Fabrice Fontaine <[email protected]>--- ...-ninfod_name.c-fix-build-with-nettle.patch | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 package/iputils/0001-ninfod-ninfod_name.c-fix-build-with-nettle.patch
Applied to next, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com