Skip to contentSkip to conversation

mfgtools: bump version to 1.2.91

PATCH Superseded Gary Bisson 3 participants 4 messages May 25, 2019 – May 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mfgtools: bump version to 1.2.91

NXP deprecated the old mfgtools code, also called mfgtools v2 although the releases were named v0.xx.

It has been replaced by the Universal Update Utility (uuu), also called mfgtools v3 although the releases are named v1.x.yy.

This new tool actually resides in the same repository in the master branch whereas the old one is now in a 'linux' branch.

Since the old tool has issues building lately, let's switch to the new one. Note that uuu seems to be cleaner, supports much more features (i.MX8/8M/8QXP boot, fastboot etc..) and has a better documentation:
https://github.com/NXPmicro/mfgtools/wiki

---
Changelog v2:
- update Config.in help text to mention tool version
- update project URL (codeauroraforum doesn't apply to NXP repositories now that the Qualcomm merger isn't happening)
- add README.md to license files (like before)

---
 package/mfgtools/Config.in.host | 10 ++++----
 package/mfgtools/mfgtools.hash  |  6 ++---
 package/mfgtools/mfgtools.mk    | 31 ++++-------------------
 package/mfgtools/readme.txt     | 45 +++++----------------------------
 4 files changed, 20 insertions(+), 72 deletions(-)
package/mfgtools/Config.in.host +5 -5
index 4bbdde38e2..dd4f037b6c 100644
@@ -6,9 +6,9 @@ config BR2_PACKAGE_HOST_MFGTOOLS
 	depends on BR2_arm
 	depends on BR2_HOST_GCC_AT_LEAST_4_8 # needs C++11
 	help
-	  This package contains the Freescale manufacturing tool.
-	  It is designed to program firmware to i.MX boards during
-	  production. The communication is done over USB using the
-	  Freescale UTP protocol.
+	  This package contains the NXP Universal Update Utility
+	  (MFGTools v3) for i.MX boards.
+	  It allows to load a bootloader/kernel/ramdisk over USB SDP
+	  protocol as well as sending commands to flash a storage.
 
-	  https://github.com/codeauroraforum/mfgtools
+	  https://github.com/NXPmicro/mfgtools
package/mfgtools/mfgtools.hash +3 -3
index 4932a80dba..c5ba57ec72 100644
@@ -1,4 +1,4 @@
 # locally computed
-sha256  055d71227d18883d6e8bc9e854c076015f9a7749820a94272e19071bf0b25c89  mfgtools-v0.02.tar.gz
-sha256  2655559a6bb1179eae514f5c7166f4ede4f2453efa9cf4dc3c045cab5d57dede  LICENSE
-sha256  0963b6e5086bf454265b0f57821a02b681d1211e40ad74c310231cb4d94815c9  README.txt
+sha256  378caa930fdc1b06d49abf26811827f12103d995438b91302a7c6e34368419f9  mfgtools-1.2.91.tar.gz
+sha256  cc8d47f7b9260f6669ecd41c24554c552f17581d81ee8fc602c6d23edb8bf495  LICENSE
+sha256  01a4b15843de543b01fb0600eba02248273182bcf11da60d2d7736440f0995b6  README.md
package/mfgtools/mfgtools.mk +5 -26
index e4663a8af9..bfeb33f4e0 100644
@@ -4,31 +4,10 @@
 #
 ################################################################################
 
-MFGTOOLS_VERSION = v0.02
-MFGTOOLS_SITE = $(call github,codeauroraforum,mfgtools,$(MFGTOOLS_VERSION))
-MFGTOOLS_SUBDIR = MfgToolLib
-MFGTOOLS_LICENSE = BSD-3-Clause or CPOL
-MFGTOOLS_LICENSE_FILES = LICENSE README.txt
-HOST_MFGTOOLS_DEPENDENCIES = host-libusb
-
-HOST_MFGTOOLS_CFLAGS = \
-	$(HOST_CFLAGS) $(HOST_LDFLAGS) -std=c++11 -lpthread \
-	-L$(@D)/MfgToolLib -lMfgToolLib -I$(@D)/MfgToolLib \
-	-lusb-1.0 -I$(HOST_DIR)/include/libusb-1.0 \
-	-fpermissive -Wno-write-strings
-
-define HOST_MFGTOOLS_CLI_BUILD
-	$(HOST_CONFIGURE_OPTS) $(MAKE) CC="$(HOSTCXX)" \
-		CFLAGS="$(HOST_MFGTOOLS_CFLAGS)" -C $(@D)/TestPrgm
-endef
-
-HOST_MFGTOOLS_POST_BUILD_HOOKS += HOST_MFGTOOLS_CLI_BUILD
-
-define HOST_MFGTOOLS_INSTALL_CMDS
-	$(INSTALL) -D -m 755 $(@D)/MfgToolLib/libMfgToolLib.so \
-		$(HOST_DIR)/lib/libMfgToolLib.so
-	$(INSTALL) -D -m 755 $(@D)/TestPrgm/mfgtoolcli \
-		$(HOST_DIR)/bin/mfgtoolcli
-endef
+MFGTOOLS_VERSION = 1.2.91
+MFGTOOLS_SITE = $(call github,NXPmicro,mfgtools,uuu_$(MFGTOOLS_VERSION))
+MFGTOOLS_LICENSE = BSD-3-Clause
+MFGTOOLS_LICENSE_FILES = LICENSE README.md
+HOST_MFGTOOLS_DEPENDENCIES = host-libusb host-bzip2 host-libzip host-zlib
 
 $(eval $(host-cmake-package))
package/mfgtools/readme.txt +7 -38

57 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 mfgtools: bump version to 1.2.91

Hello Gary,

Quoted 9 lines · On Sat, 25 May 2019 16:18:00 +0200 Gary Bisson <[email protected]> wrote:

NXP deprecated the old mfgtools code, also called mfgtools v2 although the releases were named v0.xx.

It has been replaced by the Universal Update Utility (uuu), also called mfgtools v3 although the releases are named v1.x.yy.

This new tool actually resides in the same repository in the master branch whereas the old one is now in a 'linux' branch.

Quoted 6 lines

Since the old tool has issues building lately, let's switch to the new one. Note that uuu seems to be cleaner, supports much more features (i.MX8/8M/8QXP boot, fastboot etc..) and has a better documentation:
https://github.com/NXPmicro/mfgtools/wiki

Thanks for this patch. Unfortunately, it fails to build on my system, with:

[100%] Linking CXX executable uuu
/usr/bin/ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status

This is because it is passing -static-libstdc++ at link time, for some odd reason.

Do you know why they are doing:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++ -static-libgcc")

in uuu/CMakeLists.txt. This seems pretty bogus for something that should be just a regular user-space program.

Could you have a look into this ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 mfgtools: bump version to 1.2.91

Hi Thomas,

Quoted 31 lines · Thomas Petazzoni

Hello Gary,

Quoted 9 lines · On Sat, 25 May 2019 16:18:00 +0200 Gary Bisson <[email protected]> wrote:

NXP deprecated the old mfgtools code, also called mfgtools v2 although the releases were named v0.xx.

It has been replaced by the Universal Update Utility (uuu), also called mfgtools v3 although the releases are named v1.x.yy.

This new tool actually resides in the same repository in the master branch whereas the old one is now in a 'linux' branch.

Quoted 6 lines

Since the old tool has issues building lately, let's switch to the new one. Note that uuu seems to be cleaner, supports much more features (i.MX8/8M/8QXP boot, fastboot etc..) and has a better documentation:
https://github.com/NXPmicro/mfgtools/wiki

Thanks for this patch. Unfortunately, it fails to build on my system, with:

[100%] Linking CXX executable uuu
/usr/bin/ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status

This is because it is passing -static-libstdc++ at link time, for some odd reason.

Quoted 8 lines

Do you know why they are doing:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++ -static-libgcc")

in uuu/CMakeLists.txt. This seems pretty bogus for something that should be just a regular user-space program.

Could you have a look into this ?

My understanding, looking at the git history and other comments, is that this tool is meant to be build for Windows/Linux/Mac OSes. And apparently Windows only supports to build statically.

You can see that someone removed that line for the 'APPLE' build, so I've offered a pull-request to NXP to only do so for WIN32 instead [1].

However, while writing that PR, I linked to this thread archive and realized Joerg is already offering a patch for mfgtools [2].

Adding Joerg to this thread then, I'll let you guys know if the PR is accepted. @Joerg, let me know if you want to do the next patch version, no need to do the same work twice ;)

BTW, I saw that you made a change for the git commit version, I'd suggest sending a PR for that too instead of patching it in Buildroot.

Regards,
Gary

[1] https://github.com/NXPmicro/mfgtools/pull/105
[2] http://lists.busybox.net/pipermail/buildroot/2019-May/249362.html

#3 lore raw

PATCH v2 1/1 mfgtools: bump version to 1.2.91

Hi Gary,

Quoted 50 lines · Gary Bisson

Hi Thomas,

Quoted 31 lines · Thomas Petazzoni

Hello Gary,

Quoted 9 lines · On Sat, 25 May 2019 16:18:00 +0200 Gary Bisson <[email protected]> wrote:

NXP deprecated the old mfgtools code, also called mfgtools v2 although the releases were named v0.xx.

It has been replaced by the Universal Update Utility (uuu), also called mfgtools v3 although the releases are named v1.x.yy.

This new tool actually resides in the same repository in the master branch whereas the old one is now in a 'linux' branch.

Quoted 6 lines

Since the old tool has issues building lately, let's switch to the new one. Note that uuu seems to be cleaner, supports much more features (i.MX8/8M/8QXP boot, fastboot etc..) and has a better documentation:
https://github.com/NXPmicro/mfgtools/wiki

Thanks for this patch. Unfortunately, it fails to build on my system, with:

[100%] Linking CXX executable uuu
/usr/bin/ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status

This is because it is passing -static-libstdc++ at link time, for some odd reason.

Quoted 8 lines

Do you know why they are doing:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++ -static-libgcc")

in uuu/CMakeLists.txt. This seems pretty bogus for something that should be just a regular user-space program.

Could you have a look into this ?

My understanding, looking at the git history and other comments, is that this tool is meant to be build for Windows/Linux/Mac OSes. And apparently Windows only supports to build statically.

You can see that someone removed that line for the 'APPLE' build, so I've offered a pull-request to NXP to only do so for WIN32 instead [1].

Quoted 6 lines

However, while writing that PR, I linked to this thread archive and realized Joerg is already offering a patch for mfgtools [2].

Adding Joerg to this thread then, I'll let you guys know if the PR is accepted. @Joerg, let me know if you want to do the next patch version, no need to do the same work twice ;)

I'm fine if you take over and integrate the overwrite gen_ver.sh hook as it solves a runtime issue.

Quoted 2 lines

BTW, I saw that you made a change for the git commit version, I'd suggest sending a PR for that too instead of patching it in Buildroot.

This change is not upstreamable. There has been a discussion upstream about missing gitversion.h in source tarballs:
https://github.com/NXPmicro/mfgtools/issues/77

The conclusion was, that upstream does not support building uuu from a tarball. Therefore, the hook to overwrite the git version logic.

Quoted 5 lines

Regards,
Gary

[1] https://github.com/NXPmicro/mfgtools/pull/105
[2] http://lists.busybox.net/pipermail/buildroot/2019-May/249362.html

Best regards
J?rg Krause