package/supertux: fix debug build on uclibc/musl
PATCH 1/1 package/supertux: fix debug build on uclibc/musl
Always set CMAKE_BUILD_TYPE to Release otherwise supertux will be built with -pg since:
https://github.com/SuperTux/supertux/commit/afd5f1b33c110104a7f286d6d7854157919a0a52
This will result in the following build failure on uclibc or musl:
[ 77%] Linking C executable sq_staticCMakeFiles/sq_static.dir/sq.c.o: In function `quit':/home/buildroot/autobuild/instance-3/output/build/supertux-0.6.0/external/squirrel/sq/sq.c:42: undefined reference to `__gnu_mcount_nc'
Fixes:
- http://autobuild.buildroot.org/results/b0b2e25af198d01713d1e2bcf38c77ae8ffbd7de
--- package/supertux/supertux.mk | 2 ++ 1 file changed, 2 insertions(+)
package/supertux/supertux.mk +2 -0
@@ -18,6 +18,7 @@ SUPERTUX_LICENSE_FILES = LICENSE.txt data/AUTHORS SUPERTUX_DEPENDENCIES = host-pkgconf boost freetype libcurl libgl libglew libglu \ libogg libpng libvorbis openal physfs sdl2 sdl2_image +# CMAKE_BUILD_TYPE=Release: disable profiling code (-pg) # ENABLE_BOOST_STATIC_LIBS=OFF: use boost shared libraries since supertux # depends on !BR2_STATIC_LIBS and boost provide only shared libraries with # BR2_SHARED_LIBS.
@@ -28,6 +29,7 @@ SUPERTUX_DEPENDENCIES = host-pkgconf boost freetype libcurl libgl libglew libglu # in physfs.h (CHECK_SYMBOL_EXISTS) doesn't work. # ENABLE_OPENGLES2=OFF: Disable opengles2 for now. SUPERTUX_CONF_OPTS += \ + -DCMAKE_BUILD_TYPE=Release \ -DENABLE_BOOST_STATIC_LIBS=OFF \ -DBUILD_DOCUMENTATION=OFF \ -DENABLE_OPENGL=ON \
Signature · 1 line
2.20.1
PATCH 1/1 package/supertux: fix debug build on uclibc/musl
Hello,
+Arnout in Cc.
Quoted 9 lines · On Sun, 26 May 2019 21:18:14 +0200 Fabrice Fontaine…
Always set
CMAKE_BUILD_TYPEto Release otherwise supertux will be built with -pg since:
https://github.com/SuperTux/supertux/commit/afd5f1b33c110104a7f286d6d7854157919a0a52This will result in the following build failure on uclibc or musl:
[ 77%] Linking C executablesq_staticCMakeFiles/sq_static.dir/sq.c.o: In function `quit':/home/buildroot/autobuild/instance-3/output/build/supertux-0.6.0/external/squirrel/sq/sq.c:42: undefined reference to `__gnu_mcount_nc'
Quoted 4 lines
Fixes:
- http://autobuild.buildroot.org/results/b0b2e25af198d01713d1e2bcf38c77ae8ffbd7deSigned-off-by Fabrice Fontaine <[email protected]>
So, it really seems like we want to stop using -DCMAKE_BUILD_TYPE=Debug when BR2_ENABLE_DEBUG=y, like Arnout suggested in another thread. Packages are adding random flags when -DCMAKE_BUILD_TYPE=Debug, it is not really usable, as BR2_ENABLE_DEBUG should only mean "add -g to CFLAGS".
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/supertux: fix debug build on uclibc/musl
Quoted 16 lines · Thomas Petazzoni
Hello,
+Arnout in Cc.
Quoted 9 lines · On Sun, 26 May 2019 21:18:14 +0200 Fabrice Fontaine…
Always set
CMAKE_BUILD_TYPEto Release otherwise supertux will be built with -pg since:
https://github.com/SuperTux/supertux/commit/afd5f1b33c110104a7f286d6d7854157919a0a52This will result in the following build failure on uclibc or musl:
[ 77%] Linking C executablesq_staticCMakeFiles/sq_static.dir/sq.c.o: In function `quit':/home/buildroot/autobuild/instance-3/output/build/supertux-0.6.0/external/squirrel/sq/sq.c:42: undefined reference to `__gnu_mcount_nc'
Quoted 7 lines
Quoted 4 lines
Fixes:
- http://autobuild.buildroot.org/results/b0b2e25af198d01713d1e2bcf38c77ae8ffbd7deSigned-off-by Fabrice Fontaine <[email protected]>So, it really seems like we want to stop using -DCMAKE_BUILD_TYPE=Debug when BR2_ENABLE_DEBUG=y, like Arnout suggested in another thread.
I guess that means you agree with my analysis then? :-)
Note, however, that the current patch can go to master, while the change of
build type is definitely *not* for master...
[Or maybe I misread your statement, I thought you meant that Fabrice should
drop this patch and instead globally set build type to Release.]
Regards,
Arnout
Quoted 6 lines
Packages are adding random flags when -DCMAKE_BUILD_TYPE=Debug, it is not really usable, as
BR2_ENABLE_DEBUGshould only mean "add -g to CFLAGS".Thomas
PATCH 1/1 package/supertux: fix debug build on uclibc/musl
In reply to Fabrice FontaineQuoted 9 lines · Fabrice Fontaine
Always set
CMAKE_BUILD_TYPEto Release otherwise supertux will be built with -pg since:
https://github.com/SuperTux/supertux/commit/afd5f1b33c110104a7f286d6d7854157919a0a52This will result in the following build failure on uclibc or musl:
[ 77%] Linking C executablesq_staticCMakeFiles/sq_static.dir/sq.c.o: In function `quit':/home/buildroot/autobuild/instance-3/output/build/supertux-0.6.0/external/squirrel/sq/sq.c:42: undefined reference to `__gnu_mcount_nc'
Quoted 4 lines
Fixes:
- http://autobuild.buildroot.org/results/b0b2e25af198d01713d1e2bcf38c77ae8ffbd7deSigned-off-by Fabrice Fontaine <[email protected]>
As predicted: Applied to master, thanks.
Regards,
Arnout
Quoted 25 lines
--- package/supertux/supertux.mk | 2 ++ 1 file changed, 2 insertions(+)package/supertux/supertux.mk +2
-0@@ -18,6 +18,7 @@ SUPERTUX_LICENSE_FILES = LICENSE.txt data/AUTHORS SUPERTUX_DEPENDENCIES = host-pkgconf boost freetype libcurl libgl libglew libglu \ libogg libpng libvorbis openal physfs sdl2 sdl2_image +# CMAKE_BUILD_TYPE=Release: disable profiling code (-pg) # ENABLE_BOOST_STATIC_LIBS=OFF: use boost shared libraries since supertux # depends on !BR2_STATIC_LIBS and boost provide only shared libraries with # BR2_SHARED_LIBS.@@ -28,6 +29,7 @@ SUPERTUX_DEPENDENCIES = host-pkgconf boost freetype libcurl libgl libglew libglu # in physfs.h (CHECK_SYMBOL_EXISTS) doesn't work. # ENABLE_OPENGLES2=OFF: Disable opengles2 for now. SUPERTUX_CONF_OPTS += \ + -DCMAKE_BUILD_TYPE=Release \ -DENABLE_BOOST_STATIC_LIBS=OFF \ -DBUILD_DOCUMENTATION=OFF \ -DENABLE_OPENGL=ON \
PATCH 1/1 package/supertux: fix debug build on uclibc/musl
In reply to Fabrice FontaineQuoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Always set
CMAKE_BUILD_TYPEto Release otherwise supertux will be built with -pg since:
https://github.com/SuperTux/supertux/commit/afd5f1b33c110104a7f286d6d7854157919a0a52This will result in the following build failure on uclibc or musl:
[ 77%] Linking C executablesq_staticCMakeFiles/sq_static.dir/sq.c.o: In function `quit':/home/buildroot/autobuild/instance-3/output/build/supertux-0.6.0/external/squirrel/sq/sq.c:42: undefined reference to `__gnu_mcount_nc'
Quoted 4 lines
Fixes:
- http://autobuild.buildroot.org/results/b0b2e25af198d01713d1e2bcf38c77ae8ffbd7deSigned-off-by Fabrice Fontaine <[email protected]>
Committed to 2019.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard