Skip to contentSkip to conversation

net: stmmac: Do not output error on deferred probe

PATCH Applied Thierry Reding 3 participants 3 messages May 27, 2019 – May 28, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: stmmac: Do not output error on deferred probe

From: Thierry Reding <[email protected]>

If the subdriver defers probe, do not show an error message. It's perfectly fine for this error to occur since the driver will get another chance to probe after some time and will usually succeed after all of the resources that it requires have been registered.

---
 drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c +5 -1
index 3256e5cbad27..5bc224834c77 100644
@@ -455,7 +455,11 @@ static int dwc_eth_dwmac_probe(struct platform_device *pdev)
 	priv = data->probe(pdev, plat_dat, &stmmac_res);
 	if (IS_ERR(priv)) {
 		ret = PTR_ERR(priv);
-		dev_err(&pdev->dev, "failed to probe subdriver: %d\n", ret);
+
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "failed to probe subdriver: %d\n",
+				ret);
+
 		goto remove_config;
 	}
 
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

If the subdriver defers probe, do not show an error message. It's perfectly fine for this error to occur since the driver will get another chance to probe after some time and will usually succeed after all of the resources that it requires have been registered.

Andrew

maintainer Applied
#2 lore raw
In reply to Thierry Reding

From: Thierry Reding <[email protected]>
Date: Mon, 27 May 2019 12:52:51 +0200

Quoted 8 lines

From: Thierry Reding <[email protected]>

If the subdriver defers probe, do not show an error message. It's perfectly fine for this error to occur since the driver will get another chance to probe after some time and will usually succeed after all of the resources that it requires have been registered.

Applied.