drivers: staging: speakup: serialio: fix warning linux/serial.h is included more than once
PATCH 1/1 drivers: staging: speakup: serialio: fix warning linux/serial.h is included more than once
fix below warning reported by includecheck
./drivers/staging/speakup/serialio.h: linux/serial.h is included more than once.
--- drivers/staging/speakup/serialio.h | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/speakup/serialio.h +0 -3
@@ -4,9 +4,6 @@#include <linux/serial.h> /* for rs_table, serial constants */ #include <linux/serial_reg.h> /* for more serial constants */ -#ifndef __sparc__ -#include <linux/serial.h> -#endif #include <linux/serial_core.h> #include "spk_priv.h"
Signature · 1 line
2.7.4
Hariprasad Kelam, le dim. 26 mai 2019 12:43:22 +0530, a ecrit:
Quoted 6 lines
fix below warning reported by includecheck
./drivers/staging/speakup/serialio.h:linux/serial.his included more than once.Signed-off-by Hariprasad Kelam <[email protected]>
That was indeed the result of f79b0d9c223ca09cefffc72304a7bcbc401a1c6f ("staging: speakup: Fixed warning <linux/serial.h> instead of <asm/serial.h>") which didn't take care of the inclusion above. I believe <linux/serial.h> only is fine, the important part is in drivers/staging/speakup/serialio.c which really needs to include asm/serial.h to get SERIAL_PORT_DFNS
Quoted 21 lines
--- drivers/staging/speakup/serialio.h | 3 --- 1 file changed, 3 deletions(-)drivers/staging/speakup/serialio.h +0
-3@@ -4,9 +4,6 @@#include <linux/serial.h> /* for rs_table, serial constants */ #include <linux/serial_reg.h> /* for more serial constants */ -#ifndef __sparc__ -#include <linux/serial.h> -#endif #include <linux/serial_core.h> #include "spk_priv.h" Signature · 1 line
2.7.4
Signature · 1 line
Samuel
Quoted 1 line
No manual is ever necessary.
May I politely interject here: BULLSHIT. That's the biggest Apple lie of all! (Discussion in comp.os.linux.misc on the intuitiveness of interfaces.)