Skip to contentSkip to conversation

kbuild: tar-pkg: enable communication with jobserver

PATCH In review Trevor Bourget 2 participants 2 messages May 27, 2019 – May 28, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: tar-pkg: enable communication with jobserver

The buildtar script might want to invoke a make, so tell the parent make to pass the jobserver token pipe to the subcommand by prefixing the command with a +.

This addresses the issue seen here:

/bin/sh ../scripts/package/buildtar tar-pkg
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.

See https://www.gnu.org/software/make/manual/html_node/Job-Slots.html
for more information.

---
 scripts/package/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/Makefile +1 -1
index 27b42d5b6c4f..ca7f46b562a4 100644
@@ -104,7 +104,7 @@ clean-dirs += $(objtree)/snap/
 # ---------------------------------------------------------------------------
 tar%pkg: FORCE
 	$(MAKE) -f $(srctree)/Makefile
-	$(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@
+	+$(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@
 
 clean-dirs += $(objtree)/tar-install/
 
Signature · 1 line
2.22.0.rc1.257.g3120a18244-goog
#1 lore raw
Quoted 7 lines · Trevor Bourget

The buildtar script might want to invoke a make, so tell the parent make to pass the jobserver token pipe to the subcommand by prefixing the command with a +.

This addresses the issue seen here:

Quoted 8 lines

/bin/sh ../scripts/package/buildtar tar-pkg
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.

See https://www.gnu.org/software/make/manual/html_node/Job-Slots.html
for more information.

---

Applied to linux-kbuild/fixes. Thanks.

Quoted 19 lines
 scripts/package/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/Makefile +1 -2
index 27b42d5b6c4f..ca7f46b562a4 100644
@@ -104,7 +104,7 @@ clean-dirs += $(objtree)/snap/
 # ---------------------------------------------------------------------------
 tar%pkg: FORCE
        $(MAKE) -f $(srctree)/Makefile
-       $(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@
+       +$(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@
 
 clean-dirs += $(objtree)/tar-install/
 
--

2.22.0.rc1.257.g3120a18244-goog

Signature · 2 lines
Best Regards
Masahiro Yamada