Skip to contentSkip to conversation

powerpc/mm: Move some of the boot time info print to generic file

PATCH In review Aneesh Kumar K.V 2 participants 3 messages May 28, 2019 – May 30, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/mm: Move some of the boot time info print to generic file

With radix translation enabled we find in dmesg

hash-mmu: ppc64_pft_size = 0x0

 hash-mmu: kernel vmalloc start   = 0xc008000000000000
 hash-mmu: kernel IO start        = 0xc00a000000000000
 hash-mmu: kernel vmemmap start   = 0xc00c000000000000

This is because these pr_info calls are in hash_utils.c which has

#define pr_fmt(fmt) "hash-mmu: " fmt

The information printed in generic and hence move that to generic file

---
 arch/powerpc/kernel/setup-common.c    | 4 ++++
 arch/powerpc/mm/book3s64/hash_utils.c | 5 -----
 2 files changed, 4 insertions(+), 5 deletions(-)
arch/powerpc/kernel/setup-common.c +4 -0
index aad9f5df6ab6..a73a91f2c21f 100644
@@ -810,6 +810,10 @@ static __init void print_system_info(void)
 	pr_info("mmu_features      = 0x%08x\n", cur_cpu_spec->mmu_features);
 #ifdef CONFIG_PPC64
 	pr_info("firmware_features = 0x%016lx\n", powerpc_firmware_features);
+	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
+	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
+	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
+	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
 #endif
 
 	print_system_hash_info();
arch/powerpc/mm/book3s64/hash_utils.c +0 -5
index 919a861a8ec0..2f677914bfd2 100644
@@ -1950,11 +1950,6 @@ machine_device_initcall(pseries, hash64_debugfs);
 
 void __init print_system_hash_info(void)
 {
-	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
-
 	if (htab_hash_mask)
 		pr_info("htab_hash_mask    = 0x%lx\n", htab_hash_mask);
-	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
-	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
-	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
 }
Signature · 1 line
2.21.0
#1 lore raw

"Aneesh Kumar K.V" <[email protected]> a écrit :

Quoted 7 lines

With radix translation enabled we find in dmesg

hash-mmu: ppc64_pft_size = 0x0

 hash-mmu: kernel vmalloc start   = 0xc008000000000000
 hash-mmu: kernel IO start        = 0xc00a000000000000
 hash-mmu: kernel vmemmap start   = 0xc00c000000000000
Quoted 5 lines

This is because these pr_info calls are in hash_utils.c which has

#define pr_fmt(fmt) "hash-mmu: " fmt

The information printed in generic and hence move that to generic file

Some similarities with Nick's patch https://patchwork.ozlabs.org/patch/1100245/ ?

Christophe

Quoted 40 lines
---
 arch/powerpc/kernel/setup-common.c    | 4 ++++
 arch/powerpc/mm/book3s64/hash_utils.c | 5 -----
 2 files changed, 4 insertions(+), 5 deletions(-)
arch/powerpc/kernel/setup-common.c +4 -0
index aad9f5df6ab6..a73a91f2c21f 100644
@@ -810,6 +810,10 @@ static __init void print_system_info(void)
 	pr_info("mmu_features      = 0x%08x\n", cur_cpu_spec->mmu_features);
 #ifdef CONFIG_PPC64
 	pr_info("firmware_features = 0x%016lx\n", powerpc_firmware_features);
+	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
+	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
+	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
+	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
 #endif
 
 	print_system_hash_info();
arch/powerpc/mm/book3s64/hash_utils.c +0 -6
index 919a861a8ec0..2f677914bfd2 100644
@@ -1950,11 +1950,6 @@ machine_device_initcall(pseries, hash64_debugfs);
 
 void __init print_system_hash_info(void)
 {
-	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
-
 	if (htab_hash_mask)
 		pr_info("htab_hash_mask    = 0x%lx\n", htab_hash_mask);
-	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
-	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
-	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
 }
--

2.21.0

#2 lore raw
Quoted 9 lines · Christophe Leroy

"Aneesh Kumar K.V" <[email protected]> a écrit :

Quoted 7 lines

With radix translation enabled we find in dmesg

 hash-mmu: ppc64_pft_size    = 0x0
 hash-mmu: kernel vmalloc start   = 0xc008000000000000
 hash-mmu: kernel IO start        = 0xc00a000000000000
 hash-mmu: kernel vmemmap start   = 0xc00c000000000000

Quoted 9 lines
Quoted 5 lines

This is because these pr_info calls are in hash_utils.c which has

 #define pr_fmt(fmt) "hash-mmu: " fmt

The information printed in generic and hence move that to generic file

Some similarities with Nick's patch https://patchwork.ozlabs.org/patch/1100245/ ?

I missed that completely.

-aneesh