package/ascii-invaders: Add the game ascii-invaders
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
An ASCII-art game like Space Invaders using ncurses.
---
v2:
- I'm submitting the patch individually now, to ease the review
- Addressed Gilles' review feedback from v1
- Cleaned warnings from utils/check-package
- Checked with utils/test-pkg, added POST_EXTRACT_HOOK to fix a problem when linking the program statically
- Use $(call github, ...) helper to create the SITE variable
DEVELOPERS | 3 +++ package/Config.in | 1 + package/ascii-invaders/Config.in | 7 ++++++ package/ascii-invaders/ascii-invaders.hash | 5 ++++ package/ascii-invaders/ascii-invaders.mk | 28 ++++++++++++++++++++++ 5 files changed, 44 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mk
DEVELOPERS +3 -0
@@ -2166,6 +2166,9 @@ F: support/scripts/size-stats F: utils/size-stats-compare F: toolchain/ +N: Thomas Huth <[email protected]> +F: package/ascii-invaders/ + N: Thomas Petazzoni <[email protected]> F: arch/Config.in.arm F: boot/boot-wrapper-aarch64/
package/Config.in +1 -0
@@ -243,6 +243,7 @@ comment "Themes" endmenu menu "Games" + source "package/ascii-invaders/Config.in" source "package/chocolate-doom/Config.in" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in"
package/ascii-invaders/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_ASCII_INVADERS + bool "ascii_invaders" + select BR2_PACKAGE_NCURSES + help + An ASCII-art game like Space Invaders using ncurses. + + https://github.com/macdice/ascii-invaders
package/ascii-invaders/ascii-invaders.hash new file +5 -0
@@ -0,0 +1,5 @@ +# Locally calculated +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz + +# Hash for license file +sha512 1e455684996d7733b2f1ccd4606d034694d16ceff6ede6125d7f1537d20dabe05976cca4cef5cbf6c31352cbd62a515fd8e34a2ffb54dae1181c1116b24c6cf7 LICENSE
package/ascii-invaders/ascii-invaders.mk new file +28 -0
@@ -0,0 +1,28 @@ +################################################################################ +# +# ASCII-Invaders +# +################################################################################ + +ASCII_INVADERS_VERSION = v1.0.1 +ASCII_INVADERS_SOURCE = $(ASCII_INVADERS_VERSION).tar.gz +ASCII_INVADERS_SITE = $(call github,macdice,ascii-invaders,$(ASCII_INVADERS_VERSION)) +ASCII_INVADERS_DEPENDENCIES = ncurses +ASCII_INVADERS_LICENSE = GPL-2.0+ +ASCII_INVADERS_LICENSE_FILES = LICENSE + +# For compiling statically, libraries must be specified after the object file +define ASCII_INVADERS_POST_EXTRACT_FIXUP + sed -i 's/\$$(LIBS) invaders.o/invaders.o \$$(LIBS)/' $(@D)/Makefile +endef +ASCII_INVADERS_POST_EXTRACT_HOOKS += ASCII_INVADERS_POST_EXTRACT_FIXUP + +define ASCII_INVADERS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) +endef + +define ASCII_INVADERS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin/ascii_invaders +endef + +$(eval $(generic-package))
Signature · 1 line
2.17.2
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
Quoted 97 lines · Thomas Huth
An ASCII-art game like Space Invaders using ncurses.
Signed-off-by Thomas Huth <[email protected]>---
v2:
- I'm submitting the patch individually now, to ease the review
- Addressed Gilles' review feedback from v1
- Cleaned warnings from utils/check-package
- Checked with utils/test-pkg, addedPOST_EXTRACT_HOOKto fix a problem when linking the program statically
- Use $(call github, ...) helper to create the SITE variableDEVELOPERS | 3 +++ package/Config.in | 1 + package/ascii-invaders/Config.in | 7 ++++++ package/ascii-invaders/ascii-invaders.hash | 5 ++++ package/ascii-invaders/ascii-invaders.mk | 28 ++++++++++++++++++++++ 5 files changed, 44 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mkDEVELOPERS +3
-0@@ -2166,6 +2166,9 @@ F: support/scripts/size-stats F: utils/size-stats-compare F: toolchain/ +N: Thomas Huth <[email protected]> +F: package/ascii-invaders/ + N: Thomas Petazzoni <[email protected]> F: arch/Config.in.arm F: boot/boot-wrapper-aarch64/package/Config.in +1
-0@@ -243,6 +243,7 @@ comment "Themes" endmenu menu "Games" + source "package/ascii-invaders/Config.in" source "package/chocolate-doom/Config.in" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in"package/ascii-invaders/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_ASCII_INVADERS + bool "ascii_invaders" + select BR2_PACKAGE_NCURSES + help + An ASCII-art game like Space Invaders using ncurses. + + https://github.com/macdice/ascii-invaderspackage/ascii-invaders/ascii-invaders.hash new file +5
-0@@ -0,0 +1,5 @@ +# Locally calculated +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz + +# Hash for license file +sha512 1e455684996d7733b2f1ccd4606d034694d16ceff6ede6125d7f1537d20dabe05976cca4cef5cbf6c31352cbd62a515fd8e34a2ffb54dae1181c1116b24c6cf7 LICENSEpackage/ascii-invaders/ascii-invaders.mk new file +18
-0@@ -0,0 +1,28 @@ +################################################################################ +# +# ASCII-Invaders +# +################################################################################ + +ASCII_INVADERS_VERSION = v1.0.1 +ASCII_INVADERS_SOURCE = $(ASCII_INVADERS_VERSION).tar.gz +ASCII_INVADERS_SITE = $(call github,macdice,ascii-invaders,$(ASCII_INVADERS_VERSION)) +ASCII_INVADERS_DEPENDENCIES = ncurses +ASCII_INVADERS_LICENSE = GPL-2.0+ +ASCII_INVADERS_LICENSE_FILES = LICENSE + +# For compiling statically, libraries must be specified after the object file +define ASCII_INVADERS_POST_EXTRACT_FIXUP + sed -i 's/\$$(LIBS) invaders.o/invaders.o \$$(LIBS)/' $(@D)/Makefile +endef +ASCII_INVADERS_POST_EXTRACT_HOOKS += ASCII_INVADERS_POST_EXTRACT_FIXUP
package/ascii-invaders/ascii-invaders.mk line 28
Quoted 10 lines
package/ascii-invaders/ascii-invaders.mk new file +10
-0+ +define ASCII_INVADERS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) +endef + +define ASCII_INVADERS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin/ascii_invaders +endef + +$(eval $(generic-package))
Friendly *ping*
Thomas
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
Quoted 102 lines · Thomas Huth
Quoted 101 lines · Thomas Huth
An ASCII-art game like Space Invaders using ncurses.
Signed-off-by Thomas Huth <[email protected]>---
v2:
- I'm submitting the patch individually now, to ease the review
- Addressed Gilles' review feedback from v1
- Cleaned warnings from utils/check-package
- Checked with utils/test-pkg, addedPOST_EXTRACT_HOOKto fix a problem when linking the program statically
- Use $(call github, ...) helper to create the SITE variableDEVELOPERS | 3 +++ package/Config.in | 1 + package/ascii-invaders/Config.in | 7 ++++++ package/ascii-invaders/ascii-invaders.hash | 5 ++++ package/ascii-invaders/ascii-invaders.mk | 28 ++++++++++++++++++++++ 5 files changed, 44 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mkDEVELOPERS +3
-0@@ -2166,6 +2166,9 @@ F: support/scripts/size-stats F: utils/size-stats-compare F: toolchain/ +N: Thomas Huth <[email protected]> +F: package/ascii-invaders/ + N: Thomas Petazzoni <[email protected]> F: arch/Config.in.arm F: boot/boot-wrapper-aarch64/package/Config.in +1
-0@@ -243,6 +243,7 @@ comment "Themes" endmenu menu "Games" + source "package/ascii-invaders/Config.in" source "package/chocolate-doom/Config.in" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in"package/ascii-invaders/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_ASCII_INVADERS + bool "ascii_invaders" + select BR2_PACKAGE_NCURSES + help + An ASCII-art game like Space Invaders using ncurses. + + https://github.com/macdice/ascii-invaderspackage/ascii-invaders/ascii-invaders.hash new file +5
-0@@ -0,0 +1,5 @@ +# Locally calculated +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz + +# Hash for license file +sha512 1e455684996d7733b2f1ccd4606d034694d16ceff6ede6125d7f1537d20dabe05976cca4cef5cbf6c31352cbd62a515fd8e34a2ffb54dae1181c1116b24c6cf7 LICENSEpackage/ascii-invaders/ascii-invaders.mk new file +23
-0@@ -0,0 +1,28 @@ +################################################################################ +# +# ASCII-Invaders +# +################################################################################ + +ASCII_INVADERS_VERSION = v1.0.1 +ASCII_INVADERS_SOURCE = $(ASCII_INVADERS_VERSION).tar.gz +ASCII_INVADERS_SITE = $(call github,macdice,ascii-invaders,$(ASCII_INVADERS_VERSION)) +ASCII_INVADERS_DEPENDENCIES = ncurses +ASCII_INVADERS_LICENSE = GPL-2.0+ +ASCII_INVADERS_LICENSE_FILES = LICENSE + +# For compiling statically, libraries must be specified after the object file +define ASCII_INVADERS_POST_EXTRACT_FIXUP + sed -i 's/\$$(LIBS) invaders.o/invaders.o \$$(LIBS)/' $(@D)/Makefile +endef +ASCII_INVADERS_POST_EXTRACT_HOOKS += ASCII_INVADERS_POST_EXTRACT_FIXUP + +define ASCII_INVADERS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) +endef +
Quoted 8 lines
package/ascii-invaders/ascii-invaders.mk line 28
Quoted 6 lines
package/ascii-invaders/ascii-invaders.mk new file +5
-0+define ASCII_INVADERS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin/ascii_invaders +endef + +$(eval $(generic-package))Friendly *ping*
Ping^2 ?
Thomas
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
Hello Thomas,
Quoted 6 lines · On Mon, 27 May 2019 17:22:09 +0200 Thomas Huth <[email protected]> wrote:
Quoted 4 lines
Quoted 2 lines
+$(eval $(generic-package))
Friendly *ping*
Ping^2 ?
Sorry for the lack of answer/feedback. However, sending pings is not really useful: your patch cannot be lost because we have a tool tracking all patches sent to the mailing list,
http://patchwork.ozlabs.org/project/buildroot/list/. As long as your patch is still there, it is not lost. The queue of patches is currently 227 patches, so your best chance to get your patch reviewed and merged is to help by reviewing/testing patches submitted by others :-)
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
Am Mon, 27 May 2019 17:32:00 +0200
schrieb Thomas Petazzoni <[email protected]>:
Quoted 8 lines
Hello Thomas,
Quoted 3 lines · On Mon, 27 May 2019 17:22:09 +0200 Thomas Huth <[email protected]> wrote:
Quoted 3 lines
Quoted 2 lines
+$(eval $(generic-package))
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Friendly *ping*
Ping^2 ?
Sorry for the lack of answer/feedback. However, sending pings is not really useful: your patch cannot be lost because we have a tool tracking all patches sent to the mailing list,
http://patchwork.ozlabs.org/project/buildroot/list/.
Ah, alright. Sorry, so far I mainly participated in projects where one was supposed to "ping" on the patches after a couple of weeks. Using patchwork is certainly the better idea.
Quoted 5 lines
As long as your
patch is still there, it is not lost. The queue of patches is currently 227 patches, so your best chance to get your patch reviewed and merged is to help by reviewing/testing patches submitted by others :-)
Ok, I'll have a try.
Thomas
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
In reply to Thomas HuthLe lun. 22 avr. 2019 ? 10:11, Thomas Huth <[email protected]> a ?crit :
Quoted 108 lines
An ASCII-art game like Space Invaders using ncurses.
Signed-off-by Thomas Huth <[email protected]>---
v2:
- I'm submitting the patch individually now, to ease the review
- Addressed Gilles' review feedback from v1
- Cleaned warnings from utils/check-package
- Checked with utils/test-pkg, addedPOST_EXTRACT_HOOKto fix a problem when linking the program statically
- Use $(call github, ...) helper to create the SITE variableDEVELOPERS | 3 +++ package/Config.in | 1 + package/ascii-invaders/Config.in | 7 ++++++ package/ascii-invaders/ascii-invaders.hash | 5 ++++ package/ascii-invaders/ascii-invaders.mk | 28 ++++++++++++++++++++++ 5 files changed, 44 insertions(+) create mode 100644 package/ascii-invaders/Config.in create mode 100644 package/ascii-invaders/ascii-invaders.hash create mode 100644 package/ascii-invaders/ascii-invaders.mkDEVELOPERS +3
-0@@ -2166,6 +2166,9 @@ F: support/scripts/size-stats F: utils/size-stats-compare F: toolchain/ +N: Thomas Huth <[email protected]> +F: package/ascii-invaders/ + N: Thomas Petazzoni <[email protected]> F: arch/Config.in.arm F: boot/boot-wrapper-aarch64/package/Config.in +1
-0@@ -243,6 +243,7 @@ comment "Themes" endmenu menu "Games" + source "package/ascii-invaders/Config.in" source "package/chocolate-doom/Config.in" source "package/doom-wad/Config.in" source "package/flare-engine/Config.in"package/ascii-invaders/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_ASCII_INVADERS + bool "ascii_invaders" + select BR2_PACKAGE_NCURSES + help + An ASCII-art game like Space Invaders using ncurses. + + https://github.com/macdice/ascii-invaderspackage/ascii-invaders/ascii-invaders.hash new file +5
-0@@ -0,0 +1,5 @@ +# Locally calculated +sha512 326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7 v1.0.1.tar.gz + +# Hash for license file +sha512 1e455684996d7733b2f1ccd4606d034694d16ceff6ede6125d7f1537d20dabe05976cca4cef5cbf6c31352cbd62a515fd8e34a2ffb54dae1181c1116b24c6cf7 LICENSEpackage/ascii-invaders/ascii-invaders.mk new file +28
-1@@ -0,0 +1,28 @@ +################################################################################ +# +# ASCII-Invaders +# +################################################################################ + +ASCII_INVADERS_VERSION = v1.0.1 +ASCII_INVADERS_SOURCE = $(ASCII_INVADERS_VERSION).tar.gz +ASCII_INVADERS_SITE = $(call github,macdice,ascii-invaders,$(ASCII_INVADERS_VERSION)) +ASCII_INVADERS_DEPENDENCIES = ncurses +ASCII_INVADERS_LICENSE = GPL-2.0+ +ASCII_INVADERS_LICENSE_FILES = LICENSE + +# For compiling statically, libraries must be specified after the object file +define ASCII_INVADERS_POST_EXTRACT_FIXUP + sed -i 's/\$$(LIBS) invaders.o/invaders.o \$$(LIBS)/' $(@D)/Makefile +endef +ASCII_INVADERS_POST_EXTRACT_HOOKS += ASCII_INVADERS_POST_EXTRACT_FIXUP + +define ASCII_INVADERS_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) +endef + +define ASCII_INVADERS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/ascii_invaders $(TARGET_DIR)/usr/bin/ascii_invaders +endef + +$(eval $(generic-package)) --
Quoted 2 lines
2.17.2
PATCH v2 1/1 package/ascii-invaders: Add the game ascii-invaders
In reply to Thomas HuthQuoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Huth <[email protected]> writes:
An ASCII-art game like Space Invaders using ncurses.
Signed-off-by Thomas Huth <[email protected]>
Quoted 8 lines
---
v2:
- I'm submitting the patch individually now, to ease the review
- Addressed Gilles' review feedback from v1
- Cleaned warnings from utils/check-package
- Checked with utils/test-pkg, addedPOST_EXTRACT_HOOKto fix a problem when linking the program statically
- Use $(call github, ...) helper to create the SITE variable
Cute ;)
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard