net/ena: update Rx checksum errors on Rx path
PATCH 1/1 net/ena: update Rx checksum errors on Rx path
Rx checksum flags and input errors shouldn't be updated on Tx, as it would work only for packets forwarding.
The ierrors statistic should be updated on Rx, right after checking Rx checksum flags if the Rx checksum offload is enabled.
Signed-off-by Michal Krawczyk <[email protected]>
--- drivers/net/ena/ena_ethdev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/net/ena/ena_ethdev.c +3 -5
@@ -2105,8 +2105,10 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,ena_rx_mbuf_prepare (mbuf_head, &ena_rx_ctx);if (unlikely (mbuf_head->ol_flags & - (PKT_RX_IP_CKSUM_BAD |PKT_RX_L4_CKSUM_BAD ))) + (PKT_RX_IP_CKSUM_BAD |PKT_RX_L4_CKSUM_BAD ))) { +rte_atomic64_inc (&rx_ring->adapter->drv_stats->ierrors); ++rx_ring->rx_stats.bad_csum; + } mbuf_head->hash.rss = ena_rx_ctx.hash;
@@ -2334,10 +2336,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,/* Set TX offloads flags, if applicable */ ena_tx_mbuf_prepare (mbuf, &ena_tx_ctx, tx_ring->offloads); -if (unlikely (mbuf->ol_flags & - (PKT_RX_L4_CKSUM_BAD |PKT_RX_IP_CKSUM_BAD ))) -rte_atomic64_inc (&tx_ring->adapter->drv_stats->ierrors); -rte_prefetch0 (tx_pkts[(sent_idx +4 ) & ring_mask]);/* Process first segment taking into
Signature · 1 line
2.14.1
Ferruh Yigit
AppliedQuoted 7 lines · Michal Krawczyk
Rx checksum flags and input errors shouldn't be updated on Tx, as it would work only for packets forwarding.
The ierrors statistic should be updated on Rx, right after checking Rx checksum flags if the Rx checksum offload is enabled.
Signed-off-by Michal Krawczyk <[email protected]>
Applied to dpdk-next-net/master, thanks.