Skip to contentSkip to conversation

boot/barebox: add hash for the license file

PATCH New Bartosz Bilas 3 participants 6 messages May 27, 2019 – May 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boot/barebox: add hash for the license file

---
 boot/barebox/barebox.hash | 1 +
 1 file changed, 1 insertion(+)
boot/barebox/barebox.hash +1 -0
index fb371ab671..aa9038b9d4 100644
@@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f barebox-2019.05.0.tar.bz2
 
 # Locally calculated
 sha256 704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d barebox-2019.05.0.tar.bz2
+sha256 ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4 COPYING
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 boot/barebox: add hash for the license file

Am Mon, 27 May 2019 17:30:54 +0200
schrieb Bartosz Bilas <[email protected]>:

Quoted 10 lines
---
 boot/barebox/barebox.hash | 1 +
 1 file changed, 1 insertion(+)
boot/barebox/barebox.hash +0 -0
index fb371ab671..aa9038b9d4 100644
@@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f
Quoted 7 lines

barebox-2019.05.0.tar.bz2
# Locally calculated
sha256
704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d barebox-2019.05.0.tar.bz2 +sha256 ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4 COPYING

The COPYING file is only a short description which refers to LICENSES/preferred/GPL-2.0 ... so I think you should provide a hash for that file, too?

Thomas

#2 lore raw

PATCH 1/1 boot/barebox: add hash for the license file

There is also BSD-3-Clause used in some files so there is necessity to complete licence files with them. I will prepare a new patch with that.

Best
Bartek

Quoted 25 lines · Thomas Huth

Am Mon, 27 May 2019 17:30:54 +0200
schrieb Bartosz Bilas <[email protected]>:

Quoted 10 lines
---
  boot/barebox/barebox.hash | 1 +
  1 file changed, 1 insertion(+)
boot/barebox/barebox.hash +0 -0
index fb371ab671..aa9038b9d4 100644
@@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f
Quoted 7 lines

barebox-2019.05.0.tar.bz2
# Locally calculated
sha256
704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d barebox-2019.05.0.tar.bz2 +sha256 ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4 COPYING

The COPYING file is only a short description which refers to LICENSES/preferred/GPL-2.0 ... so I think you should provide a hash for that file, too?

Thomas

#3 lore raw

PATCH 1/1 boot/barebox: add hash for the license file

Quoted 2 lines · Bartosz Bi?as

There is also BSD-3-Clause used in some files so there is necessity to complete licence files with them. I will prepare a new patch with that.

Can you also check (and specify in the commit message) if this file exists in
*all* versions of barebox? It is possible to configure a custom version of barebox, so it can be pretty much anything...

Well, I checked myself: the LICENSES directory exists since 2019.04.0...

There is unfortunately no simple way to conditionally add license files: if a
file specified in _LICENSE_FILES doesn't exist, it's a hard error. You can use $(wildcard ...) but then you have to strip off the source directory again.

Regards,
Arnout

Quoted 33 lines

Best
Bartek

Quoted 24 lines · Thomas Huth

Am Mon, 27 May 2019 17:30:54 +0200
schrieb Bartosz Bilas <[email protected]>:

Quoted 10 lines

---
? boot/barebox/barebox.hash | 1 +
? 1 file changed, 1 insertion(+)

boot/barebox/barebox.hash +0 -0
index fb371ab671..aa9038b9d4 100644
@@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f
Quoted 7 lines

barebox-2019.05.0.tar.bz2
? # Locally calculated
? sha256 704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d barebox-2019.05.0.tar.bz2 +sha256 ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4 COPYING

The COPYING file is only a short description which refers to LICENSES/preferred/GPL-2.0 ... so I think you should provide a hash for that file, too?

Quoted 1 line

? Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw

PATCH 1/1 boot/barebox: add hash for the license file

Am Tue, 28 May 2019 20:16:42 +0200
schrieb Arnout Vandecappelle <[email protected]>:

Quoted 11 lines · Bartosz Bi?as
Quoted 3 lines

There is also BSD-3-Clause used in some files so there is necessity to complete licence files with them. I will prepare a new patch with that.

Can you also check (and specify in the commit message) if this file
exists in *all* versions of barebox? It is possible to configure a custom version of barebox, so it can be pretty much anything...

Quoted 7 lines

Well, I checked myself: the LICENSES directory exists since
2019.04.0...

There is unfortunately no simple way to conditionally add license
files: if a file specified in _LICENSE_FILES doesn't exist, it's a hard error. You can use $(wildcard ...) but then you have to strip off the source directory again.

Hmm, don't we have the problem with the hash of the tarball itself already? If you specify another version, the hash of the tar.bz2 file certainly does not match anymore...

Thomas

#5 lore raw

PATCH 1/1 boot/barebox: add hash for the license file

Quoted 17 lines · Thomas Huth

Am Tue, 28 May 2019 20:16:42 +0200
schrieb Arnout Vandecappelle <[email protected]>:

Quoted 14 lines · Bartosz Bi?as
Quoted 3 lines

There is also BSD-3-Clause used in some files so there is necessity to complete licence files with them. I will prepare a new patch with that.

Can you also check (and specify in the commit message) if this file
exists in *all* versions of barebox? It is possible to configure a custom version of barebox, so it can be pretty much anything...

Well, I checked myself: the LICENSES directory exists since
2019.04.0...

Quoted 8 lines
Quoted 4 lines

There is unfortunately no simple way to conditionally add license
files: if a file specified in _LICENSE_FILES doesn't exist, it's a hard error. You can use $(wildcard ...) but then you have to strip off the source directory again.

Hmm, don't we have the problem with the hash of the tarball itself already? If you specify another version, the hash of the tar.bz2 file certainly does not match anymore...

The hash of the tarball isn't checked for custom versions:

ifeq ($(BR2_TARGET_BAREBOX)$(BR2_TARGET_BAREBOX_LATEST_VERSION),y) BR_NO_CHECK_HASH_FOR += $(BAREBOX_SOURCE)
endif

Regards,
Arnout