Skip to contentSkip to conversation

p54: Support boottime in scan results

PATCH In review Christian Lamparter 2 participants 2 messages May 24, 2019 – May 28, 2019 P54 wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 p54: Support boottime in scan results

This patch fixes an issue with wpa_supplicant dropping all scan results because their where considered to be "too old" (e.g.:
"skip - scan result not recent enough (121056.086325 seconds too old)") which is very weird because this looks like that the scan results have been received before a scan started. This is due to the inaccuracy of the default timing mechanism for calculating the BSS entry age.

---
 drivers/net/wireless/intersil/p54/txrx.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/wireless/intersil/p54/txrx.c +6 -0
index 5bf1c19ecced..f80c5056ccb7 100644
@@ -334,6 +334,7 @@ static int p54_rx_data(struct p54_common *priv, struct sk_buff *skb)
 	u16 freq = le16_to_cpu(hdr->freq);
 	size_t header_len = sizeof(*hdr);
 	u32 tsf32;
+	__le16 fc;
 	u8 rate = hdr->rate & 0xf;
 
 	/*
@@ -382,6 +383,11 @@ static int p54_rx_data(struct p54_common *priv, struct sk_buff *skb)
 
 	skb_pull(skb, header_len);
 	skb_trim(skb, le16_to_cpu(hdr->len));
+
+	fc = ((struct ieee80211_hdr *)skb->data)->frame_control;
+	if (ieee80211_is_probe_resp(fc) || ieee80211_is_beacon(fc))
+		rx_status->boottime_ns = ktime_get_boot_ns();
+
 	if (unlikely(priv->hw->conf.flags & IEEE80211_CONF_PS))
 		p54_pspoll_workaround(priv, skb);
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 8 lines · Christian Lamparter

This patch fixes an issue with wpa_supplicant dropping all scan results because their where considered to be "too old" (e.g.:
"skip - scan result not recent enough (121056.086325 seconds too old)") which is very weird because this looks like that the scan results have been received before a scan started. This is due to the inaccuracy of the default timing mechanism for calculating the BSS entry age.

Patch applied to wireless-drivers-next.git, thanks.

c11c75ec784e p54: Support boottime in scan results

Signature · 3 lines
https://patchwork.kernel.org/patch/10960463/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches