Skip to contentSkip to conversation

lib/igt: fix igt_audio include

PATCH In review Simon Ser 3 participants 3 messages May 28, 2019 Library code

lore
Share & tools
lore

Simon Ser

author
#0 lore raw

PATCH 1/1 lib/igt: fix igt_audio include

igt_audio includes a libasound header. We should guard it behind HAVE_CHAMELIUM.

---
 lib/igt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt.h +1 -1
index 82cdd57a4deb..a6c4e44d2172 100644
@@ -35,13 +35,13 @@
 #include "igt_dummyload.h"
 #include "igt_fb.h"
 #include "igt_frame.h"
-#include "igt_audio.h"
 #include "igt_gt.h"
 #include "igt_kms.h"
 #include "igt_pm.h"
 #include "igt_stats.h"
 #ifdef HAVE_CHAMELIUM
 #include "igt_alsa.h"
+#include "igt_audio.h"
 #include "igt_chamelium.h"
 #include "igt_chamelium_stream.h"
 #endif

--
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Ser, Simon
Sent: Tuesday, May 28, 2019 7:17 PM
To: [email protected]
Cc: Hiler, Arkadiusz <[email protected]>; Peres, Martin <[email protected]>; C, Ramalingam <[email protected]>
Subject: [PATCH i-g-t] lib/igt: fix igt_audio include

Quoted 4 lines

igt_audio includes a libasound header. We should guard it behind HAVE_CHAMELIUM.

-Ram.

Quoted 24 lines
---
 lib/igt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt.h +1 -2
index 82cdd57a4deb..a6c4e44d2172 100644
@@ -35,13 +35,13 @@
 #include "igt_dummyload.h"
 #include "igt_fb.h"
 #include "igt_frame.h"
-#include "igt_audio.h"
 #include "igt_gt.h"
 #include "igt_kms.h"
 #include "igt_pm.h"
 #include "igt_stats.h"
 #ifdef HAVE_CHAMELIUM
 #include "igt_alsa.h"
+#include "igt_audio.h"
 #include "igt_chamelium.h"
 #include "igt_chamelium_stream.h"
 #endif
--
Quoted 1 line

2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt: fix igt_audio include

In reply to Simon Ser
== Series Details ==

== Series Details ==

Series: lib/igt: fix igt_audio include
URL : https://patchwork.freedesktop.org/series/61245/
State : failure

== Summary ==

Series 61245 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev