Skip to contentSkip to conversation

tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI

PATCH In review Philippe Mathieu-Daudé 3 participants 3 messages May 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI

This started to fail 6 months ago [1] and lately occurs too often on the main Travis CI.

Travis CI set the CONTINUOUS_INTEGRATION variable in the process environment [2]. Let's use it to disable it when running this test there.

[1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
[2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

---
 tests/migration-test.c | 5 +++++
 1 file changed, 5 insertions(+)
tests/migration-test.c +5 -0
index bd3f5c3125..c5091e1fb1 100644
@@ -764,6 +764,11 @@ static void test_postcopy(void)
 {
     QTestState *from, *to;
 
+    if (getenv("CONTINUOUS_INTEGRATION")) {
+        /* Test failing on Travis-CI */
+        g_test_skip("Running on Travis-CI");
+    }
+
     if (migrate_postcopy_prepare(&from, &to, false)) {
         return;
     }
Signature · 1 line
2.20.1
#1 lore raw
Quoted 9 lines · * Philippe Mathieu-Daudé ([email protected]) wrote:

This started to fail 6 months ago [1] and lately occurs too often on the main Travis CI.

Travis CI set the CONTINUOUS_INTEGRATION variable in the process environment [2]. Let's use it to disable it when running this test there.

[1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
[2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

I think the right solution here is to disable it under TCG.

Dave

Quoted 25 lines
---
 tests/migration-test.c | 5 +++++
 1 file changed, 5 insertions(+)
tests/migration-test.c +5 -0
index bd3f5c3125..c5091e1fb1 100644
@@ -764,6 +764,11 @@ static void test_postcopy(void)
 {
     QTestState *from, *to;
 
+    if (getenv("CONTINUOUS_INTEGRATION")) {
+        /* Test failing on Travis-CI */
+        g_test_skip("Running on Travis-CI");
+    }
+
     if (migrate_postcopy_prepare(&from, &to, false)) {
         return;
     }
Signature · 1 line
2.20.1

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

#2 lore raw
Quoted 4 lines · Dr. David Alan Gilbert
Quoted 3 lines · * Philippe Mathieu-Daudé ([email protected]) wrote:

This started to fail 6 months ago [1] and lately occurs too often on the main Travis CI.

Quoted 9 lines
Quoted 6 lines

Travis CI set the CONTINUOUS_INTEGRATION variable in the process environment [2]. Let's use it to disable it when running this test there.

[1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
[2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

I think the right solution here is to disable it under TCG.

For example, it's already done for ppc64 and s390x:

d254b392cb10 tests/migration-test: Disable s390x test when running with TCG 5fd4a9c97397 tests/migration: Skip tests for ppc tcg

You need the same for aarch64 since:
c02b37814cf6 tests: Add migration test for aarch64

Thanks,
Laurent