ia64: fix build errors by exporting paddr_to_nid()
PATCH 1/1 ia64: fix build errors by exporting paddr_to_nid()
From: Randy Dunlap <[email protected]>
Fix build errors on ia64 when DISCONTIGMEM=y and NUMA=y by exporting paddr_to_nid().
Fixes these build errors:
ERROR: "paddr_to_nid" [sound/core/snd-pcm.ko] undefined!
ERROR: "paddr_to_nid" [net/sunrpc/sunrpc.ko] undefined!
ERROR: "paddr_to_nid" [fs/cifs/cifs.ko] undefined!
ERROR: "paddr_to_nid" [drivers/video/fbdev/core/fb.ko] undefined!
ERROR: "paddr_to_nid" [drivers/usb/mon/usbmon.ko] undefined!
ERROR: "paddr_to_nid" [drivers/usb/core/usbcore.ko] undefined!
ERROR: "paddr_to_nid" [drivers/md/raid1.ko] undefined!
ERROR: "paddr_to_nid" [drivers/md/dm-mod.ko] undefined!
ERROR: "paddr_to_nid" [drivers/md/dm-crypt.ko] undefined!
ERROR: "paddr_to_nid" [drivers/md/dm-bufio.ko] undefined!
ERROR: "paddr_to_nid" [drivers/ide/ide-core.ko] undefined!
ERROR: "paddr_to_nid" [drivers/ide/ide-cd_mod.ko] undefined!
ERROR: "paddr_to_nid" [drivers/gpu/drm/drm.ko] undefined!
ERROR: "paddr_to_nid" [drivers/char/agp/agpgart.ko] undefined!
ERROR: "paddr_to_nid" [drivers/block/nbd.ko] undefined!
ERROR: "paddr_to_nid" [drivers/block/loop.ko] undefined!
ERROR: "paddr_to_nid" [drivers/block/brd.ko] undefined!
ERROR: "paddr_to_nid" [crypto/ccm.ko] undefined!
--- arch/ia64/mm/numa.c | 1 + 1 file changed, 1 insertion(+)
arch/ia64/mm/numa.c +1 -0
@@ -55,6 +55,7 @@ paddr_to_nid(unsigned long paddr)return (i < num_node_memblks) ? node_memblk[i].nid : (num_node_memblks ?-1 :0 ); } +EXPORT_SYMBOL (paddr_to_nid);#if defined(CONFIG_SPARSEMEM ) && defined(CONFIG_NUMA )/*
Signature · 1 line
2.20.1
Linus Torvalds
AppliedQuoted 3 lines · Tony Luck
Fix build errors on ia64 when DISCONTIGMEM=y and NUMA=y by exporting
paddr_to_nid().
Applied.
Just out of curiosity, what caused this error? It doesn't _look_ new, just judging from the patch itself. Is this just a configuration that nobody has noticed before, or something else that changed that caused it to happen now?
Linus
PiBKdXN0IG91dCBvZiBjdXJpb3NpdHksIHdoYXQgY2F1c2VkIHRoaXMgZXJyb3I/IEl0IGRvZXNu J3QgX2xvb2tfIG5ldywNCj4ganVzdCBqdWRnaW5nIGZyb20gdGhlIHBhdGNoIGl0c2VsZi4gSXMg dGhpcyBqdXN0IGEgY29uZmlndXJhdGlvbiB0aGF0DQo+IG5vYm9keSBoYXMgbm90aWNlZCBiZWZv cmUsIG9yIHNvbWV0aGluZyBlbHNlIHRoYXQgY2hhbmdlZCB0aGF0IGNhdXNlZA0KPiBpdCB0byBo YXBwZW4gbm93Pw0KDQpJJ20gY29uZnVzZWQgYnkgdGhlIGVycm9yIGJlY2F1c2UgSSBkb24ndCBz ZWUgaXQgdXNpbmcgYW4gb2xkZXIgKDQuNi40KSB2ZXJzaW9uDQpvZiBnY2MuIEJ1dCBSYW5keSBp cyBidWlsZGluZyB3aXRoIHNvbWV0aGluZyBtb2Rlcm4gYW5kIHJ1bnMgaW50byBpdC4NCg0KU28g c29tZSBhZ2dyZXNzaXZlIG9wdGltaXphdGlvbi9pbmxpbmU/DQoNCi1Ub255DQo
Quoted 11 lines · Tony
Quoted 4 lines
Just out of curiosity, what caused this error? It doesn't _look_ new, just judging from the patch itself. Is this just a configuration that nobody has noticed before, or something else that changed that caused it to happen now?
I'm confused by the error because I don't see it using an older (4.6.4) version of gcc. But Randy is building with something modern and runs into it.
So some aggressive optimization/inline?
-Tony
kbuild test robot reported the build error. It uses gcc 7.x. I am using gcc 8.1 from kernel.org crosstools.
Signature · 1 line
~Randy