net/i40e: remove queue_stats_mapping_set
PATCH 1/1 net/i40e: remove queue_stats_mapping_set
This driver was inserting its own stub for queue_stats_mapping which did nothing but cause this device to return a different errno than every other device driver. All devices that don't implement queue stats mapping should return the same error.
Maybe the plan originally was to implement something, if that ever happens, just put in the right code.
--- drivers/net/i40e/i40e_ethdev.c | 16 ---------------- 1 file changed, 16 deletions(-)
drivers/net/i40e/i40e_ethdev.c +0 -16
@@ -237,10 +237,6 @@ static int i40e_dev_xstats_get_names(struct rte_eth_dev *dev,struct rte_eth_xstat_name *xstats_names, unsigned limit);static void i40e_dev_stats_reset (struct rte_eth_dev *dev); -static int i40e_dev_queue_stats_mapping_set (struct rte_eth_dev *dev, -uint16_t queue_id, -uint8_t stat_idx, -uint8_t is_rx);static int i40e_fw_version_get (struct rte_eth_dev *dev,char *fw_version,size_t fw_size); static void i40e_dev_info_get(struct rte_eth_dev *dev,
@@ -456,7 +452,6 @@ static const struct eth_dev_ops i40e_eth_dev_ops = { .xstats_get_names = i40e_dev_xstats_get_names, .stats_reset = i40e_dev_stats_reset, .xstats_reset = i40e_dev_stats_reset, - .queue_stats_mapping_set = i40e_dev_queue_stats_mapping_set, .fw_version_get = i40e_fw_version_get, .dev_infos_get = i40e_dev_info_get, .dev_supported_ptypes_get = i40e_dev_supported_ptypes_get,
@@ -3431,17 +3426,6 @@ i40e_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,return count; } -static int -i40e_dev_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev, - __rte_unused uint16_t queue_id, - __rte_unused uint8_t stat_idx, - __rte_unused uint8_t is_rx) -{ -PMD_INIT_FUNC_TRACE (); - -return -ENOSYS ; -} -static int i40e_fw_version_get (struct rte_eth_dev *dev,char *fw_version,size_t fw_size) {
Signature · 1 line
2.20.1
Quoted 5 lines · Stephen Hemminger
This driver was inserting its own stub for
queue_stats_mappingwhich did nothing but cause this device to return a different errno than every other device driver. All devices that don't implement queue stats mapping should return the same error.
Quoted 9 lines
Maybe the plan originally was to implement something, if that ever happens, just put in the right code.
Fixes 4861cde46116 ("i40e: new poll mode driver")Signed-off-by Stephen Hemminger <[email protected]>--- drivers/net/i40e/i40e_ethdev.c | 16 ---------------- 1 file changed, 16 deletions(-)
Zhang, Qi Z
AppliedQuoted 29 lines
-----Original Message-----
From: Maxime Coquelin [mailto:[email protected]]
Sent: Wednesday, May 29, 2019 5:12 PM
To: Stephen Hemminger <[email protected]>; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH] net/i40e: removequeue_stats_mapping_setQuoted 5 lines · Stephen Hemminger
This driver was inserting its own stub for
queue_stats_mappingwhich did nothing but cause this device to return a different errno than every other device driver. All devices that don't implement queue stats mapping should return the same error.Quoted 9 lines
Maybe the plan originally was to implement something, if that ever happens, just put in the right code.
Fixes 4861cde46116 ("i40e: new poll mode driver")Signed-off-by Stephen Hemminger <[email protected]>--- drivers/net/i40e/i40e_ethdev.c | 16 ---------------- 1 file changed, 16 deletions(-)
Quoted 1 line
Acked-by Maxime Coquelin <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi