powerpc/pseries: avoid blocking in irq when queuing hotplug events
PATCH 1/1 powerpc/pseries: avoid blocking in irq when queuing hotplug events
A couple of bugs in queue_hotplug_event():
1. Unchecked kmalloc result which could lead to an oops.
2. Use of GFP_KERNEL allocations in interrupt context (this code's only caller is ras_hotplug_interrupt()).
Use kmemdup to avoid open-coding the allocation+copy and check for failure; use GFP_ATOMIC for both allocations.
Ultimately it probably would be better to avoid or reduce allocations in this path if possible.
---
Found by inspection, built but not runtime-tested.
arch/powerpc/platforms/pseries/dlpar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/powerpc/platforms/pseries/dlpar.c +4 -4
@@ -386,11 +386,11 @@ void queue_hotplug_event(struct pseries_hp_errorlog *hp_errlog)struct pseries_hp_work *work;struct pseries_hp_errorlog *hp_errlog_copy; - hp_errlog_copy =kmalloc (sizeof (struct pseries_hp_errorlog ), -GFP_KERNEL ); -memcpy (hp_errlog_copy, hp_errlog,sizeof (struct pseries_hp_errorlog )); + hp_errlog_copy =kmemdup (hp_errlog,sizeof (*hp_errlog),GFP_ATOMIC ); +if (!hp_errlog_copy) +return ; - work =kmalloc (sizeof (struct pseries_hp_work ),GFP_KERNEL ); + work =kmalloc (sizeof (struct pseries_hp_work ),GFP_ATOMIC );if (work) {INIT_WORK ((struct work_struct *)work, pseries_hp_work_fn); work->errlog = hp_errlog_copy;
Signature · 1 line
2.20.1
Michael Ellerman
AppliedQuoted 6 lines · Nathan Lynch
A couple of bugs in
queue_hotplug_event():1. Unchecked kmalloc result which could lead to an oops.
2. Use ofGFP_KERNELallocations in interrupt context (this code's only caller isras_hotplug_interrupt()).
Quoted 7 lines
Use kmemdup to avoid open-coding the allocation+copy and check for failure; use
GFP_ATOMICfor both allocations.Ultimately it probably would be better to avoid or reduce allocations in this path if possible.
Signed-off-by Nathan Lynch <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/348ea30f51fc63ce3c7fd7dba6043e8e3ee0ef34
cheers