Skip to contentSkip to conversation

lib/telemetry: fix memory leak

PATCH Applied Reshma Pattan 3 participants 3 messages May 29, 2019 – Jun 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/telemetry: fix memory leak

Free the values pointer before returning from rte_telemetry_command_ports_all_stat_values() to avoid memory leak.

Fixes c12cefa379 ("telemetry: fix mapping of statistics")
---
 lib/librte_telemetry/rte_telemetry_parser.c | 1 +
 1 file changed, 1 insertion(+)
lib/librte_telemetry/rte_telemetry_parser.c +1 -0
index 9bc16eef4..e9297021a 100644
@@ -342,6 +342,7 @@ rte_telemetry_command_ports_all_stat_values(struct telemetry_impl *telemetry,
 		goto fail;
 	}
 
+	free(values);
 	return 0;
 
 fail:
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Reshma Pattan

Free the values pointer before returning from rte_telemetry_command_ports_all_stat_values() to avoid memory leak.

Fixes c12cefa379 ("telemetry: fix mapping of statistics")
---
  lib/librte_telemetry/rte_telemetry_parser.c | 1 +
  1 file changed, 1 insertion(+)
lib/librte_telemetry/rte_telemetry_parser.c +0 -0
index 9bc16eef4..e9297021a 100644

lib/librte_telemetry/rte_telemetry_parser.c rte_telemetry_command_ports_all_stat_values(struct telemetry_impl *telemetry, · line 348

Quoted 7 lines
lib/librte_telemetry/rte_telemetry_parser.c +1 -0
@@ -342,6 +342,7 @@ rte_telemetry_command_ports_all_stat_values(struct telemetry_impl *telemetry,
  		goto fail;
  	}
 
+	free(values);
  	return 0;
 
  fail: