Skip to contentSkip to conversation

MAINTAINERS: Clean up and improve section headlines

PATCH Superseded Markus Armbruster 6 participants 20 messages May 29, 2019 – Jun 6, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover MAINTAINERS: Clean up and improve section headlines

Markus Armbruster (3):
MAINTAINERS: Drop redundant L: [email protected]
MAINTAINERS: Improve section headlines
MAINTAINERS: Polish headline decorations

 MAINTAINERS | 113 +++++++++++++++++++++++-----------------------------
 1 file changed, 50 insertions(+), 63 deletions(-)
Signature · 1 line
2.17.2
#1 lore raw

PATCH 1/3 MAINTAINERS: Drop redundant L: [email protected]

Redundant since commit c9a19d5b95 "MAINTAINERS: add all-match entry for qemu-devel@".

---
 MAINTAINERS | 11 -----------
 1 file changed, 11 deletions(-)
MAINTAINERS +0 -11
index 1f5f8b7a2c..edc260e503 100644
@@ -109,7 +109,6 @@ L: [email protected]
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: [email protected]
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
@@ -444,19 +443,16 @@ F: util/*posix*.c
 F: include/qemu/*posix*.h
 
 NETBSD
-L: [email protected]
 M: Kamil Rytarowski <[email protected]>
 S: Maintained
 K: ^Subject:.*(?i)NetBSD
 
 OPENBSD
-L: [email protected]
 M: Brad Smith <[email protected]>
 S: Maintained
 K: ^Subject:.*(?i)OpenBSD
 
 W32, W64
-L: [email protected]
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: *win32*
@@ -565,7 +561,6 @@ F: include/hw/*/digic*
 Gumstix
 M: Peter Maydell <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
-L: [email protected]
 L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c
@@ -1044,7 +1039,6 @@ F: pc-bios/qemu_vga.ndrv
 
 PReP
 M: Hervé Poussineau <[email protected]>
-L: [email protected]
 L: [email protected]
 S: Maintained
 F: hw/ppc/prep.c
@@ -1831,7 +1825,6 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: [email protected]
 S: Supported
 F: qom/cpu.c
 F: include/qom/cpu.h
@@ -2566,7 +2559,6 @@ F: qapi/rdma.json
 
 Semihosting
 M: Alex Bennée <[email protected]>
-L: [email protected]
 S: Maintained
 F: hw/semihosting/
 F: include/hw/semihosting/
@@ -2577,7 +2569,6 @@ Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
-L: [email protected]
 S: Maintained
 F: .travis.yml
 F: scripts/travis/
@@ -2592,7 +2583,6 @@ W: http://patchew.org/QEMU/
 FreeBSD Hosted Continuous Integration
 M: Ed Maste <[email protected]>
 M: Li-Wen Hsu <[email protected]>
-L: [email protected]
 S: Maintained
 F: .cirrus.yml
 W: https://cirrus-ci.com/github/qemu/qemu
@@ -2608,7 +2598,6 @@ R: Philippe Mathieu-Daudé <[email protected]>
 S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
-L: [email protected]
 
 Documentation
 -------------
Signature · 1 line
2.17.2
Reviewed-by on v1 1/3
#2 lore raw

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: Drop redundant L: [email protected]

Quoted 2 lines · Markus Armbruster

Redundant since commit c9a19d5b95 "MAINTAINERS: add all-match entry for qemu-devel@".

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05019.html

:(

Quoted 1 line
Quoted 93 lines
---
 MAINTAINERS | 11 -----------
 1 file changed, 11 deletions(-)
MAINTAINERS +0 -11
index 1f5f8b7a2c..edc260e503 100644
@@ -109,7 +109,6 @@ L: [email protected]
 Guest CPU cores (TCG):
 ----------------------
 Overall
-L: [email protected]
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
@@ -444,19 +443,16 @@ F: util/*posix*.c
 F: include/qemu/*posix*.h
 
 NETBSD
-L: [email protected]
 M: Kamil Rytarowski <[email protected]>
 S: Maintained
 K: ^Subject:.*(?i)NetBSD
 
 OPENBSD
-L: [email protected]
 M: Brad Smith <[email protected]>
 S: Maintained
 K: ^Subject:.*(?i)OpenBSD
 
 W32, W64
-L: [email protected]
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: *win32*
@@ -565,7 +561,6 @@ F: include/hw/*/digic*
 Gumstix
 M: Peter Maydell <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
-L: [email protected]
 L: [email protected]
 S: Odd Fixes
 F: hw/arm/gumstix.c
@@ -1044,7 +1039,6 @@ F: pc-bios/qemu_vga.ndrv
 
 PReP
 M: Hervé Poussineau <[email protected]>
-L: [email protected]
 L: [email protected]
 S: Maintained
 F: hw/ppc/prep.c
@@ -1831,7 +1825,6 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: [email protected]
 S: Supported
 F: qom/cpu.c
 F: include/qom/cpu.h
@@ -2566,7 +2559,6 @@ F: qapi/rdma.json
 
 Semihosting
 M: Alex Bennée <[email protected]>
-L: [email protected]
 S: Maintained
 F: hw/semihosting/
 F: include/hw/semihosting/
@@ -2577,7 +2569,6 @@ Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
-L: [email protected]
 S: Maintained
 F: .travis.yml
 F: scripts/travis/
@@ -2592,7 +2583,6 @@ W: http://patchew.org/QEMU/
 FreeBSD Hosted Continuous Integration
 M: Ed Maste <[email protected]>
 M: Li-Wen Hsu <[email protected]>
-L: [email protected]
 S: Maintained
 F: .cirrus.yml
 W: https://cirrus-ci.com/github/qemu/qemu
@@ -2608,7 +2598,6 @@ R: Philippe Mathieu-Daudé <[email protected]>
 S: Maintained
 F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
-L: [email protected]
 
 Documentation
 -------------
#3 lore raw

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: Drop redundant L: [email protected]

Quoted 7 lines · Philippe Mathieu-Daudé
Quoted 2 lines · Markus Armbruster

Redundant since commit c9a19d5b95 "MAINTAINERS: add all-match entry for qemu-devel@".

https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05019.html

:(

Oh.

I'm happy to take your patch if it applies without too much trouble.

Did more of that series get stuck?

Quoted 3 lines
Quoted 1 line

Thanks!

#4 lore raw

PATCH 2/3 MAINTAINERS: Improve section headlines

In reply to Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)
MAINTAINERS +39 -39
index edc260e503..196282d165 100644
@@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
 
 Architecture support
 --------------------
-S390
+S390 general architecture support
 M: Cornelia Huck <[email protected]>
 S: Supported
 F: default-configs/s390x-softmmu.mak
@@ -108,7 +108,7 @@ L: [email protected]
 
 Guest CPU cores (TCG):
 ----------------------
-Overall
+Overall CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
@@ -133,14 +133,14 @@ F: fpu/
 F: include/fpu/
 F: tests/fp/
 
-Alpha
+Alpha CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/alpha/
 F: tests/tcg/alpha/
 F: disas/alpha.c
 
-ARM
+ARM CPU cores (TCG)
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
@@ -161,7 +161,7 @@ S: Maintained
 F: hw/arm/smmu*
 F: include/hw/arm/smmu*
 
-CRIS
+CRIS CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/cris/
@@ -170,14 +170,14 @@ F: include/hw/cris/
 F: tests/tcg/cris/
 F: disas/cris.c
 
-HPPA (PA-RISC)
+HPPA (PA-RISC) CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/hppa/
 F: hw/hppa/
 F: disas/hppa.c
 
-LM32
+LM32 CPU cores (TCG)
 M: Michael Walle <[email protected]>
 S: Maintained
 F: target/lm32/
@@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
 F: include/hw/lm32/
 F: tests/tcg/lm32/
 
-M68K
+M68K CPU cores (TCG)
 M: Laurent Vivier <[email protected]>
 S: Maintained
 F: target/m68k/
 F: disas/m68k.c
 
-MicroBlaze
+MicroBlaze CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/microblaze/
 F: hw/microblaze/
 F: disas/microblaze.c
 
-MIPS
+MIPS CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 M: Aleksandar Markovic <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
@@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
 F: tests/tcg/mips/
 K: ^Subject:.*(?i)mips
 
-Moxie
+Moxie CPU cores (TCG)
 M: Anthony Green <[email protected]>
 S: Maintained
 F: target/moxie/
@@ -232,7 +232,7 @@ F: disas/moxie.c
 F: hw/moxie/
 F: default-configs/moxie-softmmu.mak
 
-NiosII
+NiosII CPU cores (TCG)
 M: Chris Wulff <[email protected]>
 M: Marek Vasut <[email protected]>
 S: Maintained
@@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
 F: disas/nios2.c
 F: default-configs/nios2-softmmu.mak
 
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/
 
-PowerPC
+PowerPC CPU cores (TCG)
 M: David Gibson <[email protected]>
 L: [email protected]
 S: Maintained
@@ -258,7 +258,7 @@ F: hw/ppc/
 F: include/hw/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V CPU cores (TCG)
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 M: Sagar Karandikar <[email protected]>
@@ -271,7 +271,7 @@ F: include/hw/riscv/
 F: linux-user/host/riscv32/
 F: linux-user/host/riscv64/
 
-S390
+S390 CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 M: David Hildenbrand <[email protected]>
 S: Maintained
@@ -281,7 +281,7 @@ F: disas/s390.c
 F: tests/tcg/s390x/
 L: [email protected]
 
-SH4
+SH4 CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 S: Odd Fixes
 F: target/sh4/
@@ -289,7 +289,7 @@ F: hw/sh4/
 F: disas/sh4.c
 F: include/hw/sh4/
 
-SPARC
+SPARC CPU cores (TCG)
 M: Mark Cave-Ayland <[email protected]>
 M: Artyom Tarasenko <[email protected]>
 S: Maintained
@@ -299,14 +299,14 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
-UniCore32
+UniCore32 CPU cores (TCG)
 M: Guan Xuetao <[email protected]>
 S: Maintained
 F: target/unicore32/
 F: hw/unicore32/
 F: include/hw/unicore32/
 
-X86
+X86 CPU cores (TCG)
 M: Paolo Bonzini <[email protected]>
 M: Richard Henderson <[email protected]>
 M: Eduardo Habkost <[email protected]>
@@ -319,7 +319,7 @@ F: disas/i386.c
 F: docs/qemu-cpu-models.texi
 T: git https://github.com/ehabkost/qemu.git x86-next
 
-Xtensa
+Xtensa CPU cores (TCG)
 M: Max Filippov <[email protected]>
 W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
 S: Maintained
@@ -330,7 +330,7 @@ F: disas/xtensa.c
 F: include/hw/xtensa/xtensa-isa.h
 F: default-configs/xtensa*.mak
 
-TriCore
+TriCore CPU cores (TCG)
 M: Bastian Koppelmann <[email protected]>
 S: Maintained
 F: target/tricore/
@@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
 Guest CPU Cores (KVM):
 ----------------------
 
-Overall
+Overall CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 L: [email protected]
 S: Supported
@@ -356,24 +356,24 @@ F: include/hw/kvm/
 F: include/sysemu/kvm*.h
 F: scripts/kvm/kvm_flightrecorder
 
-ARM
+ARM CPU cores (KVM)
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: target/arm/kvm.c
 
-MIPS
+MIPS CPU cores (KVM)
 M: James Hogan <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: target/mips/kvm.c
 
-PPC
+PPC CPU cores (KVM)
 M: David Gibson <[email protected]>
 S: Maintained
 F: target/ppc/kvm.c
 
-S390
+S390 CPU cores (KVM)
 M: Halil Pasic <[email protected]>
 M: Cornelia Huck <[email protected]>
 M: Christian Borntraeger <[email protected]>
@@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
 T: git https://github.com/borntraeger/qemu.git s390-next
 L: [email protected]
 
-X86
+X86 CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 M: Marcelo Tosatti <[email protected]>
 L: [email protected]
@@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
 Guest CPU Cores (Xen):
 ----------------------
 
-X86
+X86 CPU cores (Xen)
 M: Stefano Stabellini <[email protected]>
 M: Anthony Perard <[email protected]>
 M: Paul Durrant <[email protected]>
@@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
 
 Usermode Emulation
 ------------------
-Overall
+Overall usermode emulation
 M: Riku Voipio <[email protected]>
 S: Maintained
 F: thunk.c
@@ -2282,7 +2282,7 @@ M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/
 
-AArch64 target
+AArch64 TCG target
 M: Claudio Fontana <[email protected]>
 M: Claudio Fontana <[email protected]>
 S: Maintained
@@ -2291,33 +2291,33 @@ F: tcg/aarch64/
 F: disas/arm-a64.cc
 F: disas/libvixl/
 
-ARM target
+ARM TCG target
 M: Andrzej Zaborowski <[email protected]>
 S: Maintained
 L: [email protected]
 F: tcg/arm/
 F: disas/arm.c
 
-i386 target
+i386 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
 
-MIPS target
+MIPS TCG target
 M: Aurelien Jarno <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: tcg/mips/
 F: disas/mips.c
 
-PPC
+PPC TCG target
 M: Richard Henderson <[email protected]>
 S: Odd Fixes
 F: tcg/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V TCG target
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 L: [email protected]
@@ -2325,19 +2325,19 @@ S: Maintained
 F: tcg/riscv/
 F: disas/riscv.c
 
-S390 target
+S390 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/s390/
 F: disas/s390.c
 L: [email protected]
 
-SPARC target
+SPARC TCG target
 S: Odd Fixes
 F: tcg/sparc/
 F: disas/sparc.c
 
-TCI target
+TCI TCG target
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: tcg/tci/
Signature · 1 line
2.17.2
#5 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 14 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

Quoted 9 lines

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

Unintentional truncation? Or leftover thought that should be removed after you instead split things?

Quoted 4 lines
---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
#6 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 20 lines · Eric Blake
Quoted 19 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

Quoted 7 lines
Quoted 4 lines

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

Unintentional truncation? Or leftover thought that should be removed after you instead split things?

leftover :)

"While there, polish headline decorations"

Quoted 6 lines
Quoted 5 lines
---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)
#7 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · Eric Blake
Quoted 23 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

Quoted 6 lines
Quoted 2 lines

Unintentional truncation? Or leftover thought that should be removed after you instead split things?

leftover :)

"While there, polish headline decorations"

You're reading my distracted mind.

#8 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

In reply to Markus Armbruster
Quoted 12 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

Quoted 8 lines

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

I find the "cores" pattern more confusing now :S

Quoted 11 lines
---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)
MAINTAINERS +0 -0
index edc260e503..196282d165 100644

MAINTAINERS T: git https://github.com/vivier/qemu.git trivial-patches · line 86

Quoted 5 lines
MAINTAINERS +1 -1
@@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
 
 Architecture support
 --------------------
-S390
+S390 general architecture support

OK

MAINTAINERS L: [email protected] · line 111

Quoted 9 lines
MAINTAINERS +1 -1
 M: Cornelia Huck <[email protected]>
 S: Supported
 F: default-configs/s390x-softmmu.mak
@@ -108,7 +108,7 @@ L: [email protected]
 
 Guest CPU cores (TCG):
 ----------------------
-Overall
+Overall CPU cores (TCG)

What about "TCG (Overall)"?

MAINTAINERS F: fpu/ · line 136

Quoted 9 lines
MAINTAINERS +1 -1
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
@@ -133,14 +133,14 @@ F: fpu/
 F: include/fpu/
 F: tests/fp/
 
-Alpha
+Alpha CPU cores (TCG)

I find "cores" confusing here, why not use "Alpha CPU (TCG)"?

MAINTAINERS F: fpu/ · line 143

Quoted 8 lines
MAINTAINERS +1 -1
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/alpha/
 F: tests/tcg/alpha/
 F: disas/alpha.c
 
-ARM
+ARM CPU cores (TCG)

Ditto.

Quoted 160 lines
MAINTAINERS +18 -18
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
@@ -161,7 +161,7 @@ S: Maintained
 F: hw/arm/smmu*
 F: include/hw/arm/smmu*
 
-CRIS
+CRIS CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/cris/
@@ -170,14 +170,14 @@ F: include/hw/cris/
 F: tests/tcg/cris/
 F: disas/cris.c
 
-HPPA (PA-RISC)
+HPPA (PA-RISC) CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/hppa/
 F: hw/hppa/
 F: disas/hppa.c
 
-LM32
+LM32 CPU cores (TCG)
 M: Michael Walle <[email protected]>
 S: Maintained
 F: target/lm32/
@@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
 F: include/hw/lm32/
 F: tests/tcg/lm32/
 
-M68K
+M68K CPU cores (TCG)
 M: Laurent Vivier <[email protected]>
 S: Maintained
 F: target/m68k/
 F: disas/m68k.c
 
-MicroBlaze
+MicroBlaze CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/microblaze/
 F: hw/microblaze/
 F: disas/microblaze.c
 
-MIPS
+MIPS CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 M: Aleksandar Markovic <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
@@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
 F: tests/tcg/mips/
 K: ^Subject:.*(?i)mips
 
-Moxie
+Moxie CPU cores (TCG)
 M: Anthony Green <[email protected]>
 S: Maintained
 F: target/moxie/
@@ -232,7 +232,7 @@ F: disas/moxie.c
 F: hw/moxie/
 F: default-configs/moxie-softmmu.mak
 
-NiosII
+NiosII CPU cores (TCG)
 M: Chris Wulff <[email protected]>
 M: Marek Vasut <[email protected]>
 S: Maintained
@@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
 F: disas/nios2.c
 F: default-configs/nios2-softmmu.mak
 
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/
 
-PowerPC
+PowerPC CPU cores (TCG)
 M: David Gibson <[email protected]>
 L: [email protected]
 S: Maintained
@@ -258,7 +258,7 @@ F: hw/ppc/
 F: include/hw/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V CPU cores (TCG)
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 M: Sagar Karandikar <[email protected]>
@@ -271,7 +271,7 @@ F: include/hw/riscv/
 F: linux-user/host/riscv32/
 F: linux-user/host/riscv64/
 
-S390
+S390 CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 M: David Hildenbrand <[email protected]>
 S: Maintained
@@ -281,7 +281,7 @@ F: disas/s390.c
 F: tests/tcg/s390x/
 L: [email protected]
 
-SH4
+SH4 CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 S: Odd Fixes
 F: target/sh4/
@@ -289,7 +289,7 @@ F: hw/sh4/
 F: disas/sh4.c
 F: include/hw/sh4/
 
-SPARC
+SPARC CPU cores (TCG)
 M: Mark Cave-Ayland <[email protected]>
 M: Artyom Tarasenko <[email protected]>
 S: Maintained
@@ -299,14 +299,14 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
-UniCore32
+UniCore32 CPU cores (TCG)
 M: Guan Xuetao <[email protected]>
 S: Maintained
 F: target/unicore32/
 F: hw/unicore32/
 F: include/hw/unicore32/
 
-X86
+X86 CPU cores (TCG)
 M: Paolo Bonzini <[email protected]>
 M: Richard Henderson <[email protected]>
 M: Eduardo Habkost <[email protected]>
@@ -319,7 +319,7 @@ F: disas/i386.c
 F: docs/qemu-cpu-models.texi
 T: git https://github.com/ehabkost/qemu.git x86-next
 
-Xtensa
+Xtensa CPU cores (TCG)
 M: Max Filippov <[email protected]>
 W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
 S: Maintained
@@ -330,7 +330,7 @@ F: disas/xtensa.c
 F: include/hw/xtensa/xtensa-isa.h
 F: default-configs/xtensa*.mak
 
-TriCore
+TriCore CPU cores (TCG)
 M: Bastian Koppelmann <[email protected]>
 S: Maintained
 F: target/tricore/

MAINTAINERS F: tests/tcg/multiarch/ · line 348

Quoted 5 lines
MAINTAINERS +1 -1
@@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
 Guest CPU Cores (KVM):
 ----------------------
 
-Overall
+Overall CPU cores (KVM)

"KVM (Overall)"?

MAINTAINERS F: include/hw/kvm/ · line 359

Quoted 9 lines
MAINTAINERS +1 -1
 M: Paolo Bonzini <[email protected]>
 L: [email protected]
 S: Supported
@@ -356,24 +356,24 @@ F: include/hw/kvm/
 F: include/sysemu/kvm*.h
 F: scripts/kvm/kvm_flightrecorder
 
-ARM
+ARM CPU cores (KVM)

"ARM CPU (KVM)"?

Quoted 42 lines
MAINTAINERS +5 -5
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: target/arm/kvm.c
 
-MIPS
+MIPS CPU cores (KVM)
 M: James Hogan <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: target/mips/kvm.c
 
-PPC
+PPC CPU cores (KVM)
 M: David Gibson <[email protected]>
 S: Maintained
 F: target/ppc/kvm.c
 
-S390
+S390 CPU cores (KVM)
 M: Halil Pasic <[email protected]>
 M: Cornelia Huck <[email protected]>
 M: Christian Borntraeger <[email protected]>
@@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
 T: git https://github.com/borntraeger/qemu.git s390-next
 L: [email protected]
 
-X86
+X86 CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 M: Marcelo Tosatti <[email protected]>
 L: [email protected]
@@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
 Guest CPU Cores (Xen):
 ----------------------
 
-X86
+X86 CPU cores (Xen)
 M: Stefano Stabellini <[email protected]>
 M: Anthony Perard <[email protected]>
 M: Paul Durrant <[email protected]>

MAINTAINERS F: tests/uefi-test-tools/ · line 2259

Quoted 5 lines
MAINTAINERS +1 -1
@@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
 
 Usermode Emulation
 ------------------
-Overall
+Overall usermode emulation

"Usermode Emulation (Overall)"?

Quoted 75 lines
MAINTAINERS +9 -9
 M: Riku Voipio <[email protected]>
 S: Maintained
 F: thunk.c
@@ -2282,7 +2282,7 @@ M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/
 
-AArch64 target
+AArch64 TCG target
 M: Claudio Fontana <[email protected]>
 M: Claudio Fontana <[email protected]>
 S: Maintained
@@ -2291,33 +2291,33 @@ F: tcg/aarch64/
 F: disas/arm-a64.cc
 F: disas/libvixl/
 
-ARM target
+ARM TCG target
 M: Andrzej Zaborowski <[email protected]>
 S: Maintained
 L: [email protected]
 F: tcg/arm/
 F: disas/arm.c
 
-i386 target
+i386 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
 
-MIPS target
+MIPS TCG target
 M: Aurelien Jarno <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: tcg/mips/
 F: disas/mips.c
 
-PPC
+PPC TCG target
 M: Richard Henderson <[email protected]>
 S: Odd Fixes
 F: tcg/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V TCG target
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 L: [email protected]
@@ -2325,19 +2325,19 @@ S: Maintained
 F: tcg/riscv/
 F: disas/riscv.c
 
-S390 target
+S390 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/s390/
 F: disas/s390.c
 L: [email protected]
 
-SPARC target
+SPARC TCG target
 S: Odd Fixes
 F: tcg/sparc/
 F: disas/sparc.c
 
-TCI target
+TCI TCG target
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: tcg/tci/
#9 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 15 lines · Philippe Mathieu-Daudé
Quoted 14 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

Quoted 8 lines
Quoted 6 lines

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

I find the "cores" pattern more confusing now :S

Then let's find less confusing headlines together.

Quoted 23 lines
Quoted 10 lines
---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)
MAINTAINERS +0 -0
index edc260e503..196282d165 100644

MAINTAINERS T: git https://github.com/vivier/qemu.git trivial-patches · line 86

Quoted 5 lines
MAINTAINERS +1 -1
@@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
 
 Architecture support
 --------------------
-S390
+S390 general architecture support

OK

Quoted 5 lines
MAINTAINERS +0 -0
 M: Cornelia Huck <[email protected]>
 S: Supported
 F: default-configs/s390x-softmmu.mak
@@ -108,7 +108,7 @@ L: [email protected]
 
Quoted 6 lines

MAINTAINERS L: [email protected] · line 111

Quoted 4 lines
MAINTAINERS +1 -1
 Guest CPU cores (TCG):
 ----------------------
-Overall
+Overall CPU cores (TCG)

What about "TCG (Overall)"?

Could be confused with the stuff under "Tiny Code Generator (TCG)" below.

"Overall CPUs (TCG)"?

"TCG CPUs (overall)"?

Quoted 11 lines

MAINTAINERS F: fpu/ · line 136

Quoted 9 lines
MAINTAINERS +1 -1
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
@@ -133,14 +133,14 @@ F: fpu/
 F: include/fpu/
 F: tests/fp/
 
-Alpha
+Alpha CPU cores (TCG)

I find "cores" confusing here, why not use "Alpha CPU (TCG)"?

"Alpha CPUs (TCG)"?

"TCG Alpha CPUs"?

Same for KVM and Xen below.

Quoted 234 lines

MAINTAINERS F: fpu/ · line 143

Quoted 8 lines
MAINTAINERS +1 -1
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/alpha/
 F: tests/tcg/alpha/
 F: disas/alpha.c
 
-ARM
+ARM CPU cores (TCG)

Ditto.

Quoted 160 lines
MAINTAINERS +18 -18
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
@@ -161,7 +161,7 @@ S: Maintained
 F: hw/arm/smmu*
 F: include/hw/arm/smmu*
 
-CRIS
+CRIS CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/cris/
@@ -170,14 +170,14 @@ F: include/hw/cris/
 F: tests/tcg/cris/
 F: disas/cris.c
 
-HPPA (PA-RISC)
+HPPA (PA-RISC) CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/hppa/
 F: hw/hppa/
 F: disas/hppa.c
 
-LM32
+LM32 CPU cores (TCG)
 M: Michael Walle <[email protected]>
 S: Maintained
 F: target/lm32/
@@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
 F: include/hw/lm32/
 F: tests/tcg/lm32/
 
-M68K
+M68K CPU cores (TCG)
 M: Laurent Vivier <[email protected]>
 S: Maintained
 F: target/m68k/
 F: disas/m68k.c
 
-MicroBlaze
+MicroBlaze CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/microblaze/
 F: hw/microblaze/
 F: disas/microblaze.c
 
-MIPS
+MIPS CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 M: Aleksandar Markovic <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
@@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
 F: tests/tcg/mips/
 K: ^Subject:.*(?i)mips
 
-Moxie
+Moxie CPU cores (TCG)
 M: Anthony Green <[email protected]>
 S: Maintained
 F: target/moxie/
@@ -232,7 +232,7 @@ F: disas/moxie.c
 F: hw/moxie/
 F: default-configs/moxie-softmmu.mak
 
-NiosII
+NiosII CPU cores (TCG)
 M: Chris Wulff <[email protected]>
 M: Marek Vasut <[email protected]>
 S: Maintained
@@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
 F: disas/nios2.c
 F: default-configs/nios2-softmmu.mak
 
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/
 
-PowerPC
+PowerPC CPU cores (TCG)
 M: David Gibson <[email protected]>
 L: [email protected]
 S: Maintained
@@ -258,7 +258,7 @@ F: hw/ppc/
 F: include/hw/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V CPU cores (TCG)
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 M: Sagar Karandikar <[email protected]>
@@ -271,7 +271,7 @@ F: include/hw/riscv/
 F: linux-user/host/riscv32/
 F: linux-user/host/riscv64/
 
-S390
+S390 CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 M: David Hildenbrand <[email protected]>
 S: Maintained
@@ -281,7 +281,7 @@ F: disas/s390.c
 F: tests/tcg/s390x/
 L: [email protected]
 
-SH4
+SH4 CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 S: Odd Fixes
 F: target/sh4/
@@ -289,7 +289,7 @@ F: hw/sh4/
 F: disas/sh4.c
 F: include/hw/sh4/
 
-SPARC
+SPARC CPU cores (TCG)
 M: Mark Cave-Ayland <[email protected]>
 M: Artyom Tarasenko <[email protected]>
 S: Maintained
@@ -299,14 +299,14 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
-UniCore32
+UniCore32 CPU cores (TCG)
 M: Guan Xuetao <[email protected]>
 S: Maintained
 F: target/unicore32/
 F: hw/unicore32/
 F: include/hw/unicore32/
 
-X86
+X86 CPU cores (TCG)
 M: Paolo Bonzini <[email protected]>
 M: Richard Henderson <[email protected]>
 M: Eduardo Habkost <[email protected]>
@@ -319,7 +319,7 @@ F: disas/i386.c
 F: docs/qemu-cpu-models.texi
 T: git https://github.com/ehabkost/qemu.git x86-next
 
-Xtensa
+Xtensa CPU cores (TCG)
 M: Max Filippov <[email protected]>
 W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
 S: Maintained
@@ -330,7 +330,7 @@ F: disas/xtensa.c
 F: include/hw/xtensa/xtensa-isa.h
 F: default-configs/xtensa*.mak
 
-TriCore
+TriCore CPU cores (TCG)
 M: Bastian Koppelmann <[email protected]>
 S: Maintained
 F: target/tricore/

MAINTAINERS F: tests/tcg/multiarch/ · line 348

Quoted 5 lines
MAINTAINERS +1 -1
@@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
 Guest CPU Cores (KVM):
 ----------------------
 
-Overall
+Overall CPU cores (KVM)

"KVM (Overall)"?

MAINTAINERS F: include/hw/kvm/ · line 359

Quoted 9 lines
MAINTAINERS +1 -1
 M: Paolo Bonzini <[email protected]>
 L: [email protected]
 S: Supported
@@ -356,24 +356,24 @@ F: include/hw/kvm/
 F: include/sysemu/kvm*.h
 F: scripts/kvm/kvm_flightrecorder
 
-ARM
+ARM CPU cores (KVM)

"ARM CPU (KVM)"?

Quoted 43 lines
MAINTAINERS +5 -5
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: target/arm/kvm.c
 
-MIPS
+MIPS CPU cores (KVM)
 M: James Hogan <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: target/mips/kvm.c
 
-PPC
+PPC CPU cores (KVM)
 M: David Gibson <[email protected]>
 S: Maintained
 F: target/ppc/kvm.c
 
-S390
+S390 CPU cores (KVM)
 M: Halil Pasic <[email protected]>
 M: Cornelia Huck <[email protected]>
 M: Christian Borntraeger <[email protected]>
@@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
 T: git https://github.com/borntraeger/qemu.git s390-next
 L: [email protected]
 
-X86
+X86 CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 M: Marcelo Tosatti <[email protected]>
 L: [email protected]
@@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
 Guest CPU Cores (Xen):
 ----------------------
 
-X86
+X86 CPU cores (Xen)
 M: Stefano Stabellini <[email protected]>
 M: Anthony Perard <[email protected]>
 M: Paul Durrant <[email protected]>
@@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
 
Quoted 6 lines

MAINTAINERS F: tests/uefi-test-tools/ · line 2259

Quoted 4 lines
MAINTAINERS +1 -1
 Usermode Emulation
 ------------------
-Overall
+Overall usermode emulation

"Usermode Emulation (Overall)"?

Works for me.

Quoted 4 lines

MAINTAINERS M: Richard Henderson <[email protected]>

Quoted 4 lines
MAINTAINERS +0 -0
 M: Riku Voipio <[email protected]>
 S: Maintained
 F: thunk.c
@@ -2282,7 +2282,7 @@ M: Richard Henderson <[email protected]>

Missed one:

Tiny Code Generator (TCG)
-------------------------
Common code

Something like "TCG common code" should do.

M: Richard Henderson <[email protected]>

Quoted 71 lines
Quoted 71 lines
MAINTAINERS +9 -9
 S: Maintained
 F: tcg/
 
-AArch64 target
+AArch64 TCG target
 M: Claudio Fontana <[email protected]>
 M: Claudio Fontana <[email protected]>
 S: Maintained
@@ -2291,33 +2291,33 @@ F: tcg/aarch64/
 F: disas/arm-a64.cc
 F: disas/libvixl/
 
-ARM target
+ARM TCG target
 M: Andrzej Zaborowski <[email protected]>
 S: Maintained
 L: [email protected]
 F: tcg/arm/
 F: disas/arm.c
 
-i386 target
+i386 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
 
-MIPS target
+MIPS TCG target
 M: Aurelien Jarno <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: tcg/mips/
 F: disas/mips.c
 
-PPC
+PPC TCG target
 M: Richard Henderson <[email protected]>
 S: Odd Fixes
 F: tcg/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V TCG target
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 L: [email protected]
@@ -2325,19 +2325,19 @@ S: Maintained
 F: tcg/riscv/
 F: disas/riscv.c
 
-S390 target
+S390 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/s390/
 F: disas/s390.c
 L: [email protected]
 
-SPARC target
+SPARC TCG target
 S: Odd Fixes
 F: tcg/sparc/
 F: disas/sparc.c
 
-TCI target
+TCI TCG target
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: tcg/tci/
#10 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

In reply to Markus Armbruster
Quoted 9 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Quoted 8 lines

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

In its essence definitely not a bad idea, but I must admit I tend to agree with Philippe the new titles sound confusing, odd, artificial. Perhaps the better alternative could be:

“FOO TCG guest”
“FOO KVM guest”
“FOO Xen guest”

Quoted 3 lines

* "Architecture support" from "FOO" to "FOO general architecture support"

Here we have a kind of strange situation with S390 architecture - it is the only one present in this way in MAINTAINERS. Othrr than that, your new wording looks fine to me.

Quoted 2 lines

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

I think this one you got it right.

Yours,
Aleksandar

MAINTAINERS T: git https://github.com/vivier/qemu.git

Quoted 12 lines
---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)
MAINTAINERS +0 -0
index edc260e503..196282d165 100644
@@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git

trivial-patches

Quoted 330 lines
MAINTAINERS +39 -40
 Architecture support
 --------------------
-S390
+S390 general architecture support
 M: Cornelia Huck <[email protected]>
 S: Supported
 F: default-configs/s390x-softmmu.mak
@@ -108,7 +108,7 @@ L: [email protected]
 
 Guest CPU cores (TCG):
 ----------------------
-Overall
+Overall CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
 S: Maintained
@@ -133,14 +133,14 @@ F: fpu/
 F: include/fpu/
 F: tests/fp/
 
-Alpha
+Alpha CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/alpha/
 F: tests/tcg/alpha/
 F: disas/alpha.c
 
-ARM
+ARM CPU cores (TCG)
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
@@ -161,7 +161,7 @@ S: Maintained
 F: hw/arm/smmu*
 F: include/hw/arm/smmu*
 
-CRIS
+CRIS CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/cris/
@@ -170,14 +170,14 @@ F: include/hw/cris/
 F: tests/tcg/cris/
 F: disas/cris.c
 
-HPPA (PA-RISC)
+HPPA (PA-RISC) CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: target/hppa/
 F: hw/hppa/
 F: disas/hppa.c
 
-LM32
+LM32 CPU cores (TCG)
 M: Michael Walle <[email protected]>
 S: Maintained
 F: target/lm32/
@@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
 F: include/hw/lm32/
 F: tests/tcg/lm32/
 
-M68K
+M68K CPU cores (TCG)
 M: Laurent Vivier <[email protected]>
 S: Maintained
 F: target/m68k/
 F: disas/m68k.c
 
-MicroBlaze
+MicroBlaze CPU cores (TCG)
 M: Edgar E. Iglesias <[email protected]>
 S: Maintained
 F: target/microblaze/
 F: hw/microblaze/
 F: disas/microblaze.c
 
-MIPS
+MIPS CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 M: Aleksandar Markovic <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
@@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
 F: tests/tcg/mips/
 K: ^Subject:.*(?i)mips
 
-Moxie
+Moxie CPU cores (TCG)
 M: Anthony Green <[email protected]>
 S: Maintained
 F: target/moxie/
@@ -232,7 +232,7 @@ F: disas/moxie.c
 F: hw/moxie/
 F: default-configs/moxie-softmmu.mak
 
-NiosII
+NiosII CPU cores (TCG)
 M: Chris Wulff <[email protected]>
 M: Marek Vasut <[email protected]>
 S: Maintained
@@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
 F: disas/nios2.c
 F: default-configs/nios2-softmmu.mak
 
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/
 
-PowerPC
+PowerPC CPU cores (TCG)
 M: David Gibson <[email protected]>
 L: [email protected]
 S: Maintained
@@ -258,7 +258,7 @@ F: hw/ppc/
 F: include/hw/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V CPU cores (TCG)
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 M: Sagar Karandikar <[email protected]>
@@ -271,7 +271,7 @@ F: include/hw/riscv/
 F: linux-user/host/riscv32/
 F: linux-user/host/riscv64/
 
-S390
+S390 CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 M: David Hildenbrand <[email protected]>
 S: Maintained
@@ -281,7 +281,7 @@ F: disas/s390.c
 F: tests/tcg/s390x/
 L: [email protected]
 
-SH4
+SH4 CPU cores (TCG)
 M: Aurelien Jarno <[email protected]>
 S: Odd Fixes
 F: target/sh4/
@@ -289,7 +289,7 @@ F: hw/sh4/
 F: disas/sh4.c
 F: include/hw/sh4/
 
-SPARC
+SPARC CPU cores (TCG)
 M: Mark Cave-Ayland <[email protected]>
 M: Artyom Tarasenko <[email protected]>
 S: Maintained
@@ -299,14 +299,14 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
-UniCore32
+UniCore32 CPU cores (TCG)
 M: Guan Xuetao <[email protected]>
 S: Maintained
 F: target/unicore32/
 F: hw/unicore32/
 F: include/hw/unicore32/
 
-X86
+X86 CPU cores (TCG)
 M: Paolo Bonzini <[email protected]>
 M: Richard Henderson <[email protected]>
 M: Eduardo Habkost <[email protected]>
@@ -319,7 +319,7 @@ F: disas/i386.c
 F: docs/qemu-cpu-models.texi
 T: git https://github.com/ehabkost/qemu.git x86-next
 
-Xtensa
+Xtensa CPU cores (TCG)
 M: Max Filippov <[email protected]>
 W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
 S: Maintained
@@ -330,7 +330,7 @@ F: disas/xtensa.c
 F: include/hw/xtensa/xtensa-isa.h
 F: default-configs/xtensa*.mak
 
-TriCore
+TriCore CPU cores (TCG)
 M: Bastian Koppelmann <[email protected]>
 S: Maintained
 F: target/tricore/
@@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
 Guest CPU Cores (KVM):
 ----------------------
 
-Overall
+Overall CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 L: [email protected]
 S: Supported
@@ -356,24 +356,24 @@ F: include/hw/kvm/
 F: include/sysemu/kvm*.h
 F: scripts/kvm/kvm_flightrecorder
 
-ARM
+ARM CPU cores (KVM)
 M: Peter Maydell <[email protected]>
 L: [email protected]
 S: Maintained
 F: target/arm/kvm.c
 
-MIPS
+MIPS CPU cores (KVM)
 M: James Hogan <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: target/mips/kvm.c
 
-PPC
+PPC CPU cores (KVM)
 M: David Gibson <[email protected]>
 S: Maintained
 F: target/ppc/kvm.c
 
-S390
+S390 CPU cores (KVM)
 M: Halil Pasic <[email protected]>
 M: Cornelia Huck <[email protected]>
 M: Christian Borntraeger <[email protected]>
@@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
 T: git https://github.com/borntraeger/qemu.git s390-next
 L: [email protected]
 
-X86
+X86 CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 M: Marcelo Tosatti <[email protected]>
 L: [email protected]
@@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
 Guest CPU Cores (Xen):
 ----------------------
 
-X86
+X86 CPU cores (Xen)
 M: Stefano Stabellini <[email protected]>
 M: Anthony Perard <[email protected]>
 M: Paul Durrant <[email protected]>
@@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
 
 Usermode Emulation
 ------------------
-Overall
+Overall usermode emulation
 M: Riku Voipio <[email protected]>
 S: Maintained
 F: thunk.c
@@ -2282,7 +2282,7 @@ M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/
 
-AArch64 target
+AArch64 TCG target
 M: Claudio Fontana <[email protected]>
 M: Claudio Fontana <[email protected]>
 S: Maintained
@@ -2291,33 +2291,33 @@ F: tcg/aarch64/
 F: disas/arm-a64.cc
 F: disas/libvixl/
 
-ARM target
+ARM TCG target
 M: Andrzej Zaborowski <[email protected]>
 S: Maintained
 L: [email protected]
 F: tcg/arm/
 F: disas/arm.c
 
-i386 target
+i386 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
 
-MIPS target
+MIPS TCG target
 M: Aurelien Jarno <[email protected]>
 R: Aleksandar Rikalo <[email protected]>
 S: Maintained
 F: tcg/mips/
 F: disas/mips.c
 
-PPC
+PPC TCG target
 M: Richard Henderson <[email protected]>
 S: Odd Fixes
 F: tcg/ppc/
 F: disas/ppc.c
 
-RISC-V
+RISC-V TCG target
 M: Palmer Dabbelt <[email protected]>
 M: Alistair Francis <[email protected]>
 L: [email protected]
@@ -2325,19 +2325,19 @@ S: Maintained
 F: tcg/riscv/
 F: disas/riscv.c
 
-S390 target
+S390 TCG target
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/s390/
 F: disas/s390.c
 L: [email protected]
 
-SPARC target
+SPARC TCG target
 S: Odd Fixes
 F: tcg/sparc/
 F: disas/sparc.c
 
-TCI target
+TCI TCG target
 M: Stefan Weil <[email protected]>
 S: Maintained
 F: tcg/tci/
--

2.17.2

#11 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 19 lines · Aleksandar Markovic
Quoted 9 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Quoted 8 lines

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

Quoted 7 lines

In its essence definitely not a bad idea, but I must admit I tend to agree with Philippe the new titles sound confusing, odd, artificial. Perhaps the better alternative could be:

“FOO TCG guest”
“FOO KVM guest”
“FOO Xen guest”

Other suggestions mentioned so far:

"FOO CPUs (TCG)"
"TCG FOO CPUs"

and same for KVM and Xen.

I guess mentioning target first, accelerator second, no parenthesis makes sense. That leaves "guest" vs. "CPUs". Which one's closer to the truth?

Quoted 7 lines
Quoted 3 lines

* "Architecture support" from "FOO" to "FOO general architecture support"

Here we have a kind of strange situation with S390 architecture - it is the only one present in this way in MAINTAINERS. Othrr than that, your new wording looks fine to me.

Yes, it's odd. But it's what works for the S390 maintainers.

Quoted 4 lines
Quoted 2 lines

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

I think this one you got it right.

Thanks!

#12 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 31 lines · On Mon, 03 Jun 2019 10:29:35 +0200 Markus Armbruster <[email protected]> wrote:
Quoted 19 lines · Aleksandar Markovic
Quoted 9 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Quoted 8 lines

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

Quoted 7 lines

In its essence definitely not a bad idea, but I must admit I tend to agree with Philippe the new titles sound confusing, odd, artificial. Perhaps the better alternative could be:

“FOO TCG guest”
“FOO KVM guest”
“FOO Xen guest”

Other suggestions mentioned so far:

Quoted 8 lines

"FOO CPUs (TCG)"
"TCG FOO CPUs"

and same for KVM and Xen.

I guess mentioning target first, accelerator second, no parenthesis makes sense. That leaves "guest" vs. "CPUs". Which one's closer to the truth?

'CPUs' makes more sense to me; 'guest' would also include (architecture-specific) emulated devices.

Quoted 10 lines
Quoted 8 lines
Quoted 4 lines

* "Architecture support" from "FOO" to "FOO general architecture support"

Here we have a kind of strange situation with S390 architecture - it is the only one present in this way in MAINTAINERS. Othrr than that, your new wording looks fine to me.

Yes, it's odd. But it's what works for the S390 maintainers.

Yes. I basically integrate all s390 stuff, including pull requests from others. I'm more wondering why other architectures don't do that as well :) Different setup, I guess.

#13 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

In reply to Markus Armbruster
Quoted 27 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

...

MAINTAINERS F: hw/intc/nios2_iic.c · line 250

Quoted 8 lines
MAINTAINERS +1 -1
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/

As directories listed there I look over both target/ (TCG?) and hw/. Would it be better to be 'OpenRISC general architecture'?

-Stafford

#14 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 31 lines · Stafford Horne
Quoted 27 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

...

Quoted 10 lines

MAINTAINERS F: hw/intc/nios2_iic.c · line 250

Quoted 8 lines
MAINTAINERS +1 -1
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/

As directories listed there I look over both target/ (TCG?) and hw/.

Same for ARM, LM32, MicroBlaze, MIPS, Moxie, ...

Quoted 1 line

Would it be better to be 'OpenRISC general architecture'?

Valid question. Peter, do you have an opinion?

#15 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

In reply to Stafford Horne
Quoted 31 lines · Stafford Horne
Quoted 27 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

...

Quoted 11 lines

MAINTAINERS F: hw/intc/nios2_iic.c · line 250

Quoted 8 lines
MAINTAINERS +1 -1
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/

As directories listed there I look over both target/ (TCG?) and hw/. Would it be better to be 'OpenRISC general architecture'?

There is a historical separation between target/ and hw/ because they cover different concepts, and have different maintainers/reviewers.

- target/$arch/ is for TCG/KVM
- hw/ is for machines and their devices
(some devices are reused by multiple archs)

Although the separation is not always clear (some devices are tied to an architecture, some architecture instruction directly access devices) I'd prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer of both). This will ease developper with specific background/interests to volunteer to a particular section.

Regards,

Phil.

#16 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 51 lines · Philippe Mathieu-Daudé
Quoted 31 lines · Stafford Horne
Quoted 27 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

...

Quoted 11 lines

MAINTAINERS F: hw/intc/nios2_iic.c · line 250

Quoted 8 lines
MAINTAINERS +1 -1
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/

As directories listed there I look over both target/ (TCG?) and hw/. Would it be better to be 'OpenRISC general architecture'?

There is a historical separation between target/ and hw/ because they cover different concepts, and have different maintainers/reviewers.

- target/$arch/ is for TCG/KVM
- hw/ is for machines and their devices
(some devices are reused by multiple archs)

Quoted 5 lines

Although the separation is not always clear (some devices are tied to an architecture, some architecture instruction directly access devices) I'd prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer of both). This will ease developper with specific background/interests to volunteer to a particular section.

Hello,

Thanks for the explaination. I think it makes sense to have 2 different maintainer sections. In that case should this patch be amended to move the 'F: hw/openrisc/' etc out to a different section with the different header?

-Stafford

#17 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 58 lines · Stafford Horne
Quoted 51 lines · Philippe Mathieu-Daudé
Quoted 31 lines · Stafford Horne
Quoted 27 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

...

Quoted 11 lines

MAINTAINERS F: hw/intc/nios2_iic.c · line 250

Quoted 8 lines
MAINTAINERS +1 -1
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/

As directories listed there I look over both target/ (TCG?) and hw/. Would it be better to be 'OpenRISC general architecture'?

There is a historical separation between target/ and hw/ because they cover different concepts, and have different maintainers/reviewers.

- target/$arch/ is for TCG/KVM
- hw/ is for machines and their devices
(some devices are reused by multiple archs)

Quoted 5 lines

Although the separation is not always clear (some devices are tied to an architecture, some architecture instruction directly access devices) I'd prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer of both). This will ease developper with specific background/interests to volunteer to a particular section.

Quoted 5 lines

Hello,

Thanks for the explaination. I think it makes sense to have 2 different maintainer sections. In that case should this patch be amended to move the 'F: hw/openrisc/' etc out to a different section with the different header?

This patch merely improves headlines. Splitting up the OpenRISC section above should be separate. Care to send the patch?

#18 lore raw

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

Quoted 60 lines · Markus Armbruster
Quoted 58 lines · Stafford Horne
Quoted 56 lines · Philippe Mathieu-Daudé
Quoted 31 lines · Stafford Horne
Quoted 27 lines · Markus Armbruster

When scripts/get_maintainer.pl reports something like

John Doe <[email protected]> (maintainer:Overall)

the user is left to wonder *which* of our three "Overall" sections applies. We have three, one each under "Guest CPU cores (TCG)", "Guest CPU Cores (KVM)", and "Overall usermode emulation".

Rename sections under

* "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"

* "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"

* "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"

* "Architecture support" from "FOO" to "FOO general architecture support"

* "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"

While there,

---
 MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

...

Quoted 11 lines

MAINTAINERS F: hw/intc/nios2_iic.c · line 250

Quoted 8 lines
MAINTAINERS +1 -1
-OpenRISC
+OpenRISC CPU cores (TCG)
 M: Stafford Horne <[email protected]>
 S: Odd Fixes
 F: target/openrisc/
 F: hw/openrisc/
 F: tests/tcg/openrisc/

As directories listed there I look over both target/ (TCG?) and hw/. Would it be better to be 'OpenRISC general architecture'?

There is a historical separation between target/ and hw/ because they cover different concepts, and have different maintainers/reviewers.

- target/$arch/ is for TCG/KVM
- hw/ is for machines and their devices
(some devices are reused by multiple archs)

Although the separation is not always clear (some devices are tied to an architecture, some architecture instruction directly access devices) I'd prefer we keep 2 distincts MAINTAINERS sections (keeping you maintainer of both). This will ease developper with specific background/interests to volunteer to a particular section.

Quoted 8 lines
Quoted 5 lines

Hello,

Thanks for the explaination. I think it makes sense to have 2 different maintainer sections. In that case should this patch be amended to move the 'F: hw/openrisc/' etc out to a different section with the different header?

This patch merely improves headlines. Splitting up the OpenRISC section above should be separate. Care to send the patch?

Sure, now that I look at it, there is a section for 'OpenRISC Machines' and the maintainer is out of date.

-Stafford

#19 lore raw

PATCH 3/3 MAINTAINERS: Polish headline decorations

In reply to Markus Armbruster
---
 MAINTAINERS | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)
MAINTAINERS +11 -13
index 196282d165..f8a5a3d448 100644
@@ -65,7 +65,7 @@ F: *
 F: */
 
 Responsible Disclosure, Reporting Security Issues
-------------------------------
+-------------------------------------------------
 W: https://wiki.qemu.org/SecurityProcess
 M: Michael S. Tsirkin <[email protected]>
 L: [email protected]
@@ -106,8 +106,8 @@ K: ^Subject:.*(?i)s390x?
 T: git https://github.com/cohuck/qemu.git s390-next
 L: [email protected]
 
-Guest CPU cores (TCG):
-----------------------
+Guest CPU cores (TCG)
+---------------------
 Overall CPU cores (TCG)
 M: Richard Henderson <[email protected]>
 R: Paolo Bonzini <[email protected]>
@@ -342,9 +342,8 @@ M: Alex Bennée <[email protected]>
 S: Maintained
 F: tests/tcg/multiarch/
 
-Guest CPU Cores (KVM):
-----------------------
-
+Guest CPU Cores (KVM)
+---------------------
 Overall CPU cores (KVM)
 M: Paolo Bonzini <[email protected]>
 L: [email protected]
@@ -400,9 +399,8 @@ S: Supported
 F: target/i386/kvm.c
 F: scripts/kvm/vmxcap
 
-Guest CPU Cores (Xen):
-----------------------
-
+Guest CPU Cores (Xen)
+---------------------
 X86 CPU cores (Xen)
 M: Stefano Stabellini <[email protected]>
 M: Anthony Perard <[email protected]>
@@ -423,9 +421,8 @@ F: include/hw/block/dataplane/xen*
 F: include/hw/xen/
 F: include/sysemu/xen-mapcache.h
 
-Hosts:
-------
-
+Hosts
+-----
 LINUX
 M: Michael S. Tsirkin <[email protected]>
 M: Cornelia Huck <[email protected]>
@@ -462,6 +459,7 @@ X: qga/*win32*
 F: qemu.nsi
 
 Alpha Machines
+--------------
 M: Richard Henderson <[email protected]>
 S: Maintained
 F: hw/alpha/
@@ -1196,7 +1194,7 @@ F: hw/s390x/s390-pci*
 L: [email protected]
 
 UniCore32 Machines
--------------
+------------------
 PKUnity-3 SoC initramfs-with-busybox
 M: Guan Xuetao <[email protected]>
 S: Maintained
Signature · 1 line
2.17.2