Skip to contentSkip to conversation

ath11k: Avoid frequency offset based sanity check in radar detection event

PATCH In review Sriram R 2 participants 2 messages May 27, 2019 – May 29, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore

Sriram R

author
#0 lore raw

PATCH 1/1 ath11k: Avoid frequency offset based sanity check in radar detection event

Currently the detected radar is indicated to mac80211 only when the active rx channel is indicated in the event through channel frequency and offset. But in case there is a minor difference in this offset provided,say +/- 1, the event will rejected.

Hence avoid having these checks to indicate radar to mac80211. Basically the event from firmware is highly reliable and such sanity checks are not necessary.

---
 drivers/net/wireless/ath/ath11k/wmi.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/net/wireless/ath/ath11k/wmi.c +1 -6
index 4f2ac21..90d9560 100644
@@ -5809,12 +5809,6 @@ ath11k_wmi_pdev_dfs_radar_detected_event(struct ath11k_base *ab,
 		goto exit;
 	}
 
-	if (ar->rx_channel && ar->rx_channel->center_freq != (ev->chan_freq
-	    - ev->freq_offset)) {
-		ath11k_warn(ab, "Radar detected in non-operating channel");
-		goto exit;
-	}
-
 	ath11k_dbg(ar->ab, ATH11K_DBG_REG, "DFS Radar Detected in pdev %d\n",
 		   ev->pdev_id);
 
@@ -5826,6 +5820,7 @@ ath11k_wmi_pdev_dfs_radar_detected_event(struct ath11k_base *ab,
 exit:
 	kfree(tb);
 }
+
 static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb)
 {
 	struct wmi_cmd_hdr *cmd_hdr;
Signature · 7 lines
2.7.4


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 10 lines · Sriram R

Currently the detected radar is indicated to mac80211 only when the active rx channel is indicated in the event through channel frequency and offset. But in case there is a minor difference in this offset provided,say +/- 1, the event will rejected.

Hence avoid having these checks to indicate radar to mac80211. Basically the event from firmware is highly reliable and such sanity checks are not necessary.

Patch applied to ath.git, thanks.

48177eb4fb0e ath11k: Avoid frequency offset based sanity check in radar detection event

Signature · 9 lines
https://patchwork.kernel.org/patch/10963033/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k