Skip to contentSkip to conversation

ath11k: Fix invalid dma address access in hal rx

PATCH In review Karthikeyan Periyasamy 2 participants 2 messages May 27, 2019 – May 29, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: Fix invalid dma address access in hal rx

ath11k_hal_rx_buf_addr_info_get() populating the MSB of the dma address from the info0 member, which is invalid. It has to populate the MSB from info1 member.

---
 drivers/net/wireless/ath/ath11k/hal_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/hal_rx.c +1 -1
index 6eb47d9..c37340f 100644
@@ -286,7 +286,7 @@ void ath11k_hal_rx_buf_addr_info_get(void *desc, dma_addr_t *paddr,
 	struct buffer_addr *binfo = (struct buffer_addr *)desc;
 
 	*paddr =
-		(((u64)FIELD_GET(BUFFER_ADDR_INFO1_ADDR, binfo->info0)) << 32) |
+		(((u64)FIELD_GET(BUFFER_ADDR_INFO1_ADDR, binfo->info1)) << 32) |
 		FIELD_GET(BUFFER_ADDR_INFO0_ADDR, binfo->info0);
 	*cookie = FIELD_GET(BUFFER_ADDR_INFO1_SW_COOKIE, binfo->info1);
 	*rbm = FIELD_GET(BUFFER_ADDR_INFO1_RET_BUF_MGR, binfo->info1);
Signature · 7 lines
1.9.1


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 5 lines · Karthikeyan Periyasamy

ath11k_hal_rx_buf_addr_info_get() populating the MSB of the dma address from the info0 member, which is invalid. It has to populate the MSB from info1 member.

Patch applied to ath.git, thanks.

911365b0f0a8 ath11k: Fix invalid dma address access in hal rx

Signature · 9 lines
https://patchwork.kernel.org/patch/10963087/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k