Skip to contentSkip to conversation

cmd: remove unused `display` command

PATCH New Heinrich Schuchardt 3 participants 3 messages May 21, 2019 – May 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: remove unused `display` command

Compiling the display command leads to an error

undefined reference to `display_set'

No implementation of display_set() exists in U-Boot.

Eliminate the display command as well as the accompanying files.

---
 cmd/Kconfig            |  8 -------
 cmd/Makefile           |  1 -
 cmd/display.c          | 53 ------------------------------------------
 doc/README.LED_display | 26 ---------------------
 include/led-display.h  | 18 --------------
 5 files changed, 106 deletions(-)
 delete mode 100644 cmd/display.c
 delete mode 100644 doc/README.LED_display
 delete mode 100644 include/led-display.h
cmd/Kconfig +0 -8
index 0d36da2a5c4..0badcb3fe00 100644
@@ -1425,14 +1425,6 @@ config CMD_CLS
 	  Enable the 'cls' command which clears the screen contents
 	  on video frame buffer.
 
-config CMD_DISPLAY
-	bool "Enable the 'display' command, for character displays"
-	help
-	  (this needs porting to driver model)
-	  This enables the 'display' command which allows a string to be
-	  displayed on a simple board-specific display. Implement
-	  display_putc() to use it.
-
 config CMD_EFIDEBUG
 	bool "efidebug - display/configure UEFI environment"
 	depends on EFI_LOADER
cmd/Makefile +0 -1
index 7864fcf95c3..f982564ab9f 100644
@@ -45,7 +45,6 @@ obj-$(CONFIG_CMD_SOUND) += sound.o
 ifdef CONFIG_POST
 obj-$(CONFIG_CMD_DIAG) += diag.o
 endif
-obj-$(CONFIG_CMD_DISPLAY) += display.o
 obj-$(CONFIG_CMD_DTIMG) += dtimg.o
 obj-$(CONFIG_CMD_ECHO) += echo.o
 obj-$(CONFIG_ENV_IS_IN_EEPROM) += eeprom.o
cmd/display.c deleted +0 -53

53 lines not on this page · raw message

doc/README.LED_display deleted +0 -26
deleted file mode 100644
index 19977ea7e0d..00000000000
@@ -1,26 +0,0 @@
-LED display internal API
-=======================================
-
-This README describes the LED display API.
-
-The API is defined by the include file include/led-display.h
-
-The first step in to define CONFIG_CMD_DISPLAY in the board config file.
-Then you need to provide the following functions to access LED display:
-
-void display_set(int cmd);
-
-This function should control the state of the LED display. Argument is
-an ORed combination of the following values:
- DISPLAY_CLEAR	-- clear the display
- DISPLAY_HOME	-- set the position to the beginning of display
-
-int display_putc(char c);
-
-This function should display it's parameter on the LED display in the
-current position. Returns the displayed character on success or -1 in
-case of failure.
-
-With this functions defined 'display' command will display it's
-arguments on the LED display (or clear the display if called without
-arguments).
include/led-display.h deleted +0 -18
deleted file mode 100644
index b21f3b05700..00000000000
@@ -1,18 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * (C) Copyright 2005-2010
- * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
- *
- * (C) Copyright 2010
- * Sergei Poselenov, Emcraft Systems, sposelenov at emcraft.com.
- */
-#ifndef _led_display_h_
-#define _led_display_h_
-
-/* Display Commands */
-#define DISPLAY_CLEAR	0x1 /* Clear the display */
-#define DISPLAY_HOME	0x2 /* Set cursor at home position */
-
-void display_set(int cmd);
-int display_putc(char c);
-#endif

--
2.20.1

#1 lore raw

PATCH 1/1 cmd: remove unused `display` command

Quoted 10 lines · Heinrich Schuchardt

Compiling the display command leads to an error

undefined reference to `display_set'

No implementation of display_set() exists in U-Boot.

Eliminate the display command as well as the accompanying files.

Quoted 10 lines
---
 cmd/Kconfig            |  8 -------
 cmd/Makefile           |  1 -
 cmd/display.c          | 53 ------------------------------------------
 doc/README.LED_display | 26 ---------------------
 include/led-display.h  | 18 --------------
 5 files changed, 106 deletions(-)
 delete mode 100644 cmd/display.c
 delete mode 100644 doc/README.LED_display
 delete mode 100644 include/led-display.h
#2 lore raw

PATCH 1/1 cmd: remove unused `display` command

In reply to Heinrich Schuchardt
Quoted 10 lines · Heinrich Schuchardt

Compiling the display command leads to an error

undefined reference to `display_set'

No implementation of display_set() exists in U-Boot.

Eliminate the display command as well as the accompanying files.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190529/516ddeee/attachment.sig>