Skip to contentSkip to conversation

ARM: dts: Drop bogus CLKSEL for timer12 on dra7

PATCH In review Tony Lindgren 3 participants 4 messages May 30, 2019 – Jun 11, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Drop bogus CLKSEL for timer12 on dra7

There is no CLKSEL for timer12 on dra6 unlike for timer1. This causes issues on booting the device that Tomi noticed if DEBUG_SLAB is enabled and the clkctrl clock does not properly handle non-existing clock. Let's drop the bogus CLKSEL clock, the clkctrl clock handling gets fixed separately.

Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Fixes 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
---
 arch/arm/boot/dts/dra7-l4.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/dra7-l4.dtsi +0 -2
@@ -4450,8 +4450,6 @@
 			timer12: timer@0 {
 				compatible = "ti,omap5430-timer";
 				reg = <0x0 0x80>;
-				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
-				clock-names = "fck";
 				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
 				ti,timer-alwon;
 				ti,timer-secure;
Signature · 1 line
2.21.0
Tested-by on v1 1/1
#1 lore raw
Quoted 1 line · Tony Lindgren

There is no CLKSEL for timer12 on dra6 unlike for timer1. This

dra7

Quoted 20 lines

causes issues on booting the device that Tomi noticed if DEBUG_SLAB is enabled and the clkctrl clock does not properly handle non-existing clock. Let's drop the bogus CLKSEL clock, the clkctrl clock handling gets fixed separately.

Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Fixes 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
---
  arch/arm/boot/dts/dra7-l4.dtsi | 2 --
  1 file changed, 2 deletions(-)

arch/arm/boot/dts/dra7-l4.dtsi line 4455

Quoted 8 lines
arch/arm/boot/dts/dra7-l4.dtsi +0 -2
@@ -4450,8 +4450,6 @@
  			timer12: timer@0 {
  				compatible = "ti,omap5430-timer";
  				reg = <0x0 0x80>;
-				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
-				clock-names = "fck";
  				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
  				ti,timer-alwon;
  				ti,timer-secure;

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#2 lore raw
Quoted 4 lines · Tomi Valkeinen
Quoted 1 line · Tony Lindgren

There is no CLKSEL for timer12 on dra6 unlike for timer1. This

dra7

Thanks for spotting the typo, pushed out now and will send a pull request for the dra7 fixes probably on Wednesday.

Regards,

Tony

Tested-by on v1 1/1
#3 lore raw
In reply to Tony Lindgren
Quoted 5 lines · Tony Lindgren

There is no CLKSEL for timer12 on dra6 unlike for timer1. This causes issues on booting the device that Tomi noticed if DEBUG_SLAB is enabled and the clkctrl clock does not properly handle non-existing clock. Let's drop the bogus CLKSEL clock, the clkctrl clock handling gets fixed separately.

Quoted 15 lines
Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Fixes 4ed0dfe3cf39 ("ARM: dts: dra7: Move l4 child devices to probe them with ti-sysc")
---
 arch/arm/boot/dts/dra7-l4.dtsi | 2 --
 1 file changed, 2 deletions(-)

arch/arm/boot/dts/dra7-l4.dtsi line 4455

Quoted 8 lines
arch/arm/boot/dts/dra7-l4.dtsi +0 -2
@@ -4450,8 +4450,6 @@
 			timer12: timer@0 {
 				compatible = "ti,omap5430-timer";
 				reg = <0x0 0x80>;
-				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
-				clock-names = "fck";
 				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
 				ti,timer-alwon;
 				ti,timer-secure;

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki