staging: rtl8723bs: core: fix warning Comparison to NULL
PATCH 1/1 staging: rtl8723bs: core: fix warning Comparison to NULL
this patch fixes "Comparison to NULL" warnings reported by checkpatch
Signed-off-by Hariprasad Kelam <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 54 +++++++++++++++---------------- 1 file changed, 27 insertions(+), 27 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +27 -27
@@ -76,7 +76,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_frame_buf =vzalloc (NR_XMITFRAME *sizeof (struct xmit_frame ) +4 ); -if (pxmitpriv->pallocated_frame_buf ==NULL ) { +if (!pxmitpriv->pallocated_frame_buf) { pxmitpriv->pxmit_frame_buf =NULL ;RT_TRACE (_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_frame fail!\n" )); res = _FAIL;
@@ -115,7 +115,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_xmitbuf =vzalloc (NR_XMITBUFF *sizeof (struct xmit_buf ) +4 ); -if (pxmitpriv->pallocated_xmitbuf ==NULL ) { +if (!pxmitpriv->pallocated_xmitbuf) {RT_TRACE (_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_buf fail!\n" )); res = _FAIL; goto exit;
@@ -166,7 +166,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->xframe_ext_alloc_addr =vzalloc (NR_XMIT_EXTBUFF *sizeof (struct xmit_frame ) +4 ); -if (pxmitpriv->xframe_ext_alloc_addr ==NULL ) { +if (!pxmitpriv->xframe_ext_alloc_addr) { pxmitpriv->xframe_ext =NULL ;RT_TRACE (_module_rtl871x_xmit_c_, _drv_err_, ("alloc xframe_ext fail!\n" )); res = _FAIL;
@@ -199,7 +199,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_xmit_extbuf =vzalloc (NR_XMIT_EXTBUFF *sizeof (struct xmit_buf ) +4 ); -if (pxmitpriv->pallocated_xmit_extbuf ==NULL ) { +if (!pxmitpriv->pallocated_xmit_extbuf) {RT_TRACE (_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_extbuf fail!\n" )); res = _FAIL; goto exit;
@@ -288,7 +288,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv)rtw_hal_free_xmit_priv (padapter); -if (pxmitpriv->pxmit_frame_buf ==NULL ) +if (!pxmitpriv->pxmit_frame_buf)return ;for (i =0 ; i <NR_XMITFRAME ; i++) {
@@ -335,7 +335,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv)for (i =0 ; i <CMDBUF_MAX ; i++) { pxmitbuf = &pxmitpriv->pcmd_xmitbuf[i]; -if (pxmitbuf !=NULL ) +if (pxmitbuf)rtw_os_xmit_resource_free (padapter, pxmitbuf,MAX_CMDBUF_SZ +XMITBUF_ALIGN_SZ , true); }
@@ -774,7 +774,7 @@ static s32 update_attrib(struct adapter *padapter, _pkt *pkt, struct pkt_attrib psta =rtw_get_bcmc_stainfo (padapter); }else { psta =rtw_get_stainfo (pstapriv, pattrib->ra); -if (psta ==NULL ) {/* if we cannot get psta => drop the pkt */ +if (!psta) {/* if we cannot get psta => drop the pkt */ DBG_COUNTER (padapter->tx_logs.core_tx_upd_attrib_err_ucast_sta);RT_TRACE (_module_rtl871x_xmit_c_, _drv_alert_, ("\nupdate_attrib => get sta_info fail, ra:" MAC_FMT "\n" ,MAC_ARG (pattrib->ra)));#ifdef DBG_TX_DROP_FRAME
@@ -789,7 +789,7 @@ static s32 update_attrib(struct adapter *padapter, _pkt *pkt, struct pkt_attrib } } -if (psta ==NULL ) { +if (!psta) {/* if we cannot get psta => drop the pkt */ DBG_COUNTER (padapter->tx_logs.core_tx_upd_attrib_err_sta);RT_TRACE (_module_rtl871x_xmit_c_, _drv_alert_, ("\nupdate_attrib => get sta_info fail, ra:" MAC_FMT "\n" ,MAC_ARG (pattrib->ra)));
@@ -1098,7 +1098,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrreturn _FAIL; } -if (psta ==NULL ) { +if (!psta) {DBG_871X ("%s, psta ==NUL\n" , __func__);return _FAIL; }
@@ -1241,7 +1241,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, _pkt *pkt, struct xmit_framreturn _FAIL; } */ -if (pxmitframe->buf_addr ==NULL ) { +if (!pxmitframe->buf_addr) {DBG_8192C ("==> %s buf_addr == NULL\n" , __func__);return _FAIL; }
@@ -1376,7 +1376,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, _pkt *pkt, struct xmit tmp_buf =BIP_AAD =rtw_zmalloc (ori_len); subtype =GetFrameSubType (pframe);/* bit(7)~bit(2) */ -if (BIP_AAD ==NULL ) +if (!BIP_AAD )return _FAIL;spin_lock_bh (&padapter->security_key_mutex);
@@ -1442,13 +1442,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, _pkt *pkt, struct xmitelse psta =rtw_get_stainfo (&padapter->stapriv, pattrib->ra); -if (psta ==NULL ) { +if (!psta) {DBG_871X ("%s, psta ==NUL\n" , __func__); goto xmitframe_coalesce_fail; } -if (!(psta->state & _FW_LINKED) || pxmitframe->buf_addr ==NULL ) { +if (!(psta->state & _FW_LINKED) || !pxmitframe->buf_addr) {DBG_871X ("%s, not _FW_LINKED or addr null\n" , __func__); goto xmitframe_coalesce_fail; }
@@ -1570,7 +1570,7 @@ void rtw_update_protection(struct adapter *padapter, u8 *ie, uint ie_len)case AUTO_VCS :default : perp =rtw_get_ie (ie, _ERPINFO_IE_, &erp_len, ie_len); -if (perp ==NULL ) +if (!perp) pxmitpriv->vcs =NONE_VCS ;else { protection = (*(perp +2 )) &BIT (1 );
@@ -1622,7 +1622,7 @@ static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struct xmit_priv *pxmitpriv,struct xmit_buf *pxmitbuf =NULL ; pxmitbuf = &pxmitpriv->pcmd_xmitbuf[buf_type]; -if (pxmitbuf !=NULL ) { +if (pxmitbuf) { pxmitbuf->priv_data =NULL ; pxmitbuf->len =0 ;
@@ -1647,13 +1647,13 @@ struct xmit_frame *__rtw_alloc_cmdxmitframe(struct xmit_priv *pxmitpriv,struct xmit_buf *pxmitbuf; pcmdframe =rtw_alloc_xmitframe (pxmitpriv); -if (pcmdframe ==NULL ) { +if (!pcmdframe) {DBG_871X ("%s, alloc xmitframe fail\n" , __func__);return NULL ; } pxmitbuf =__rtw_alloc_cmd_xmitbuf (pxmitpriv, buf_type); -if (pxmitbuf ==NULL ) { +if (!pxmitbuf) {DBG_871X ("%s, alloc xmitbuf fail\n" , __func__);rtw_free_xmitframe (pxmitpriv, pcmdframe);return NULL ;
@@ -1693,7 +1693,7 @@ struct xmit_buf *rtw_alloc_xmitbuf_ext(struct xmit_priv *pxmitpriv)list_del_init (&(pxmitbuf->list)); } -if (pxmitbuf !=NULL ) { +if (pxmitbuf) { pxmitpriv->free_xmit_extbuf_cnt--;#ifdef DBG_XMIT_BUF_EXT DBG_871X ("DBG_XMIT_BUF_EXT ALLOC no =%d, free_xmit_extbuf_cnt =%d\n" , pxmitbuf->no, pxmitpriv->free_xmit_extbuf_cnt);
@@ -1723,7 +1723,7 @@ s32 rtw_free_xmitbuf_ext(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)_irqL irqL;struct __queue *pfree_queue = &pxmitpriv->free_xmit_extbuf_queue; -if (pxmitbuf ==NULL ) +if (!pxmitbuf)return _FAIL;spin_lock_irqsave (&pfree_queue->lock, irqL);
@@ -1765,7 +1765,7 @@ struct xmit_buf *rtw_alloc_xmitbuf(struct xmit_priv *pxmitpriv)list_del_init (&(pxmitbuf->list)); } -if (pxmitbuf !=NULL ) { +if (pxmitbuf) { pxmitpriv->free_xmitbuf_cnt--;#ifdef DBG_XMIT_BUF DBG_871X ("DBG_XMIT_BUF ALLOC no =%d, free_xmitbuf_cnt =%d\n" , pxmitbuf->no, pxmitpriv->free_xmitbuf_cnt);
@@ -1801,7 +1801,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)/* DBG_871X("+rtw_free_xmitbuf\n"); */ -if (pxmitbuf ==NULL ) +if (!pxmitbuf)return _FAIL;if (pxmitbuf->sctx) {
@@ -1831,7 +1831,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)static void rtw_init_xmitframe (struct xmit_frame *pxframe) { -if (pxframe !=NULL ) {/* default value setting */ +if (pxframe) {/* default value setting */ pxframe->buf_addr =NULL ; pxframe->pxmitbuf =NULL ;
@@ -1927,7 +1927,7 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit_priv *pxmitpriv) alloc_addr =rtw_zmalloc (sizeof (struct xmit_frame ) +4 ); -if (alloc_addr ==NULL ) +if (!alloc_addr) goto exit; pxframe = (struct xmit_frame *)N_BYTE_ALIGMENT ((SIZE_PTR )(alloc_addr),4 );
@@ -1955,7 +1955,7 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitframstruct adapter *padapter = pxmitpriv->adapter;_pkt *pndis_pkt =NULL ; -if (pxmitframe ==NULL ) { +if (!pxmitframe) {RT_TRACE (_module_rtl871x_xmit_c_, _drv_err_, ("======rtw_free_xmitframe():pxmitframe == NULL!!!!!!!!!!\n" )); goto exit; }
@@ -2109,7 +2109,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe)return _FAIL; } -if (psta ==NULL ) { +if (!psta) {DBG_COUNTER (padapter->tx_logs.core_tx_enqueue_class_err_nosta); res = _FAIL;DBG_8192C ("rtw_xmit_classifier: psta == NULL\n" );
@@ -2310,7 +2310,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt) drop_cnt =0 ; } -if (pxmitframe ==NULL ) { +if (!pxmitframe) { drop_cnt++;RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: no more pxmitframe\n" ));DBG_COUNTER (padapter->tx_logs.core_tx_err_pxmitframe);
@@ -2409,7 +2409,7 @@ sint xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, struct xmit_frreturn false; } -if (psta ==NULL ) { +if (!psta) {DBG_COUNTER (padapter->tx_logs.core_tx_ap_enqueue_warn_nosta);DBG_871X ("%s, psta ==NUL\n" , __func__);return false;
Signature · 1 line
2.7.4