staging: media: davinci_vpfe: Remove variable vpfe_dev
Subsystems (2)
PATCH 1/1 staging: media: davinci_vpfe: Remove variable vpfe_dev
Remove variable vpfe_dev and replace it with its value (since the function otherwise uses values directly instead of local variables). Issue found with Coccinelle.
--- drivers/staging/media/davinci_vpfe/vpfe_video.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/media/davinci_vpfe/vpfe_video.c +2 -4
@@ -448,7 +448,6 @@ vpfe_video_get_next_buffer(struct vpfe_video_device *video)/* schedule the next buffer which is available on dma queue */ void vpfe_video_schedule_next_buffer (struct vpfe_video_device *video) { -struct vpfe_device *vpfe_dev = video->vpfe_dev;unsigned long addr;if (list_empty (&video->dma_queue))
@@ -463,19 +462,18 @@ void vpfe_video_schedule_next_buffer(struct vpfe_video_device *video)list_del (&video->next_frm->list); video->next_frm->vb.vb2_buf.state =VB2_BUF_STATE_ACTIVE ; addr =vb2_dma_contig_plane_dma_addr (&video->next_frm->vb.vb2_buf,0 ); - video->ops->queue (vpfe_dev, addr); + video->ops->queue (video->vpfe_dev, addr); video->state =VPFE_VIDEO_BUFFER_QUEUED ; }/* schedule the buffer for capturing bottom field */ void vpfe_video_schedule_bottom_field (struct vpfe_video_device *video) { -struct vpfe_device *vpfe_dev = video->vpfe_dev;unsigned long addr; addr =vb2_dma_contig_plane_dma_addr (&video->cur_frm->vb.vb2_buf,0 ); addr += video->field_off; - video->ops->queue (vpfe_dev, addr); + video->ops->queue (video->vpfe_dev, addr); }/* make buffer available for dequeue */
Signature · 1 line
2.19.1
Greg KH
maintainerQuoted 2 lines · Nishka Dasgupta
Remove variable
vpfe_devand replace it with its value (since the function otherwise uses values directly instead of local variables).
This says _what_ you do. But we can see that in the patch itself.
You need to say _why_ you are doing this.
There's no need for this change at all. Again, as I have said before, we write code for developers to read first, the compiler second. By making these types of changes you are making it harder to read/understand by a developer, and providing absolutely no benifit to the compiler at all.
So it's actually making the code worse!
not good at all.
Please reconsider this type of change, as I keep asking you to.
greg k-h
Quoted 14 lines · Greg KH
Quoted 2 lines · Nishka Dasgupta
Remove variable
vpfe_devand replace it with its value (since the function otherwise uses values directly instead of local variables).This says _what_ you do. But we can see that in the patch itself.
You need to say _why_ you are doing this.
There's no need for this change at all. Again, as I have said before, we write code for developers to read first, the compiler second. By making these types of changes you are making it harder to read/understand by a developer, and providing absolutely no benifit to the compiler at all.
Quoted 5 lines
So it's actually making the code worse!
not good at all.
Please reconsider this type of change, as I keep asking you to.
Okay. In this case I thought it wouldn't make it worse since the function is low on local variables anyway? Clearly I was wrong, so I won't count this case as an exception in future.
Thanking you,
Nishka
Quoted 2 lines
greg k-h
Greg KH
maintainerQuoted 17 lines · Nishka Dasgupta
Quoted 16 lines · Greg KH
Quoted 2 lines · Nishka Dasgupta
Remove variable
vpfe_devand replace it with its value (since the function otherwise uses values directly instead of local variables).This says _what_ you do. But we can see that in the patch itself.
You need to say _why_ you are doing this.
There's no need for this change at all. Again, as I have said before, we write code for developers to read first, the compiler second. By making these types of changes you are making it harder to read/understand by a developer, and providing absolutely no benifit to the compiler at all.
So it's actually making the code worse!
Quoted 7 lines
Quoted 3 lines
not good at all.
Please reconsider this type of change, as I keep asking you to.
Okay. In this case I thought it wouldn't make it worse since the function is low on local variables anyway? Clearly I was wrong, so I won't count this case as an exception in future.
Did you check the object file output to verify this? Try it and see :)