Skip to contentSkip to conversation

staging: rtl8712: Replace function r8712_free_network_queue

PATCH Superseded Nishka Dasgupta 2 participants 2 messages May 30, 2019 – Jun 3, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8712: Replace function r8712_free_network_queue

Remove function r8712_free_network_queue as it does nothing except call _free_network_queue.
Rename _free_network_queue to r8712_free_network_queue (and change its type to static) for continued use of the original functionality.

---
 drivers/staging/rtl8712/rtl871x_mlme.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +1 -6
index 57d8e7dceef7..f6ba3e865a30 100644
@@ -151,7 +151,7 @@ static struct wlan_network *_r8712_find_network(struct  __queue *scanned_queue,
 	return pnetwork;
 }
 
-static void _free_network_queue(struct _adapter *padapter)
+void r8712_free_network_queue(struct _adapter *padapter)
 {
 	unsigned long irqL;
 	struct list_head *phead, *plist;
@@ -215,11 +215,6 @@ static struct	wlan_network *alloc_network(struct mlme_priv *pmlmepriv)
 	return _r8712_alloc_network(pmlmepriv);
 }
 
-void r8712_free_network_queue(struct _adapter *dev)
-{
-	_free_network_queue(dev);
-}
-
 /*
  * return the wlan_network with the matching addr
  * Shall be called under atomic context...
Signature · 1 line
2.19.1
maintainer
#1 lore raw
Quoted 4 lines · Nishka Dasgupta

Remove function r8712_free_network_queue as it does nothing except call _free_network_queue.
Rename _free_network_queue to r8712_free_network_queue (and change its type to static) for continued use of the original functionality.

You did not change the type to static:

drivers/staging/rtl8712/rtl871x_mlme.c static struct wlan_network *_r8712_find_network(struct __queue *scanned_queue, · line 154

Quoted 2 lines
drivers/staging/rtl8712/rtl871x_mlme.c +1 -1
-static void _free_network_queue(struct _adapter *padapter)
+void r8712_free_network_queue(struct _adapter *padapter)

:(