perf jvmti: Fix gcc string overflow warning
Jiri Olsa
reviewerPATCH 1/1 perf jvmti: Fix gcc string overflow warning
We are getting fake gcc warning when we compile with gcc9 (9.1.1):
CC jvmti/libjvmti.o
In file included from /usr/include/string.h:494,
from jvmti/libjvmti.c:5:
In function ‘strncpy’,
inlined from ‘copy_class_filename.constprop’ at jvmti/libjvmti.c:166:3:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jvmti/libjvmti.c: In function ‘copy_class_filename.constprop’:
jvmti/libjvmti.c:165:26: note: length computed here
165 | size_t file_name_len = strlen(file_name);
| ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
First I wanted to disable the check, but now I think the code could be more straight forward. There's no need to check the source size, strncpy will do that. We just need to make sure the string is correctly terminated.
--- tools/perf/jvmti/libjvmti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/jvmti/libjvmti.c +2 -2
@@ -162,8 +162,8 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu result[i] ='\0' ; }else {/* fallback case */ -size_t file_name_len =strlen (file_name); -strncpy (result, file_name, file_name_len < max_length ? file_name_len : max_length); +strncpy (result, file_name, max_length -1 ); + result[max_length -1 ] =0 ; } }
Signature · 1 line
2.21.0
Em Fri, May 31, 2019 at 10:03:07AM +0200, Jiri Olsa escreveu:
Quoted 34 lines
We are getting fake gcc warning when we compile with gcc9 (9.1.1):
CC
jvmti/libjvmti.o
In file included from/usr/include/string.h:494,
fromjvmti/libjvmti.c:5:
In function ‘strncpy’,
inlined from ‘copy_class_filename.constprop’ atjvmti/libjvmti.c:166:3:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ jvmti/libjvmti.c: In function ‘copy_class_filename.constprop’: jvmti/libjvmti.c:165:26: note: length computed here 165 | size_t file_name_len = strlen(file_name); | ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
First I wanted to disable the check, but now I think the code could be more straight forward. There's no need to check the source size, strncpy will do that. We just need to make sure the string is correctly terminated.
Cc Ben Gainey <[email protected]>Cc Stephane Eranian <[email protected]>Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/jvmti/libjvmti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/jvmti/libjvmti.c +0
-0
tools/perf/jvmti/libjvmti.c copy_class_filename(const char * class_sign, const char * file_name, char * resu · line 166
Quoted 7 lines
tools/perf/jvmti/libjvmti.c +2
-2@@ -162,8 +162,8 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu result[i] ='\0' ; }else {/* fallback case */ -size_t file_name_len =strlen (file_name); -strncpy (result, file_name, file_name_len < max_length ? file_name_len : max_length); +strncpy (result, file_name, max_length -1 ); + result[max_length -1 ] =0 ;
The usual idiom here, if we stay with strncpy is:
strncpy(result, file_name, max_length - 1)[max_length - 1] = 0;
one line instead of two, but there are other possibilities, what I've done int these cases in tools/perf/ is to switch to strlcpy, so just flip that 'n' to a 'l' and it should be enough.
For that we just have a copy of the kernel's strlcpy() implementation in lib/string.c, and it has this doc:
/**
* strlcpy - Copy a C-string into a sized buffer
* @dest: Where to copy the string to
* @src: Where to copy the string from
* @size: size of destination buffer
*
* Compatible with ``*BSD``: the result is always a valid
* NUL-terminated string that fits in the buffer (unless,
* of course, the buffer size is zero). It does not pad
* out the result like strncpy() does.
*/
The kernel folks moved beyond that and in lib/string.c we have:
/**
* strscpy - Copy a C-string into a sized buffer
* @dest: Where to copy the string to
* @src: Where to copy the string from
* @count: Size of destination buffer
*
* Copy the string, or as much of it as fits, into the dest buffer. The
* behavior is undefined if the string buffers overlap. The destination
* buffer is always NUL terminated, unless it's zero-sized. *
* Preferred to strlcpy() since the API doesn't require reading memory
* from the src string beyond the specified "count" bytes, and since
* the return value is easier to error-check than strlcpy()'s.
* In addition, the implementation is robust to the string changing out
* from underneath it, unlike the current strlcpy() implementation. *
* Preferred to strncpy() since it always returns a valid string, and
* doesn't unnecessarily force the tail of the destination buffer to be
* zeroed. If zeroing is desired please use strscpy_pad(). *
* Return: The number of characters copied (not including the trailing
* %NUL) or -E2BIG if the destination buffer wasn't big enough.
*/ssize_t strscpy(char *dest, const char *src, size_t count)
I think for these needs flipping that 'n' into a 'l' is good enough.
- Arnaldo
Quoted 5 lines
tools/perf/jvmti/libjvmti.c +0
-0} }Signature · 1 line
2.21.0
Signature · 1 line
- Arnaldo
PATCH v2 1/1 perf jvmti: Fix gcc string overflow warning
On Fri, May 31, 2019 at 09:05:30AM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
Quoted 29 lines
The kernel folks moved beyond that and in
lib/string.cwe have:/**
* strscpy - Copy a C-string into a sized buffer
* @dest: Where to copy the string to
* @src: Where to copy the string from
* @count: Size of destination buffer
*
* Copy the string, or as much of it as fits, into the dest buffer. The
* behavior is undefined if the string buffers overlap. The destination
* buffer is always NUL terminated, unless it's zero-sized. *
* Preferred tostrlcpy()since the API doesn't require reading memory
* from the src string beyond the specified "count" bytes, and since
* the return value is easier to error-check than strlcpy()'s.
* In addition, the implementation is robust to the string changing out
* from underneath it, unlike the currentstrlcpy()implementation. *
* Preferred tostrncpy()since it always returns a valid string, and
* doesn't unnecessarily force the tail of the destination buffer to be
* zeroed. If zeroing is desired please usestrscpy_pad(). *
* Return: The number of characters copied (not including the trailing
* %NUL) or-E2BIGif the destination buffer wasn't big enough.
*/ssize_tstrscpy(char *dest, const char *src, size_t count)
Quoted 1 line
I think for these needs flipping that 'n' into a 'l' is good enough.
ok, I forgot there's strlcpy.. v2 attached
thanks,
jirka
---
We are getting fake gcc warning when we compile with gcc9 (9.1.1):
CC jvmti/libjvmti.o
In file included from /usr/include/string.h:494,
from jvmti/libjvmti.c:5:
In function ‘strncpy’,
inlined from ‘copy_class_filename.constprop’ at jvmti/libjvmti.c:166:3:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jvmti/libjvmti.c: In function ‘copy_class_filename.constprop’:
jvmti/libjvmti.c:165:26: note: length computed here
165 | size_t file_name_len = strlen(file_name);
| ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
As per Arnaldo's suggestion using strlcpy, which does the same thing and keeps gcc silent.
--- tools/perf/jvmti/libjvmti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/jvmti/libjvmti.c +2 -2
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 #include <linux/compiler.h> +#include <linux/string.h> #include <sys/types.h> #include <stdio.h> #include <string.h>
@@ -162,8 +163,7 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu result[i] ='\0' ; }else {/* fallback case */ -size_t file_name_len =strlen (file_name); -strncpy (result, file_name, file_name_len < max_length ? file_name_len : max_length); +strlcpy (result, file_name, max_length); } }
Signature · 1 line
2.21.0
Arnaldo Carvalho de Melo
AppliedEm Fri, May 31, 2019 at 03:13:21PM +0200, Jiri Olsa escreveu:
Quoted 4 lines · Arnaldo Carvalho de Melo
Quoted 1 line
I think for these needs flipping that 'n' into a 'l' is good enough.
ok, I forgot there's strlcpy.. v2 attached
Thanks, applied v2.
- Arnaldo
Quoted 52 lines
---
We are getting fake gcc warning when we compile with gcc9 (9.1.1):CC
jvmti/libjvmti.o
In file included from/usr/include/string.h:494,
fromjvmti/libjvmti.c:5:
In function ‘strncpy’,
inlined from ‘copy_class_filename.constprop’ atjvmti/libjvmti.c:166:3:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ jvmti/libjvmti.c: In function ‘copy_class_filename.constprop’: jvmti/libjvmti.c:165:26: note: length computed here 165 | size_t file_name_len = strlen(file_name); | ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
As per Arnaldo's suggestion using strlcpy, which does the same thing and keeps gcc silent.
Cc Ben Gainey <[email protected]>Cc Stephane Eranian <[email protected]>Suggested-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Jiri Olsa <[email protected]>--- tools/perf/jvmti/libjvmti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/jvmti/libjvmti.c +2
-2@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 #include <linux/compiler.h> +#include <linux/string.h> #include <sys/types.h> #include <stdio.h> #include <string.h> @@ -162,8 +163,7 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu result[i] ='\0' ; }else {/* fallback case */ -size_t file_name_len =strlen (file_name); -strncpy (result, file_name, file_name_len < max_length ? file_name_len : max_length); +strlcpy (result, file_name, max_length); } }Signature · 1 line
2.21.0
Signature · 1 line
- Arnaldo
tip-bot for Jiri Olsa
merge bot[tip:perf/core] perf jvmti: Address gcc string overflow warning for strncpy()
In reply to Jiri Olsaperf jvmti: Address gcc string overflow warning for strncpy()
Commit-ID: 279ab04dbea1370d2eac0f854270369ccaef8a44 Gitweb: https://git.kernel.org/tip/279ab04dbea1370d2eac0f854270369ccaef8a44 Author: Jiri Olsa <[email protected]> AuthorDate: Fri, 31 May 2019 15:13:21 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 5 Jun 2019 09:51:26 -0300
perf jvmti: Address gcc string overflow warning for strncpy()
We are getting false positive gcc warning when we compile with gcc9 (9.1.1):
CC jvmti/libjvmti.o
In file included from /usr/include/string.h:494,
from jvmti/libjvmti.c:5:
In function ‘strncpy’,
inlined from ‘copy_class_filename.constprop’ at jvmti/libjvmti.c:166:3:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jvmti/libjvmti.c: In function ‘copy_class_filename.constprop’:
jvmti/libjvmti.c:165:26: note: length computed here
165 | size_t file_name_len = strlen(file_name);
| ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
As per Arnaldo's suggestion use strlcpy(), which does the same thing and keeps gcc silent.
--- tools/perf/jvmti/libjvmti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/jvmti/libjvmti.c +2 -2
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 #include <linux/compiler.h> +#include <linux/string.h> #include <sys/types.h> #include <stdio.h> #include <string.h>
@@ -162,8 +163,7 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu result[i] ='\0' ; }else {/* fallback case */ -size_t file_name_len =strlen (file_name); -strncpy (result, file_name, file_name_len < max_length ? file_name_len : max_length); +strlcpy (result, file_name, max_length); } }
tip-bot for Jiri Olsa
merge bot[tip:perf/core] perf jvmti: Address gcc string overflow warning for strncpy()
In reply to Jiri Olsaperf jvmti: Address gcc string overflow warning for strncpy()
Commit-ID: dab0f4ebb22ee6d16051011d624cff79a99baa8a Gitweb: https://git.kernel.org/tip/dab0f4ebb22ee6d16051011d624cff79a99baa8a Author: Jiri Olsa <[email protected]> AuthorDate: Fri, 31 May 2019 15:13:21 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Sun, 7 Jul 2019 12:33:32 -0300
perf jvmti: Address gcc string overflow warning for strncpy()
We are getting false positive gcc warning when we compile with gcc9 (9.1.1):
CC jvmti/libjvmti.o
In file included from /usr/include/string.h:494,
from jvmti/libjvmti.c:5:
In function ‘strncpy’,
inlined from ‘copy_class_filename.constprop’ at jvmti/libjvmti.c:166:3:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jvmti/libjvmti.c: In function ‘copy_class_filename.constprop’:
jvmti/libjvmti.c:165:26: note: length computed here
165 | size_t file_name_len = strlen(file_name);
| ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
As per Arnaldo's suggestion use strlcpy(), which does the same thing and keeps gcc silent.
--- tools/perf/jvmti/libjvmti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/jvmti/libjvmti.c +2 -2
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 #include <linux/compiler.h> +#include <linux/string.h> #include <sys/types.h> #include <stdio.h> #include <string.h>
@@ -162,8 +163,7 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu result[i] ='\0' ; }else {/* fallback case */ -size_t file_name_len =strlen (file_name); -strncpy (result, file_name, file_name_len < max_length ? file_name_len : max_length); +strlcpy (result, file_name, max_length); } }