Skip to contentSkip to conversation

configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

PATCH New Ezequiel Garcia 7 participants 41 messages May 25, 2019 – May 31, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -
 configs/pcm058_defconfig            | 1 -
 configs/pfla02_defconfig            | 1 -
 configs/platinum_picon_defconfig    | 1 -
 configs/platinum_titanium_defconfig | 1 -
 configs/riotboard_spl_defconfig     | 1 -
 configs/sksimx6_defconfig           | 1 -
 configs/udoo_defconfig              | 1 -
 configs/udoo_neo_defconfig          | 1 -
 configs/wandboard_defconfig         | 1 -
 configs/xpress_spl_defconfig        | 1 -
 configs/zc5202_defconfig            | 1 -
 configs/zc5601_defconfig            | 1 -
 21 files changed, 21 deletions(-)
configs/cgtqmx6eval_defconfig +0 -1
index 0a6ff20a4d42..cf8502b370f4 100644
@@ -22,7 +22,6 @@ CONFIG_MISC_INIT_R=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
configs/mx6cuboxi_defconfig +0 -1
index f13e6885071b..31427e24ad14 100644
@@ -18,7 +18,6 @@ CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd"
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 # CONFIG_CMD_FLASH is not set
configs/mx6sabreauto_defconfig +0 -1
index d0f302e9d09b..303636511326 100644
@@ -24,7 +24,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_FIT_IMAGE_TINY=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_HUSH_PARSER=y
configs/mx6sabresd_defconfig +0 -1
index 0fda6fc3946e..c060d6f692d7 100644
@@ -23,7 +23,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_FIT_IMAGE_TINY=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_OS_BOOT=y
 CONFIG_SPL_USB_HOST_SUPPORT=y
configs/mx6slevk_spl_defconfig +0 -1
index 4841dc62bf5c..fbf0e3e774c7 100644
@@ -16,7 +16,6 @@ CONFIG_SUPPORT_RAW_INITRD=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_HUSH_PARSER=y
configs/mx6sxsabresd_spl_defconfig +0 -1
index 159f07931a3b..51eb0726d658 100644
@@ -18,7 +18,6 @@ CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 CONFIG_SUPPORT_RAW_INITRD=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_HUSH_PARSER=y
configs/mx6ul_14x14_evk_defconfig +0 -1
index 2fc7119042a1..8735401bb71a 100644
@@ -17,7 +17,6 @@ CONFIG_SUPPORT_RAW_INITRD=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_HUSH_PARSER=y
configs/mx6ul_9x9_evk_defconfig +0 -1
index 8816f6a4fdec..c204b49e2bc9 100644
@@ -17,7 +17,6 @@ CONFIG_SUPPORT_RAW_INITRD=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_HUSH_PARSER=y
configs/novena_defconfig +0 -1
index 340e1cd91c69..a7386b6108c7 100644
@@ -24,7 +24,6 @@ CONFIG_VERSION_VARIABLE=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_ASKENV=y
configs/pcm058_defconfig +0 -1
index c4614593af90..ebf015246274 100644
@@ -23,7 +23,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_DMA_SUPPORT=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
configs/pfla02_defconfig +0 -1
index aeab883258da..e500419d61d9 100644
@@ -23,7 +23,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_DMA_SUPPORT=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
configs/platinum_picon_defconfig +0 -1
index 786f6a4ba4c4..07ae40a1cf73 100644
@@ -18,7 +18,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_DMA_SUPPORT=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_NAND_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
configs/platinum_titanium_defconfig +0 -1
index c45abb0356ae..c8a408116a27 100644
@@ -18,7 +18,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_DMA_SUPPORT=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_NAND_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
configs/riotboard_spl_defconfig +0 -1
index 1b61232d5c46..9c7f1c0a3645 100644
@@ -19,7 +19,6 @@ CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_RAW_IMAGE_SUPPORT=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_OS_BOOT=y
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
configs/sksimx6_defconfig +0 -1
index 164614decdd3..bccf3ce01693 100644
@@ -24,7 +24,6 @@ CONFIG_VERSION_VARIABLE=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_GPIO=y
configs/udoo_defconfig +0 -1
index 317592b5e95e..c56dc5d9218f 100644
@@ -17,7 +17,6 @@ CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd"
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_CMD_GPIO=y
configs/udoo_neo_defconfig +0 -1
index e8df11db669b..e327c9728d1d 100644
@@ -18,7 +18,6 @@ CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
 CONFIG_SPL_ENV_SUPPORT=y
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
configs/wandboard_defconfig +0 -1
index ee81e1aa1c8e..a25cc6e924ed 100644
@@ -23,7 +23,6 @@ CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 # CONFIG_CMD_FLASH is not set
configs/xpress_spl_defconfig +0 -1
index e79a038816d5..7c22abf7dcd2 100644
@@ -17,7 +17,6 @@ CONFIG_SUPPORT_RAW_INITRD=y
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
 CONFIG_HUSH_PARSER=y
configs/zc5202_defconfig +0 -1
index ae3a6b32bf21..5964472d694a 100644
@@ -20,7 +20,6 @@ CONFIG_DEFAULT_FDT_FILE="imx6q-zc5202.dtb"
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
configs/zc5601_defconfig +0 -1
index 65a19151a829..65afbc2736ef 100644
@@ -20,7 +20,6 @@ CONFIG_DEFAULT_FDT_FILE="imx6q-zc5601.dtb"
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x00908000
-CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 38 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -
Quoted 4 lines

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

Thanks for the review,
Eze

#3 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 39 lines · Ezequiel Garcia
Quoted 38 lines · Marek Vasut
Quoted 36 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -
Quoted 7 lines
Quoted 4 lines

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 40 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

#5 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 46 lines · Ezequiel Garcia
Quoted 45 lines · Marek Vasut
Quoted 44 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 56 lines · Marek Vasut
Quoted 46 lines · Ezequiel Garcia
Quoted 45 lines · Marek Vasut
Quoted 44 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not? There are setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190525/12e291cf/attachment.sig>
#7 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 57 lines · Tom Rini
Quoted 56 lines · Marek Vasut
Quoted 54 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 40 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Signature · 2 lines
Best regards,
Marek Vasut
#8 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 74 lines · Marek Vasut
Quoted 57 lines · Tom Rini
Quoted 56 lines · Marek Vasut
Quoted 54 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 40 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190525/38f68258/attachment.sig>
#9 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 75 lines · Tom Rini
Quoted 74 lines · Marek Vasut
Quoted 57 lines · Tom Rini
Quoted 56 lines · Marek Vasut
Quoted 54 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 40 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 8 lines
Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

Signature · 2 lines
Best regards,
Marek Vasut
#10 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 81 lines · Marek Vasut
Quoted 80 lines · Tom Rini
Quoted 78 lines · Marek Vasut
Quoted 57 lines · Tom Rini
Quoted 56 lines · Marek Vasut
Quoted 54 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 40 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 6 lines
Quoted 3 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

No, it's what the board maintainer says, for wandboard.

Quoted 5 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

By that logic you should be enabling every possible filesystem in SPL and a bunch of other features too just in case. No, if no one is _using_ a feature on a board, removing useless features is a goal onto itself.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190525/c2dc646e/attachment.sig>
#11 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 82 lines · Tom Rini
Quoted 81 lines · Marek Vasut
Quoted 80 lines · Tom Rini
Quoted 78 lines · Marek Vasut
Quoted 57 lines · Tom Rini
Quoted 56 lines · Marek Vasut
Quoted 54 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 40 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

No, it's what the board maintainer says, for wandboard.

I would like to avoid carrying downstream patch.

Quoted 8 lines
Quoted 5 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

By that logic you should be enabling every possible filesystem in SPL and a bunch of other features too just in case.

I never implied this. All I said is that I am strongly opposed to removing useful functionality to accommodate useless bloat. It is the bloat that should be fixed and the functionality should be retained.

Quoted 3 lines

No, if no one is
_using_ a feature on a board, removing useless features is a goal onto itself.

I just said I am using ext4 on at least novena and wandboard.

Signature · 2 lines
Best regards,
Marek Vasut
#12 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

In reply to Marek Vasut

Dear Marek, Tom,

Quoted 88 lines · Tom Rini
Quoted 82 lines · Marek Vasut
Quoted 76 lines · Tom Rini
Quoted 59 lines · Marek Vasut
Quoted 58 lines · Ezequiel Garcia
Quoted 56 lines · Marek Vasut
Quoted 43 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 28 lines

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -  

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Quoted 9 lines

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------
Before conversion: 35 KiB
DM conversion: 47 KiB
(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.

2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Unfortunately, it would take some time.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190526/1b2f8768/attachment.sig>

#13 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 138 lines · Lukasz Majewski

Dear Marek, Tom,

Quoted 88 lines · Tom Rini
Quoted 82 lines · Marek Vasut
Quoted 76 lines · Tom Rini
Quoted 59 lines · Marek Vasut
Quoted 58 lines · Ezequiel Garcia
Quoted 56 lines · Marek Vasut
Quoted 43 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Ezequiel Garcia
Quoted 28 lines

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -  

NAK, I boot my Novena from ext4 and this just broke it.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 8 lines
Quoted 6 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 4 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Quoted 9 lines

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------
Before conversion: 35 KiB
DM conversion: 47 KiB
(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.

2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

Quoted 7 lines

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago, when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190526/046fbeed/attachment.sig>
#14 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Hi Tom,

Quoted 151 lines · Lukasz Majewski
Quoted 150 lines

Dear Marek, Tom,

Quoted 96 lines · Tom Rini
Quoted 87 lines · Marek Vasut
Quoted 81 lines · Tom Rini
Quoted 70 lines
Quoted 60 lines · Marek Vasut
Quoted 52 lines · Ezequiel Garcia
Quoted 51 lines · Marek Vasut
Quoted 49 lines · Ezequiel Garcia
Quoted 41 lines · Marek Vasut
Quoted 30 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi <[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> --- Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -    
Quoted 4 lines

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

Quoted 6 lines
Quoted 2 lines

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 1 line

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------
Before conversion: 35 KiB
DM conversion: 47 KiB
(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.

2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Quoted 5 lines
Quoted 1 line

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Ok, so we do have agreement here. Good.

Quoted 4 lines

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago,

Frankly speaking - I do prefer to use older, well tested and stable SW.

And such situation we had with i.MX port. It was (and still is) working, being there before the whole DM/DTS stuff.

I can understand that we advised new ports/archs to use DM/DTS. But i.MX has a lot of legacy code, which is already deployed. Changing it because "we move to DM/DTS" immediately is not practical as we loose the code base developed, tested and validated for years.

Quoted 3 lines

when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

Please consider that we even now have issues with some non-converted drivers. Some drivers were "under conversion" for years (spi framework, sf command). Please also note how many drivers actually support OF_PLATDATA?

Quoted 4 lines

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

Quoted 1 line

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190526/1c83a528/attachment.sig>

#15 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 113 lines · Lukasz Majewski

Hi Tom,

Quoted 111 lines · Lukasz Majewski
Quoted 110 lines

Dear Marek, Tom,

Quoted 96 lines · Tom Rini
Quoted 87 lines · Marek Vasut
Quoted 81 lines · Tom Rini
Quoted 70 lines
Quoted 60 lines · Marek Vasut
Quoted 52 lines · Ezequiel Garcia
Quoted 51 lines · Marek Vasut
Quoted 49 lines · Ezequiel Garcia
Quoted 41 lines · Marek Vasut
Quoted 39 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from
unformatted space, and should not need Ext filesystem
support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4
| xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674
(-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi
<[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> ---
Tested on Wandboard only. Maintainers, please ACK or
NAK!

configs/cgtqmx6eval_defconfig | 1 -
configs/mx6cuboxi_defconfig | 1 -
configs/mx6sabreauto_defconfig | 1 -
configs/mx6sabresd_defconfig | 1 -
configs/mx6slevk_spl_defconfig | 1 -
configs/mx6sxsabresd_spl_defconfig | 1 -
configs/mx6ul_14x14_evk_defconfig | 1 -
configs/mx6ul_9x9_evk_defconfig | 1 -
configs/novena_defconfig | 1 -

Quoted 4 lines

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

Quoted 6 lines
Quoted 2 lines

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 1 line

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

Better yet, the ability to short-circuit the whole DM functionality for systems which only have one driver per subsystem in the SPL, and optimize the entire DM machinery out in such a case, since it's all not required only to track one driver instance.

[...]

Quoted 4 lines

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

VFAT is a patent minefield, which is why people use ext4 in the first place. Migrating from ext4 -> VFAT is like moving from a good thing to bad thing.

Signature · 2 lines
Best regards,
Marek Vasut
#16 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

In reply to Lukasz Majewski
Quoted 168 lines · Lukasz Majewski

Hi Tom,

Quoted 151 lines · Lukasz Majewski
Quoted 150 lines

Dear Marek, Tom,

Quoted 96 lines · Tom Rini
Quoted 87 lines · Marek Vasut
Quoted 81 lines · Tom Rini
Quoted 70 lines
Quoted 60 lines · Marek Vasut
Quoted 52 lines · Ezequiel Garcia
Quoted 51 lines · Marek Vasut
Quoted 49 lines · Ezequiel Garcia
Quoted 41 lines · Marek Vasut
Quoted 39 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from
unformatted space, and should not need Ext filesystem
support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4
| xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674
(-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi
<[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> ---
Tested on Wandboard only. Maintainers, please ACK or
NAK!

configs/cgtqmx6eval_defconfig | 1 -
configs/mx6cuboxi_defconfig | 1 -
configs/mx6sabreauto_defconfig | 1 -
configs/mx6sabresd_defconfig | 1 -
configs/mx6slevk_spl_defconfig | 1 -
configs/mx6sxsabresd_spl_defconfig | 1 -
configs/mx6ul_14x14_evk_defconfig | 1 -
configs/mx6ul_9x9_evk_defconfig | 1 -
configs/novena_defconfig | 1 -

Quoted 4 lines

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

Quoted 6 lines
Quoted 2 lines

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 1 line

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------
Before conversion: 35 KiB
DM conversion: 47 KiB
(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.

2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Quoted 5 lines
Quoted 1 line

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Ok, so we do have agreement here. Good.

Quoted 4 lines

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago,

Frankly speaking - I do prefer to use older, well tested and stable SW.

Quoted 7 lines

And such situation we had with i.MX port. It was (and still is) working, being there before the whole DM/DTS stuff.

I can understand that we advised new ports/archs to use DM/DTS. But i.MX has a lot of legacy code, which is already deployed. Changing it because "we move to DM/DTS" immediately is not practical as we loose the code base developed, tested and validated for years.

DM/DT has been around for over 7 years now, so it too is "legacy code". So it's not "immediately", it's been several years now of trying to get people to migrate and introducing more firm deadlines about it.

And I'm _still_ not removing code that's close to a full year past the published "We're going to remove this now" date.

Quoted 8 lines
Quoted 3 lines

when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

Please consider that we even now have issues with some non-converted drivers. Some drivers were "under conversion" for years (spi framework, sf command). Please also note how many drivers actually support OF_PLATDATA?

Yes, it's been hard to get some drivers converted because just not doing it had no consequences. And yes, I'm sure drivers you need will need OF_PLATDATA hooks added.

Quoted 8 lines
Quoted 3 lines

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

Exactly. If people are using EXT4 on iMX6 then it should stay. We dropped it from am335x_evm over a year ago because it wasn't used.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190526/e4b8a173/attachment.sig>
#17 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Hi Tom,

Quoted 185 lines · Lukasz Majewski
Quoted 176 lines

Hi Tom,

Quoted 158 lines · Lukasz Majewski
Quoted 157 lines

Dear Marek, Tom,

Quoted 102 lines · Tom Rini
Quoted 93 lines
Quoted 86 lines · Marek Vasut
Quoted 74 lines · Tom Rini
Quoted 64 lines · Marek Vasut
Quoted 56 lines · Ezequiel Garcia
Quoted 54 lines · Marek Vasut
Quoted 52 lines · Ezequiel Garcia
Quoted 47 lines · Marek Vasut

On 5/25/19 6:49 PM, Ezequiel Garcia wrote:
i.MX6 platforms boot U-Boot second-stage from
unformatted space, and should not need Ext
filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l
SPL_FS_EXT4 | xargs sed -i -e
'/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674
(-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi
<[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> ---
Tested on Wandboard only. Maintainers, please ACK or
NAK!

configs/cgtqmx6eval_defconfig | 1 -
configs/mx6cuboxi_defconfig | 1 -
configs/mx6sabreauto_defconfig | 1 -
configs/mx6sabresd_defconfig | 1 -
configs/mx6slevk_spl_defconfig | 1 -
configs/mx6sxsabresd_spl_defconfig | 1 -
configs/mx6ul_14x14_evk_defconfig | 1 -
configs/mx6ul_9x9_evk_defconfig | 1 -
configs/novena_defconfig | 1 -

NAK, I boot my Novena from ext4 and this just broke
it.

And also, NAK, this removes functionality from SPL
which worked fine before.

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

Quoted 6 lines
Quoted 2 lines

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 2 lines

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------
Before conversion: 35 KiB
DM conversion: 47 KiB
(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.
fdtdec_get_chosen_node
2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Quoted 5 lines
Quoted 1 line

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Ok, so we do have agreement here. Good.

Quoted 4 lines

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago,

Frankly speaking - I do prefer to use older, well tested and stable SW.

Quoted 7 lines

And such situation we had with i.MX port. It was (and still is) working, being there before the whole DM/DTS stuff.

I can understand that we advised new ports/archs to use DM/DTS. But i.MX has a lot of legacy code, which is already deployed. Changing it because "we move to DM/DTS" immediately is not practical as we loose the code base developed, tested and validated for years.

Quoted 4 lines

DM/DT has been around for over 7 years now, so it too is "legacy code". So it's not "immediately", it's been several years now of trying to get people to migrate and introducing more firm deadlines about it.

I'm not talking about generic DM/DTS adoption - this goes pretty well.

I'm specific about OF_PLATDATA in SPL, which is lagging behind in the whole U-Boot.
To efficiently convert SPL on i.MX we do need it.

Quoted 3 lines

And I'm _still_ not removing code that's close to a full year past the published "We're going to remove this now" date.

And this is a good approach. This code is a legacy one, but still working and sometimes used.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

Quoted 8 lines
Quoted 4 lines

Please consider that we even now have issues with some non-converted drivers. Some drivers were "under conversion" for years (spi framework, sf command). Please also note how many drivers actually support OF_PLATDATA?

Yes, it's been hard to get some drivers converted because just not doing it had no consequences. And yes, I'm sure drivers you need will need OF_PLATDATA hooks added.

Yes, certainly.

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

Quoted 8 lines
Quoted 4 lines

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

Exactly. If people are using EXT4 on iMX6 then it should stay. We dropped it from am335x_evm over a year ago because it wasn't used.

Yes. I also do agree.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190526/3b6f384d/attachment.sig>

#18 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 233 lines · Lukasz Majewski

Hi Tom,

Quoted 185 lines · Lukasz Majewski
Quoted 176 lines

Hi Tom,

Quoted 158 lines · Lukasz Majewski
Quoted 157 lines

Dear Marek, Tom,

Quoted 102 lines · Tom Rini
Quoted 93 lines
Quoted 86 lines · Marek Vasut
Quoted 74 lines · Tom Rini
Quoted 64 lines · Marek Vasut
Quoted 56 lines · Ezequiel Garcia
Quoted 54 lines · Marek Vasut
Quoted 52 lines · Ezequiel Garcia

On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut
wrote:
On 5/25/19 6:49 PM, Ezequiel Garcia wrote:
i.MX6 platforms boot U-Boot second-stage from
unformatted space, and should not need Ext
filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l
SPL_FS_EXT4 | xargs sed -i -e
'/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674
(-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi
<[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> ---
Tested on Wandboard only. Maintainers, please ACK or
NAK!

configs/cgtqmx6eval_defconfig | 1 -
configs/mx6cuboxi_defconfig | 1 -
configs/mx6sabreauto_defconfig | 1 -
configs/mx6sabresd_defconfig | 1 -
configs/mx6slevk_spl_defconfig | 1 -
configs/mx6sxsabresd_spl_defconfig | 1 -
configs/mx6ul_14x14_evk_defconfig | 1 -
configs/mx6ul_9x9_evk_defconfig | 1 -
configs/novena_defconfig | 1 -

NAK, I boot my Novena from ext4 and this just broke
it.

And also, NAK, this removes functionality from SPL
which worked fine before.

I'll drop from Novena, but I think the patch still
makes some sense, why do you want Ext4 on SPL?

Quoted 6 lines
Quoted 2 lines

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 2 lines

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------

Before conversion:                              35 KiB
DM conversion:                                  47 KiB

(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.
fdtdec_get_chosen_node
2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Quoted 5 lines
Quoted 1 line

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Ok, so we do have agreement here. Good.

Quoted 4 lines

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago,

Frankly speaking - I do prefer to use older, well tested and stable SW.

Quoted 7 lines

And such situation we had with i.MX port. It was (and still is) working, being there before the whole DM/DTS stuff.

I can understand that we advised new ports/archs to use DM/DTS. But i.MX has a lot of legacy code, which is already deployed. Changing it because "we move to DM/DTS" immediately is not practical as we loose the code base developed, tested and validated for years.

Quoted 4 lines

DM/DT has been around for over 7 years now, so it too is "legacy code". So it's not "immediately", it's been several years now of trying to get people to migrate and introducing more firm deadlines about it.

I'm not talking about generic DM/DTS adoption - this goes pretty well.

I'm specific about OF_PLATDATA in SPL, which is lagging behind in the whole U-Boot.
To efficiently convert SPL on i.MX we do need it.

Quoted 3 lines

And I'm _still_ not removing code that's close to a full year past the published "We're going to remove this now" date.

And this is a good approach. This code is a legacy one, but still working and sometimes used.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

Quoted 8 lines
Quoted 4 lines

Please consider that we even now have issues with some non-converted drivers. Some drivers were "under conversion" for years (spi framework, sf command). Please also note how many drivers actually support OF_PLATDATA?

Yes, it's been hard to get some drivers converted because just not doing it had no consequences. And yes, I'm sure drivers you need will need OF_PLATDATA hooks added.

Yes, certainly.

Quoted 10 lines
Quoted 9 lines
Quoted 4 lines

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

Quoted 6 lines
Quoted 3 lines

Exactly. If people are using EXT4 on iMX6 then it should stay. We dropped it from am335x_evm over a year ago because it wasn't used.

Yes. I also do agree.

I don't want to get into the DM discussion, the intention of this patch was to reduce SPL size, not make room for a future increase.

That said, I am surprised it is so controversial to slim down a Defconfig, which (at least in my mind) is just the "Maintainer Recommended Starting Point". By removing Ext4 we stating that it's no needed for the board "typical" use.

Of course, anyone can still turn Ext4 -and many other features- on.

Once again, this is only possible if we maintain SPL "starting point" size as small as possible, which probably excludes DM or any other form of bloat.

In fact, if I can keep removing features and still boot the board with the typical setup, I'll be happy to keep suggesting such patches.

Thanks!
Eze

#19 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 238 lines · Ezequiel Garcia
Quoted 237 lines · Lukasz Majewski

Hi Tom,

Quoted 185 lines · Lukasz Majewski
Quoted 176 lines

Hi Tom,

Quoted 158 lines · Lukasz Majewski
Quoted 157 lines

Dear Marek, Tom,

Quoted 102 lines · Tom Rini
Quoted 93 lines
Quoted 86 lines · Marek Vasut
Quoted 74 lines · Tom Rini
Quoted 64 lines · Marek Vasut
Quoted 56 lines · Ezequiel Garcia
Quoted 54 lines · Marek Vasut

On 5/25/19 11:47 PM, Ezequiel Garcia wrote:
On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut
wrote:
On 5/25/19 6:49 PM, Ezequiel Garcia wrote:
i.MX6 platforms boot U-Boot second-stage from
unformatted space, and should not need Ext
filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l
SPL_FS_EXT4 | xargs sed -i -e
'/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674
(-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi
<[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> ---
Tested on Wandboard only. Maintainers, please ACK or
NAK!

configs/cgtqmx6eval_defconfig | 1 -
configs/mx6cuboxi_defconfig | 1 -
configs/mx6sabreauto_defconfig | 1 -
configs/mx6sabresd_defconfig | 1 -
configs/mx6slevk_spl_defconfig | 1 -
configs/mx6sxsabresd_spl_defconfig | 1 -
configs/mx6ul_14x14_evk_defconfig | 1 -
configs/mx6ul_9x9_evk_defconfig | 1 -
configs/novena_defconfig | 1 -

NAK, I boot my Novena from ext4 and this just broke
it.

And also, NAK, this removes functionality from SPL
which worked fine before.

I'll drop from Novena, but I think the patch still
makes some sense, why do you want Ext4 on SPL?

Quoted 6 lines
Quoted 2 lines

What other filesystem is available in SPL and doesn't
have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 2 lines

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------

Before conversion:                              35 KiB
DM conversion:                                  47 KiB

(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.
fdtdec_get_chosen_node
2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Quoted 5 lines
Quoted 1 line

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Ok, so we do have agreement here. Good.

Quoted 4 lines

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago,

Frankly speaking - I do prefer to use older, well tested and stable SW.

Quoted 7 lines

And such situation we had with i.MX port. It was (and still is) working, being there before the whole DM/DTS stuff.

I can understand that we advised new ports/archs to use DM/DTS. But i.MX has a lot of legacy code, which is already deployed. Changing it because "we move to DM/DTS" immediately is not practical as we loose the code base developed, tested and validated for years.

Quoted 4 lines

DM/DT has been around for over 7 years now, so it too is "legacy code". So it's not "immediately", it's been several years now of trying to get people to migrate and introducing more firm deadlines about it.

I'm not talking about generic DM/DTS adoption - this goes pretty well.

I'm specific about OF_PLATDATA in SPL, which is lagging behind in the whole U-Boot.
To efficiently convert SPL on i.MX we do need it.

Quoted 3 lines

And I'm _still_ not removing code that's close to a full year past the published "We're going to remove this now" date.

And this is a good approach. This code is a legacy one, but still working and sometimes used.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

Quoted 8 lines
Quoted 4 lines

Please consider that we even now have issues with some non-converted drivers. Some drivers were "under conversion" for years (spi framework, sf command). Please also note how many drivers actually support OF_PLATDATA?

Yes, it's been hard to get some drivers converted because just not doing it had no consequences. And yes, I'm sure drivers you need will need OF_PLATDATA hooks added.

Yes, certainly.

Quoted 13 lines
Quoted 9 lines
Quoted 4 lines

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

Exactly. If people are using EXT4 on iMX6 then it should stay. We dropped it from am335x_evm over a year ago because it wasn't used.

Quoted 5 lines
Quoted 2 lines

Yes. I also do agree.

I don't want to get into the DM discussion, the intention of this patch was to reduce SPL size, not make room for a future increase.

SPL size should not be reduced at the expense of useful functionality though.

Quoted 4 lines

That said, I am surprised it is so controversial to slim down a Defconfig, which (at least in my mind) is just the "Maintainer Recommended Starting Point". By removing Ext4 we stating that it's no needed for the board "typical" use.

Maybe you can remove VFAT first, why ext4 in the first place ?

Quoted 1 line

Of course, anyone can still turn Ext4 -and many other features- on.

I was under the impression that mainline should be as useful as possible. Maybe I'm mistaken and carrying random downstream patches is now the suggested approach ?

Quoted 6 lines

Once again, this is only possible if we maintain SPL "starting point" size as small as possible, which probably excludes DM or any other form of bloat.

In fact, if I can keep removing features and still boot the board with the typical setup, I'll be happy to keep suggesting such patches.

That's fine, unless it breaks other peoples' existing setups .

Signature · 2 lines
Best regards,
Marek Vasut
#20 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 249 lines · Marek Vasut
Quoted 238 lines · Ezequiel Garcia
Quoted 237 lines · Lukasz Majewski

Hi Tom,

Quoted 185 lines · Lukasz Majewski
Quoted 176 lines

Hi Tom,

Quoted 158 lines · Lukasz Majewski
Quoted 157 lines

Dear Marek, Tom,

Quoted 102 lines · Tom Rini
Quoted 93 lines
Quoted 86 lines · Marek Vasut
Quoted 74 lines · Tom Rini
Quoted 64 lines · Marek Vasut
Quoted 62 lines · Ezequiel Garcia

On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut
wrote:
On 5/25/19 11:47 PM, Ezequiel Garcia wrote:
On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut
wrote:
On 5/25/19 6:49 PM, Ezequiel Garcia wrote:
i.MX6 platforms boot U-Boot second-stage from
unformatted space, and should not need Ext
filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l
SPL_FS_EXT4 | xargs sed -i -e
'/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674
(-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc: Otavio Salvador <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: Stefan Roese <[email protected]>
Cc: "Eric Bénard" <[email protected]>
Cc: Breno Lima <[email protected]>
Cc: Francesco Montefoschi
<[email protected]> Signed-off-by:
Ezequiel Garcia <[email protected]> ---
Tested on Wandboard only. Maintainers, please ACK or
NAK!

configs/cgtqmx6eval_defconfig | 1 -
configs/mx6cuboxi_defconfig | 1 -
configs/mx6sabreauto_defconfig | 1 -
configs/mx6sabresd_defconfig | 1 -
configs/mx6slevk_spl_defconfig | 1 -
configs/mx6sxsabresd_spl_defconfig | 1 -
configs/mx6ul_14x14_evk_defconfig | 1 -
configs/mx6ul_9x9_evk_defconfig | 1 -
configs/novena_defconfig | 1 -

NAK, I boot my Novena from ext4 and this just broke
it.

And also, NAK, this removes functionality from SPL
which worked fine before.

I'll drop from Novena, but I think the patch still
makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't
have patent problems ?

Sorry for not being clear. I am asking why turn on a
feature that is so heavy, on a system that won't need
it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired. 2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

Quoted 2 lines

So, are you using SPL to load something from ext4 or not?

Yes, I think that's what I said.

Quoted 5 lines

There are
setups where people have configured the system such that SPL loads something from ext4 and that's why we have it available. Is anyone doing that on Novena? Or any iMX system?

Quoted 4 lines

Quoting my first response in this thread:
"
NAK, I boot my Novena from ext4 and this just broke it. "

Quoted 4 lines

Actually, I wasn't sure from your first response if you're using SPL to load u-boot from EXT4 or not. So, Novena is a no and we should wait for more board maintainers to speak up to see if they use it or not, thanks!

Novena is certainly a no. Since I use a couple of wandboards, those are no as well.

Quoted 6 lines

But I do not want to see useful functionality removed from SPL only to make space for useless DM/DT bloat. Temporarily band-aiding this real problem by removing functionality is a no-go, no matter how you slice it. The real fix is to fix the DM/DT and figure out a way to reduce it's size and _retain_ _all_ the functionality.

I fully agree with Marek here - the DM/DT SPL support (in the form as it is now) is a bloat. The SPL size increases considerably.

The _real_ issue is the lack of OF_PLATDATA support for DM/DTS drivers, which are used when we convert u-boot to DM/DTS.

For boards, which have enough internal on-chip RAM (OCRAM in case of imx6q) it is doable to convert them to DM/DTS in SPL.

However, nobody wants to say it loud, but the footprint considerably increases in SPL - for example:

SPL (and I only use eMMC there - no SPI, no I2C):
------------------------------------------------

Before conversion:                              35 KiB
DM conversion:                                  47 KiB

(around ~25% increase)

For u-boot proper:
----------------------------
Footprint changes (u-boot.imx):

Before conversion:                              345 KiB
DM conversion:                    415 KiB

(around + 17% increase)

This has several implications:

1. We replace small, robust SPL (I speak only for i.MX) with something which is XX% larger and hence boot time increases. In short - customers are/will not be happy. We do introduce regression here.
fdtdec_get_chosen_node
2. To make it usable (with the size comparable to what we do have now) we need to add OF_PLATDATA support to eMMC, SPI, I2C, etc. drivers. Test them and validate.

That is why we now "just" convert only U-Boot proper to DM/DTS.

As a follow up - it seems pragmatic to not touch SPL for now, and start the conversion ONLY when necessary drivers gain support for OF_PLATDATA (so we don't need DTS support in SPL).

Quoted 5 lines
Quoted 1 line

Unfortunately, it would take some time.

Right, and again, DM support in SPL is not required as we haven't sorted out some of the issues such as making sure it is still small enough.

Ok, so we do have agreement here. Good.

Quoted 4 lines

Which is why I'm quite frustrated at the moment about "just now" starting to convert these things for i.MX rather than several years ago,

Frankly speaking - I do prefer to use older, well tested and stable SW.

Quoted 7 lines

And such situation we had with i.MX port. It was (and still is) working, being there before the whole DM/DTS stuff.

I can understand that we advised new ports/archs to use DM/DTS. But i.MX has a lot of legacy code, which is already deployed. Changing it because "we move to DM/DTS" immediately is not practical as we loose the code base developed, tested and validated for years.

Quoted 4 lines

DM/DT has been around for over 7 years now, so it too is "legacy code". So it's not "immediately", it's been several years now of trying to get people to migrate and introducing more firm deadlines about it.

I'm not talking about generic DM/DTS adoption - this goes pretty well.

I'm specific about OF_PLATDATA in SPL, which is lagging behind in the whole U-Boot.
To efficiently convert SPL on i.MX we do need it.

Quoted 3 lines

And I'm _still_ not removing code that's close to a full year past the published "We're going to remove this now" date.

And this is a good approach. This code is a legacy one, but still working and sometimes used.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

when the first "hey, this might be too big for some platforms" conversations started and we changed from "OF_PLATDATA is a stop-gap" to "OF_PLATDATA is a required feature or we'll never be small enough".

Quoted 8 lines
Quoted 4 lines

Please consider that we even now have issues with some non-converted drivers. Some drivers were "under conversion" for years (spi framework, sf command). Please also note how many drivers actually support OF_PLATDATA?

Yes, it's been hard to get some drivers converted because just not doing it had no consequences. And yes, I'm sure drivers you need will need OF_PLATDATA hooks added.

Yes, certainly.

Quoted 13 lines
Quoted 9 lines
Quoted 4 lines

And it's still unrelated to removing unused features from a build, which this thread is about. If platforms aren't loading U-Boot from EXT4, that's just unused bloat.

I do agree with the above sentence. If the feature is not used - it shall be removed. However, if somebody deployed it already - then - well it must be supported or other, acceptable solution needs to be used (e.g. EXT4 -> VFAT conversion).

Exactly. If people are using EXT4 on iMX6 then it should stay. We dropped it from am335x_evm over a year ago because it wasn't used.

Quoted 5 lines
Quoted 2 lines

Yes. I also do agree.

I don't want to get into the DM discussion, the intention of this patch was to reduce SPL size, not make room for a future increase.

SPL size should not be reduced at the expense of useful functionality though.

Quoted 7 lines
Quoted 4 lines

That said, I am surprised it is so controversial to slim down a Defconfig, which (at least in my mind) is just the "Maintainer Recommended Starting Point". By removing Ext4 we stating that it's no needed for the board "typical" use.

Maybe you can remove VFAT first, why ext4 in the first place ?

I guess we shouldn't remove VFAT either (or anything!) since it might break someone setup as well.

Quoted 6 lines
Quoted 1 line

Of course, anyone can still turn Ext4 -and many other features- on.

I was under the impression that mainline should be as useful as possible. Maybe I'm mistaken and carrying random downstream patches is now the suggested approach ?

Quoted 9 lines
Quoted 6 lines

Once again, this is only possible if we maintain SPL "starting point" size as small as possible, which probably excludes DM or any other form of bloat.

In fact, if I can keep removing features and still boot the board with the typical setup, I'll be happy to keep suggesting such patches.

That's fine, unless it breaks other peoples' existing setups .

I don't want to break anyone's setup (much less yours).

I never thought we considered defconfig as something people use, for anything except starting point.

I'm happy to drop this patch (partially or fully).

Thanks,
Eze

#21 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

On 5/27/19 4:59 AM, Ezequiel Garcia wrote:
[...]

Quoted 11 lines
Quoted 11 lines
Quoted 2 lines

I don't want to get into the DM discussion, the intention of this patch was to reduce SPL size, not make room for a future increase.

SPL size should not be reduced at the expense of useful functionality though.

Quoted 4 lines

That said, I am surprised it is so controversial to slim down a Defconfig, which (at least in my mind) is just the "Maintainer Recommended Starting Point". By removing Ext4 we stating that it's no needed for the board "typical" use.

Quoted 5 lines
Quoted 2 lines

Maybe you can remove VFAT first, why ext4 in the first place ?

I guess we shouldn't remove VFAT either (or anything!) since it might break someone setup as well.

Correct.

Note that VFAT has quite a footprint, see FS_FAT_MAX_CLUSTSIZE , which ends up preallocating large static buffers.

Quoted 10 lines
Quoted 10 lines
Quoted 1 line

Of course, anyone can still turn Ext4 -and many other features- on.

I was under the impression that mainline should be as useful as possible. Maybe I'm mistaken and carrying random downstream patches is now the suggested approach ?

Quoted 4 lines

Once again, this is only possible if we maintain SPL "starting point" size as small as possible, which probably excludes DM or any other form of bloat.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

In fact, if I can keep removing features and still boot the board with the typical setup, I'll be happy to keep suggesting such patches.

That's fine, unless it breaks other peoples' existing setups .

I don't want to break anyone's setup (much less yours).

I hope we don't have some weird personality cult going on here. Just to make this perfectly clear, breaking anyones' setup is bad.

Quoted 2 lines

I never thought we considered defconfig as something people use, for anything except starting point.

I think this is where we disconnected. My take is that defconfig is something I build, install the result and can just use the device without fighting any weird problems (like missing support for some obvious boot device).

Quoted 5 lines

I'm happy to drop this patch (partially or fully).

Thanks,
Eze

Signature · 2 lines
Best regards,
Marek Vasut
#22 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

In reply to Marek Vasut

Hi Ezequiel,

Quoted 56 lines · Marek Vasut
Quoted 46 lines · Ezequiel Garcia
Quoted 45 lines · Marek Vasut
Quoted 44 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

They *could* be good reasons, but it depends on the use case. In case of Novena as Marek stated, it boots from filesystem and dropping this feature breaks definetly the board.

My position is that each board maintainer can take the decision what is necessary for the board he maintained. I think this should be done per each board, so just send single patches (not a compund as this one) just for the boards you want to drop ext4 (I guess just sabre and Wandboard). If the board maintainers agree (Fabio and Otavio), patches can be merged.

Thanks,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#23 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Hi Stefano,

Quoted 9 lines · Stefano Babic

They *could* be good reasons, but it depends on the use case. In case of Novena as Marek stated, it boots from filesystem and dropping this feature breaks definetly the board.

My position is that each board maintainer can take the decision what is necessary for the board he maintained. I think this should be done per each board, so just send single patches (not a compund as this one) just for the boards you want to drop ext4 (I guess just sabre and Wandboard). If the board maintainers agree (Fabio and Otavio), patches can be merged.

I agree that we should remove CONFIG_SPL_FS_EXT4 on a case by case basis.

Thanks

#24 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 8 lines · Fabio Estevam

Hi Stefano,

Quoted 4 lines · Stefano Babic

They *could* be good reasons, but it depends on the use case. In case of Novena as Marek stated, it boots from filesystem and dropping this feature breaks definetly the board.

Quoted 7 lines
Quoted 5 lines

My position is that each board maintainer can take the decision what is necessary for the board he maintained. I think this should be done per each board, so just send single patches (not a compund as this one) just for the boards you want to drop ext4 (I guess just sabre and Wandboard). If the board maintainers agree (Fabio and Otavio), patches can be merged.

I agree that we should remove CONFIG_SPL_FS_EXT4 on a case by case basis.

So I will have to track a downstream patch for wandboard now ?

Signature · 2 lines
Best regards,
Marek Vasut
reviewer
#25 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

I do want to remove it from mx6sabresd for sure.

#26 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 5 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

Signature · 2 lines
Best regards,
Marek Vasut
#27 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 5 lines · Marek Vasut
Quoted 4 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

Quoted 7 lines
Quoted 1 line

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190531/f64368db/attachment.sig>
#28 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 10 lines · Tom Rini
Quoted 9 lines · Marek Vasut
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

Signature · 2 lines
Best regards,
Marek Vasut
#29 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 15 lines · Marek Vasut
Quoted 14 lines · Tom Rini
Quoted 12 lines · Marek Vasut
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

Quoted 7 lines
Quoted 3 lines

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

So you've setup your own one-off. That's fine and something to support. But it's irregular and uncommon.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190531/b6e712ba/attachment.sig>
#30 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 20 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 17 lines · Tom Rini
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

Quoted 7 lines
Quoted 1 line

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Quoted 6 lines
Quoted 3 lines

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

So you've setup your own one-off. That's fine and something to support. But it's irregular and uncommon.

I would say this is the recommended approach over just writing U-Boot binary to random offset on the card at hoping that your data will be safe the next time you update it ?

Signature · 2 lines
Best regards,
Marek Vasut
#31 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 25 lines · Marek Vasut
Quoted 24 lines · Tom Rini
Quoted 22 lines · Marek Vasut
Quoted 10 lines · Tom Rini
Quoted 9 lines · Marek Vasut
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

Quoted 6 lines
Quoted 2 lines

So you've setup your own one-off. That's fine and something to support. But it's irregular and uncommon.

I would say this is the recommended approach over just writing U-Boot binary to random offset on the card at hoping that your data will be safe the next time you update it ?

No, it's generally not.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190531/7fa7717b/attachment.sig>
#32 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 26 lines · Tom Rini
Quoted 25 lines · Marek Vasut
Quoted 24 lines · Tom Rini
Quoted 22 lines · Marek Vasut
Quoted 10 lines · Tom Rini
Quoted 9 lines · Marek Vasut
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

So you've setup your own one-off. That's fine and something to support. But it's irregular and uncommon.

I would say this is the recommended approach over just writing U-Boot binary to random offset on the card at hoping that your data will be safe the next time you update it ?

No, it's generally not.

That's not the point, the point is that writing data to random offset is likely to end up with silent FS corruption eventually.

Signature · 2 lines
Best regards,
Marek Vasut
#33 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 30 lines · Marek Vasut
Quoted 29 lines · Tom Rini
Quoted 28 lines · Marek Vasut
Quoted 26 lines · Tom Rini
Quoted 15 lines · Marek Vasut
Quoted 14 lines · Tom Rini
Quoted 12 lines · Marek Vasut
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

Quoted 7 lines
Quoted 3 lines

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

So you've setup your own one-off. That's fine and something to support. But it's irregular and uncommon.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I would say this is the recommended approach over just writing U-Boot binary to random offset on the card at hoping that your data will be safe the next time you update it ?

No, it's generally not.

That's not the point, the point is that writing data to random offset is likely to end up with silent FS corruption eventually.

No, it's generally not.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190531/ec2ceb40/attachment.sig>
#34 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 35 lines · Tom Rini
Quoted 34 lines · Marek Vasut
Quoted 33 lines · Tom Rini
Quoted 31 lines · Marek Vasut
Quoted 20 lines · Tom Rini
Quoted 19 lines · Marek Vasut
Quoted 17 lines · Tom Rini
Quoted 5 lines · Marek Vasut
Quoted 4 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

So I will have to track a downstream patch for wandboard now ?

Quoted 7 lines
Quoted 1 line

I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard.

Ah OK, good, thanks.

Quoted 1 line

I do want to remove it from mx6sabresd for sure.

How does the sabresd boot ?

How does your wandboard/novena boot? I'd have sworn most distros do VFAT /boot not ext4 /boot. Of course I'm still surprised anyone is loading u-boot from fs on iMX since I always see that as raw offsets.

Quoted 6 lines
Quoted 3 lines

Novena is ext4 for sure, for two reasons -- VFAT has patent problems and putting it at raw offset is just an accident waiting to happen (silent FT corruption if the image gets too large)

So you've setup your own one-off. That's fine and something to support. But it's irregular and uncommon.

I would say this is the recommended approach over just writing U-Boot binary to random offset on the card at hoping that your data will be safe the next time you update it ?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

No, it's generally not.

That's not the point, the point is that writing data to random offset is likely to end up with silent FS corruption eventually.

No, it's generally not.

You do agree that putting as much as possible into a filesystem is better and safer than putting it at random offset in raw block device , yes ?

Signature · 2 lines
Best regards,
Marek Vasut
reviewer
#35 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

In reply to Marek Vasut
Quoted 1 line · Marek Vasut

How does the sabresd boot ?

It boots from SD card with SPL at 1kB and u-boot-dtb.img at 69kB.

We don't need EXT4 in SPL at all.

#36 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 7 lines · Fabio Estevam
Quoted 1 line · Marek Vasut

How does the sabresd boot ?

It boots from SD card with SPL at 1kB and u-boot-dtb.img at 69kB.

We don't need EXT4 in SPL at all.

It's an accident just waiting to happen -- only a matter of time until someone writes too large u-boot-dtb.img and silently corrupts the file system right behind it ;-)

Signature · 2 lines
Best regards,
Marek Vasut
reviewer
#37 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 3 lines · Marek Vasut

It's an accident just waiting to happen -- only a matter of time until someone writes too large u-boot-dtb.img and silently corrupts the file system right behind it ;-)

If u-boot-dtb.img grows it will corrupt the env region.

We can detect this situation in build time using CONFIG_BOARD_SIZE_LIMIT.

#38 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 9 lines · Fabio Estevam
Quoted 3 lines · Marek Vasut

It's an accident just waiting to happen -- only a matter of time until someone writes too large u-boot-dtb.img and silently corrupts the file system right behind it ;-)

If u-boot-dtb.img grows it will corrupt the env region.

We can detect this situation in build time using CONFIG_BOARD_SIZE_LIMIT.

With filesystem, you can grow until you exhaust the boot partition capacity.

Signature · 2 lines
Best regards,
Marek Vasut
#39 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

Quoted 7 lines · Marek Vasut
Quoted 6 lines · Fabio Estevam
Quoted 3 lines · Marek Vasut

It's an accident just waiting to happen -- only a matter of time until someone writes too large u-boot-dtb.img and silently corrupts the file system right behind it ;-)

Quoted 5 lines
Quoted 3 lines

If u-boot-dtb.img grows it will corrupt the env region.

We can detect this situation in build time using CONFIG_BOARD_SIZE_LIMIT.

With filesystem, you can grow until you exhaust the boot partition capacity.

Unrestricted growth isn't a good thing :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190531/c1decf0a/attachment.sig>
#40 lore raw

PATCH 1/1 configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

In reply to Stefano Babic
Quoted 71 lines · Stefano Babic

Hi Ezequiel,

Quoted 56 lines · Marek Vasut
Quoted 46 lines · Ezequiel Garcia
Quoted 45 lines · Marek Vasut
Quoted 44 lines · Ezequiel Garcia
Quoted 42 lines · Marek Vasut
Quoted 27 lines · Ezequiel Garcia

i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.

The commit was generated with:

git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'

This change has a dramatic impact on SPL size:

./scripts/bloat-o-meter old new
add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..]
Total: Before=38320, After=29646, chg -22.64%

Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Stefan Roese <[email protected]>
Cc "Eric Bénard" <[email protected]>
Cc Breno Lima <[email protected]>
Cc Francesco Montefoschi <[email protected]>

---
Tested on Wandboard only. Maintainers, please ACK or NAK!

Quoted 9 lines
 configs/cgtqmx6eval_defconfig       | 1 -
 configs/mx6cuboxi_defconfig         | 1 -
 configs/mx6sabreauto_defconfig      | 1 -
 configs/mx6sabresd_defconfig        | 1 -
 configs/mx6slevk_spl_defconfig      | 1 -
 configs/mx6sxsabresd_spl_defconfig  | 1 -
 configs/mx6ul_14x14_evk_defconfig   | 1 -
 configs/mx6ul_9x9_evk_defconfig     | 1 -
 configs/novena_defconfig            | 1 -

NAK, I boot my Novena from ext4 and this just broke it.

And also, NAK, this removes functionality from SPL which worked fine before.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?

What other filesystem is available in SPL and doesn't have patent problems ?

Sorry for not being clear. I am asking why turn on a feature that is so heavy, on a system that won't need it (such as Sabre* boards, Wandboard and similar)?

Quoted 7 lines

Two reasons:
1) It was enabled, disabling it means removing functionality for no good reason (oops, bloat, is not a good reason), and that is not desired.
2) Booting from block device implies booting from a filesystem, otherwise you might overwrite various things on the block device when updating the file (u-boot image).

They *could* be good reasons, but it depends on the use case. In case of Novena as Marek stated, it boots from filesystem and dropping this feature breaks definetly the board.

Quoted 6 lines

My position is that each board maintainer can take the decision what is necessary for the board he maintained. I think this should be done per each board, so just send single patches (not a compund as this one) just for the boards you want to drop ext4 (I guess just sabre and Wandboard). If the board maintainers agree (Fabio and Otavio), patches can be merged.

I am dropping these changes. If board maintainers want to pursue this path, it's up to them, as this clearly has heavier implications than I originally thought.

Thanks,
Ezequiel