Skip to contentSkip to conversation

syscalls: testing on all fs for copy_file_range02 and getxattr04

PATCH New Murphy Zhou 2 participants 2 messages May 31, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls: testing on all fs for copy_file_range02 and getxattr04

To increase test coverage. If the testing fs is not supporting this syscall, tcase handles it well.

---
 testcases/kernel/syscalls/copy_file_range/copy_file_range02.c | 2 +-
 testcases/kernel/syscalls/getxattr/getxattr04.c               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/copy_file_range/copy_file_range02.c +1 -1
index 07c0207c2..d3fb737be 100644
@@ -113,6 +113,6 @@ static struct tst_test test = {
 	.needs_root = 1,
 	.mount_device = 1,
 	.mntpoint = MNTPOINT,
-	.dev_fs_type = "ext4",
+	.all_filesystems = 1,
 	.test_variants = TEST_VARIANTS,
 };
testcases/kernel/syscalls/getxattr/getxattr04.c +1 -1
index 1dcb14da3..905abd587 100644
@@ -121,7 +121,7 @@ static struct tst_test test = {
 	.needs_tmpdir = 1,
 	.needs_root = 1,
 	.mount_device = 1,
-	.dev_fs_type = "xfs",
+	.all_filesystems = 1,
 	.mntpoint = MNTPOINT,
 	.forks_child = 1,
 	.test_all = verify_getxattr,
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 syscalls: testing on all fs for copy_file_range02 and getxattr04

Hi!

Quoted 14 lines

To increase test coverage. If the testing fs is not supporting this syscall, tcase handles it well.

---
 testcases/kernel/syscalls/copy_file_range/copy_file_range02.c | 2 +-
 testcases/kernel/syscalls/getxattr/getxattr04.c               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/copy_file_range/copy_file_range02.c +0 -0
index 07c0207c2..d3fb737be 100644

testcases/kernel/syscalls/copy_file_range/copy_file_range02.c static struct tst_test test = { · line 118

Quoted 7 lines
testcases/kernel/syscalls/copy_file_range/copy_file_range02.c +1 -1
@@ -113,6 +113,6 @@ static struct tst_test test = {
 	.needs_root = 1,
 	.mount_device = 1,
 	.mntpoint = MNTPOINT,
-	.dev_fs_type = "ext4",
+	.all_filesystems = 1,
 	.test_variants = TEST_VARIANTS,
 };

Actually looking at the kernel code all these error checks are done in the vfs_copy_file_range() function so as far as I can tell there is no point in running copy_file_range02 test for all filesystems. Maybe we can just delete all the device code and change the test to use the default TMPDIR instead?

It would may much more sense to run the copy_file_range01 and copy_file_range03 for all filesystems, because these tests advance beyond the common checks and actually copy the file which invokes either the f_op->copy_file_range() or the do_splice_direct() fallback.

testcases/kernel/syscalls/getxattr/getxattr04.c static struct tst_test test = { · line 127

Quoted 13 lines
testcases/kernel/syscalls/getxattr/getxattr04.c +1 -1
index 1dcb14da3..905abd587 100644
@@ -121,7 +121,7 @@ static struct tst_test test = {
 	.needs_tmpdir = 1,
 	.needs_root = 1,
 	.mount_device = 1,
-	.dev_fs_type = "xfs",
+	.all_filesystems = 1,
 	.mntpoint = MNTPOINT,
 	.forks_child = 1,
 	.test_all = verify_getxattr,

Can you please split the patch?

It's a bit cleaner (and easier when we have to revert) to enable the all_filesystem flags for each syscall in a separate patch.

Signature · 2 lines
Cyril Hrubis
[email protected]