Skip to contentSkip to conversation

drm/i915/gtt: No need to zero the table for page dirs

PATCH In review Mika Kuoppala 3 participants 3 messages May 31, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gtt: No need to zero the table for page dirs

We set them to scratch right after allocation so prevent useless zeroing before.

---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +3 -2
index ca8a69e8b098..f237ad310426 100644
@@ -681,7 +681,7 @@ static struct i915_page_directory *alloc_pd(struct i915_address_space *vm)
 {
 	struct i915_page_directory *pd;
 
-	pd = kzalloc(sizeof(*pd), I915_GFP_ALLOW_FAIL);
+	pd = kmalloc(sizeof(*pd), I915_GFP_ALLOW_FAIL);
 	if (unlikely(!pd))
 		return ERR_PTR(-ENOMEM);
 
@@ -738,7 +738,7 @@ alloc_pdp(struct i915_address_space *vm)
 
 	GEM_BUG_ON(!i915_vm_is_4lvl(vm));
 
-	pdp = kzalloc(sizeof(*pdp), GFP_KERNEL);
+	pdp = kmalloc(sizeof(*pdp), GFP_KERNEL);
 	if (!pdp)
 		return ERR_PTR(-ENOMEM);
 
@@ -750,6 +750,7 @@ alloc_pdp(struct i915_address_space *vm)
 	if (ret)
 		goto fail_page_m;
 
+	pdp->used_pdpes = 0;
 	return pdp;
 
 fail_page_m:
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw

Quoting Mika Kuoppala (2019-05-31 17:18:36)

Quoted 32 lines

We set them to scratch right after allocation so prevent useless zeroing before.

---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +2 -2
index ca8a69e8b098..f237ad310426 100644
@@ -681,7 +681,7 @@ static struct i915_page_directory *alloc_pd(struct i915_address_space *vm)
 {
        struct i915_page_directory *pd;
 
-       pd = kzalloc(sizeof(*pd), I915_GFP_ALLOW_FAIL);
+       pd = kmalloc(sizeof(*pd), I915_GFP_ALLOW_FAIL);
        if (unlikely(!pd))
                return ERR_PTR(-ENOMEM);
 
@@ -738,7 +738,7 @@ alloc_pdp(struct i915_address_space *vm)
 
        GEM_BUG_ON(!i915_vm_is_4lvl(vm));
 
-       pdp = kzalloc(sizeof(*pdp), GFP_KERNEL);
+       pdp = kmalloc(sizeof(*pdp), GFP_KERNEL);
        if (!pdp)
                return ERR_PTR(-ENOMEM);
 

drivers/gpu/drm/i915/i915_gem_gtt.c alloc_pdp(struct i915_address_space *vm) · line 753

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +1 -0
@@ -750,6 +750,7 @@ alloc_pdp(struct i915_address_space *vm)
        if (ret)
                goto fail_page_m;
 
+       pdp->used_pdpes = 0;

-> __pdp_init.

That makes more sense when you see my patches ;)

With putting initialisation in __pdp_init

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✗ Fi.CI.BAT: failure for drm/i915/gtt: No need to zero the table for page dirs

In reply to Mika Kuoppala
== Series Details ==

== Series Details ==

Series: drm/i915/gtt: No need to zero the table for page dirs
URL : https://patchwork.freedesktop.org/series/61439/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6177 -> Patchwork_13149
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_13149 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_13149, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_13149:

### IGT changes ###

#### Possible regressions ####

* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-kbl-8809g/igt@amdgpu/[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@i915_selftest@live_mman}:
- fi-bxt-dsi: NOTRUN -> [TIMEOUT][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-bxt-dsi/igt@i915_selftest@live_mman.html

Known issues
------------

Here are the changes found in Patchwork_13149 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-hsw-peppy: [PASS][5] -> [DMESG-FAIL][6] ([fdo#110235])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-hsw-peppy/igt@i915_selftest@live_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-hsw-peppy/igt@i915_selftest@live_contexts.html

* igt@kms_addfb_basic@bad-pitch-1024:
- fi-icl-dsi: [PASS][7] -> [DMESG-WARN][8] ([fdo#106107])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-icl-dsi/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-icl-dsi/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- {fi-icl-guc}: [INCOMPLETE][9] ([fdo#107713] / [fdo#109100]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-icl-guc/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-icl-guc/igt@[email protected]

* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-8809g: [INCOMPLETE][11] ([fdo#103665] / [fdo#107139] / [fdo#108126]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-kbl-8809g/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-kbl-8809g/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- fi-bxt-dsi: [INCOMPLETE][13] ([fdo#103927]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-bxt-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-bxt-dsi/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: [FAIL][15] ([fdo#103167]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-icl-u3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-icl-u3/igt@[email protected]
- fi-hsw-peppy: [DMESG-WARN][17] ([fdo#102614]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6177/fi-hsw-peppy/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/fi-hsw-peppy/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108126]: https://bugs.freedesktop.org/show_bug.cgi?id=108126
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (54 -> 43)
------------------------------

Missing (11): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-kbl-guc fi-kbl-7560u fi-byt-clapper fi-bdw-samus fi-cml-u

Build changes
-------------

* Linux: CI_DRM_6177 -> Patchwork_13149

CI_DRM_6177: bc3f44a8efe8b460f5a812d8b72d010bffd88405 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5026: 4108c74c3b15460de25ab989f4e2031594559dfc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13149: 707b37e76585629119681939a7fbfd7daa16a074 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

707b37e76585 drm/i915/gtt: No need to zero the table for page dirs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13149/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx